146367 2015-06-26 16:07:07 -0700 WebPage::getPositionInformation() should not copy an image that is larger than the screen 2015-06-26 16:49:30 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin thorton oldest_to_newest 1105086 0 bdakin 2015-06-26 16:07:07 -0700 WebPage::getPositionInformation() should not copy an image that is larger than the screen 1105087 1 255674 bdakin 2015-06-26 16:11:16 -0700 Created attachment 255674 Patch 1105090 2 255674 thorton 2015-06-26 16:44:44 -0700 Comment on attachment 255674 Patch As discussed, please make this work with deviceScaleFactor≠1. 1105092 3 bdakin 2015-06-26 16:49:30 -0700 Thanks Tim! http://trac.webkit.org/changeset/186018 255674 2015-06-26 16:11:16 -0700 2015-06-26 16:44:44 -0700 Patch for-review.txt text/plain 4557 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NjAxNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA2LTI2ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJQYWdlOjpnZXRQb3NpdGlvbklu Zm9ybWF0aW9uKCkgc2hvdWxkIG5vdCBjb3B5IGFuIGltYWdlIHRoYXQgaXMgbGFyZ2VyIHRoYW4g dGhlICAKKyAgICAgICAgc2NyZWVuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDYzNjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBFeHBvcnQgdGhlIHJlY3QgdmVyc2lvbiBvZiB0aGlzIGZ1bmN0aW9uIHRv by4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaDoKKwogMjAx NS0wNi0yNiAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgUm9s bGluZyBvdXQgcjE4NDY2MApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv R3JhcGhpY3NDb250ZXh0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmgJKHJldmlzaW9uIDE4NTk2MikKKysrIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5oCSh3b3JraW5nIGNvcHkp CkBAIC0zMDcsNyArMzA3LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBXRUJDT1JF X0VYUE9SVCB2b2lkIHN0cm9rZVJlY3QoY29uc3QgRmxvYXRSZWN0JiwgZmxvYXQgbGluZVdpZHRo KTsKIAogICAgICAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIGRyYXdJbWFnZShJbWFnZSosIENvbG9y U3BhY2UsIGNvbnN0IEZsb2F0UG9pbnQmIGRlc3RpbmF0aW9uLCBjb25zdCBJbWFnZVBhaW50aW5n T3B0aW9ucyYgPSBJbWFnZVBhaW50aW5nT3B0aW9ucygpKTsKLSAgICAgICAgdm9pZCBkcmF3SW1h Z2UoSW1hZ2UqLCBDb2xvclNwYWNlLCBjb25zdCBGbG9hdFJlY3QmIGRlc3RpbmF0aW9uLCBjb25z dCBJbWFnZVBhaW50aW5nT3B0aW9ucyYgPSBJbWFnZVBhaW50aW5nT3B0aW9ucygpKTsKKyAgICAg ICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBkcmF3SW1hZ2UoSW1hZ2UqLCBDb2xvclNwYWNlLCBjb25z dCBGbG9hdFJlY3QmIGRlc3RpbmF0aW9uLCBjb25zdCBJbWFnZVBhaW50aW5nT3B0aW9ucyYgPSBJ bWFnZVBhaW50aW5nT3B0aW9ucygpKTsKICAgICAgICAgdm9pZCBkcmF3SW1hZ2UoSW1hZ2UqLCBD b2xvclNwYWNlLCBjb25zdCBGbG9hdFJlY3QmIGRlc3RpbmF0aW9uLCBjb25zdCBGbG9hdFJlY3Qm IHNvdXJjZSwgY29uc3QgSW1hZ2VQYWludGluZ09wdGlvbnMmID0gSW1hZ2VQYWludGluZ09wdGlv bnMoKSk7CiAKICAgICAgICAgdm9pZCBkcmF3VGlsZWRJbWFnZShJbWFnZSosIENvbG9yU3BhY2Us IGNvbnN0IEZsb2F0UmVjdCYgZGVzdGluYXRpb24sIGNvbnN0IEZsb2F0UG9pbnQmIHNvdXJjZSwg Y29uc3QgRmxvYXRTaXplJiB0aWxlU2l6ZSwKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NjAx NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE2IEBACisyMDE1LTA2LTI2ICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAg ICAgICBXZWJQYWdlOjpnZXRQb3NpdGlvbkluZm9ybWF0aW9uKCkgc2hvdWxkIG5vdCBjb3B5IGFu IGltYWdlIHRoYXQgaXMgbGFyZ2VyIHRoYW4gdGhlICAKKyAgICAgICAgc2NyZWVuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDYzNjcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWludGFpbiBhc3BlY3RS YXRpbywgYnV0IHNjYWxlIGRvd24gdGhlIGJ1ZmZlciBzaXplIGlmIHRoZSBpbWFnZSBpcyBsYXJn ZXIgdGhhbiAKKyAgICAgICAgdGhlIHNjcmVlbi4KKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBh Z2UvaW9zL1dlYlBhZ2VJT1MubW06CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OmdldFBvc2l0 aW9uSW5mb3JtYXRpb24pOgorCiAyMDE1LTA2LTI2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxl LmNvbT4KIAogICAgICAgICBHYXJkZWluaW5nOiByZW1vdmUgYW4gYXNzZXJ0aW9uIGFuZCBhICNp bXBvcnQgdG8gZ3JlZW4gdGhlIGJvdC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0JKHJldmlzaW9uIDE4NjAwOCkKKysr IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQkod29y a2luZyBjb3B5KQpAQCAtNjAsNiArNjAsNyBAQAogI2ltcG9ydCA8V2ViQ29yZS9Gb2N1c0NvbnRy b2xsZXIuaD4KICNpbXBvcnQgPFdlYkNvcmUvRnJhbWUuaD4KICNpbXBvcnQgPFdlYkNvcmUvRnJh bWVWaWV3Lmg+CisjaW1wb3J0IDxXZWJDb3JlL0dlb21ldHJ5VXRpbGl0aWVzLmg+CiAjaW1wb3J0 IDxXZWJDb3JlL0hUTUxFbGVtZW50VHlwZUhlbHBlcnMuaD4KICNpbXBvcnQgPFdlYkNvcmUvSFRN TEZvcm1FbGVtZW50Lmg+CiAjaW1wb3J0IDxXZWJDb3JlL0hUTUxJbnB1dEVsZW1lbnQuaD4KQEAg LTIxMzksOSArMjE0MCwxMSBAQCB2b2lkIFdlYlBhZ2U6OmdldFBvc2l0aW9uSW5mb3JtYXRpb24o Y29uCiAgICAgICAgICAgICAgICAgICAgIGF1dG8mIHJlbmRlckltYWdlID0gZG93bmNhc3Q8UmVu ZGVySW1hZ2U+KCooZWxlbWVudC0+cmVuZGVyZXIoKSkpOwogICAgICAgICAgICAgICAgICAgICBp ZiAocmVuZGVySW1hZ2UuY2FjaGVkSW1hZ2UoKSAmJiAhcmVuZGVySW1hZ2UuY2FjaGVkSW1hZ2Uo KS0+ZXJyb3JPY2N1cnJlZCgpKSB7CiAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoSW1hZ2Uq IGltYWdlID0gcmVuZGVySW1hZ2UuY2FjaGVkSW1hZ2UoKS0+aW1hZ2VGb3JSZW5kZXJlcigmcmVu ZGVySW1hZ2UpKSB7Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgaWYgKFJlZlB0cjxTaGFy ZWFibGVCaXRtYXA+IHNoYXJlZEJpdG1hcCA9IFNoYXJlYWJsZUJpdG1hcDo6Y3JlYXRlU2hhcmVh YmxlKEludFNpemUoaW1hZ2UtPnNpemUoKSksIFNoYXJlYWJsZUJpdG1hcDo6U3VwcG9ydHNBbHBo YSkpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBGbG9hdFNpemUgc2NhbGVkU2l6ZSA9 IGxhcmdlc3RSZWN0V2l0aEFzcGVjdFJhdGlvSW5zaWRlUmVjdChpbWFnZS0+c2l6ZSgpLndpZHRo KCkgLyBpbWFnZS0+c2l6ZSgpLmhlaWdodCgpLCBGbG9hdFJlY3QoMCwgMCwgc2NyZWVuU2l6ZSgp LndpZHRoKCksIHNjcmVlblNpemUoKS5oZWlnaHQoKSkpLnNpemUoKTsKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICBGbG9hdFNpemUgYml0bWFwU2l6ZSA9IHNjYWxlZFNpemUud2lkdGgoKSA8 IGltYWdlLT5zaXplKCkud2lkdGgoKSA/IHNjYWxlZFNpemUgOiBpbWFnZS0+c2l6ZSgpOworICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChSZWZQdHI8U2hhcmVhYmxlQml0bWFwPiBzaGFy ZWRCaXRtYXAgPSBTaGFyZWFibGVCaXRtYXA6OmNyZWF0ZVNoYXJlYWJsZShJbnRTaXplKGJpdG1h cFNpemUpLCBTaGFyZWFibGVCaXRtYXA6OlN1cHBvcnRzQWxwaGEpKSB7CiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGF1dG8gZ3JhcGhpY3NDb250ZXh0ID0gc2hhcmVkQml0bWFwLT5j cmVhdGVHcmFwaGljc0NvbnRleHQoKTsKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Z3JhcGhpY3NDb250ZXh0LT5kcmF3SW1hZ2UoaW1hZ2UsIENvbG9yU3BhY2VEZXZpY2VSR0IsIEZs b2F0UG9pbnQoMCwgMCkpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBncmFwaGlj c0NvbnRleHQtPmRyYXdJbWFnZShpbWFnZSwgQ29sb3JTcGFjZURldmljZVJHQiwgRmxvYXRSZWN0 KDAsIDAsIGJpdG1hcFNpemUud2lkdGgoKSwgYml0bWFwU2l6ZS5oZWlnaHQoKSkpOwogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBpbmZvLmltYWdlID0gc2hhcmVkQml0bWFwOwogICAg ICAgICAgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICAgICAgICAgIH0K