146355 2015-06-26 11:48:49 -0700 Add support for 'Default' media session types 2015-06-28 22:32:33 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 145411 1 mrajca webkit-unassigned conrad_shultz eric.carlson jer.noble mrajca webkit-bug-importer oldest_to_newest 1105003 0 mrajca 2015-06-26 11:48:49 -0700 Media elements that do not specify a media session content kind should be assigned the top-level browsing context's media session. 1105004 1 webkit-bug-importer 2015-06-26 11:49:39 -0700 <rdar://problem/21569054> 1105097 2 255676 mrajca 2015-06-26 16:58:29 -0700 Created attachment 255676 Patch 1105220 3 255676 darin 2015-06-27 15:31:16 -0700 Comment on attachment 255676 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255676&action=review > Source/WebCore/Modules/mediasession/MediaSession.cpp:62 > + , m_kind(MediaSession::Kind::Default) Here in the MediaSession class, the name of this type is Kind, not MediaSession::Kind, so can leave off the MediaSession part. Seems that m_kind could default to this in the header, then we could omit it in this constructor. Syntax we would normally use in the class definition is: Kind m_kind { Kind::Default }; > Source/WebCore/Modules/mediasession/MediaSession.h:53 > + MediaSession(Document&); Probably should be: explicit MediaSession(Document&); 1105341 4 mrajca 2015-06-28 22:21:45 -0700 (In reply to comment #3) > Comment on attachment 255676 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=255676&action=review > > > Source/WebCore/Modules/mediasession/MediaSession.cpp:62 > > + , m_kind(MediaSession::Kind::Default) > > Here in the MediaSession class, the name of this type is Kind, not > MediaSession::Kind, so can leave off the MediaSession part. > > Seems that m_kind could default to this in the header, then we could omit it > in this constructor. Syntax we would normally use in the class definition is: > > Kind m_kind { Kind::Default }; That's simpler. Changed. > > > Source/WebCore/Modules/mediasession/MediaSession.h:53 > > + MediaSession(Document&); > > Probably should be: > > explicit MediaSession(Document&); Yup, looks like we use `explicit` heavily throughout WebKit to avoid implicit conversions with single-argument constructors. Thanks! 1105342 5 mrajca 2015-06-28 22:32:33 -0700 Committed r186064: <http://trac.webkit.org/changeset/186064> 255676 2015-06-26 16:58:29 -0700 2015-06-27 15:31:16 -0700 Patch bug-146355-20150626165742.patch text/plain 6052 mrajca U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2MDAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODhkZGVkNTAyZTNkNDAx ODJkZGM2MDAxMjZjZmY1YjkyMWY4MzZjZi4uZTNmMGI2MTQ1M2NlMWZhY2Y0OTY0MGY5NTU2OTMw MWFkZjM0NTBiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA2LTI2ICBNYXR0 IFJhamNhICA8bXJhamNhQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgc3VwcG9ydCBmb3IgJ0Rl ZmF1bHQnIG1lZGlhIHNlc3Npb24gdHlwZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0NjM1NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXNlc3Npb24vTWVkaWFTZXNzaW9uLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU2Vzc2lvbjo6TWVkaWFTZXNzaW9uKTogQWRkZWQg YSBuZXcgY29uc3RydWN0b3IgZm9yIGNyZWF0aW5nICdEZWZhdWx0JyBtZWRpYSBzZXNzaW9ucy4K KyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU2Vzc2lvbjo6a2luZCk6ICdEZWZhdWx0JyBtZWRpYSBz ZXNzaW9ucyBhcmUgcmVwcmVzZW50ZWQgYnkgYW4gZW1wdHkgc3RyaW5nLgorICAgICAgICAqIE1v ZHVsZXMvbWVkaWFzZXNzaW9uL01lZGlhU2Vzc2lvbi5oOgorICAgICAgICAqIGRvbS9Eb2N1bWVu dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6ZGVmYXVsdE1lZGlhU2Vzc2lvbik6 IExhemlseSBjb25zdHJ1Y3QgdGhlIGRlZmF1bHQgbWVkaWEgc2Vzc2lvbi4KKyAgICAgICAgKiBk b20vRG9jdW1lbnQuaDoKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6SFRNTE1lZGlhRWxlbWVudCk6IE5ldyBt ZWRpYSBlbGVtZW50cyBhcmUgYXNzaWduZWQgdG8gdGhlICdEZWZhdWx0JyBtZWRpYSBzZXNzaW9u LgorCiAyMDE1LTA2LTI2ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+ CiAKICAgICAgICAgW0NvY29hXSBTYW5zLXNlcmlmIGdlbmVyaWMgZm9udCBmYW1pbHkgc2hvdWxk IG1hcCB0byBQaW5nRmFuZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YXNlc3Npb24vTWVkaWFTZXNzaW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFz ZXNzaW9uL01lZGlhU2Vzc2lvbi5jcHAKaW5kZXggYjQ3ODA1ZmU4MmM1NjMwYjg4YTQwZTdjNWQ2 MDU2ZjFhZGVkZGM2OS4uZTNmMjgyNjYwZWEwYTQxNGFmNjMzMWE2ZTc5NDBjM2MxM2NmMTUzOCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNlc3Npb24vTWVkaWFTZXNz aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc2Vzc2lvbi9NZWRpYVNl c3Npb24uY3BwCkBAIC0zNyw2ICszNyw3IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorc3Rh dGljIGNvbnN0IGNoYXIqIGRlZmF1bHRLaW5kID0gIiI7CiBzdGF0aWMgY29uc3QgY2hhciogYW1i aWVudEtpbmQgPSAiYW1iaWVudCI7CiBzdGF0aWMgY29uc3QgY2hhciogdHJhbnNpZW50S2luZCA9 ICJ0cmFuc2llbnQiOwogc3RhdGljIGNvbnN0IGNoYXIqIHRyYW5zaWVudFNvbG9LaW5kID0gInRy YW5zaWVudC1zb2xvIjsKQEAgLTU2LDYgKzU3LDEzIEBAIE1lZGlhU2Vzc2lvbjo6S2luZCBNZWRp YVNlc3Npb246OnBhcnNlS2luZChjb25zdCBTdHJpbmcmIGtpbmQpCiAgICAgcmV0dXJuIE1lZGlh U2Vzc2lvbjo6S2luZDo6Q29udGVudDsKIH0KIAorTWVkaWFTZXNzaW9uOjpNZWRpYVNlc3Npb24o RG9jdW1lbnQmIGRvY3VtZW50KQorICAgIDogbV9kb2N1bWVudChkb2N1bWVudCkKKyAgICAsIG1f a2luZChNZWRpYVNlc3Npb246OktpbmQ6OkRlZmF1bHQpCit7CisgICAgTWVkaWFTZXNzaW9uTWFu YWdlcjo6c2luZ2xldG9uKCkuYWRkTWVkaWFTZXNzaW9uKCp0aGlzKTsKK30KKwogTWVkaWFTZXNz aW9uOjpNZWRpYVNlc3Npb24oU2NyaXB0RXhlY3V0aW9uQ29udGV4dCYgY29udGV4dCwgY29uc3Qg U3RyaW5nJiBraW5kKQogICAgIDogbV9kb2N1bWVudChkb3duY2FzdDxEb2N1bWVudD4oY29udGV4 dCkpCiAgICAgLCBtX2tpbmQocGFyc2VLaW5kKGtpbmQpKQpAQCAtNzcsNiArODUsOCBAQCBNZWRp YVNlc3Npb246On5NZWRpYVNlc3Npb24oKQogU3RyaW5nIE1lZGlhU2Vzc2lvbjo6a2luZCgpIGNv bnN0CiB7CiAgICAgc3dpdGNoIChtX2tpbmQpIHsKKyAgICBjYXNlIE1lZGlhU2Vzc2lvbjo6S2lu ZDo6RGVmYXVsdDoKKyAgICAgICAgcmV0dXJuIGRlZmF1bHRLaW5kOwogICAgIGNhc2UgTWVkaWFT ZXNzaW9uOjpLaW5kOjpBbWJpZW50OgogICAgICAgICByZXR1cm4gYW1iaWVudEtpbmQ7CiAgICAg Y2FzZSBNZWRpYVNlc3Npb246OktpbmQ6OlRyYW5zaWVudDoKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFzZXNzaW9uL01lZGlhU2Vzc2lvbi5oIGIvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9tZWRpYXNlc3Npb24vTWVkaWFTZXNzaW9uLmgKaW5kZXggZDA0NDM1Zjg5ODQ2 OTY3ZTUzNjFlODVjOWFhY2MyYzM0OTUyMTdhYy4uZTBmZDc5ZWViMzU2MjljM2VkMTAzMWU5MzFm MjliZDhlZDgzNmY1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNl c3Npb24vTWVkaWFTZXNzaW9uLmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNl c3Npb24vTWVkaWFTZXNzaW9uLmgKQEAgLTUwLDYgKzUwLDcgQEAgcHVibGljOgogICAgICAgICBy ZXR1cm4gYWRvcHRSZWYoKm5ldyBNZWRpYVNlc3Npb24oY29udGV4dCwga2luZCkpOwogICAgIH0K IAorICAgIE1lZGlhU2Vzc2lvbihEb2N1bWVudCYpOwogICAgIE1lZGlhU2Vzc2lvbihTY3JpcHRF eGVjdXRpb25Db250ZXh0JiwgY29uc3QgU3RyaW5nJik7CiAgICAgfk1lZGlhU2Vzc2lvbigpOwog CkBAIC03Myw2ICs3NCw3IEBAIHByaXZhdGU6CiAgICAgZnJpZW5kIGNsYXNzIEhUTUxNZWRpYUVs ZW1lbnQ7CiAKICAgICBlbnVtIGNsYXNzIEtpbmQgeworICAgICAgICBEZWZhdWx0LAogICAgICAg ICBDb250ZW50LAogICAgICAgICBUcmFuc2llbnQsCiAgICAgICAgIFRyYW5zaWVudFNvbG8sCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNv cmUvZG9tL0RvY3VtZW50LmNwcAppbmRleCBmNTVmOWIxZjRlMDMxMDBlODI4NGU4MGM3ODZkNGY5 ZjhkZDc1NGIzLi44ZDZlOTZhNzAwOTlhNjIzMGE2NDc4NzJhZmU4M2E3ZDkwNzI3ZjNlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTIzMyw2ICsyMzMsMTAgQEAKICNpbmNsdWRlICJNZWRp YVBsYXliYWNrVGFyZ2V0Q2xpZW50LmgiCiAjZW5kaWYKIAorI2lmIEVOQUJMRShNRURJQV9TRVNT SU9OKQorI2luY2x1ZGUgIk1lZGlhU2Vzc2lvbi5oIgorI2VuZGlmCisKIHVzaW5nIG5hbWVzcGFj ZSBXVEY7CiB1c2luZyBuYW1lc3BhY2UgVW5pY29kZTsKIApAQCAtNjY1MCw2ICs2NjU0LDE2IEBA IHZvaWQgRG9jdW1lbnQ6OnNldFNob3VsZFBsYXlUb1BsYXliYWNrVGFyZ2V0KHVpbnQ2NF90IGNs aWVudElkLCBib29sIHNob3VsZFBsYXkpCiB9CiAjZW5kaWYgLy8gRU5BQkxFKFdJUkVMRVNTX1BM QVlCQUNLX1RBUkdFVCkKIAorI2lmIEVOQUJMRShNRURJQV9TRVNTSU9OKQorTWVkaWFTZXNzaW9u JiBEb2N1bWVudDo6ZGVmYXVsdE1lZGlhU2Vzc2lvbigpCit7CisgICAgaWYgKCFtX2RlZmF1bHRN ZWRpYVNlc3Npb24pCisgICAgICAgIG1fZGVmYXVsdE1lZGlhU2Vzc2lvbiA9IGFkb3B0UmVmKCpu ZXcgTWVkaWFTZXNzaW9uKCp0aGlzKSk7CisKKyAgICByZXR1cm4gKm1fZGVmYXVsdE1lZGlhU2Vz c2lvbjsKK30KKyNlbmRpZgorCiBTaG91bGRPcGVuRXh0ZXJuYWxVUkxzUG9saWN5IERvY3VtZW50 OjpzaG91bGRPcGVuRXh0ZXJuYWxVUkxzUG9saWN5VG9Qcm9wYWdhdGUoKSBjb25zdAogewogICAg IGlmIChEb2N1bWVudExvYWRlciogZG9jdW1lbnRMb2FkZXIgPSBsb2FkZXIoKSkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL0Rv Y3VtZW50LmgKaW5kZXggMGRiNjE0MzM3MjRkMjViMWI1ZTc2ZmQwNzIzOGQ0YjA1MTJlYTVmZi4u NDI5OTE1OTI0MzM3NjljNGJkZmMxNWNkYjlhYzljMGY2OGI0MWI5YiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3Vt ZW50LmgKQEAgLTIyMiw2ICsyMjIsMTAgQEAgc3RydWN0IFRleHRBdXRvU2l6aW5nVHJhaXRzIDog V1RGOjpHZW5lcmljSGFzaFRyYWl0czxUZXh0QXV0b1NpemluZ0tleT4gewogfTsKICNlbmRpZgog CisjaWYgRU5BQkxFKE1FRElBX1NFU1NJT04pCitjbGFzcyBNZWRpYVNlc3Npb247CisjZW5kaWYK KwogZW51bSBQYWdlc2hvd0V2ZW50UGVyc2lzdGVuY2UgewogICAgIFBhZ2VzaG93RXZlbnROb3RQ ZXJzaXN0ZWQgPSAwLAogICAgIFBhZ2VzaG93RXZlbnRQZXJzaXN0ZWQgPSAxCkBAIC05ODAsNiAr OTg0LDEwIEBAIHB1YmxpYzoKICAgICB2b2lkIHVucmVnaXN0ZXJGb3JNZWRpYVZvbHVtZUNhbGxi YWNrcyhFbGVtZW50Kik7CiAgICAgdm9pZCBtZWRpYVZvbHVtZURpZENoYW5nZSgpOwogCisjaWYg RU5BQkxFKE1FRElBX1NFU1NJT04pCisgICAgTWVkaWFTZXNzaW9uJiBkZWZhdWx0TWVkaWFTZXNz aW9uKCk7CisjZW5kaWYKKwogICAgIHZvaWQgcmVnaXN0ZXJGb3JQcml2YXRlQnJvd3NpbmdTdGF0 ZUNoYW5nZWRDYWxsYmFja3MoRWxlbWVudCopOwogICAgIHZvaWQgdW5yZWdpc3RlckZvclByaXZh dGVCcm93c2luZ1N0YXRlQ2hhbmdlZENhbGxiYWNrcyhFbGVtZW50Kik7CiAgICAgdm9pZCBzdG9y YWdlQmxvY2tpbmdTdGF0ZURpZENoYW5nZSgpOwpAQCAtMTcwNiw2ICsxNzE0LDEwIEBAIHByaXZh dGU6CiAgICAgdHlwZWRlZiBIYXNoTWFwPFdlYkNvcmU6Ok1lZGlhUGxheWJhY2tUYXJnZXRDbGll bnQqLCB1aW50NjRfdD4gVGFyZ2V0Q2xpZW50VG9JZE1hcDsKICAgICBUYXJnZXRDbGllbnRUb0lk TWFwIG1fY2xpZW50VG9JRE1hcDsKICNlbmRpZgorCisjaWYgRU5BQkxFKE1FRElBX1NFU1NJT04p CisgICAgUmVmUHRyPE1lZGlhU2Vzc2lvbj4gbV9kZWZhdWx0TWVkaWFTZXNzaW9uOworI2VuZGlm CiB9OwogCiBpbmxpbmUgdm9pZCBEb2N1bWVudDo6bm90aWZ5UmVtb3ZlUGVuZGluZ1NoZWV0SWZO ZWVkZWQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKaW5kZXggZGQy NmNjYTg1YmE4NjJjMzk4YmZhOGFiZTgzMDMyNTU2YWU1NDlkNS4uYmYxNDk5ZmE5NzFmZTU1Mjc0 NTU1NmJiZjQ3YzE4MzgxOTI4MjM1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MTWVkaWFFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVs ZW1lbnQuY3BwCkBAIC00MDAsNiArNDAwLDEwIEBAIEhUTUxNZWRpYUVsZW1lbnQ6OkhUTUxNZWRp YUVsZW1lbnQoY29uc3QgUXVhbGlmaWVkTmFtZSYgdGFnTmFtZSwgRG9jdW1lbnQmIGRvY3VtCiAg ICAgICAgIG1fY2FwdGlvbkRpc3BsYXlNb2RlID0gZG9jdW1lbnQucGFnZSgpLT5ncm91cCgpLmNh cHRpb25QcmVmZXJlbmNlcygpLT5jYXB0aW9uRGlzcGxheU1vZGUoKTsKICNlbmRpZgogCisjaWYg RU5BQkxFKE1FRElBX1NFU1NJT04pCisgICAgbV9zZXNzaW9uID0gJmRvY3VtZW50LmRlZmF1bHRN ZWRpYVNlc3Npb24oKTsKKyNlbmRpZgorCiAgICAgcmVnaXN0ZXJXaXRoRG9jdW1lbnQoZG9jdW1l bnQpOwogfQogCg==