14635 2007-07-17 01:32:35 -0700 Uploading file with non-ASCII character in path fails 2007-08-13 22:52:38 -0700 1 1 1 Unclassified WebKit Forms 523.x (Safari 3) PC Windows XP RESOLVED FIXED InRadar P2 Major --- 1 808caaa4.8ce9.9cd6c799e9f6 ap ap ddkilzer oldest_to_newest 4563 0 808caaa4.8ce9.9cd6c799e9f6 2007-07-17 01:32:35 -0700 With this site(webkit-buglizza), I cannot upload file from my Desktop. After moving file to somewhere like c:\__sendtemp\, uploading succeeded. 'filename' is full path, and contains UTF8(nonascii) chars. With some environment directory name "desktop" is localized into nonascii strings. I don't know who has responsiblility, or whether we should always send fullpath. ; =============== ; posts ; =============== POST http://bugs.webkit.org/attachment.cgi HTTP/1.1 User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja) AppleWebKit/522.14.1+ (KHTML, like Gecko) Version/3.0.2 Safari/522.13.1 Content-Type: multipart/form-data; boundary=----WebKitFormBoundaryAAsdAAJVAApEAA5j Transfer-Encoding: Chunked ..... ------WebKitFormBoundaryAAsdAAJVAApEAA5j Content-Disposition: form-data; name="data"; filename="C:\Documents and Settings\*****\εγ‘¦€»εβ―εγ°ε₯γεγΝ½test.html.png" Content-Type: image/png ; =============== ; response ; =============== HTTP/1.1 411 Length Required Server: Apache/1.3.33 (Darwin) PHP/4.4.1 mod_ssl/2.8.24 OpenSSL/0.9.7i DAV/1.0.3 Transfer-Encoding: chunked Content-Type: text/html; charset=iso-8859-1 4557 1 808caaa4.8ce9.9cd6c799e9f6 2007-07-17 02:07:46 -0700 Oh, HTMLFormElement::formData() converts path to current encoding. At the time above I certainly settled DefaultEncoding as UTF8. Now I retried with reloaded attachment.cgi while Encoding->Europian. Path is converted as below and still uploading failed. Content-Disposition: form-data; name="data"; filename="C:\Documents and Settings\********\デスクトップ\test.txt" 4550 2 ap 2007-07-17 04:16:48 -0700 I might well be wrong, but I think that a full path is not really needed (and is sometimes harmful) in Content-Disposition, so just a file name can be sent. Would you be willing to submit such a patch for WebCore, as described in <http://webkit.org/coding/contributing.html>? 4514 3 ddkilzer 2007-07-17 08:23:03 -0700 What does Firefox or MSIE (or Opera) when uploading this file? Do they encode the path differently? 4515 4 ddkilzer 2007-07-17 08:24:01 -0700 (In reply to comment #2) > I might well be wrong, but I think that a full path is not really needed (and > is sometimes harmful) in Content-Disposition, so just a file name can be sent. But if the actual file contained UTF8 (non-ASCII) characters, this doesn't really fix the issue. 4516 5 ddkilzer 2007-07-17 08:24:35 -0700 <rdar://problem/5340188> 4493 6 ap 2007-07-17 12:44:56 -0700 (In reply to comment #4) > But if the actual file contained UTF8 (non-ASCII) characters, this doesn't > really fix the issue. That's true, but we don't have to fix everything at once - there isn't any 100% correct solution for non-ASCII characters in HTTP headers AFAIK, so it will take a lot of tweaking. Also, most experienced users know about the perils of non-ASCII file names, while it's really hard to guess that a problem with uploading is caused by a directory name somewhere in the path. 4421 7 ddkilzer 2007-07-18 08:34:49 -0700 (In reply to comment #6) > (In reply to comment #4) > > But if the actual file contained UTF8 (non-ASCII) characters, this doesn't > > really fix the issue. > > That's true, but we don't have to fix everything at once - there isn't any 100% > correct solution for non-ASCII characters in HTTP headers AFAIK, so it will > take a lot of tweaking. > > Also, most experienced users know about the perils of non-ASCII file names, > while it's really hard to guess that a problem with uploading is caused by a > directory name somewhere in the path. My main concern is that this would make Safari on Windows behave differently from every other browser with respect to uploading files. 4382 8 ddkilzer 2007-07-18 15:26:25 -0700 Why can't we use "encoded-word" encoding for the path as defined by RFC 2047? It's perfect for this application--encoding non-US-ASCII characters in a US-ASCII-only field! We could either encode the path on a per-directory basis (encode each set of characters between directory separators), or encode the whole string. (I would recommend encoding text between each directory separator since server-side software would have to be updated to understand how to decode such fields.) http://tools.ietf.org/html/rfc2047 Updates to RFC 2047: http://tools.ietf.org/html/rfc2184 http://tools.ietf.org/html/rfc2231 Confirming bug based on empirical evidence. 4363 9 ap 2007-07-18 21:30:52 -0700 (In reply to comment #8) > Why can't we use "encoded-word" encoding for the path as defined by RFC 2047? Let's track this as a separate bug, please. The fact that a full path is sent from Windows is just a porting bug AFAICT - it's not sent from the Mac. 4314 10 808caaa4.8ce9.9cd6c799e9f6 2007-07-19 03:56:54 -0700 /* bug#14667 for the encoding of filename part discussion */ 2782 11 ap 2007-08-08 22:21:49 -0700 The problem is in HTMLFormElement::formData(): int start = path.reverseFind('/') + 1; We should be using PathFindFileName() API on Windows, and possibly basename(3) where available. I'm trying to think of a good place to put a helper function... 2503 12 15933 ap 2007-08-11 12:50:38 -0700 Created attachment 15933 proposed fix Not tested, as I don't have a Windows build environment set up. AFAICT, path operations aren't needed anywhere else in WebCore, so a slightly buggy static helper looks like an fine solution :-) 2504 13 15933 aroben 2007-08-11 12:54:17 -0700 Comment on attachment 15933 proposed fix +static String pathGetFileName(const String& path) +{ +#if PLATFORM(WIN_OS) + return String(PathFindFileName(path.charactersWithNullTermination())); This won't compile, since charactersWithNullTermination is a non-const instance method. 2506 14 15934 ap 2007-08-11 13:03:26 -0700 Created attachment 15934 updated patch Oops - I wonder why it is non-const if it doesn't really modify the string. 2397 15 15934 darin 2007-08-13 11:39:27 -0700 Comment on attachment 15934 updated patch + return String(PathFindFileName(path.charactersWithNullTermination())); Do you need the explicit String() here? Doesn't the conversion happen automatically? Also, we often use "filename" as a single word; so I think the variables and functions could just be all lowercase. r=me 2392 16 ap 2007-08-13 12:12:25 -0700 (In reply to comment #15) > Do you need the explicit String() here? Doesn't the conversion happen > automatically? I wondered the same when I saw such a construct in FileChooserWin.cpp, so I preserved it for safety (I don't have a Windows build environment set up at the moment). 2374 17 ap 2007-08-13 22:52:38 -0700 Committed revision 25067. 15933 2007-08-11 12:50:38 -0700 2007-08-11 13:03:26 -0700 proposed fix 14635r1_patch.txt text/plain 2944 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTAxMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDctMDgtMTEgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjM1CisgICAgICAgIHJk YXI6Ly9wcm9ibGVtLzUzNDAxODgKKyAgICAgICAgVXBsb2FkaW5nIGZpbGUgd2l0aCBub24tQVND SUkgY2hhcmFjdGVyIGluIHBhdGggZmFpbHMKKworICAgICAgICBGaWxlIHVwbG9hZCBjYW5ub3Qg YmUgdGVzdGVkIGluIER1bXBSZW5kZXJUcmVlLgorCisgICAgICAgICogaHRtbC9IVE1MRm9ybUVs ZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cGF0aEdldEZpbGVOYW1lKTogQSBjcm9zcy1w bGF0Zm9ybSBoZWxwZXIgdGhhdCBleHRyYWN0cyBhIGZpbGUgbmFtZSBmcm9tIGEgcGF0aC4KKyAg ICAgICAgKFdlYkNvcmU6OkhUTUxGb3JtRWxlbWVudDo6Zm9ybURhdGEpOiBVc2UgdGhlIGFib3Zl IGhlbHBlciBpbnN0ZWFkIG9mIGNvZGUgdGhhdCBkb2Vzbid0IHdvcmsgb24gV2luZG93cy4KKwog MjAwNy0wOC0xMSAgTWl0eiBQZXR0ZWwgIDxtaXR6QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGFyaW4uCkluZGV4OiBXZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmNwcAkocmV2aXNpb24g MjUwMTMpCisrKyBXZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMjE1LDYgKzIxNSwxOCBAQCBzdGF0aWMgaW50IHJhbmRvbU51bWJlcigpCiAjZW5kaWYK IH0KIAorLy8gV2FybmluZzogdGhpcyBoZWxwZXIgZG9lc24ndCBjdXJyZW50bHkgaGF2ZSBhIHJl bGlhYmxlIGNyb3NzLXBsYXRmb3JtIGJlaGF2aW9yIGluIGNlcnRhaW4gZWRnZSBjYXNlcworLy8g KHNlZSBiYXNlbmFtZSgzKSBzcGVjaWZpY2F0aW9uIGZvciBleGFtcGxlcykuCisvLyBDb25zaWRl ciB0aGlzIGlmIGl0IGV2ZXIgbmVlZHMgdG8gYmVjb21lIGEgZ2VuZXJhbCBwdXJwb3NlIG1ldGhv ZC4KK3N0YXRpYyBTdHJpbmcgcGF0aEdldEZpbGVOYW1lKGNvbnN0IFN0cmluZyYgcGF0aCkKK3sK KyNpZiBQTEFURk9STShXSU5fT1MpCisgICAgcmV0dXJuIFN0cmluZyhQYXRoRmluZEZpbGVOYW1l KHBhdGguY2hhcmFjdGVyc1dpdGhOdWxsVGVybWluYXRpb24oKSkpOworI2Vsc2UKKyAgICByZXR1 cm4gcGF0aC5zdWJzdHJpbmcocGF0aC5yZXZlcnNlRmluZCgnLycpICsgMSk7CisjZW5kaWYKK30K KwogUGFzc1JlZlB0cjxGb3JtRGF0YT4gSFRNTEZvcm1FbGVtZW50Ojpmb3JtRGF0YShjb25zdCBj aGFyKiBib3VuZGFyeSkgY29uc3QKIHsKICAgICBEZXByZWNhdGVkQ1N0cmluZyBlbmNfc3RyaW5n ID0gIiI7CkBAIC0yNzUsMTUgKzI4NywxNCBAQCBQYXNzUmVmUHRyPEZvcm1EYXRhPiBIVE1MRm9y bUVsZW1lbnQ6OmZvCiAgICAgICAgICAgICAgICAgICAgIGlmIChjdXJyZW50LT5oYXNMb2NhbE5h bWUoaW5wdXRUYWcpICYmCiAgICAgICAgICAgICAgICAgICAgICAgICBzdGF0aWNfY2FzdDxIVE1M SW5wdXRFbGVtZW50Kj4oY3VycmVudCktPmlucHV0VHlwZSgpID09IEhUTUxJbnB1dEVsZW1lbnQ6 OkZJTEUpIHsKICAgICAgICAgICAgICAgICAgICAgICAgIFN0cmluZyBwYXRoID0gc3RhdGljX2Nh c3Q8SFRNTElucHV0RWxlbWVudCo+KGN1cnJlbnQpLT52YWx1ZSgpOworICAgICAgICAgICAgICAg ICAgICAgICAgU3RyaW5nIGZpbGVOYW1lID0gcGF0aEdldEZpbGVOYW1lKHBhdGgpOwogCiAgICAg ICAgICAgICAgICAgICAgICAgICAvLyBGSVhNRTogVGhpcyB3b24ndCB3b3JrIGlmIHRoZSBmaWxl bmFtZSBpbmNsdWRlcyBhICIgbWFyaywKICAgICAgICAgICAgICAgICAgICAgICAgIC8vIG9yIGNv bnRyb2wgY2hhcmFjdGVycyBsaWtlIENSIG9yIExGLiBUaGlzIGFsc28gZG9lcyBzdHJhbmdlCiAg ICAgICAgICAgICAgICAgICAgICAgICAvLyB0aGluZ3MgaWYgdGhlIGZpbGVuYW1lIGluY2x1ZGVz IGNoYXJhY3RlcnMgeW91IGNhbid0IGVuY29kZQogICAgICAgICAgICAgICAgICAgICAgICAgLy8g aW4gdGhlIHdlYnNpdGUncyBjaGFyYWN0ZXIgc2V0LgogICAgICAgICAgICAgICAgICAgICAgICAg aHN0ciArPSAiOyBmaWxlbmFtZT1cIiI7Ci0gICAgICAgICAgICAgICAgICAgICAgICBpbnQgc3Rh cnQgPSBwYXRoLnJldmVyc2VGaW5kKCcvJykgKyAxOwotICAgICAgICAgICAgICAgICAgICAgICAg aW50IGxlbmd0aCA9IHBhdGgubGVuZ3RoKCkgLSBzdGFydDsKLSAgICAgICAgICAgICAgICAgICAg ICAgIGhzdHIgKz0gZW5jb2RpbmcuZW5jb2RlKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgVUNoYXIq PihwYXRoLmNoYXJhY3RlcnMoKSArIHN0YXJ0KSwgbGVuZ3RoLCB0cnVlKS5kYXRhKCk7CisgICAg ICAgICAgICAgICAgICAgICAgICBoc3RyICs9IGVuY29kaW5nLmVuY29kZShyZWludGVycHJldF9j YXN0PGNvbnN0IFVDaGFyKj4oZmlsZU5hbWUuY2hhcmFjdGVycygpKSwgZmlsZU5hbWUubGVuZ3Ro KCksIHRydWUpLmRhdGEoKTsKICAgICAgICAgICAgICAgICAgICAgICAgIGhzdHIgKz0gIlwiIjsK IAogICAgICAgICAgICAgICAgICAgICAgICAgaWYgKCFzdGF0aWNfY2FzdDxIVE1MSW5wdXRFbGVt ZW50Kj4oY3VycmVudCktPnZhbHVlKCkuaXNFbXB0eSgpKSB7Cg== 15934 2007-08-11 13:03:26 -0700 2007-08-13 11:39:27 -0700 updated patch 14635r2_patch.txt text/plain 2937 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTAxMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDctMDgtMTEgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjM1CisgICAgICAgIHJk YXI6Ly9wcm9ibGVtLzUzNDAxODgKKyAgICAgICAgVXBsb2FkaW5nIGZpbGUgd2l0aCBub24tQVND SUkgY2hhcmFjdGVyIGluIHBhdGggZmFpbHMKKworICAgICAgICBGaWxlIHVwbG9hZCBjYW5ub3Qg YmUgdGVzdGVkIGluIER1bXBSZW5kZXJUcmVlLgorCisgICAgICAgICogaHRtbC9IVE1MRm9ybUVs ZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cGF0aEdldEZpbGVOYW1lKTogQSBjcm9zcy1w bGF0Zm9ybSBoZWxwZXIgdGhhdCBleHRyYWN0cyBhIGZpbGUgbmFtZSBmcm9tIGEgcGF0aC4KKyAg ICAgICAgKFdlYkNvcmU6OkhUTUxGb3JtRWxlbWVudDo6Zm9ybURhdGEpOiBVc2UgdGhlIGFib3Zl IGhlbHBlciBpbnN0ZWFkIG9mIGNvZGUgdGhhdCBkb2Vzbid0IHdvcmsgb24gV2luZG93cy4KKwog MjAwNy0wOC0xMSAgTWl0eiBQZXR0ZWwgIDxtaXR6QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGFyaW4uCkluZGV4OiBXZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmNwcAkocmV2aXNpb24g MjUwMTMpCisrKyBXZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMjE1LDYgKzIxNSwxOCBAQCBzdGF0aWMgaW50IHJhbmRvbU51bWJlcigpCiAjZW5kaWYK IH0KIAorLy8gV2FybmluZzogdGhpcyBoZWxwZXIgZG9lc24ndCBjdXJyZW50bHkgaGF2ZSBhIHJl bGlhYmxlIGNyb3NzLXBsYXRmb3JtIGJlaGF2aW9yIGluIGNlcnRhaW4gZWRnZSBjYXNlcworLy8g KHNlZSBiYXNlbmFtZSgzKSBzcGVjaWZpY2F0aW9uIGZvciBleGFtcGxlcykuCisvLyBDb25zaWRl ciB0aGlzIGlmIGl0IGV2ZXIgbmVlZHMgdG8gYmVjb21lIGEgZ2VuZXJhbCBwdXJwb3NlIG1ldGhv ZC4KK3N0YXRpYyBTdHJpbmcgcGF0aEdldEZpbGVOYW1lKFN0cmluZyBwYXRoKQoreworI2lmIFBM QVRGT1JNKFdJTl9PUykKKyAgICByZXR1cm4gU3RyaW5nKFBhdGhGaW5kRmlsZU5hbWUocGF0aC5j aGFyYWN0ZXJzV2l0aE51bGxUZXJtaW5hdGlvbigpKSk7CisjZWxzZQorICAgIHJldHVybiBwYXRo LnN1YnN0cmluZyhwYXRoLnJldmVyc2VGaW5kKCcvJykgKyAxKTsKKyNlbmRpZgorfQorCiBQYXNz UmVmUHRyPEZvcm1EYXRhPiBIVE1MRm9ybUVsZW1lbnQ6OmZvcm1EYXRhKGNvbnN0IGNoYXIqIGJv dW5kYXJ5KSBjb25zdAogewogICAgIERlcHJlY2F0ZWRDU3RyaW5nIGVuY19zdHJpbmcgPSAiIjsK QEAgLTI3NSwxNSArMjg3LDE0IEBAIFBhc3NSZWZQdHI8Rm9ybURhdGE+IEhUTUxGb3JtRWxlbWVu dDo6Zm8KICAgICAgICAgICAgICAgICAgICAgaWYgKGN1cnJlbnQtPmhhc0xvY2FsTmFtZShpbnB1 dFRhZykgJiYKICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXRpY19jYXN0PEhUTUxJbnB1dEVs ZW1lbnQqPihjdXJyZW50KS0+aW5wdXRUeXBlKCkgPT0gSFRNTElucHV0RWxlbWVudDo6RklMRSkg ewogICAgICAgICAgICAgICAgICAgICAgICAgU3RyaW5nIHBhdGggPSBzdGF0aWNfY2FzdDxIVE1M SW5wdXRFbGVtZW50Kj4oY3VycmVudCktPnZhbHVlKCk7CisgICAgICAgICAgICAgICAgICAgICAg ICBTdHJpbmcgZmlsZU5hbWUgPSBwYXRoR2V0RmlsZU5hbWUocGF0aCk7CiAKICAgICAgICAgICAg ICAgICAgICAgICAgIC8vIEZJWE1FOiBUaGlzIHdvbid0IHdvcmsgaWYgdGhlIGZpbGVuYW1lIGlu Y2x1ZGVzIGEgIiBtYXJrLAogICAgICAgICAgICAgICAgICAgICAgICAgLy8gb3IgY29udHJvbCBj aGFyYWN0ZXJzIGxpa2UgQ1Igb3IgTEYuIFRoaXMgYWxzbyBkb2VzIHN0cmFuZ2UKICAgICAgICAg ICAgICAgICAgICAgICAgIC8vIHRoaW5ncyBpZiB0aGUgZmlsZW5hbWUgaW5jbHVkZXMgY2hhcmFj dGVycyB5b3UgY2FuJ3QgZW5jb2RlCiAgICAgICAgICAgICAgICAgICAgICAgICAvLyBpbiB0aGUg d2Vic2l0ZSdzIGNoYXJhY3RlciBzZXQuCiAgICAgICAgICAgICAgICAgICAgICAgICBoc3RyICs9 ICI7IGZpbGVuYW1lPVwiIjsKLSAgICAgICAgICAgICAgICAgICAgICAgIGludCBzdGFydCA9IHBh dGgucmV2ZXJzZUZpbmQoJy8nKSArIDE7Ci0gICAgICAgICAgICAgICAgICAgICAgICBpbnQgbGVu Z3RoID0gcGF0aC5sZW5ndGgoKSAtIHN0YXJ0OwotICAgICAgICAgICAgICAgICAgICAgICAgaHN0 ciArPSBlbmNvZGluZy5lbmNvZGUocmVpbnRlcnByZXRfY2FzdDxjb25zdCBVQ2hhcio+KHBhdGgu Y2hhcmFjdGVycygpICsgc3RhcnQpLCBsZW5ndGgsIHRydWUpLmRhdGEoKTsKKyAgICAgICAgICAg ICAgICAgICAgICAgIGhzdHIgKz0gZW5jb2RpbmcuZW5jb2RlKHJlaW50ZXJwcmV0X2Nhc3Q8Y29u c3QgVUNoYXIqPihmaWxlTmFtZS5jaGFyYWN0ZXJzKCkpLCBmaWxlTmFtZS5sZW5ndGgoKSwgdHJ1 ZSkuZGF0YSgpOwogICAgICAgICAgICAgICAgICAgICAgICAgaHN0ciArPSAiXCIiOwogCiAgICAg ICAgICAgICAgICAgICAgICAgICBpZiAoIXN0YXRpY19jYXN0PEhUTUxJbnB1dEVsZW1lbnQqPihj dXJyZW50KS0+dmFsdWUoKS5pc0VtcHR5KCkpIHsK