146343 2015-06-26 04:40:08 -0700 [Curl] Compile errors; ResourceResponseBase::resourceLoadTiming() has changed return type. 2015-06-26 11:53:27 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham commit-queue galpeter ossy oldest_to_newest 1104908 0 peavo 2015-06-26 04:40:08 -0700 The resourceLoadTiming() member of the class ResourceResponseBase does not return a pointer, but a reference. 1104912 1 255633 peavo 2015-06-26 05:23:44 -0700 Created attachment 255633 Patch 1104936 2 255633 bfulgham 2015-06-26 09:20:18 -0700 Comment on attachment 255633 Patch r=me. Thank you for fixing this! 1104963 3 255633 commit-queue 2015-06-26 10:10:49 -0700 Comment on attachment 255633 Patch Clearing flags on attachment: 255633 Committed r186000: <http://trac.webkit.org/changeset/186000> 1104964 4 commit-queue 2015-06-26 10:10:55 -0700 All reviewed patches have been landed. Closing bug. 1105006 5 peavo 2015-06-26 11:53:27 -0700 (In reply to comment #2) > Comment on attachment 255633 [details] > Patch > > r=me. Thank you for fixing this! Thanks for reviewing :) 255633 2015-06-26 05:23:44 -0700 2015-06-26 10:10:49 -0700 Patch bug-146343-20150626142239.patch text/plain 4312 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTk5MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA2LTI2ICBQZXIgQXJu ZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbQ3VybF0gQ29tcGlsZSBl cnJvcnM7IFJlc291cmNlUmVzcG9uc2VCYXNlOjpyZXNvdXJjZUxvYWRUaW1pbmcoKSBoYXMgY2hh bmdlZCByZXR1cm4gdHlwZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE0NjM0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpjYWxjdWxhdGVXZWJUaW1pbmdJbmZvcm1hdGlvbnMpOgor ICAgICAgICAoV2ViQ29yZTo6aGVhZGVyQ2FsbGJhY2spOgorICAgICAgICAoV2ViQ29yZTo6UmVz b3VyY2VIYW5kbGVNYW5hZ2VyOjppbml0aWFsaXplSGFuZGxlKToKKyAgICAgICAgKFdlYkNvcmU6 OlJlc291cmNlSGFuZGxlTWFuYWdlcjo6aW5pdENvb2tpZVNlc3Npb24pOgorICAgICAgICAoV2Vi Q29yZTo6c29ja29wdGZ1bmN0aW9uKTogRGVsZXRlZC4KKwogMjAxNS0wNi0yNSAgTHVjYXMgRm9y c2NobGVyICA8bGZvcnNjaGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWls ZCBmaXguCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3Vy Y2VIYW5kbGVNYW5hZ2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcAkocmV2aXNpb24gMTg1OTg5 KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxl TWFuYWdlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3MSwzMCArMTcxLDE3IEBAIHN0YXRpYyB2 b2lkIGNhbGN1bGF0ZVdlYlRpbWluZ0luZm9ybWF0aW8KICAgICBjdXJsX2Vhc3lfZ2V0aW5mbyhk LT5tX2hhbmRsZSwgQ1VSTElORk9fU1RBUlRUUkFOU0ZFUl9USU1FLCAmc3RhcnRUcmFuc2ZlcnRU aW1lKTsKICAgICBjdXJsX2Vhc3lfZ2V0aW5mbyhkLT5tX2hhbmRsZSwgQ1VSTElORk9fUFJFVFJB TlNGRVJfVElNRSwgJnByZVRyYW5zZmVyVGltZSk7CiAKLSAgICBkLT5tX3Jlc3BvbnNlLnJlc291 cmNlTG9hZFRpbWluZygpLT5kbnNTdGFydCA9IDA7Ci0gICAgZC0+bV9yZXNwb25zZS5yZXNvdXJj ZUxvYWRUaW1pbmcoKS0+ZG5zRW5kID0gc3RhdGljX2Nhc3Q8aW50PihkbnNsb29rdXBUaW1lICog MTAwMCk7CisgICAgZC0+bV9yZXNwb25zZS5yZXNvdXJjZUxvYWRUaW1pbmcoKS5kb21haW5Mb29r dXBTdGFydCA9IDA7CisgICAgZC0+bV9yZXNwb25zZS5yZXNvdXJjZUxvYWRUaW1pbmcoKS5kb21h aW5Mb29rdXBFbmQgPSBzdGF0aWNfY2FzdDxpbnQ+KGRuc2xvb2t1cFRpbWUgKiAxMDAwKTsKIAot ICAgIGQtPm1fcmVzcG9uc2UucmVzb3VyY2VMb2FkVGltaW5nKCktPmNvbm5lY3RTdGFydCA9IHN0 YXRpY19jYXN0PGludD4oZG5zbG9va3VwVGltZSAqIDEwMDApOwotICAgIGQtPm1fcmVzcG9uc2Uu cmVzb3VyY2VMb2FkVGltaW5nKCktPmNvbm5lY3RFbmQgPSBzdGF0aWNfY2FzdDxpbnQ+KGNvbm5l Y3RUaW1lICogMTAwMCk7CisgICAgZC0+bV9yZXNwb25zZS5yZXNvdXJjZUxvYWRUaW1pbmcoKS5j b25uZWN0U3RhcnQgPSBzdGF0aWNfY2FzdDxpbnQ+KGRuc2xvb2t1cFRpbWUgKiAxMDAwKTsKKyAg ICBkLT5tX3Jlc3BvbnNlLnJlc291cmNlTG9hZFRpbWluZygpLmNvbm5lY3RFbmQgPSBzdGF0aWNf Y2FzdDxpbnQ+KGNvbm5lY3RUaW1lICogMTAwMCk7CiAKLSAgICBkLT5tX3Jlc3BvbnNlLnJlc291 cmNlTG9hZFRpbWluZygpLT5zZW5kU3RhcnQgPSBzdGF0aWNfY2FzdDxpbnQ+KGNvbm5lY3RUaW1l ICoxMDAwKTsKLSAgICBkLT5tX3Jlc3BvbnNlLnJlc291cmNlTG9hZFRpbWluZygpLT5zZW5kRW5k ID1zdGF0aWNfY2FzdDxpbnQ+KHByZVRyYW5zZmVyVGltZSAqIDEwMDApOworICAgIGQtPm1fcmVz cG9uc2UucmVzb3VyY2VMb2FkVGltaW5nKCkucmVxdWVzdFN0YXJ0ID0gc3RhdGljX2Nhc3Q8aW50 Pihjb25uZWN0VGltZSAqMTAwMCk7CisgICAgZC0+bV9yZXNwb25zZS5yZXNvdXJjZUxvYWRUaW1p bmcoKS5yZXNwb25zZVN0YXJ0ID1zdGF0aWNfY2FzdDxpbnQ+KHByZVRyYW5zZmVyVGltZSAqIDEw MDApOwogCi0gICAgaWYgKGFwcENvbm5lY3RUaW1lKSB7Ci0gICAgICAgIGQtPm1fcmVzcG9uc2Uu cmVzb3VyY2VMb2FkVGltaW5nKCktPnNzbFN0YXJ0ID0gc3RhdGljX2Nhc3Q8aW50Pihjb25uZWN0 VGltZSAqIDEwMDApOwotICAgICAgICBkLT5tX3Jlc3BvbnNlLnJlc291cmNlTG9hZFRpbWluZygp LT5zc2xFbmQgPSBzdGF0aWNfY2FzdDxpbnQ+KGFwcENvbm5lY3RUaW1lICoxMDAwKTsKLSAgICB9 Ci19Ci0KLXN0YXRpYyBpbnQgc29ja29wdGZ1bmN0aW9uKHZvaWQqIGRhdGEsIGN1cmxfc29ja2V0 X3QgLypjdXJsZmQqLywgY3VybHNvY2t0eXBlIC8qcHVycG9zZSovKQotewotICAgIFJlc291cmNl SGFuZGxlKiBqb2IgPSBzdGF0aWNfY2FzdDxSZXNvdXJjZUhhbmRsZSo+KGRhdGEpOwotICAgIFJl c291cmNlSGFuZGxlSW50ZXJuYWwqIGQgPSBqb2ItPmdldEludGVybmFsKCk7Ci0KLSAgICBpZiAo ZC0+bV9yZXNwb25zZS5yZXNvdXJjZUxvYWRUaW1pbmcoKSkKLSAgICAgICAgZC0+bV9yZXNwb25z ZS5yZXNvdXJjZUxvYWRUaW1pbmcoKS0+cmVxdWVzdFRpbWUgPSBtb25vdG9uaWNhbGx5SW5jcmVh c2luZ1RpbWUoKTsKLQotICAgIHJldHVybiAwOworICAgIGlmIChhcHBDb25uZWN0VGltZSkKKyAg ICAgICAgZC0+bV9yZXNwb25zZS5yZXNvdXJjZUxvYWRUaW1pbmcoKS5zZWN1cmVDb25uZWN0aW9u U3RhcnQgPSBzdGF0aWNfY2FzdDxpbnQ+KGNvbm5lY3RUaW1lICogMTAwMCk7CiB9CiAjZW5kaWYK IApAQCAtNTE4LDExICs1MDUsNiBAQCBzdGF0aWMgc2l6ZV90IGhlYWRlckNhbGxiYWNrKGNoYXIq IHB0ciwKICAgICAgICAgICAgICAgICBkLT5tX211bHRpcGFydEhhbmRsZSA9IHN0ZDo6bWFrZV91 bmlxdWU8TXVsdGlwYXJ0SGFuZGxlPihqb2IsIGJvdW5kYXJ5KTsKICAgICAgICAgfQogCi0jaWYg RU5BQkxFKFdFQl9USU1JTkcpCi0gICAgICAgIGlmIChkLT5tX3Jlc3BvbnNlLnJlc291cmNlTG9h ZFRpbWluZygpICYmIGQtPm1fcmVzcG9uc2UucmVzb3VyY2VMb2FkVGltaW5nKCktPnJlcXVlc3RU aW1lKQotICAgICAgICAgICAgZC0+bV9yZXNwb25zZS5yZXNvdXJjZUxvYWRUaW1pbmcoKS0+cmVj ZWl2ZUhlYWRlcnNFbmQgPSBtaWxpc2Vjb25kc1NpbmNlUmVxdWVzdChkLT5tX3Jlc3BvbnNlLnJl c291cmNlTG9hZFRpbWluZygpLT5yZXF1ZXN0VGltZSk7Ci0jZW5kaWYKLQogICAgICAgICAvLyBI VFRQIHJlZGlyZWN0aW9uCiAgICAgICAgIGlmIChpc0h0dHBSZWRpcmVjdChodHRwQ29kZSkpIHsK ICAgICAgICAgICAgIFN0cmluZyBsb2NhdGlvbiA9IGQtPm1fcmVzcG9uc2UuaHR0cEhlYWRlckZp ZWxkKEhUVFBIZWFkZXJOYW1lOjpMb2NhdGlvbik7CkBAIC0xMTQ5LDExICsxMTMxLDYgQEAgdm9p ZCBSZXNvdXJjZUhhbmRsZU1hbmFnZXI6OmluaXRpYWxpemVIYQogICAgICAgICBjdXJsX2Vhc3lf c2V0b3B0KGQtPm1faGFuZGxlLCBDVVJMT1BUX1BST1hZLCBtX3Byb3h5LnV0ZjgoKS5kYXRhKCkp OwogICAgICAgICBjdXJsX2Vhc3lfc2V0b3B0KGQtPm1faGFuZGxlLCBDVVJMT1BUX1BST1hZVFlQ RSwgbV9wcm94eVR5cGUpOwogICAgIH0KLSNpZiBFTkFCTEUoV0VCX1RJTUlORykKLSAgICBjdXJs X2Vhc3lfc2V0b3B0KGQtPm1faGFuZGxlLCBDVVJMT1BUX1NPQ0tPUFRGVU5DVElPTiwgc29ja29w dGZ1bmN0aW9uKTsKLSAgICBjdXJsX2Vhc3lfc2V0b3B0KGQtPm1faGFuZGxlLCBDVVJMT1BUX1NP Q0tPUFREQVRBLCBqb2IpOwotICAgIGQtPm1fcmVzcG9uc2Uuc2V0UmVzb3VyY2VMb2FkVGltaW5n KFJlc291cmNlTG9hZFRpbWluZzo6Y3JlYXRlKCkpOwotI2VuZGlmCiB9CiAKIHZvaWQgUmVzb3Vy Y2VIYW5kbGVNYW5hZ2VyOjppbml0Q29va2llU2Vzc2lvbigpCg==