146342 2015-06-26 03:50:25 -0700 [EFL] Remove unnecessary overriden methods from ScrollBarEfl 2015-06-29 03:11:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 146327 1 ossy ossy andersca commit-queue ossy oldest_to_newest 1104898 0 ossy 2015-06-26 03:50:25 -0700 bug146327 is going to remove the invalidate method, which would break the EFL build. But we can remove it from ScrollBarEfl now, because they are exactly same. Additionally we can remove setFrameRect, setParent and frameRectsChanged too. 1104899 1 255628 ossy 2015-06-26 03:51:22 -0700 Created attachment 255628 Patch 1104920 2 255628 commit-queue 2015-06-26 06:06:02 -0700 Comment on attachment 255628 Patch Clearing flags on attachment: 255628 Committed r185995: <http://trac.webkit.org/changeset/185995> 1104921 3 commit-queue 2015-06-26 06:06:06 -0700 All reviewed patches have been landed. Closing bug. 1104944 4 andersca 2015-06-26 09:41:41 -0700 Looks like we could just remove all of ScrollbarEfl now? 1104948 5 ossy 2015-06-26 09:44:37 -0700 (In reply to comment #4) > Looks like we could just remove all of ScrollbarEfl now? I will check it and submit a patch if it is possible. 1105363 6 ossy 2015-06-29 03:11:22 -0700 (In reply to comment #5) > (In reply to comment #4) > > Looks like we could just remove all of ScrollbarEfl now? > > I will check it and submit a patch if it is possible. It seems it can be removed, at least bug143566 would like to do it. 255628 2015-06-26 03:51:22 -0700 2015-06-26 06:06:02 -0700 Patch bug-146342-20150626035035.patch text/plain 2328 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1OTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDc0YzQ3YWEwZjNkY2E1 ZmI2NjFjZTNhODMxYjAzYjUwYzUwZjMyMC4uZTYyYmFhODI2YjYzMGJmNjhjMzNmY2EzZDVlNTll NzBhMjMxMTZlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA2LTI2ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0VGTF0gUmVtb3Zl IHVubmVjZXNzYXJ5IG92ZXJyaWRlbiBtZXRob2RzIGZyb20gU2Nyb2xsQmFyRWZsCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDYzNDIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2VmbC9T Y3JvbGxiYXJFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyRWZsOjpzZXRQYXJl bnQpOiBEZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyRWZsOjpzZXRGcmFtZVJl Y3QpOiBEZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyRWZsOjpmcmFtZVJlY3Rz Q2hhbmdlZCk6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxiYXJFZmw6OmludmFs aWRhdGUpOiBEZWxldGVkLgorICAgICAgICAqIHBsYXRmb3JtL2VmbC9TY3JvbGxiYXJFZmwuaDoK KwogMjAxNS0wNi0yNSAgTHVjYXMgRm9yc2NobGVyICA8bGZvcnNjaGxlckBhcHBsZS5jb20+CiAK ICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyRWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2VmbC9TY3JvbGxiYXJFZmwuY3BwCmluZGV4IGM4NGE1NjZjM2E4MTYyOTM5MzcxMGE5M2UyOTgx MjI0MDNhYTY1ZWEuLjM4ZGQ0MTMwOWQzMDdkMDExOTgxYjU3NzNjMDFkNmJiYzUxZGYyMWQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9TY3JvbGxiYXJFZmwuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9TY3JvbGxiYXJFZmwuY3BwCkBAIC00NSwy NCArNDUsNCBAQCBTY3JvbGxiYXJFZmw6On5TY3JvbGxiYXJFZmwoKQogewogfQogCi12b2lkIFNj cm9sbGJhckVmbDo6c2V0UGFyZW50KFNjcm9sbFZpZXcqIHZpZXcpCi17Ci0gICAgV2lkZ2V0Ojpz ZXRQYXJlbnQodmlldyk7Ci19Ci0KLXZvaWQgU2Nyb2xsYmFyRWZsOjpzZXRGcmFtZVJlY3QoY29u c3QgSW50UmVjdCYgcmVjdCkKLXsKLSAgICBXaWRnZXQ6OnNldEZyYW1lUmVjdChyZWN0KTsKLSAg ICBmcmFtZVJlY3RzQ2hhbmdlZCgpOwotfQotCi12b2lkIFNjcm9sbGJhckVmbDo6ZnJhbWVSZWN0 c0NoYW5nZWQoKQotewotfQotCi12b2lkIFNjcm9sbGJhckVmbDo6aW52YWxpZGF0ZSgpCi17Ci0g ICAgV2lkZ2V0OjppbnZhbGlkYXRlKCk7Ci19Ci0KIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2VmbC9TY3JvbGxiYXJFZmwuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2VmbC9TY3JvbGxiYXJFZmwuaAppbmRleCA0MGM2NDZiMjU5YjBiYjZiYjdjZDJmNmYyNzdlYWVk ZDgzYzUwNTU1Li41MTIxNWM3MDYyNjEzZjQ5MjQyMmI1MGJjYjQ5ZTAzYTdmNzczMDFkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyRWZsLmgKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhckVmbC5oCkBAIC0zNywxNyArMzcs MTEgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogY2xhc3MgU2Nyb2xsYmFyRWZsIGZpbmFsIDogcHVi bGljIFNjcm9sbGJhciB7CiBwdWJsaWM6CiAgICAgZnJpZW5kIGNsYXNzIFNjcm9sbGJhcjsKLQog ICAgIHZpcnR1YWwgflNjcm9sbGJhckVmbCgpOwogCi0gICAgdmlydHVhbCB2b2lkIHNldEZyYW1l UmVjdChjb25zdCBJbnRSZWN0Jikgb3ZlcnJpZGU7Ci0gICAgdmlydHVhbCB2b2lkIGZyYW1lUmVj dHNDaGFuZ2VkKCkgb3ZlcnJpZGU7Ci0gICAgdmlydHVhbCB2b2lkIGludmFsaWRhdGUoKSBvdmVy cmlkZTsKLQogcHJvdGVjdGVkOgogICAgIFNjcm9sbGJhckVmbChTY3JvbGxhYmxlQXJlYSYsIFNj cm9sbGJhck9yaWVudGF0aW9uLCBTY3JvbGxiYXJDb250cm9sU2l6ZSk7CiAKLSAgICB2aXJ0dWFs IHZvaWQgc2V0UGFyZW50KFNjcm9sbFZpZXcqKSBvdmVycmlkZTsKIH07CiAKIH0K