146334 2015-06-25 17:47:19 -0700 [EFL] Purge unused favicons from IconDatabase after 30 days 2015-06-29 03:10:58 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 82346 1 hyungwook.lee hyungwook.lee commit-queue gyuyoung.kim japhet lucas.de.marchi oldest_to_newest 1104812 0 hyungwook.lee 2015-06-25 17:47:19 -0700 We need purge unused favicons from IconDatabase for database size control. 1104815 1 255604 hyungwook.lee 2015-06-25 17:55:54 -0700 Created attachment 255604 Patch 1104854 2 255604 gyuyoung.kim 2015-06-25 20:01:46 -0700 Comment on attachment 255604 Patch I agree with keeping favicons for 30 days as GTK port. LGTM. BTW, it seems there is some missing APIs to support favicon. For example, EFL port needs to support to clear all favicons by EWK APIs. Could you do that ? 1104866 3 hyungwook.lee 2015-06-25 23:19:53 -0700 I will implement remove all icons API for EFL port soon. 1105361 4 255604 commit-queue 2015-06-29 03:10:54 -0700 Comment on attachment 255604 Patch Clearing flags on attachment: 255604 Committed r186068: <http://trac.webkit.org/changeset/186068> 1105362 5 commit-queue 2015-06-29 03:10:58 -0700 All reviewed patches have been landed. Closing bug. 255604 2015-06-25 17:55:54 -0700 2015-06-29 03:10:54 -0700 Patch bug-146334-20150626095456.patch text/plain 1897 hyungwook.lee SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTk3MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA2LTI1ICBIeXVuZ3dv b2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtFRkxdIFB1 cmdlIHVudXNlZCBmYXZpY29ucyBmcm9tIEljb25EYXRhYmFzZSBhZnRlciAzMCBkYXlzLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2MzM0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgbmVlZCBwdXJn ZSB1bnVzZWQgZmF2aWNvbnMgZnJvbSBJY29uRGF0YWJhc2UgZm9yIGRhdGFiYXNlIHNpemUgY29u dHJvbC4KKworICAgICAgICAqIGxvYWRlci9pY29uL0ljb25EYXRhYmFzZS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpJY29uRGF0YWJhc2U6OnBlcmZvcm1VUkxJbXBvcnQpOgorCiAyMDE1LTA2LTI1 ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1Mg V0syXSBTd2lwaW5nIGJhY2sganVzdCBhZnRlciBzY3JvbGxpbmcgY2FuIGNhdXNlIHNvbWUgdGls ZXMgdG8gZGlzYXBwZWFyCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvaWNvbi9JY29uRGF0 YWJhc2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9pY29uL0ljb25E YXRhYmFzZS5jcHAJKHJldmlzaW9uIDE4NTk3MikKKysrIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9p Y29uL0ljb25EYXRhYmFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcwLDcgKzcwLDcgQEAgc3Rh dGljIGNvbnN0IGludCB1cGRhdGVUaW1lckRlbGF5ID0gNTsKIAogc3RhdGljIGJvb2wgY2hlY2tJ bnRlZ3JpdHlPbk9wZW4gPSBmYWxzZTsKIAotI2lmIFBMQVRGT1JNKEdUSykKKyNpZiBQTEFURk9S TShHVEspIHx8IFBMQVRGT1JNKEVGTCkKIC8vIFdlIGFyZSBub3QgaW50ZXJlc3RlZCBpbiBpY29u cyB0aGF0IGhhdmUgYmVlbiB1bnVzZWQgZm9yIG1vcmUgdGhhbgogLy8gMzAgZGF5cywgZGVsZXRl IHRoZW0gZXZlbiBpZiB0aGV5IGhhdmUgbm90IGJlZW4gZXhwbGljaXRseSByZWxlYXNlZC4KIHN0 YXRpYyBjb25zdCBpbnQgbm90VXNlZEljb25FeHBpcmF0aW9uVGltZSA9IDYwKjYwKjI0KjMwOwpA QCAtMTE5MSw3ICsxMTkxLDcgQEAgdm9pZCBJY29uRGF0YWJhc2U6OnBlcmZvcm1VUkxJbXBvcnQo KQogewogICAgIEFTU0VSVF9JQ09OX1NZTkNfVEhSRUFEKCk7CiAKLSMgaWYgUExBVEZPUk0oR1RL KQorIyBpZiBQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKEVGTCkKICAgICAvLyBEbyBub3QgaW1w b3J0IGljb25zIG5vdCB1c2VkIGluIHRoZSBsYXN0IDMwIGRheXMuIFRoZXkgd2lsbCBiZSBhdXRv bWF0aWNhbGx5IHBydW5lZCBsYXRlciBpZiBub2JvZHkgcmV0YWlucyB0aGVtLgogICAgIC8vIE5v dGUgdGhhdCBJY29uSW5mby5zdGFtcCBpcyBvbmx5IHNldCB3aGVuIHRoZSBpY29uIGRhdGEgaXMg cmV0cmlldmVkIGZyb20gdGhlIHNlcnZlciAoYW5kIHRodXMgaXMgbm90IHVwZGF0ZWQgd2hldGhl cgogICAgIC8vIHdlIHVzZSBpdCBvciBub3QpLiBUaGlzIGNvZGUgd29ya3MgYW55d2F5IGJlY2F1 c2UgdGhlIEljb25EYXRhYmFzZSBkb3dubG9hZHMgaWNvbnMgYWdhaW4gaWYgdGhleSBhcmUgb2xk ZXIgdGhhbiA0IGRheXMsCg==