146328 2015-06-25 15:50:27 -0700 Inline media controls disappear when returning a video to inline 2015-06-25 18:01:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino oldest_to_newest 1104752 0 dino 2015-06-25 15:50:27 -0700 Inline media controls disappear when returning a video to inline 1104756 1 dino 2015-06-25 15:57:17 -0700 <rdar://problem/21142862> 1104757 2 255585 dino 2015-06-25 15:57:43 -0700 Created attachment 255585 Patch 1104764 3 255585 thorton 2015-06-25 16:07:05 -0700 Comment on attachment 255585 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255585&action=review > Source/WebCore/ChangeLog:33 > + naming doesn't make much sense :( this is sad, indeed. 1104774 4 dino 2015-06-25 16:15:36 -0700 Committed r185969: <http://trac.webkit.org/changeset/185969> 1104820 5 255585 eric.carlson 2015-06-25 18:01:19 -0700 Comment on attachment 255585 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255585&action=review r=me too > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:350 > + if (this.controlsAreHidden() || !this.controls.panel.classList.contains(this.ClassNames.show)) { Now might not be the time to do this, but we should consider putting this logic into controlsAreHidden. 255585 2015-06-25 15:57:43 -0700 2015-06-25 16:07:05 -0700 Patch bug-146328-20150626085657.patch text/plain 4644 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1OTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTk4ODFmNzRiMjk1YzI1 NzRiZjZiOWY1MDYwNTJlYjVmNGE0ODY3Ny4uNTc3ODJjODA1N2RlMzdkNDNiZmRlYzc0ZDc4ODAz MzQyYWUxNmIxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM3IEBACisyMDE1LTA2LTI1ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBJbmxpbmUgbWVkaWEgY29udHJv bHMgZGlzYXBwZWFyIHdoZW4gcmV0dXJuaW5nIGEgdmlkZW8gdG8gaW5saW5lCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDYzMjgKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzIxMTQyODYyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdlIHdlcmUgZ2V0dGluZyBpbnRvIGEgc3RhdGUgd2hlcmUgdGhlIGNv bnRyb2xzIHdlcmUgYmVpbmcKKyAgICAgICAgaGlkZGVuIHZpYSBhIHRpbWVyIHdoaWxlIHdlIHdl cmUgaW4gZnVsbHNjcmVlbiBvciBvbgorICAgICAgICBhbm90aGVyIHRhYi4gTWVhbndoaWxlLCB3 ZSBjb3VsZCBleGl0IGZyb20gc3VjaAorICAgICAgICBhIGNvbmRpdGlvbiB0byBhIHBvaW50IHdo ZXJlIHRoZSBjb250cm9scyB3ZXJlCisgICAgICAgIG5vdCB2aXNpYmxlLCBidXQgbm90IGNvbXBs ZXRlbHkgcmVtb3ZlZCBmcm9tIHRoZSBET00sIGNvbmZ1c2luZworICAgICAgICB0aGUgbG9naWMg dGhhdCBkZWNpZGVkIHdoZXRoZXIgdG8gc2hvdyB0aGVtIG9uIHRhcC4KKworICAgICAgICAqIE1v ZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanM6CisgICAgICAgIChDb250 cm9sbGVyLnByb3RvdHlwZS5oaWRlQ29udHJvbHMpOiBJZiB3ZSBhcmUgaW4gdGhlIGFjdCBvZiBo aWRpbmcKKyAgICAgICAgY29udHJvbHMsIHdlIGNhbiBjbGVhciBhbnkgZXhpc3RpbmcgdGltZXJz IHRoYXQgYXJlIGdvaW5nIHRvIHRyeQorICAgICAgICB0byBoaWRlIHRoZW0gYWdhaW4uCisgICAg ICAgIChDb250cm9sbGVyLnByb3RvdHlwZS5yZXNldEhpZGVDb250cm9sc1RpbWVyKTogTWFrZSBz dXJlIHdlIG51bGwKKyAgICAgICAgb3V0IHRoZSBoaWRlVGltZXIgb2JqZWN0LCBzaW5jZSB3ZSBs b29rIGF0IGl0cyB2YWx1ZSBvZnRlbiB0bworICAgICAgICBkZWNpZGUgd2hldGhlciBvciBub3Qg YSB0aW1lciBleGlzdHMuCisgICAgICAgICogTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29u dHJvbHNpT1MuanM6CisgICAgICAgIChDb250cm9sbGVySU9TLnByb3RvdHlwZS5oYW5kbGVQbGF5 QnV0dG9uVG91Y2hFbmQpOiBJZiB0aGUgdXNlcgorICAgICAgICB0YXBzIHBsYXksIHRoZW4gd2Ug c2hvdWxkIGNhbGwgc2hvd0NvbnRyb2xzLCB3aGljaCByZXNldHMgdGhlIGhpZGUKKyAgICAgICAg dGltZXJzIGFtb25nc3Qgb3RoZXIgdGhpbmdzLiBXZSBuZWVkIHRvIGRvIHRoaXMgZHVlIHRvIHRo ZSBuZXh0IGNoYW5nZSwKKyAgICAgICAgc28gdGhhdCBhIHRpbWVyIHN0YXJ0ZWQgYmVmb3JlIHdl IHByZXNzZWQgcGxheSBkb2Vzbid0IGNhdXNlIHRoZQorICAgICAgICBjb250cm9scyB0byBpbnN0 YW50bHkgZGlzYXBwZWFyIGFzIHNvb24gYXMgd2Ugc3RhcnQgcGxheWluZy4KKyAgICAgICAgKENv bnRyb2xsZXJJT1MucHJvdG90eXBlLmhhbmRsZVdyYXBwZXJUb3VjaFN0YXJ0KTogV2UgY2FuIGdl dCBpbnRvCisgICAgICAgIHRoZSBzdGF0ZSB3aGVyZSBjb250cm9scyBhcmUgaW52aXNpYmxlIGJ1 dCBzdGlsbCBpbiB0aGUgdHJlZS4gU2luY2UgdGhlCisgICAgICAgIGNvbnRyb2xzQXJlSGlkZGVu KCkgbG9naWMgb25seSBsb29rcyBmb3IgdGhlIGxhdHRlciwgd2UgbmVlZCB0byBhbHNvCisgICAg ICAgIGxvb2sgZm9yIGludmlzaWJsZSB3aGVuIHRoZSB1c2VyIHRhcHMgZm9yIHRoZSBjb250cm9s cy4gWWVzLCB0aGlzCisgICAgICAgIG5hbWluZyBkb2Vzbid0IG1ha2UgbXVjaCBzZW5zZSA6KAor CiAyMDE1LTA2LTI0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAg TnVsbCBkZXJlZmVyZW5jZSBpbiBEb2N1bWVudExvYWRlcjo6YXJlQWxsTG9hZGVyc1BhZ2VDYWNo ZUFjY2VwdGFibGUoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNv bnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qcyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVk aWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanMKaW5kZXggYWE1ZGU4MDg0NDAzZGVlNjVi MWU0MzljNzlhNmI5NmU5MDA4ODEwNi4uYWY4NDIzZDJiMWNhNThhNDMwMWM2NTQ5MjhkNGJjMzIy MGQ4YmQ3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xz L21lZGlhQ29udHJvbHNBcHBsZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh Y29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpzCkBAIC0xNDA0LDYgKzE0MDQsNyBAQCBDb250 cm9sbGVyLnByb3RvdHlwZSA9IHsKICAgICAgICAgaWYgKHRoaXMuY29udHJvbHNBbHdheXNWaXNp YmxlKCkpCiAgICAgICAgICAgICByZXR1cm47CiAKKyAgICAgICAgdGhpcy5jbGVhckhpZGVDb250 cm9sc1RpbWVyKCk7CiAgICAgICAgIHRoaXMudXBkYXRlU2hvdWxkTGlzdGVuRm9yUGxheWJhY2tU YXJnZXRBdmFpbGFiaWxpdHlFdmVudCgpOwogICAgICAgICB0aGlzLmNvbnRyb2xzLnBhbmVsLmNs YXNzTGlzdC5yZW1vdmUodGhpcy5DbGFzc05hbWVzLnNob3cpOwogICAgICAgICBpZiAodGhpcy5j b250cm9scy5wYW5lbEJhY2tncm91bmQpCkBAIC0xODc4LDggKzE4NzksMTAgQEAgQ29udHJvbGxl ci5wcm90b3R5cGUgPSB7CiAKICAgICByZXNldEhpZGVDb250cm9sc1RpbWVyOiBmdW5jdGlvbigp CiAgICAgewotICAgICAgICBpZiAodGhpcy5oaWRlVGltZXIpCisgICAgICAgIGlmICh0aGlzLmhp ZGVUaW1lcikgewogICAgICAgICAgICAgY2xlYXJUaW1lb3V0KHRoaXMuaGlkZVRpbWVyKTsKKyAg ICAgICAgICAgIHRoaXMuaGlkZVRpbWVyID0gbnVsbDsKKyAgICAgICAgfQogCiAgICAgICAgIGlm ICh0aGlzLmlzUGxheWluZykKICAgICAgICAgICAgIHRoaXMuaGlkZVRpbWVyID0gc2V0VGltZW91 dCh0aGlzLmhpZGVDb250cm9scy5iaW5kKHRoaXMpLCB0aGlzLkhpZGVDb250cm9sc0RlbGF5KTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNv bnRyb2xzaU9TLmpzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlh Q29udHJvbHNpT1MuanMKaW5kZXggNWNiYmQ4YTFkOGYyN2E3MGQyYTU4MTYzM2Q2YThlM2Y2OTAx YzFjMi4uNjdiNWU2NTc2ZjVjNWRhMjdmZGY2MmUwNzNhMGRjOWQzZTIwNGRiYSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNpT1Mu anMKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJv bHNpT1MuanMKQEAgLTI4Nyw5ICsyODcsMTAgQEAgQ29udHJvbGxlcklPUy5wcm90b3R5cGUgPSB7 CiAgICAgaGFuZGxlUGxheUJ1dHRvblRvdWNoRW5kOiBmdW5jdGlvbihldmVudCkgewogICAgICAg ICB0aGlzLmNvbnRyb2xzLnBsYXlCdXR0b24uY2xhc3NMaXN0LnJlbW92ZSgnYWN0aXZlJyk7CiAK LSAgICAgICAgaWYgKHRoaXMuY2FuUGxheSgpKQorICAgICAgICBpZiAodGhpcy5jYW5QbGF5KCkp IHsKICAgICAgICAgICAgIHRoaXMudmlkZW8ucGxheSgpOwotICAgICAgICBlbHNlCisgICAgICAg ICAgICB0aGlzLnNob3dDb250cm9scygpOworICAgICAgICB9IGVsc2UKICAgICAgICAgICAgIHRo aXMudmlkZW8ucGF1c2UoKTsKIAogICAgICAgICByZXR1cm4gdHJ1ZTsKQEAgLTM0NiwxMSArMzQ3 LDkgQEAgQ29udHJvbGxlcklPUy5wcm90b3R5cGUgPSB7CiAKICAgICAgICAgdGhpcy5tb3N0UmVj ZW50TnVtYmVyT2ZUYXJnZXR0ZWRUb3VjaGVzID0gZXZlbnQudGFyZ2V0VG91Y2hlcy5sZW5ndGg7 CiAKLSAgICAgICAgaWYgKHRoaXMuY29udHJvbHNBcmVIaWRkZW4oKSkgeworICAgICAgICBpZiAo dGhpcy5jb250cm9sc0FyZUhpZGRlbigpIHx8ICF0aGlzLmNvbnRyb2xzLnBhbmVsLmNsYXNzTGlz dC5jb250YWlucyh0aGlzLkNsYXNzTmFtZXMuc2hvdykpIHsKICAgICAgICAgICAgIHRoaXMuc2hv d0NvbnRyb2xzKCk7Ci0gICAgICAgICAgICBpZiAodGhpcy5oaWRlVGltZXIpCi0gICAgICAgICAg ICAgICAgY2xlYXJUaW1lb3V0KHRoaXMuaGlkZVRpbWVyKTsKLSAgICAgICAgICAgIHRoaXMuaGlk ZVRpbWVyID0gc2V0VGltZW91dCh0aGlzLmhpZGVDb250cm9scy5iaW5kKHRoaXMpLCB0aGlzLkhp ZGVDb250cm9sc0RlbGF5KTsKKyAgICAgICAgICAgIHRoaXMucmVzZXRIaWRlQ29udHJvbHNUaW1l cigpOwogICAgICAgICB9IGVsc2UgaWYgKCF0aGlzLmNhblBsYXkoKSkKICAgICAgICAgICAgIHRo aXMuaGlkZUNvbnRyb2xzKCk7CiAgICAgfSwK