14632 2007-07-16 06:43:51 -0700 Debug configuration doesn't work with qmake. 2007-08-19 04:20:20 -0700 1 1 1 Unclassified WebKit Tools / Tests 523.x (Safari 3) PC Linux RESOLVED FIXED P2 Normal --- 0 donaldluo webkit-unassigned son.two zecke oldest_to_newest 4632 0 donaldluo 2007-07-16 06:43:51 -0700 Debug configuration is not really activated in the qmake build system. Set configuration to Debug and build WebKit for GDK or Qt. The executable built still doesn't contain debug information. 4626 1 15531 donaldluo 2007-07-16 06:49:00 -0700 Created attachment 15531 Patch to webkitdirs.pm 2037 2 16013 son.two 2007-08-18 07:03:18 -0700 Created attachment 16013 enhanced patch as far as I know qmake could be configured to use debug configuration by default, so it looks reasonable to enhance the patch to explicitly drop unneedded mode. 2038 3 16014 son.two 2007-08-18 07:19:39 -0700 Created attachment 16014 the enhanced patch with corrected indentation 2041 4 zecke 2007-08-18 07:21:17 -0700 I'm no perl expert but it looks okay. 2042 5 16014 mrowe 2007-08-18 07:25:46 -0700 Comment on attachment 16014 the enhanced patch with corrected indentation r=me. The amount of duplication between buildQMakeProject and buildQMakeGdkProject is depressing. It'd be great if it could be cleaned up at some point. 2043 6 son.two 2007-08-18 07:35:11 -0700 (In reply to comment #5) > (From update of attachment 16014 [edit]) > r=me. The amount of duplication between buildQMakeProject and > buildQMakeGdkProject is depressing. It'd be great if it could be cleaned up at > some point. > I will see what I can do to reduce duplication :) 2029 7 16017 son.two 2007-08-18 13:12:19 -0700 Created attachment 16017 change log for the patch 2002 8 zecke 2007-08-19 04:20:20 -0700 Landed in r25146. 15531 2007-07-16 06:49:00 -0700 2007-07-16 06:49:00 -0700 Patch to webkitdirs.pm qmake_debug.patch text/plain 884 donaldluo SW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHJldmlzaW9uIDI0MzAzKQorKysgV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCSh3b3JraW5nIGNvcHkpCkBAIC01NDIsNiAr NTQyLDcgQEAgc3ViIGJ1aWxkUU1ha2VQcm9qZWN0KCQkKQogICAgIG15ICRwcmVmaXggPSAkRU5W eyJXZWJLaXRJbnN0YWxsYXRpb25QcmVmaXgifTsKIAogICAgIHB1c2ggQGJ1aWxkQXJncywgIk9V VFBVVF9ESVI9IiAuIGJhc2VQcm9kdWN0RGlyKCkgLiAiLyRjb25maWciOworICAgIHB1c2ggQGJ1 aWxkQXJncywgIkNPTkZJRys9ZGVidWciIGlmICgkY29uZmlnIGVxICJEZWJ1ZyIpOwogICAgIHB1 c2ggQGJ1aWxkQXJncywgIkNPTkZJRys9cXQtcG9ydCI7CiAgICAgcHVzaCBAYnVpbGRBcmdzLCBz b3VyY2VEaXIoKSAuICIvV2ViS2l0LnBybyI7CiAKQEAgLTU4MCw2ICs1ODEsNyBAQCBzdWIgYnVp bGRRTWFrZUdka1Byb2plY3QoJCQpCiAKICAgICBteSBAYnVpbGRBcmdzID0gKCItciIpOwogICAg IHB1c2ggQGJ1aWxkQXJncywgIk9VVFBVVF9ESVI9IiAuIGJhc2VQcm9kdWN0RGlyKCkgLiAiLyRj b25maWciOworICAgIHB1c2ggQGJ1aWxkQXJncywgIkNPTkZJRys9ZGVidWciIGlmICgkY29uZmln IGVxICJEZWJ1ZyIpOwogICAgIHB1c2ggQGJ1aWxkQXJncywgIkNPTkZJRy09cXQiOwogICAgIHB1 c2ggQGJ1aWxkQXJncywgIkNPTkZJRys9Z2RrLXBvcnQiOwogICAgIHB1c2ggQGJ1aWxkQXJncywg c291cmNlRGlyKCkgLiAiL1dlYktpdC5wcm8iOwo= 16013 2007-08-18 07:03:18 -0700 2007-08-18 07:19:39 -0700 enhanced patch gtk-debug-build.txt text/plain 1324 son.two SW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHJldmlzaW9uIDI1MTI0KQorKysgV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCSh3b3JraW5nIGNvcHkpCkBAIC01OTksNiAr NTk5LDEzIEBAIHN1YiBidWlsZFFNYWtlUHJvamVjdCgkJCkKICAgICBwdXNoIEBidWlsZEFyZ3Ms ICJPVVRQVVRfRElSPSIgLiBiYXNlUHJvZHVjdERpcigpIC4gIi8kY29uZmlnIjsKICAgICBwdXNo IEBidWlsZEFyZ3MsICJDT05GSUcrPXF0LXBvcnQiOwogICAgIHB1c2ggQGJ1aWxkQXJncywgc291 cmNlRGlyKCkgLiAiL1dlYktpdC5wcm8iOworICAgIGlmICgkY29uZmlnID1+IG0vZGVidWcvaSkg eworCXB1c2ggQGJ1aWxkQXJncywgIkNPTkZJRy09cmVsZWFzZSI7CisJcHVzaCBAYnVpbGRBcmdz LCAiQ09ORklHKz1kZWJ1ZyI7CisgICAgfSBlbHNlIHsKKwlwdXNoIEBidWlsZEFyZ3MsICJDT05G SUcrPXJlbGVhc2UiOworCXB1c2ggQGJ1aWxkQXJncywgIkNPTkZJRy09ZGVidWciOworICAgIH0K IAogICAgIHByaW50ICJDYWxsaW5nICckcW1ha2ViaW4gQGJ1aWxkQXJncycgaW4gIiAuIGJhc2VQ cm9kdWN0RGlyKCkgLiAiLyRjb25maWcgLi4uXG5cbiI7CiAgICAgcHJpbnQgIkluc3RhbGxhdGlv biBkaXJlY3Rvcnk6ICRwcmVmaXhcbiIgaWYoZGVmaW5lZCgkcHJlZml4KSk7CkBAIC02NTMsNiAr NjYwLDEzIEBAIHN1YiBidWlsZFFNYWtlR2RrUHJvamVjdCgkJCkKICAgICBwdXNoIEBidWlsZEFy Z3MsICJDT05GSUctPXF0IjsKICAgICBwdXNoIEBidWlsZEFyZ3MsICJDT05GSUcrPWdkay1wb3J0 IjsKICAgICBwdXNoIEBidWlsZEFyZ3MsIHNvdXJjZURpcigpIC4gIi9XZWJLaXQucHJvIjsKKyAg ICBpZiAoJGNvbmZpZyA9fiBtL2RlYnVnL2kpIHsKKwlwdXNoIEBidWlsZEFyZ3MsICJDT05GSUct PXJlbGVhc2UiOworCXB1c2ggQGJ1aWxkQXJncywgIkNPTkZJRys9ZGVidWciOworICAgIH0gZWxz ZSB7CisJcHVzaCBAYnVpbGRBcmdzLCAiQ09ORklHKz1yZWxlYXNlIjsKKwlwdXNoIEBidWlsZEFy Z3MsICJDT05GSUctPWRlYnVnIjsKKyAgICB9CiAKICAgICBwcmludCAiQ2FsbGluZyAncW1ha2Ug QGJ1aWxkQXJncycgaW4gIiAuIGJhc2VQcm9kdWN0RGlyKCkgLiAiLyRjb25maWcgLi4uXG5cbiI7 CiAgICAgcHJpbnQgIkluc3RhbGxhdGlvbiBkaXJlY3Rvcnk6ICRwcmVmaXhcbiIgaWYoZGVmaW5l ZCgkcHJlZml4KSk7Cg== 16014 2007-08-18 07:19:39 -0700 2007-08-18 07:25:46 -0700 the enhanced patch with corrected indentation gtk-debug-build.txt text/plain 1380 son.two SW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHJldmlzaW9uIDI1MTI0KQorKysgV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCSh3b3JraW5nIGNvcHkpCkBAIC01OTksNiAr NTk5LDEzIEBAIHN1YiBidWlsZFFNYWtlUHJvamVjdCgkJCkKICAgICBwdXNoIEBidWlsZEFyZ3Ms ICJPVVRQVVRfRElSPSIgLiBiYXNlUHJvZHVjdERpcigpIC4gIi8kY29uZmlnIjsKICAgICBwdXNo IEBidWlsZEFyZ3MsICJDT05GSUcrPXF0LXBvcnQiOwogICAgIHB1c2ggQGJ1aWxkQXJncywgc291 cmNlRGlyKCkgLiAiL1dlYktpdC5wcm8iOworICAgIGlmICgkY29uZmlnID1+IG0vZGVidWcvaSkg eworICAgICAgICBwdXNoIEBidWlsZEFyZ3MsICJDT05GSUctPXJlbGVhc2UiOworICAgICAgICBw dXNoIEBidWlsZEFyZ3MsICJDT05GSUcrPWRlYnVnIjsKKyAgICB9IGVsc2UgeworICAgICAgICBw dXNoIEBidWlsZEFyZ3MsICJDT05GSUcrPXJlbGVhc2UiOworICAgICAgICBwdXNoIEBidWlsZEFy Z3MsICJDT05GSUctPWRlYnVnIjsKKyAgICB9CiAKICAgICBwcmludCAiQ2FsbGluZyAnJHFtYWtl YmluIEBidWlsZEFyZ3MnIGluICIgLiBiYXNlUHJvZHVjdERpcigpIC4gIi8kY29uZmlnIC4uLlxu XG4iOwogICAgIHByaW50ICJJbnN0YWxsYXRpb24gZGlyZWN0b3J5OiAkcHJlZml4XG4iIGlmKGRl ZmluZWQoJHByZWZpeCkpOwpAQCAtNjUzLDYgKzY2MCwxMyBAQCBzdWIgYnVpbGRRTWFrZUdka1By b2plY3QoJCQpCiAgICAgcHVzaCBAYnVpbGRBcmdzLCAiQ09ORklHLT1xdCI7CiAgICAgcHVzaCBA YnVpbGRBcmdzLCAiQ09ORklHKz1nZGstcG9ydCI7CiAgICAgcHVzaCBAYnVpbGRBcmdzLCBzb3Vy Y2VEaXIoKSAuICIvV2ViS2l0LnBybyI7CisgICAgaWYgKCRjb25maWcgPX4gbS9kZWJ1Zy9pKSB7 CisgICAgICAgIHB1c2ggQGJ1aWxkQXJncywgIkNPTkZJRy09cmVsZWFzZSI7CisgICAgICAgIHB1 c2ggQGJ1aWxkQXJncywgIkNPTkZJRys9ZGVidWciOworICAgIH0gZWxzZSB7CisgICAgICAgIHB1 c2ggQGJ1aWxkQXJncywgIkNPTkZJRys9cmVsZWFzZSI7CisgICAgICAgIHB1c2ggQGJ1aWxkQXJn cywgIkNPTkZJRy09ZGVidWciOworICAgIH0KIAogICAgIHByaW50ICJDYWxsaW5nICdxbWFrZSBA YnVpbGRBcmdzJyBpbiAiIC4gYmFzZVByb2R1Y3REaXIoKSAuICIvJGNvbmZpZyAuLi5cblxuIjsK ICAgICBwcmludCAiSW5zdGFsbGF0aW9uIGRpcmVjdG9yeTogJHByZWZpeFxuIiBpZihkZWZpbmVk KCRwcmVmaXgpKTsK 16017 2007-08-18 13:12:19 -0700 2007-08-18 13:12:19 -0700 change log for the patch debug-build-changelog.txt text/plain 486 son.two SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI1MTQzKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTAgQEAKKzIwMDctMDgtMTkgIE9sZWcgU3VraG9kb2xza3kg IDxzb24udHdvQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgcXQgYW5kIGd0 ayBwb3J0cyBub3cgZXhwbGljaXRseSBwYXNzIGRlYnVnIChvciByZWxlYXNlKSBtb2RlIHRvIHFt YWtlLgorCiAyMDA3LTA4LTE3ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4K