146319 2015-06-25 12:33:10 -0700 iOS speech synthesizer should expose names 2015-06-26 08:19:01 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach commit-queue mario webkit-bug-importer oldest_to_newest 1104693 0 cfleizach 2015-06-25 12:33:10 -0700 The iOS Speech synthesizer integration should expose the names of the synthesizers <rdar://problem/21538631> 1104694 1 255566 cfleizach 2015-06-25 12:33:55 -0700 Created attachment 255566 patch 1104695 2 commit-queue 2015-06-25 12:36:31 -0700 Attachment 255566 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1104720 3 255566 kling 2015-06-25 14:29:34 -0700 Comment on attachment 255566 patch View in context: https://bugs.webkit.org/attachment.cgi?id=255566&action=review > Source/WebCore/platform/ios/PlatformSpeechSynthesizerIOS.mm:240 > // iOS Speech voices only expose their language as an identifying aspect. I feel like this comment just became outdated. 1104770 4 255587 cfleizach 2015-06-25 16:11:18 -0700 Created attachment 255587 patch 1104771 5 commit-queue 2015-06-25 16:13:59 -0700 Attachment 255587 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1104772 6 255588 cfleizach 2015-06-25 16:14:34 -0700 Created attachment 255588 patch comment removed. thanks 1104776 7 commit-queue 2015-06-25 16:17:02 -0700 Attachment 255588 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1104777 8 255590 cfleizach 2015-06-25 16:17:12 -0700 Created attachment 255590 patch 1104901 9 255590 mario 2015-06-26 04:06:07 -0700 Comment on attachment 255590 patch View in context: https://bugs.webkit.org/attachment.cgi?id=255590&action=review > Source/WebCore/platform/ios/PlatformSpeechSynthesizerIOS.mm:240 > + Nit. I don't think you want this blank line here either :) 1104932 10 cfleizach 2015-06-26 08:19:01 -0700 http://trac.webkit.org/changeset/185997 255566 2015-06-25 12:33:55 -0700 2015-06-25 16:11:18 -0700 patch patch text/plain 1506 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTk1NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA2LTI1ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgaU9TIHNwZWVjaCBzeW50 aGVzaXplciBzaG91bGQgZXhwb3NlIG5hbWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDYzMTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAgICAqIHBs YXRmb3JtL2lvcy9QbGF0Zm9ybVNwZWVjaFN5bnRoZXNpemVySU9TLm1tOgorICAgICAgICAoV2Vi Q29yZTo6UGxhdGZvcm1TcGVlY2hTeW50aGVzaXplcjo6aW5pdGlhbGl6ZVZvaWNlTGlzdCk6CisK IDIwMTUtMDYtMjUgIE1hdHRoZXcgRGFpdGVyICA8bWRhaXRlckBhcHBsZS5jb20+CiAKICAgICAg ICAgRW5hYmxpbmcgTUVESUFfU1RSRUFNCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9p b3MvUGxhdGZvcm1TcGVlY2hTeW50aGVzaXplcklPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9pb3MvUGxhdGZvcm1TcGVlY2hTeW50aGVzaXplcklPUy5tbQkocmV2 aXNpb24gMTg1NjA4KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1BsYXRmb3JtU3Bl ZWNoU3ludGhlc2l6ZXJJT1MubW0JKHdvcmtpbmcgY29weSkKQEAgLTIzOSw4ICsyMzksOCBAQAog ICAgIGZvciAoQVZTcGVlY2hTeW50aGVzaXNWb2ljZSAqdm9pY2UgaW4gW0FWU3BlZWNoU3ludGhl c2lzVm9pY2VDbGFzcyBzcGVlY2hWb2ljZXNdKSB7CiAgICAgICAgIC8vIGlPUyBTcGVlY2ggdm9p Y2VzIG9ubHkgZXhwb3NlIHRoZWlyIGxhbmd1YWdlIGFzIGFuIGlkZW50aWZ5aW5nIGFzcGVjdC4K ICAgICAgICAgTlNTdHJpbmcgKmxhbmd1YWdlID0gW3ZvaWNlIGxhbmd1YWdlXTsKLSAgICAgICAg TlNTdHJpbmcgKnZvaWNlVVJJID0gbGFuZ3VhZ2U7Ci0gICAgICAgIE5TU3RyaW5nICpuYW1lID0g bGFuZ3VhZ2U7CisgICAgICAgIE5TU3RyaW5nICp2b2ljZVVSSSA9IFt2b2ljZSBpZGVudGlmaWVy XTsKKyAgICAgICAgTlNTdHJpbmcgKm5hbWUgPSBbdm9pY2UgbmFtZV07CiAgICAgICAgIGJvb2wg aXNEZWZhdWx0ID0gdHJ1ZTsKICAgICAgICAgCiAgICAgICAgIG1fdm9pY2VMaXN0LmFwcGVuZChQ bGF0Zm9ybVNwZWVjaFN5bnRoZXNpc1ZvaWNlOjpjcmVhdGUodm9pY2VVUkksIG5hbWUsIGxhbmd1 YWdlLCB0cnVlLCBpc0RlZmF1bHQpKTsK 255587 2015-06-25 16:11:18 -0700 2015-06-25 16:14:34 -0700 patch patch text/plain 1569 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTk1NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA2LTI1ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgaU9TIHNwZWVjaCBzeW50 aGVzaXplciBzaG91bGQgZXhwb3NlIG5hbWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDYzMTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAgICAqIHBs YXRmb3JtL2lvcy9QbGF0Zm9ybVNwZWVjaFN5bnRoZXNpemVySU9TLm1tOgorICAgICAgICAoV2Vi Q29yZTo6UGxhdGZvcm1TcGVlY2hTeW50aGVzaXplcjo6aW5pdGlhbGl6ZVZvaWNlTGlzdCk6CisK IDIwMTUtMDYtMjUgIE1hdHRoZXcgRGFpdGVyICA8bWRhaXRlckBhcHBsZS5jb20+CiAKICAgICAg ICAgRW5hYmxpbmcgTUVESUFfU1RSRUFNCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9p b3MvUGxhdGZvcm1TcGVlY2hTeW50aGVzaXplcklPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9pb3MvUGxhdGZvcm1TcGVlY2hTeW50aGVzaXplcklPUy5tbQkocmV2 aXNpb24gMTg1NjA4KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1BsYXRmb3JtU3Bl ZWNoU3ludGhlc2l6ZXJJT1MubW0JKHdvcmtpbmcgY29weSkKQEAgLTIzOSw4ICsyMzksMTMgQEAK ICAgICBmb3IgKEFWU3BlZWNoU3ludGhlc2lzVm9pY2UgKnZvaWNlIGluIFtBVlNwZWVjaFN5bnRo ZXNpc1ZvaWNlQ2xhc3Mgc3BlZWNoVm9pY2VzXSkgewogICAgICAgICAvLyBpT1MgU3BlZWNoIHZv aWNlcyBvbmx5IGV4cG9zZSB0aGVpciBsYW5ndWFnZSBhcyBhbiBpZGVudGlmeWluZyBhc3BlY3Qu CiAgICAgICAgIE5TU3RyaW5nICpsYW5ndWFnZSA9IFt2b2ljZSBsYW5ndWFnZV07CisjaWYgX19J UEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gOTAwMDAKKyAgICAgICAgTlNTdHJpbmcg KnZvaWNlVVJJID0gW3ZvaWNlIGlkZW50aWZpZXJdOworICAgICAgICBOU1N0cmluZyAqbmFtZSA9 IFt2b2ljZSBuYW1lXTsKKyNlbHNlCiAgICAgICAgIE5TU3RyaW5nICp2b2ljZVVSSSA9IGxhbmd1 YWdlOwogICAgICAgICBOU1N0cmluZyAqbmFtZSA9IGxhbmd1YWdlOworI2VuZGlmCiAgICAgICAg IGJvb2wgaXNEZWZhdWx0ID0gdHJ1ZTsKICAgICAgICAgCiAgICAgICAgIG1fdm9pY2VMaXN0LmFw cGVuZChQbGF0Zm9ybVNwZWVjaFN5bnRoZXNpc1ZvaWNlOjpjcmVhdGUodm9pY2VVUkksIG5hbWUs IGxhbmd1YWdlLCB0cnVlLCBpc0RlZmF1bHQpKTsK 255588 2015-06-25 16:14:34 -0700 2015-06-25 16:17:12 -0700 patch patch text/plain 1630 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTk1NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA2LTI1ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgaU9TIHNwZWVjaCBzeW50 aGVzaXplciBzaG91bGQgZXhwb3NlIG5hbWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDYzMTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAgICAqIHBs YXRmb3JtL2lvcy9QbGF0Zm9ybVNwZWVjaFN5bnRoZXNpemVySU9TLm1tOgorICAgICAgICAoV2Vi Q29yZTo6UGxhdGZvcm1TcGVlY2hTeW50aGVzaXplcjo6aW5pdGlhbGl6ZVZvaWNlTGlzdCk6CisK IDIwMTUtMDYtMjUgIE1hdHRoZXcgRGFpdGVyICA8bWRhaXRlckBhcHBsZS5jb20+CiAKICAgICAg ICAgRW5hYmxpbmcgTUVESUFfU1RSRUFNCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9p b3MvUGxhdGZvcm1TcGVlY2hTeW50aGVzaXplcklPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9pb3MvUGxhdGZvcm1TcGVlY2hTeW50aGVzaXplcklPUy5tbQkocmV2 aXNpb24gMTg1NjA4KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1BsYXRmb3JtU3Bl ZWNoU3ludGhlc2l6ZXJJT1MubW0JKHdvcmtpbmcgY29weSkKQEAgLTIzNywxMCArMjM3LDE1IEBA CiB2b2lkIFBsYXRmb3JtU3BlZWNoU3ludGhlc2l6ZXI6OmluaXRpYWxpemVWb2ljZUxpc3QoKQog ewogICAgIGZvciAoQVZTcGVlY2hTeW50aGVzaXNWb2ljZSAqdm9pY2UgaW4gW0FWU3BlZWNoU3lu dGhlc2lzVm9pY2VDbGFzcyBzcGVlY2hWb2ljZXNdKSB7Ci0gICAgICAgIC8vIGlPUyBTcGVlY2gg dm9pY2VzIG9ubHkgZXhwb3NlIHRoZWlyIGxhbmd1YWdlIGFzIGFuIGlkZW50aWZ5aW5nIGFzcGVj dC4KKwogICAgICAgICBOU1N0cmluZyAqbGFuZ3VhZ2UgPSBbdm9pY2UgbGFuZ3VhZ2VdOworI2lm IF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDkwMDAwCisgICAgICAgIE5TU3Ry aW5nICp2b2ljZVVSSSA9IFt2b2ljZSBpZGVudGlmaWVyXTsKKyAgICAgICAgTlNTdHJpbmcgKm5h bWUgPSBbdm9pY2UgbmFtZV07CisjZWxzZQogICAgICAgICBOU1N0cmluZyAqdm9pY2VVUkkgPSBs YW5ndWFnZTsKICAgICAgICAgTlNTdHJpbmcgKm5hbWUgPSBsYW5ndWFnZTsKKyNlbmRpZgogICAg ICAgICBib29sIGlzRGVmYXVsdCA9IHRydWU7CiAgICAgICAgIAogICAgICAgICBtX3ZvaWNlTGlz dC5hcHBlbmQoUGxhdGZvcm1TcGVlY2hTeW50aGVzaXNWb2ljZTo6Y3JlYXRlKHZvaWNlVVJJLCBu YW1lLCBsYW5ndWFnZSwgdHJ1ZSwgaXNEZWZhdWx0KSk7Cg== 255590 2015-06-25 16:17:12 -0700 2015-06-26 04:06:07 -0700 patch patch text/plain 1674 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTk1NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA2LTI1ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgaU9TIHNwZWVjaCBzeW50 aGVzaXplciBzaG91bGQgZXhwb3NlIG5hbWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDYzMTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBVc2UgbmV3ZXIgQVBJIHRvIGdldCB0aGUgbmFtZSBhbmQgaWRl bnRpZmllciBvZiBlYWNoIHZvaWNlIGFzc2V0LgorCisgICAgICAgICogcGxhdGZvcm0vaW9zL1Bs YXRmb3JtU3BlZWNoU3ludGhlc2l6ZXJJT1MubW06CisgICAgICAgIChXZWJDb3JlOjpQbGF0Zm9y bVNwZWVjaFN5bnRoZXNpemVyOjppbml0aWFsaXplVm9pY2VMaXN0KToKKwogMjAxNS0wNi0yNSAg TWF0dGhldyBEYWl0ZXIgIDxtZGFpdGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBFbmFibGluZyBN RURJQV9TVFJFQU0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9QbGF0Zm9ybVNw ZWVjaFN5bnRoZXNpemVySU9TLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2lvcy9QbGF0Zm9ybVNwZWVjaFN5bnRoZXNpemVySU9TLm1tCShyZXZpc2lvbiAxODU2MDgp CisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvUGxhdGZvcm1TcGVlY2hTeW50aGVzaXpl cklPUy5tbQkod29ya2luZyBjb3B5KQpAQCAtMjM3LDEwICsyMzcsMTUgQEAKIHZvaWQgUGxhdGZv cm1TcGVlY2hTeW50aGVzaXplcjo6aW5pdGlhbGl6ZVZvaWNlTGlzdCgpCiB7CiAgICAgZm9yIChB VlNwZWVjaFN5bnRoZXNpc1ZvaWNlICp2b2ljZSBpbiBbQVZTcGVlY2hTeW50aGVzaXNWb2ljZUNs YXNzIHNwZWVjaFZvaWNlc10pIHsKLSAgICAgICAgLy8gaU9TIFNwZWVjaCB2b2ljZXMgb25seSBl eHBvc2UgdGhlaXIgbGFuZ3VhZ2UgYXMgYW4gaWRlbnRpZnlpbmcgYXNwZWN0LgorCiAgICAgICAg IE5TU3RyaW5nICpsYW5ndWFnZSA9IFt2b2ljZSBsYW5ndWFnZV07CisjaWYgX19JUEhPTkVfT1Nf VkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gOTAwMDAKKyAgICAgICAgTlNTdHJpbmcgKnZvaWNlVVJJ ID0gW3ZvaWNlIGlkZW50aWZpZXJdOworICAgICAgICBOU1N0cmluZyAqbmFtZSA9IFt2b2ljZSBu YW1lXTsKKyNlbHNlCiAgICAgICAgIE5TU3RyaW5nICp2b2ljZVVSSSA9IGxhbmd1YWdlOwogICAg ICAgICBOU1N0cmluZyAqbmFtZSA9IGxhbmd1YWdlOworI2VuZGlmCiAgICAgICAgIGJvb2wgaXNE ZWZhdWx0ID0gdHJ1ZTsKICAgICAgICAgCiAgICAgICAgIG1fdm9pY2VMaXN0LmFwcGVuZChQbGF0 Zm9ybVNwZWVjaFN5bnRoZXNpc1ZvaWNlOjpjcmVhdGUodm9pY2VVUkksIG5hbWUsIGxhbmd1YWdl LCB0cnVlLCBpc0RlZmF1bHQpKTsK