146316 2015-06-25 08:20:23 -0700 [SOUP] NetworkCache: Make NetworkProcess::clearDiskCache actually clear the the resources depending on the date 2015-06-27 00:43:34 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Soup P2 Normal --- 1 cgarcia webkit-unassigned commit-queue koivisto svillar oldest_to_newest 1104651 0 cgarcia 2015-06-25 08:20:23 -0700 And make sure the completion handler is called, as well. This functionality is already implemented in Storage::clear(), so we just need to pass the time point and completion handler to Cache::clear(). 1104652 1 255555 cgarcia 2015-06-25 08:23:11 -0700 Created attachment 255555 Patch 1104653 2 commit-queue 2015-06-25 08:25:06 -0700 Attachment 255555 did not pass style-queue: ERROR: Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp:156: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1104876 3 255555 svillar 2015-06-26 00:14:21 -0700 Comment on attachment 255555 Patch Don't we have layout tests for this? 1104880 4 cgarcia 2015-06-26 00:35:23 -0700 (In reply to comment #3) > Comment on attachment 255555 [details] > Patch > > Don't we have layout tests for this? I don't think so, this is more for an API test I think, and there will be one for GTK+ when we expose clear_cache in WebKitWebsiteDataManager. Writing that unit tests is how I noticed this issue, indeed. 1105152 5 cgarcia 2015-06-27 00:43:34 -0700 Committed r186022: <http://trac.webkit.org/changeset/186022> 255555 2015-06-25 08:23:11 -0700 2015-06-26 00:14:21 -0700 Patch wk2-clear-cache.diff text/plain 2121 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwODhlNmIxLi4xZmFkMDU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkg QEAKIDIwMTUtMDYtMjUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtTT1VQXSBOZXR3b3JrQ2FjaGU6IE1ha2UgTmV0d29ya1Byb2Nlc3M6OmNs ZWFyRGlza0NhY2hlIGFjdHVhbGx5IGNsZWFyIHRoZSB0aGUgcmVzb3VyY2VzIGRlcGVuZGluZyBv biB0aGUgZGF0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQ2MzE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQW5kIG1ha2Ugc3VyZSB0aGUgY29tcGxldGlvbiBoYW5kbGVyIGlzIGNhbGxlZCwgYXMgd2Vs bC4gVGhpcworICAgICAgICBmdW5jdGlvbmFsaXR5IGlzIGFscmVhZHkgaW1wbGVtZW50ZWQgaW4g U3RvcmFnZTo6Y2xlYXIoKSwgc28gd2UKKyAgICAgICAganVzdCBuZWVkIHRvIHBhc3MgdGhlIHRp bWUgcG9pbnQgYW5kIGNvbXBsZXRpb24gaGFuZGxlciB0byBDYWNoZTo6Y2xlYXIoKS4KKworICAg ICAgICAqIE5ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya1Byb2Nlc3NTb3VwLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6TmV0d29ya1Byb2Nlc3M6OmNsZWFyRGlza0NhY2hlKToKKworMjAxNS0wNi0y NSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAg W0dUS10gQWRkIGluaXRpYWwgV2ViS2l0V2Vic2l0ZURhdGFNYW5hZ2VyIEFQSSBmb3IgcHJvY2Vz cyBjb25maWd1cmF0aW9uIG9wdGlvbnMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0NjE0OQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3 b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtQcm9jZXNzU291cC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9O ZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtQcm9jZXNzU291cC5jcHAKaW5kZXggYzg2Y2VkMC4u OTEwZTYxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3Mvc291cC9O ZXR3b3JrUHJvY2Vzc1NvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNz L3NvdXAvTmV0d29ya1Byb2Nlc3NTb3VwLmNwcApAQCAtMTUzLDEyICsxNTMsMTMgQEAgdm9pZCBO ZXR3b3JrUHJvY2Vzczo6Y2xlYXJDYWNoZUZvckFsbE9yaWdpbnModWludDMyX3QgY2FjaGVzVG9D bGVhcikKICAgICBjbGVhckRpc2tDYWNoZShzdGQ6OmNocm9ubzo6c3lzdGVtX2Nsb2NrOjp0aW1l X3BvaW50OjptaW4oKSwgW10geyB9KTsKIH0KIAotdm9pZCBOZXR3b3JrUHJvY2Vzczo6Y2xlYXJE aXNrQ2FjaGUoc3RkOjpjaHJvbm86OnN5c3RlbV9jbG9jazo6dGltZV9wb2ludCAvKiBtb2RpZmll ZFNpbmNlICovLCBzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+IC8qIGNvbXBsZXRpb25IYW5kbGVyICov KQordm9pZCBOZXR3b3JrUHJvY2Vzczo6Y2xlYXJEaXNrQ2FjaGUoc3RkOjpjaHJvbm86OnN5c3Rl bV9jbG9jazo6dGltZV9wb2ludCBtb2RpZmllZFNpbmNlLCBzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+ IGNvbXBsZXRpb25IYW5kbGVyKQogewotICAgIC8vIEZJWE1FOiBGaW5kIGEgd2F5IHRvIG9ubHkg Y2xlYXIgYSBwYXJ0IG9mIHRoZSBjYWNoZSBiYXNlZCBvbiB0aGUgZGF0ZS4KICNpZiBFTkFCTEUo TkVUV09SS19DQUNIRSkKLSAgICBOZXR3b3JrQ2FjaGU6OnNpbmdsZXRvbigpLmNsZWFyKCk7Cisg ICAgTmV0d29ya0NhY2hlOjpzaW5nbGV0b24oKS5jbGVhcihtb2RpZmllZFNpbmNlLCBXVEY6Om1v dmUoY29tcGxldGlvbkhhbmRsZXIpKTsKICNlbHNlCisgICAgVU5VU0VEX1BBUkFNKG1vZGlmaWVk U2luY2UpOworICAgIFVOVVNFRF9QQVJBTShjb21wbGV0aW9uSGFuZGxlcik7CiAgICAgc291cF9j YWNoZV9jbGVhcihTb3VwTmV0d29ya1Nlc3Npb246OmRlZmF1bHRTZXNzaW9uKCkuY2FjaGUoKSk7 CiAjZW5kaWYKIH0K