146314 2015-06-25 06:06:39 -0700 NSURLCache fallback does not work on iOS due to sandboxing 2015-07-20 16:33:16 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned andersca commit-queue oldest_to_newest 1104638 0 koivisto 2015-06-25 06:06:39 -0700 If Network Cache is disabled we try to use NSURLCache. This doesn't currently work on iOS due to sandboxing. 1104639 1 koivisto 2015-06-25 06:11:30 -0700 <rdar://problem/21433691> 1104644 2 255552 koivisto 2015-06-25 06:40:26 -0700 Created attachment 255552 patch 1104654 3 koivisto 2015-06-25 08:25:47 -0700 Hmm look like this is not correct. We end up with exciting /private/var/mobile/Containers/Data/Application/38D69C4C-B96F-41D6-8186-8A78798D7EDE/Library/Caches/com.apple.WebKit.Networking/var/mobile/Containers/Data/Application/38D69C4C-B96F-41D6-8186-8A78798D7EDE/Library/Caches/WebKit/NetworkCache/Cache.db with Network Cache disabled. 1109093 4 256698 koivisto 2015-07-13 07:58:39 -0700 Created attachment 256698 patch 1110812 5 256698 commit-queue 2015-07-20 16:33:14 -0700 Comment on attachment 256698 patch Clearing flags on attachment: 256698 Committed r187045: <http://trac.webkit.org/changeset/187045> 1110813 6 commit-queue 2015-07-20 16:33:16 -0700 All reviewed patches have been landed. Closing bug. 255552 2015-06-25 06:40:26 -0700 2015-07-13 07:58:39 -0700 patch nsurlcache-sandbox.patch text/plain 2061 koivisto SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTk1MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA2LTI1ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBOU1VSTENhY2hlIGZhbGxiYWNr IGRvZXMgbm90IHdvcmsgb24gaU9TIGR1ZSB0byBzYW5kYm94aW5nCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDYzMTQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGJyb2tlIHdpdGggY2FjaGUgcGF0 aCBjaGFuZ2VzLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Byb2Nl c3NDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya1Byb2Nlc3M6OnBsYXRmb3JtSW5p dGlhbGl6ZU5ldHdvcmtQcm9jZXNzQ29jb2EpOgorCisgICAgICAgICAgICBSZW1vdmUgdGhlIGlP UyBzcGVjaWFsIGNhc2UgZm9yIE5TVVJMQ2FjaGUgcGF0aCBhbmQgdXNlIHRoZSByZWd1bGFyIGNh Y2hlIHBhdGguCisgICAgICAgICAgICBUaGlzIGlzIHRoZSBwYXRoIHdlIGNyZWF0ZSB0aGUgc2Fu ZGJveCBleHRlbnNpb24gZm9yLgorCiAyMDE1LTA2LTI1ICBUaW0gSG9ydG9uICA8dGltb3RoeV9o b3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIENyYXNoIGluIFZpZXdHZXN0dXJlQ29udHJvbGxl cjo6ZGlkUmVzdG9yZVNjcm9sbFBvc2l0aW9uKCkgcnVubmluZyBXS1dlYlZpZXcuTG9hZEFsdGVy bmF0ZUhUTUxTdHJpbmdGcm9tUHJvdmlzaW9uYWxMb2FkRXJyb3IgdGVzdApJbmRleDogU291cmNl L1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Byb2Nlc3NDb2NvYS5tbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrUHJv Y2Vzc0NvY29hLm1tCShyZXZpc2lvbiAxODU4MjIpCisrKyBTb3VyY2UvV2ViS2l0Mi9OZXR3b3Jr UHJvY2Vzcy9jb2NvYS9OZXR3b3JrUHJvY2Vzc0NvY29hLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0x MDAsMTcgKzEwMCwxMCBAQCB2b2lkIE5ldHdvcmtQcm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxpemVO CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KICNlbmRpZgotI2lmIFBMQVRGT1JNKElP UykKLSAgICAgICAgW05TVVJMQ2FjaGUgc2V0U2hhcmVkVVJMQ2FjaGU6YWRvcHROUyhbW05TVVJM Q2FjaGUgYWxsb2NdCi0gICAgICAgICAgICBfaW5pdFdpdGhNZW1vcnlDYXBhY2l0eTpwYXJhbWV0 ZXJzLm5zVVJMQ2FjaGVNZW1vcnlDYXBhY2l0eQotICAgICAgICAgICAgZGlza0NhcGFjaXR5OnBh cmFtZXRlcnMubnNVUkxDYWNoZURpc2tDYXBhY2l0eQotICAgICAgICAgICAgcmVsYXRpdmVQYXRo OnBhcmFtZXRlcnMudWlQcm9jZXNzQnVuZGxlSWRlbnRpZmllcl0pLmdldCgpXTsKLSNlbHNlCiAg ICAgICAgIFtOU1VSTENhY2hlIHNldFNoYXJlZFVSTENhY2hlOmFkb3B0TlMoW1tOU1VSTENhY2hl IGFsbG9jXQogICAgICAgICAgICAgaW5pdFdpdGhNZW1vcnlDYXBhY2l0eTpwYXJhbWV0ZXJzLm5z VVJMQ2FjaGVNZW1vcnlDYXBhY2l0eQogICAgICAgICAgICAgZGlza0NhcGFjaXR5OnBhcmFtZXRl cnMubnNVUkxDYWNoZURpc2tDYXBhY2l0eQotICAgICAgICAgICAgZGlza1BhdGg6cGFyYW1ldGVy cy5kaXNrQ2FjaGVEaXJlY3RvcnldKS5nZXQoKV07Ci0jZW5kaWYKKyAgICAgICAgICAgIGRpc2tQ YXRoOm1fZGlza0NhY2hlRGlyZWN0b3J5XSkuZ2V0KCldOwogICAgIH0KIAogICAgIFJldGFpblB0 cjxDRlVSTENhY2hlUmVmPiBjYWNoZSA9IGFkb3B0Q0YoQ0ZVUkxDYWNoZUNvcHlTaGFyZWRVUkxD YWNoZSgpKTsK 256698 2015-07-13 07:58:39 -0700 2015-07-20 16:33:14 -0700 patch nsurlcache-path-2.patch text/plain 2382 koivisto SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4Njc2MSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA3LTEzICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBOU1VSTENhY2hlIGZhbGxiYWNr IGRvZXMgbm90IHdvcmsgb24gaU9TIGR1ZSB0byBzYW5kYm94aW5nCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDYzMTQKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzIxNDMzNjkxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoaXMgYnJva2Ugd2l0aCBlYXJsaWVyIGNhY2hlIHBhdGggY29tcHV0YXRpb24g Y2hhbmdlcy4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtQcm9jZXNz Q29jb2EubW06CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtQcm9jZXNzOjpwbGF0Zm9ybUluaXRp YWxpemVOZXR3b3JrUHJvY2Vzc0NvY29hKToKKworICAgICAgICAgICAgTlNVUkxDYWNoZSBwYXRo IGlzIHJlbGF0aXZlIHRvIHRoZSBjb250YWluZXIgY2FjaGUgcGF0aCBzbyAiLiIgaXMgc3VmZmlj aWVudC4KKyAgICAgICAgICAgIFRoaXMgcHV0cyB0aGUgY2FjaGUgZmlsZXMgdW5kZXIKKyAgICAg ICAgICAgIDxjb250YWluZXI+L0xpYnJhcnkvQ2FjaGVzL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29y a2luZy8KKwogMjAxNS0wNy0xMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxp YS5jb20+CiAKICAgICAgICAgW0dUS10gQ29udGVudHMgbm90IGNvcnJlY3RseSBsYWlkIG91dCB3 aGVuIHRoZSB3ZWIgdmlldyBpcyBub3QgcmVhbGl6ZWQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL05l dHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtQcm9jZXNzQ29jb2EubW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Byb2Nlc3NDb2NvYS5t bQkocmV2aXNpb24gMTg1OTA1KQorKysgU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY29j b2EvTmV0d29ya1Byb2Nlc3NDb2NvYS5tbQkod29ya2luZyBjb3B5KQpAQCAtMTAwLDE3ICsxMDAs MTYgQEAgdm9pZCBOZXR3b3JrUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplTgogICAgICAgICAg ICAgcmV0dXJuOwogICAgICAgICB9CiAjZW5kaWYKKyAgICAgICAgU3RyaW5nIG5zVVJMQ2FjaGVE aXJlY3RvcnkgPSBtX2Rpc2tDYWNoZURpcmVjdG9yeTsKICNpZiBQTEFURk9STShJT1MpCi0gICAg ICAgIFtOU1VSTENhY2hlIHNldFNoYXJlZFVSTENhY2hlOmFkb3B0TlMoW1tOU1VSTENhY2hlIGFs bG9jXQotICAgICAgICAgICAgX2luaXRXaXRoTWVtb3J5Q2FwYWNpdHk6cGFyYW1ldGVycy5uc1VS TENhY2hlTWVtb3J5Q2FwYWNpdHkKLSAgICAgICAgICAgIGRpc2tDYXBhY2l0eTpwYXJhbWV0ZXJz Lm5zVVJMQ2FjaGVEaXNrQ2FwYWNpdHkKLSAgICAgICAgICAgIHJlbGF0aXZlUGF0aDpwYXJhbWV0 ZXJzLnVpUHJvY2Vzc0J1bmRsZUlkZW50aWZpZXJdKS5nZXQoKV07Ci0jZWxzZQorICAgICAgICAv LyBOU1VSTENhY2hlIHBhdGggaXMgcmVsYXRpdmUgdG8gbmV0d29yayBwcm9jZXNzIGNhY2hlIGRp cmVjdG9yeS4KKyAgICAgICAgLy8gVGhpcyBwdXRzIGNhY2hlIGZpbGVzIHVuZGVyIDxjb250YWlu ZXI+L0xpYnJhcnkvQ2FjaGVzL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya2luZy8KKyAgICAgICAg bnNVUkxDYWNoZURpcmVjdG9yeSA9ICIuIjsKKyNlbmRpZgogICAgICAgICBbTlNVUkxDYWNoZSBz ZXRTaGFyZWRVUkxDYWNoZTphZG9wdE5TKFtbTlNVUkxDYWNoZSBhbGxvY10KICAgICAgICAgICAg IGluaXRXaXRoTWVtb3J5Q2FwYWNpdHk6cGFyYW1ldGVycy5uc1VSTENhY2hlTWVtb3J5Q2FwYWNp dHkKICAgICAgICAgICAgIGRpc2tDYXBhY2l0eTpwYXJhbWV0ZXJzLm5zVVJMQ2FjaGVEaXNrQ2Fw YWNpdHkKLSAgICAgICAgICAgIGRpc2tQYXRoOnBhcmFtZXRlcnMuZGlza0NhY2hlRGlyZWN0b3J5 XSkuZ2V0KCldOwotI2VuZGlmCisgICAgICAgICAgICBkaXNrUGF0aDpuc1VSTENhY2hlRGlyZWN0 b3J5XSkuZ2V0KCldOwogICAgIH0KIAogICAgIFJldGFpblB0cjxDRlVSTENhY2hlUmVmPiBjYWNo ZSA9IGFkb3B0Q0YoQ0ZVUkxDYWNoZUNvcHlTaGFyZWRVUkxDYWNoZSgpKTsK