146308 2015-06-24 23:45:45 -0700 Cleanup ENABLE_CSS3_CONDITIONAL_RULES codes 2015-06-25 16:39:54 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ljaehun.lim ljaehun.lim commit-queue dbates ossy oldest_to_newest 1104605 0 ljaehun.lim 2015-06-24 23:45:45 -0700 ENABLE_CSS3_CONDITIONAL_RULES guard was removed from r174536. 1104606 1 255541 ljaehun.lim 2015-06-24 23:48:03 -0700 Created attachment 255541 Patch 1104618 2 255541 ossy 2015-06-25 01:50:54 -0700 Comment on attachment 255541 Patch LGTM, good catch. But please remove $css3ConditionalRulesSupport too from line 56 before landing. 1104751 3 255582 ljaehun.lim 2015-06-25 15:49:23 -0700 Created attachment 255582 Patch 1104753 4 ljaehun.lim 2015-06-25 15:50:41 -0700 (In reply to comment #2) > Comment on attachment 255541 [details] > Patch > > LGTM, good catch. But please remove $css3ConditionalRulesSupport too from > line 56 before landing. Thanks. I updated. 1104789 5 255582 commit-queue 2015-06-25 16:39:50 -0700 Comment on attachment 255582 Patch Clearing flags on attachment: 255582 Committed r185970: <http://trac.webkit.org/changeset/185970> 1104790 6 commit-queue 2015-06-25 16:39:54 -0700 All reviewed patches have been landed. Closing bug. 255541 2015-06-24 23:48:03 -0700 2015-06-25 15:49:16 -0700 Patch bug-146308-20150625154717.patch text/plain 1572 ljaehun.lim U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1OTQ3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTRkYTNjMzAxMTU3MzM3Y2IzYjNmOWMwYWU3NzY0OThj YTBiNmE3MS4uNTBiNWQ1YmE1YmRiMGJlNmVmNDA2ZjNjNThjYzc3NzIyOTRmZmM2YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE1LTA2LTI0ICBKYWVodW4gTGltICA8bGphZWh1bi5saW1Ac2Ftc3VuZy5jb20+CisK KyAgICAgICAgQ2xlYW51cCBFTkFCTEVfQ1NTM19DT05ESVRJT05BTF9SVUxFUyBjb2Rlcy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjMwOAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVOQUJMRV9DU1Mz X0NPTkRJVElPTkFMX1JVTEVTIGd1YXJkIHdhcyByZW1vdmVkIGZyb20gcjE3NDUzNi4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cGVybC9GZWF0dXJlTGlzdC5wbToKKwogMjAxNS0wNi0yNCAg SmFzb24gTWFyY2VsbCAgPGptYXJjZWxsQGFwcGxlLmNvbT4KIAogICAgICAgICBXb3JrIHRvd2Fy ZHM6IEFkZCBzdGF0dXMgb2YgU2FmYXJpIHByb2plY3RzIG9uIGlPUyBEYXNoYm9hcmQgb24gYnVp bGQtc2FmYXJpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxp c3QucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxpc3QucG0KaW5kZXggY2E3 YzcxNjdlY2NkYjY3MGEzMDgzZTg4MjcwN2EzNWFlMmQwYTUwMC4uOGU5YjFmZmIxYTNmNDYzYzA4 OTc2ZWJiM2U1ODIyN2JiMTk5NTUwZiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw ZXJsL0ZlYXR1cmVMaXN0LnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9GZWF0dXJl TGlzdC5wbQpAQCAtMTkyLDkgKzE5Miw2IEBAIG15IEBmZWF0dXJlcyA9ICgKICAgICB7IG9wdGlv biA9PiAiY3NzLWdyaWQtbGF5b3V0IiwgZGVzYyA9PiAiVG9nZ2xlIENTUyBHcmlkIExheW91dCBz dXBwb3J0IiwKICAgICAgIGRlZmluZSA9PiAiRU5BQkxFX0NTU19HUklEX0xBWU9VVCIsIGRlZmF1 bHQgPT4gMSwgdmFsdWUgPT4gXCRjc3NHcmlkTGF5b3V0U3VwcG9ydCB9LAogCi0gICAgeyBvcHRp b24gPT4gImNzczMtY29uZGl0aW9uYWwtcnVsZXMiLCBkZXNjID0+ICJUb2dnbGUgQ1NTMyBDb25k aXRpb25hbCBSdWxlcyBzdXBwb3J0IChpLmUuIFxAc3VwcG9ydHMpIiwKLSAgICAgIGRlZmluZSA9 PiAiRU5BQkxFX0NTUzNfQ09ORElUSU9OQUxfUlVMRVMiLCBkZWZhdWx0ID0+IDEsIHZhbHVlID0+ IFwkY3NzM0NvbmRpdGlvbmFsUnVsZXNTdXBwb3J0IH0sCi0KICAgICB7IG9wdGlvbiA9PiAiY3Nz My10ZXh0IiwgZGVzYyA9PiAiVG9nZ2xlIENTUzMgVGV4dCBzdXBwb3J0IiwKICAgICAgIGRlZmlu ZSA9PiAiRU5BQkxFX0NTUzNfVEVYVCIsIGRlZmF1bHQgPT4gKGlzRWZsKCkgfHwgaXNHdGsoKSks IHZhbHVlID0+IFwkY3NzM1RleHRTdXBwb3J0IH0sCiAK 255582 2015-06-25 15:49:23 -0700 2015-06-25 16:39:50 -0700 Patch bug-146308-20150626074835.patch text/plain 1795 ljaehun.lim U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1OTY2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmFmMjQ5NThjZDc3MGYyMmE0OTQxNDk0Mjc3MDgxZTUx NzQ4MzJmZC4uYmMyNzE0MjJkNmI3Mjg3Y2MxM2I5MGJmZWRmODUyYmU2YjU1MDlmMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE1LTA2LTI1ICBKYWVodW4gTGltICA8bGphZWh1bi5saW1Ac2Ftc3VuZy5jb20+CisK KyAgICAgICAgQ2xlYW51cCBFTkFCTEVfQ1NTM19DT05ESVRJT05BTF9SVUxFUyBjb2Rlcy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjMwOAorCisg ICAgICAgIFJldmlld2VkIGJ5IENzYWJhIE9zenRyb2dvbsOhYy4KKworICAgICAgICBFTkFCTEVf Q1NTM19DT05ESVRJT05BTF9SVUxFUyBndWFyZCB3YXMgcmVtb3ZlZCBmcm9tIHIxNzQ1MzYuCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxpc3QucG06CisKIDIwMTUtMDYt MjUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAg IFtHVEtdIEFkZCBpbml0aWFsIFdlYktpdFdlYnNpdGVEYXRhTWFuYWdlciBBUEkgZm9yIHByb2Nl c3MgY29uZmlndXJhdGlvbiBvcHRpb25zCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dHBlcmwvRmVhdHVyZUxpc3QucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxp c3QucG0KaW5kZXggY2E3YzcxNjdlY2NkYjY3MGEzMDgzZTg4MjcwN2EzNWFlMmQwYTUwMC4uOTJi NmM5MTk1ZmMwMWY2MjlmYTdhZmZkZWQ3ZDFjMmI1NGRjNjM3NyAxMDA2NDQKLS0tIGEvVG9vbHMv U2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cGVybC9GZWF0dXJlTGlzdC5wbQpAQCAtNTMsNyArNTMsNiBAQCBteSAoCiAgICAgJGNsYXNz U3ludGF4LAogICAgICR0ZW1wbGF0ZUxpdGVyYWxTeW50YXgsCiAgICAgJGNzcE5leHRTdXBwb3J0 LAotICAgICRjc3MzQ29uZGl0aW9uYWxSdWxlc1N1cHBvcnQsCiAgICAgJGNzczNUZXh0U3VwcG9y dCwKICAgICAkY3NzM1RleHRMaW5lQnJlYWtTdXBwb3J0LAogICAgICRjc3M0SW1hZ2VzU3VwcG9y dCwKQEAgLTE5Miw5ICsxOTEsNiBAQCBteSBAZmVhdHVyZXMgPSAoCiAgICAgeyBvcHRpb24gPT4g ImNzcy1ncmlkLWxheW91dCIsIGRlc2MgPT4gIlRvZ2dsZSBDU1MgR3JpZCBMYXlvdXQgc3VwcG9y dCIsCiAgICAgICBkZWZpbmUgPT4gIkVOQUJMRV9DU1NfR1JJRF9MQVlPVVQiLCBkZWZhdWx0ID0+ IDEsIHZhbHVlID0+IFwkY3NzR3JpZExheW91dFN1cHBvcnQgfSwKIAotICAgIHsgb3B0aW9uID0+ ICJjc3MzLWNvbmRpdGlvbmFsLXJ1bGVzIiwgZGVzYyA9PiAiVG9nZ2xlIENTUzMgQ29uZGl0aW9u YWwgUnVsZXMgc3VwcG9ydCAoaS5lLiBcQHN1cHBvcnRzKSIsCi0gICAgICBkZWZpbmUgPT4gIkVO QUJMRV9DU1MzX0NPTkRJVElPTkFMX1JVTEVTIiwgZGVmYXVsdCA9PiAxLCB2YWx1ZSA9PiBcJGNz czNDb25kaXRpb25hbFJ1bGVzU3VwcG9ydCB9LAotCiAgICAgeyBvcHRpb24gPT4gImNzczMtdGV4 dCIsIGRlc2MgPT4gIlRvZ2dsZSBDU1MzIFRleHQgc3VwcG9ydCIsCiAgICAgICBkZWZpbmUgPT4g IkVOQUJMRV9DU1MzX1RFWFQiLCBkZWZhdWx0ID0+IChpc0VmbCgpIHx8IGlzR3RrKCkpLCB2YWx1 ZSA9PiBcJGNzczNUZXh0U3VwcG9ydCB9LAogCg==