146291 2015-06-24 14:48:38 -0700 DFG::SpeculativeJIT shouldn't use filter==Contradiction when it meant isClear 2015-06-24 21:07:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough basile_clement benjamin ggaren mark.lam mhahnenb mmirman msaboff nrotem oliver saam sam oldest_to_newest 1104488 0 fpizlo 2015-06-24 14:48:38 -0700 These are two different concepts. 1104490 1 fpizlo 2015-06-24 14:48:54 -0700 rdar://problem/21435366 1104491 2 255515 fpizlo 2015-06-24 14:51:11 -0700 Created attachment 255515 the patch 1104493 3 255515 msaboff 2015-06-24 14:55:29 -0700 Comment on attachment 255515 the patch r=me 1104592 4 fpizlo 2015-06-24 21:07:28 -0700 Landed in http://trac.webkit.org/changeset/185941 255515 2015-06-24 14:51:11 -0700 2015-06-24 14:55:29 -0700 the patch blah.patch text/plain 6617 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg1OTI3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBA CisyMDE1LTA2LTI0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHOjpTcGVjdWxhdGl2ZUpJVCBzaG91bGRuJ3QgdXNlIGZpbHRlcj09Q29udHJhZGljdGlvbiB3 aGVuIGl0IG1lYW50IGlzQ2xlYXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0NjI5MQorICAgICAgICByZGFyOi8vcHJvYmxlbS8yMTQzNTM2NgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgVGhl IGZpbHRlcigpIG1ldGhvZCByZXR1cm5zIENvbnRyYWRpY3Rpb24gb25seSB3aGVuIGEgdmFsdWUg KmJlY29tZXMqIGNsZWFyLiBUaGlzIGlzCisgICAgICAgIG5lY2Vzc2FyeSBmb3Igc3VwcG9ydGlu ZyB0aGUgY29udmVudGlvbiB0aGF0IG5vbi1KU1ZhbHVlIG5vZGVzIGhhdmUgYSBib3R0b20gcHJv dmVkCisgICAgICAgIHR5cGUuIChXZSBzaG91bGQgZml4IHRoYXQgY29udmVudGlvbiBldmVudHVh bGx5LCBidXQgZm9yIG5vdyBsZXQncyBqdXN0IGJlIGNvbnNpc3RlbnQKKyAgICAgICAgYWJvdXQg aXQuKQorICAgICAgICAKKyAgICAgICAgKiBkZmcvREZHRmlsdHJhdGlvblJlc3VsdC5oOiBEb2N1 bWVudCB0aGUgaXNzdWUuCisgICAgICAgICogZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3Bw OiBXb3JrIGFyb3VuZCB0aGUgaXNzdWUuCisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVK SVQ6OmZpbGxTcGVjdWxhdGVJbnQzMkludGVybmFsKToKKyAgICAgICAgKEpTQzo6REZHOjpTcGVj dWxhdGl2ZUpJVDo6ZmlsbFNwZWN1bGF0ZUNlbGwpOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1 bGF0aXZlSklUOjpmaWxsU3BlY3VsYXRlQm9vbGVhbik6CisgICAgICAgICogZGZnL0RGR1NwZWN1 bGF0aXZlSklUNjQuY3BwOiBXb3JrIGFyb3VuZCB0aGUgaXNzdWUuCisgICAgICAgIChKU0M6OkRG Rzo6U3BlY3VsYXRpdmVKSVQ6OmZpbGxTcGVjdWxhdGVJbnQzMkludGVybmFsKToKKyAgICAgICAg KEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6ZmlsbFNwZWN1bGF0ZUludDUyKToKKyAgICAgICAg KEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6ZmlsbFNwZWN1bGF0ZUNlbGwpOgorICAgICAgICAo SlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpmaWxsU3BlY3VsYXRlQm9vbGVhbik6CisKIDIwMTUt MDYtMjQgIERvdWcgUnVzc2VsbCAgPGRfcnVzc2VsbEBhcHBsZS5jb20+CiAKICAgICAgICAgQnVn IDE0NjE3NyAtIEFYOiBBWE9iamVjdENhY2hlIHNob3VsZCB0cnkgdG8gdXNlIGFuIHVuaWdub3Jl ZCBhY2Nlc3NpYmlsaXR5T2JqZWN0IApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdGaWx0cmF0aW9uUmVzdWx0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdGaWx0cmF0aW9uUmVzdWx0LmgJKHJldmlzaW9uIDE4NTkyMCkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHRmlsdHJhdGlvblJlc3VsdC5oCSh3b3JraW5nIGNvcHkpCkBA IC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAxMyBBcHBsZSBJbmMuIEFsbCBy aWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTMsIDIwMTUgQXBwbGUgSW5jLiBB bGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291 cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBh cmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC0z MCw4ICszMCwyMCBAQAogCiBuYW1lc3BhY2UgSlNDIHsgbmFtZXNwYWNlIERGRyB7CiAKKy8vIFRl bGxzIHlvdSBpZiBhbiBvcGVyYXRpb24gdGhhdCBmaWx0ZXJzIHR5cGUgKGkuZS4gZG9lcyBhIHR5 cGUgY2hlY2svc3BlY3VsYXRpb24pIHdpbGwgYWx3YXlzCisvLyBleGl0LiBGb3JtYWxseSwgdGhp cyBtZWFucyB0aGF0IHRoZSBwcm92ZW4gdHlwZSBvZiBhIHZhbHVlIHByaW9yIHRvIHRoZSBmaWx0 ZXIgd2FzIG5vdAorLy8gYm90dG9tIChpLmUuIG5vdCAiY2xlYXIiIG9yICJTcGVjRW1wdHkiKSBi dXQgYmVjb21lcyBib3R0b20gYXMgYSByZXN1bHQgb2YgZXhlY3V0aW5nIHRoZQorLy8gZmlsdGVy LgorLy8KKy8vIE5vdGUgdGhhdCBwZXIgdGhpcyBkZWZpbml0aW9uLCBhIGZpbHRlciB3aWxsIG5v dCByZXR1cm4gQ29udHJhZGljdGlvbiBpZiB0aGUgbm9kZSdzIHByb3ZlbgorLy8gdHlwZSB3YXMg YWxyZWFkeSBib3R0b20uIFRoaXMgaXMgbmVjZXNzYXJ5IGJlY2F1c2Ugd2UgaGF2ZSB0aGlzIHl1 Y2t5IGNvbnZlbnRpb24gb2YgdXNpbmcKKy8vIGEgcHJvdmVuIHR5cGUgb2YgYm90dG9tIGZvciBu b2RlcyB0aGF0IGRvbid0IGhvbGQgSlMgdmFsdWVzLCBsaWtlIFBoaSBub2RlcyBpbiBUaHJlYWRl ZENQUworLy8gYW5kIHN0b3JhZ2Ugbm9kZXMuCiBlbnVtIEZpbHRyYXRpb25SZXN1bHQgeworICAg IC8vIE1lYW5zIHRoYXQgdGhpcyBvcGVyYXRpb24gbWF5IG5vdCBhbHdheXMgZXhpdC4KICAgICBG aWx0cmF0aW9uT0ssCisgICAgCisgICAgLy8gTWVhbnMgdGFodCB0aGlzIG9wZXJhdGlvbiB3aWxs IGFsd2F5cyBleGl0LgogICAgIENvbnRyYWRpY3Rpb24KIH07CiAKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcAkocmV2 aXNpb24gMTg1OTIwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2 ZUpJVDMyXzY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtODQ2LDcgKzg0Niw4IEBAIEdQUlJlZyBT cGVjdWxhdGl2ZUpJVDo6ZmlsbFNwZWN1bGF0ZUludDMKICAgICBTcGVjdWxhdGVkVHlwZSB0eXBl ID0gdmFsdWUubV90eXBlOwogICAgIEFTU0VSVChlZGdlLnVzZUtpbmQoKSAhPSBLbm93bkludDMy VXNlIHx8ICEodmFsdWUubV90eXBlICYgflNwZWNJbnQzMikpOwogCi0gICAgaWYgKG1faW50ZXJw cmV0ZXIuZmlsdGVyKHZhbHVlLCBTcGVjSW50MzIpID09IENvbnRyYWRpY3Rpb24pIHsKKyAgICBt X2ludGVycHJldGVyLmZpbHRlcih2YWx1ZSwgU3BlY0ludDMyKTsKKyAgICBpZiAodmFsdWUuaXND bGVhcigpKSB7CiAgICAgICAgIHRlcm1pbmF0ZVNwZWN1bGF0aXZlRXhlY3V0aW9uKFVuY291bnRh YmxlLCBKU1ZhbHVlUmVncygpLCAwKTsKICAgICAgICAgcmV0dXJuRm9ybWF0ID0gRGF0YUZvcm1h dEludDMyOwogICAgICAgICByZXR1cm4gYWxsb2NhdGUoKTsKQEAgLTk3Myw3ICs5NzQsOCBAQCBH UFJSZWcgU3BlY3VsYXRpdmVKSVQ6OmZpbGxTcGVjdWxhdGVDZWxsCiAgICAgU3BlY3VsYXRlZFR5 cGUgdHlwZSA9IHZhbHVlLm1fdHlwZTsKICAgICBBU1NFUlQoKGVkZ2UudXNlS2luZCgpICE9IEtu b3duQ2VsbFVzZSAmJiBlZGdlLnVzZUtpbmQoKSAhPSBLbm93blN0cmluZ1VzZSkgfHwgISh2YWx1 ZS5tX3R5cGUgJiB+U3BlY0NlbGwpKTsKIAotICAgIGlmIChtX2ludGVycHJldGVyLmZpbHRlcih2 YWx1ZSwgU3BlY0NlbGwpID09IENvbnRyYWRpY3Rpb24pIHsKKyAgICBtX2ludGVycHJldGVyLmZp bHRlcih2YWx1ZSwgU3BlY0NlbGwpOworICAgIGlmICh2YWx1ZS5pc0NsZWFyKCkpIHsKICAgICAg ICAgdGVybWluYXRlU3BlY3VsYXRpdmVFeGVjdXRpb24oVW5jb3VudGFibGUsIEpTVmFsdWVSZWdz KCksIDApOwogICAgICAgICByZXR1cm4gYWxsb2NhdGUoKTsKICAgICB9CkBAIC0xMDU1LDcgKzEw NTcsOCBAQCBHUFJSZWcgU3BlY3VsYXRpdmVKSVQ6OmZpbGxTcGVjdWxhdGVCb29sCiAgICAgQWJz dHJhY3RWYWx1ZSYgdmFsdWUgPSBtX3N0YXRlLmZvck5vZGUoZWRnZSk7CiAgICAgU3BlY3VsYXRl ZFR5cGUgdHlwZSA9IHZhbHVlLm1fdHlwZTsKIAotICAgIGlmIChtX2ludGVycHJldGVyLmZpbHRl cih2YWx1ZSwgU3BlY0Jvb2xlYW4pID09IENvbnRyYWRpY3Rpb24pIHsKKyAgICBtX2ludGVycHJl dGVyLmZpbHRlcih2YWx1ZSwgU3BlY0Jvb2xlYW4pOworICAgIGlmICh2YWx1ZS5pc0NsZWFyKCkp IHsKICAgICAgICAgdGVybWluYXRlU3BlY3VsYXRpdmVFeGVjdXRpb24oVW5jb3VudGFibGUsIEpT VmFsdWVSZWdzKCksIDApOwogICAgICAgICByZXR1cm4gYWxsb2NhdGUoKTsKICAgICB9CkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5j cHAJKHJldmlzaW9uIDE4NTkyMCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3Bl Y3VsYXRpdmVKSVQ2NC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgxOCw3ICs4MTgsOCBAQCBHUFJS ZWcgU3BlY3VsYXRpdmVKSVQ6OmZpbGxTcGVjdWxhdGVJbnQzCiAgICAgU3BlY3VsYXRlZFR5cGUg dHlwZSA9IHZhbHVlLm1fdHlwZTsKICAgICBBU1NFUlQoZWRnZS51c2VLaW5kKCkgIT0gS25vd25J bnQzMlVzZSB8fCAhKHZhbHVlLm1fdHlwZSAmIH5TcGVjSW50MzIpKTsKIAotICAgIGlmIChtX2lu dGVycHJldGVyLmZpbHRlcih2YWx1ZSwgU3BlY0ludDMyKSA9PSBDb250cmFkaWN0aW9uKSB7Cisg ICAgbV9pbnRlcnByZXRlci5maWx0ZXIodmFsdWUsIFNwZWNJbnQzMik7CisgICAgaWYgKHZhbHVl LmlzQ2xlYXIoKSkgewogICAgICAgICB0ZXJtaW5hdGVTcGVjdWxhdGl2ZUV4ZWN1dGlvbihVbmNv dW50YWJsZSwgSlNWYWx1ZVJlZ3MoKSwgMCk7CiAgICAgICAgIHJldHVybkZvcm1hdCA9IERhdGFG b3JtYXRJbnQzMjsKICAgICAgICAgcmV0dXJuIGFsbG9jYXRlKCk7CkBAIC05NTksNyArOTYwLDgg QEAgR1BSUmVnIFNwZWN1bGF0aXZlSklUOjpmaWxsU3BlY3VsYXRlSW50NQogICAgIEFTU0VSVChk ZXNpcmVkRm9ybWF0ID09IERhdGFGb3JtYXRJbnQ1MiB8fCBkZXNpcmVkRm9ybWF0ID09IERhdGFG b3JtYXRTdHJpY3RJbnQ1Mik7CiAgICAgQWJzdHJhY3RWYWx1ZSYgdmFsdWUgPSBtX3N0YXRlLmZv ck5vZGUoZWRnZSk7CiAKLSAgICBpZiAobV9pbnRlcnByZXRlci5maWx0ZXIodmFsdWUsIFNwZWNN YWNoaW5lSW50KSA9PSBDb250cmFkaWN0aW9uKSB7CisgICAgbV9pbnRlcnByZXRlci5maWx0ZXIo dmFsdWUsIFNwZWNNYWNoaW5lSW50KTsKKyAgICBpZiAodmFsdWUuaXNDbGVhcigpKSB7CiAgICAg ICAgIHRlcm1pbmF0ZVNwZWN1bGF0aXZlRXhlY3V0aW9uKFVuY291bnRhYmxlLCBKU1ZhbHVlUmVn cygpLCAwKTsKICAgICAgICAgcmV0dXJuIGFsbG9jYXRlKCk7CiAgICAgfQpAQCAtMTA5NCw3ICsx MDk2LDggQEAgR1BSUmVnIFNwZWN1bGF0aXZlSklUOjpmaWxsU3BlY3VsYXRlQ2VsbAogICAgIFNw ZWN1bGF0ZWRUeXBlIHR5cGUgPSB2YWx1ZS5tX3R5cGU7CiAgICAgQVNTRVJUKChlZGdlLnVzZUtp bmQoKSAhPSBLbm93bkNlbGxVc2UgJiYgZWRnZS51c2VLaW5kKCkgIT0gS25vd25TdHJpbmdVc2Up IHx8ICEodmFsdWUubV90eXBlICYgflNwZWNDZWxsKSk7CiAKLSAgICBpZiAobV9pbnRlcnByZXRl ci5maWx0ZXIodmFsdWUsIFNwZWNDZWxsKSA9PSBDb250cmFkaWN0aW9uKSB7CisgICAgbV9pbnRl cnByZXRlci5maWx0ZXIodmFsdWUsIFNwZWNDZWxsKTsKKyAgICBpZiAodmFsdWUuaXNDbGVhcigp KSB7CiAgICAgICAgIHRlcm1pbmF0ZVNwZWN1bGF0aXZlRXhlY3V0aW9uKFVuY291bnRhYmxlLCBK U1ZhbHVlUmVncygpLCAwKTsKICAgICAgICAgcmV0dXJuIGFsbG9jYXRlKCk7CiAgICAgfQpAQCAt MTE2Nyw3ICsxMTcwLDggQEAgR1BSUmVnIFNwZWN1bGF0aXZlSklUOjpmaWxsU3BlY3VsYXRlQm9v bAogICAgIEFic3RyYWN0VmFsdWUmIHZhbHVlID0gbV9zdGF0ZS5mb3JOb2RlKGVkZ2UpOwogICAg IFNwZWN1bGF0ZWRUeXBlIHR5cGUgPSB2YWx1ZS5tX3R5cGU7CiAKLSAgICBpZiAobV9pbnRlcnBy ZXRlci5maWx0ZXIodmFsdWUsIFNwZWNCb29sZWFuKSA9PSBDb250cmFkaWN0aW9uKSB7CisgICAg bV9pbnRlcnByZXRlci5maWx0ZXIodmFsdWUsIFNwZWNCb29sZWFuKTsKKyAgICBpZiAodmFsdWUu aXNDbGVhcigpKSB7CiAgICAgICAgIHRlcm1pbmF0ZVNwZWN1bGF0aXZlRXhlY3V0aW9uKFVuY291 bnRhYmxlLCBKU1ZhbHVlUmVncygpLCAwKTsKICAgICAgICAgcmV0dXJuIGFsbG9jYXRlKCk7CiAg ICAgfQo=