146286 2015-06-24 12:48:43 -0700 Null dereference in DocumentLoader::areAllLoadersPageCacheAcceptable() 2015-06-24 14:44:42 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez aestes barraclough commit-queue ddkilzer japhet kling oldest_to_newest 1104449 0 cdumez 2015-06-24 12:48:43 -0700 Null dereference in DocumentLoader::areAllLoadersPageCacheAcceptable(): Thread 0 name: Dispatch queue: com.apple.main-thread Thread 0 Crashed: 0 WebCore 0x00000001959dd948 WebCore::Page::sessionID() const + 0 (Page.cpp:1677) 1 WebCore 0x0000000195009efc WebCore::DocumentLoader::stopLoading() + 452 (DocumentLoader.cpp:106) 2 WebCore 0x000000019501992c WebCore::DocumentLoader::detachFromFrame() + 60 (DocumentLoader.cpp:924) 3 WebCore 0x00000001950a0248 WebCore::FrameLoader::detachViewsAndDocumentLoader() + 84 (FrameLoader.cpp:1688) 4 WebCore 0x0000000195099798 WebCore::CachedFrame::destroy() + 56 (CachedFrame.cpp:261) 5 WebCore 0x00000001950997c8 WebCore::CachedFrame::destroy() + 104 (CachedFrame.cpp:265) 6 WebCore 0x0000000195099730 WebCore::CachedPage::~CachedPage() + 24 (CachedPage.cpp:68) 1104450 1 cdumez 2015-06-24 12:48:56 -0700 <rdar://problem/21523788> 1104453 2 255505 cdumez 2015-06-24 12:53:58 -0700 Created attachment 255505 Patch 1104485 3 255505 sam 2015-06-24 14:42:20 -0700 Comment on attachment 255505 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255505&action=review > Source/WebCore/ChangeLog:10 > + Add null check for the Page in areAllLoadersPageCacheAcceptable() > + to fix this top crasher until I can how this can happen. "until I can how this can happen." doesn't quite make sense. 1104486 4 cdumez 2015-06-24 14:44:42 -0700 Committed r185927: <http://trac.webkit.org/changeset/185927> 255505 2015-06-24 12:53:58 -0700 2015-06-24 14:42:20 -0700 Patch bug-146286-20150624125313.patch text/plain 1705 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1OTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTgzMzcyOTg5OTQwN2Yw M2VlMjAzMTMyMmNiNTFjYTU5OTMwMWMzYy4uYmRkZmQzNTJjZmE0YzQ1Nzk2YWQ0MjU4M2UwOGIy NTU1YTkxOWU5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA2LTI0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTnVsbCBkZXJlZmVyZW5jZSBp biBEb2N1bWVudExvYWRlcjo6YXJlQWxsTG9hZGVyc1BhZ2VDYWNoZUFjY2VwdGFibGUoKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2Mjg2CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8yMTUyMzc4OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbnVsbCBjaGVjayBmb3IgdGhlIFBhZ2UgaW4gYXJl QWxsTG9hZGVyc1BhZ2VDYWNoZUFjY2VwdGFibGUoKQorICAgICAgICB0byBmaXggdGhpcyB0b3Ag Y3Jhc2hlciB1bnRpbCBJIGNhbiBob3cgdGhpcyBjYW4gaGFwcGVuLgorCisgICAgICAgICogbG9h ZGVyL0RvY3VtZW50TG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmFyZUFsbExvYWRlcnNQ YWdlQ2FjaGVBY2NlcHRhYmxlKToKKwogMjAxNS0wNi0yNCAgWW91ZW5uIEZhYmxldCAgPHlvdWVu bi5mYWJsZXRAY3JmLmNhbm9uLmZyPgogCiAgICAgICAgIEltcHJvdmUgSlNET01Qcm9taXNlIGNh bGxQcm9taXNlRnVuY3Rpb24gbmFtaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvRG9jdW1lbnRMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9h ZGVyLmNwcAppbmRleCBiMGEzMjZjNDJjMDZhZjg0YTE3ZjcwMWI2MGZlZTFkZmU4ZmUzYmUyLi41 ZWM0N2FjMzFmMzM1YjM1YWVlMjg3NzIyZGI2MGM1NDQ2ZDFiYjhhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKQEAgLTEwMCw3ICsxMDAsNyBAQCBzdGF0aWMgYm9v bCBhcmVBbGxMb2FkZXJzUGFnZUNhY2hlQWNjZXB0YWJsZShjb25zdCBSZXNvdXJjZUxvYWRlck1h cCYgbG9hZGVycykKICAgICBWZWN0b3I8UmVmUHRyPFJlc291cmNlTG9hZGVyPj4gbG9hZGVyc0Nv cHk7CiAgICAgY29weVZhbHVlc1RvVmVjdG9yKGxvYWRlcnMsIGxvYWRlcnNDb3B5KTsKICAgICBm b3IgKGF1dG8mIGxvYWRlciA6IGxvYWRlcnNDb3B5KSB7Ci0gICAgICAgIGlmICghbG9hZGVyLT5m cmFtZUxvYWRlcigpKQorICAgICAgICBpZiAoIWxvYWRlci0+ZnJhbWVMb2FkZXIoKSB8fCAhbG9h ZGVyLT5mcmFtZUxvYWRlcigpLT5mcmFtZSgpLnBhZ2UoKSkKICAgICAgICAgICAgIHJldHVybiBm YWxzZTsKIAogICAgICAgICBDYWNoZWRSZXNvdXJjZSogY2FjaGVkUmVzb3VyY2UgPSBNZW1vcnlD YWNoZTo6c2luZ2xldG9uKCkucmVzb3VyY2VGb3JSZXF1ZXN0KGxvYWRlci0+cmVxdWVzdCgpLCBs b2FkZXItPmZyYW1lTG9hZGVyKCktPmZyYW1lKCkucGFnZSgpLT5zZXNzaW9uSUQoKSk7Cg==