146280 2015-06-24 08:33:57 -0700 Improve JSDOMPromise callPromiseFunction naming 2015-06-24 12:09:03 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf commit-queue darin oldest_to_newest 1104374 0 youennf 2015-06-24 08:33:57 -0700 Following on bug 146060, we could do some improvements. >> Source/WebCore/bindings/js/JSDOMPromise.h:62 >> +template<class JSClassName> > >The type here is the JavaScript class, not the JavaScript class name. I suggest the name WrapperClass here instead of JSClassName. Also, we almost always use typename rather >than class in templates, although I’m not entirely sure why. > >> Source/WebCore/bindings/js/JSDOMPromise.h:63 >> +inline JSC::JSValue callPromiseFunction(JSC::ExecState& state, JSClassName& jsObject, JSC::EncodedJSValue promiseFunction(JSC::ExecState*, JSClassName*, >JSC::JSPromiseDeferred*)) > >A typical name used in bindings for what we are calling jsObject here is “wrapper” 1104376 1 255483 youennf 2015-06-24 08:37:01 -0700 Created attachment 255483 Patch 1104378 2 youennf 2015-06-24 08:38:38 -0700 Given the modifications are already suggested as part of a review, I do not think a review is needed. But just in case, I will wait for tomorrow to cq it. 1104438 3 255483 commit-queue 2015-06-24 12:08:59 -0700 Comment on attachment 255483 Patch Clearing flags on attachment: 255483 Committed r185919: <http://trac.webkit.org/changeset/185919> 1104439 4 commit-queue 2015-06-24 12:09:03 -0700 All reviewed patches have been landed. Closing bug. 255483 2015-06-24 08:37:01 -0700 2015-06-24 12:08:59 -0700 Patch bug-146280-20150624173615.patch text/plain 2182 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1ODcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODgwZGNkYWUyYzQ3NDBi OTRmNmQ2ZmQ5YjkyYTY2YmNjMTFkMTMwNC4uZWM0MDlmNmEyYjA3N2U4NTMzYWJiMTIxY2E0NWIx MGQzMWJmNTZlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA2LTI0ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CisKKyAgICAgICAgSW1wcm92 ZSBKU0RPTVByb21pc2UgY2FsbFByb21pc2VGdW5jdGlvbiBuYW1pbmcKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjI4MAorCisgICAgICAgIFVucmV2 aWV3ZWQuCisKKyAgICAgICAgTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogYmlu ZGluZ3MvanMvSlNET01Qcm9taXNlLmg6CisgICAgICAgIChXZWJDb3JlOjpjYWxsUHJvbWlzZUZ1 bmN0aW9uKToKKwogMjAxNS0wNi0yNCAgWGFiaWVyIFJvZHJpZ3VleiBDYWx2YXIgIDxjYWx2YXJp c0BpZ2FsaWEuY29tPiBhbmQgWW91ZW5uIEZhYmxldCAgPHlvdWVubi5mYWJsZXRAY3JmLmNhbm9u LmZyPgogCiAgICAgICAgIFtTdHJlYW1zIEFQSV0gSW1wbGVtZW50IEhpZ2hXYXRlck1hcmsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NUHJvbWlzZS5oIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01Qcm9taXNlLmgKaW5kZXggMDhkYjI5Y2I3ZGJh ZGE1Mjc2MGRiZWE0MTc1NmU3OGUyMDNmNzY5ZS4uZDQxNThiNzI4NWI0NTUwZmMzNzIzMzgwYTc1 MDIzNmYwZTE0ODE1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNE T01Qcm9taXNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01Qcm9taXNl LmgKQEAgLTU5LDEzICs1OSwxMyBAQCBwcml2YXRlOgogCiB2b2lkIHJlamVjdFByb21pc2VXaXRo RXhjZXB0aW9uSWZBbnkoSlNDOjpFeGVjU3RhdGUmLCBKU0RPTUdsb2JhbE9iamVjdCYsIEpTQzo6 SlNQcm9taXNlRGVmZXJyZWQmKTsKIAotdGVtcGxhdGU8Y2xhc3MgSlNDbGFzc05hbWU+Ci1pbmxp bmUgSlNDOjpKU1ZhbHVlIGNhbGxQcm9taXNlRnVuY3Rpb24oSlNDOjpFeGVjU3RhdGUmIHN0YXRl LCBKU0NsYXNzTmFtZSYganNPYmplY3QsIEpTQzo6RW5jb2RlZEpTVmFsdWUgcHJvbWlzZUZ1bmN0 aW9uKEpTQzo6RXhlY1N0YXRlKiwgSlNDbGFzc05hbWUqLCBKU0M6OkpTUHJvbWlzZURlZmVycmVk KikpCit0ZW1wbGF0ZTx0eXBlbmFtZSBKU0NsYXNzTmFtZT4KK2lubGluZSBKU0M6OkpTVmFsdWUg Y2FsbFByb21pc2VGdW5jdGlvbihKU0M6OkV4ZWNTdGF0ZSYgc3RhdGUsIEpTQ2xhc3NOYW1lJiB3 cmFwcGVyLCBKU0M6OkVuY29kZWRKU1ZhbHVlIHByb21pc2VGdW5jdGlvbihKU0M6OkV4ZWNTdGF0 ZSosIEpTQ2xhc3NOYW1lKiwgSlNDOjpKU1Byb21pc2VEZWZlcnJlZCopKQogewotICAgIEpTQzo6 SlNQcm9taXNlRGVmZXJyZWQqIHByb21pc2VEZWZlcnJlZCA9IEpTQzo6SlNQcm9taXNlRGVmZXJy ZWQ6OmNyZWF0ZSgmc3RhdGUsIGpzT2JqZWN0Lmdsb2JhbE9iamVjdCgpKTsKLSAgICBwcm9taXNl RnVuY3Rpb24oJnN0YXRlLCAmanNPYmplY3QsIHByb21pc2VEZWZlcnJlZCk7CisgICAgSlNDOjpK U1Byb21pc2VEZWZlcnJlZCogcHJvbWlzZURlZmVycmVkID0gSlNDOjpKU1Byb21pc2VEZWZlcnJl ZDo6Y3JlYXRlKCZzdGF0ZSwgd3JhcHBlci5nbG9iYWxPYmplY3QoKSk7CisgICAgcHJvbWlzZUZ1 bmN0aW9uKCZzdGF0ZSwgJndyYXBwZXIsIHByb21pc2VEZWZlcnJlZCk7CiAKLSAgICByZWplY3RQ cm9taXNlV2l0aEV4Y2VwdGlvbklmQW55KHN0YXRlLCAqanNPYmplY3QuZ2xvYmFsT2JqZWN0KCks ICpwcm9taXNlRGVmZXJyZWQpOworICAgIHJlamVjdFByb21pc2VXaXRoRXhjZXB0aW9uSWZBbnko c3RhdGUsICp3cmFwcGVyLmdsb2JhbE9iamVjdCgpLCAqcHJvbWlzZURlZmVycmVkKTsKICAgICBB U1NFUlQoIXN0YXRlLmhhZEV4Y2VwdGlvbigpKTsKICAgICByZXR1cm4gcHJvbWlzZURlZmVycmVk LT5wcm9taXNlKCk7CiB9Cg==