146279 2015-06-24 08:25:22 -0700 CSP error message when frame load is blocked does not read well 2015-06-24 08:55:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dbates dbates commit-queue mkwst ossy oldest_to_newest 1104367 0 dbates 2015-06-24 08:25:22 -0700 When the Content Security Policy (CSP) blocks a frame load it emits an error message to the Web Inspector console that has the form: Refused to frame 'http://127.0.0.1:8000/security/contentSecurityPolicy/resources/alert-fail.html' because it violates the following Content Security Policy directive: "frame-src 'none'" This error message does not read well. In particular, the phrase "Refused to frame" does not read well. We should make this error message read well so that it is clear that the CSP policy of the page blocked a frame load. 1104371 1 255482 dbates 2015-06-24 08:30:18 -0700 Created attachment 255482 Patch 1104380 2 255482 ossy 2015-06-24 08:43:22 -0700 Comment on attachment 255482 Patch Nice catch, r=me. 1104381 3 255482 dbates 2015-06-24 08:55:10 -0700 Comment on attachment 255482 Patch Clearing flags on attachment: 255482 Committed r185912: <http://trac.webkit.org/changeset/185912> 1104382 4 dbates 2015-06-24 08:55:13 -0700 All reviewed patches have been landed. Closing bug. 255482 2015-06-24 08:30:18 -0700 2015-06-24 08:55:10 -0700 Patch bug-146279-20150624082934.patch text/plain 4393 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1ODI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzE2YWU3ODVlNGRjM2U5 NGRmZTM4ODkxZTE4NjgxMzE2NTBiZDZjZS4uMWQ4MGIwMjU4MzUyZjAyMTIyY2ExZGMyOTRjNTI2 MTNmNGI4YjZiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA2LTI0ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBDb250ZW50IFNlY3VyaXR5 IFBvbGljeSBlcnJvciBtZXNzYWdlIHdoZW4gZnJhbWUgbG9hZCBpcyBibG9ja2VkIGRvZXMgbm90 IHJlYWQgd2VsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQ2Mjc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgU3Vic3RpdHV0ZSAiUmVmdXNlZCB0byBsb2FkIGZyYW1lIiBmb3IgIlJlZnVzZWQgdG8gZnJh bWUiIGFzIHRoZSBwcmVmaXggb2YgdGhlIGVycm9yIG1lc3NhZ2UKKyAgICAgICAgZW1pdHRlZCB3 aGVuIHRoZSBDb250ZW50IFNlY3VyaXR5IFBvbGljeSBvZiB0aGUgcGFnZSBibG9ja3MgYSBmcmFt ZSBsb2FkLgorCisgICAgICAgICogcGFnZS9Db250ZW50U2VjdXJpdHlQb2xpY3kuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6Q1NQRGlyZWN0aXZlTGlzdDo6Y2hlY2tTb3VyY2VBbmRSZXBvcnRWaW9s YXRpb24pOgorCiAyMDE1LTA2LTIyICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4K IAogICAgICAgICBBWDogVUkgQXV0b21hdGlvbiBjYW5ub3QgZmluZCBBdXRvRmlsbCBvciBzZWFy Y2ggY2FuY2VsIGJ1dHRvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ29udGVu dFNlY3VyaXR5UG9saWN5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ29udGVudFNlY3VyaXR5 UG9saWN5LmNwcAppbmRleCBlZTEzZTVmODkyYWViYTFmMGZiZWMxYTFjMzJjYzczZWMwZjdiZGU2 Li4yNGUyZTU1ZjhkNmQ0NDlmMzdiMDJiOGI0YmFlYjA3OGY0ZGJlZWQyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wYWdlL0NvbnRlbnRTZWN1cml0eVBvbGljeS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGFnZS9Db250ZW50U2VjdXJpdHlQb2xpY3kuY3BwCkBAIC05NzEsNyArOTcxLDcg QEAgYm9vbCBDU1BEaXJlY3RpdmVMaXN0OjpjaGVja1NvdXJjZUFuZFJlcG9ydFZpb2xhdGlvbihT b3VyY2VMaXN0RGlyZWN0aXZlKiBkaXJlY3QKICAgICBlbHNlIGlmIChmb3JtQWN0aW9uID09IGVm ZmVjdGl2ZURpcmVjdGl2ZSkKICAgICAgICAgcHJlZml4ID0gIlJlZnVzZWQgdG8gc2VuZCBmb3Jt IGRhdGEgdG8gJyI7CiAgICAgZWxzZSBpZiAoZnJhbWVTcmMgPT0gZWZmZWN0aXZlRGlyZWN0aXZl KQotICAgICAgICBwcmVmaXggPSAiUmVmdXNlZCB0byBmcmFtZSAnIjsKKyAgICAgICAgcHJlZml4 ID0gIlJlZnVzZWQgdG8gbG9hZCBmcmFtZSAnIjsKICAgICBlbHNlIGlmIChpbWdTcmMgPT0gZWZm ZWN0aXZlRGlyZWN0aXZlKQogICAgICAgICBwcmVmaXggPSAiUmVmdXNlZCB0byBsb2FkIHRoZSBp bWFnZSAnIjsKICAgICBlbHNlIGlmIChtZWRpYVNyYyA9PSBlZmZlY3RpdmVEaXJlY3RpdmUpCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK aW5kZXggYTRiN2I4NWYwYTJlNzFlYjg1NzQwMDllOTVkNjJjYThhNDU1YjU2NC4uY2U3MzM0YWQ3 NWQzZDBkNjY0ZGNhYjE4YmZjODFhMTM3MTBjYzdhOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisy MDE1LTA2LTI0ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBD b250ZW50IFNlY3VyaXR5IFBvbGljeSBlcnJvciBtZXNzYWdlIHdoZW4gZnJhbWUgbG9hZCBpcyBi bG9ja2VkIGRvZXMgbm90IHJlYWQgd2VsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2Mjc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVXBkYXRlIGV4cGVjdGVkIHJlc3VsdHMuCisKKyAgICAgICAgKiBo dHRwL3Rlc3RzL3NlY3VyaXR5L2NvbnRlbnRTZWN1cml0eVBvbGljeS9mcmFtZS1zcmMtYmxvY2tl ZC1leHBlY3RlZC50eHQ6CisgICAgICAgICogaHR0cC90ZXN0cy9zZWN1cml0eS9jb250ZW50U2Vj dXJpdHlQb2xpY3kvZnJhbWUtc3JjLXJlZGlyZWN0LWJsb2NrZWQtZXhwZWN0ZWQudHh0OgorCiAy MDE1LTA2LTIzICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBM YXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L2NvbnRlbnRTZWN1cml0eVBvbGljeS9tZWRp YS1zcmMtdHJhY2stYmxvY2suaHRtbCBhbHdheXMgcGFzc2VzCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L2NvbnRlbnRTZWN1cml0eVBvbGljeS9mcmFtZS1zcmMt YmxvY2tlZC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L2Nv bnRlbnRTZWN1cml0eVBvbGljeS9mcmFtZS1zcmMtYmxvY2tlZC1leHBlY3RlZC50eHQKaW5kZXgg ZWFlZWY3ODAxYTI2OTBlYWU3NWZjYmE5YmFiN2FkNjY2YjY5YTBhZS4uZGRlZGE3YzdhMGY0OWQw NzA3NDkwZDg0Zjc2MjJhNTJkZjE4NWYzYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9zZWN1cml0eS9jb250ZW50U2VjdXJpdHlQb2xpY3kvZnJhbWUtc3JjLWJsb2NrZWQtZXhw ZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvY29udGVudFNl Y3VyaXR5UG9saWN5L2ZyYW1lLXNyYy1ibG9ja2VkLWV4cGVjdGVkLnR4dApAQCAtMSwzICsxLDMg QEAKLUNPTlNPTEUgTUVTU0FHRTogUmVmdXNlZCB0byBmcmFtZSAnaHR0cDovLzEyNy4wLjAuMTo4 MDAwL3NlY3VyaXR5L2NvbnRlbnRTZWN1cml0eVBvbGljeS9yZXNvdXJjZXMvYWxlcnQtZmFpbC5o dG1sJyBiZWNhdXNlIGl0IHZpb2xhdGVzIHRoZSBmb2xsb3dpbmcgQ29udGVudCBTZWN1cml0eSBQ b2xpY3kgZGlyZWN0aXZlOiAiZnJhbWUtc3JjICdub25lJyIuCitDT05TT0xFIE1FU1NBR0U6IFJl ZnVzZWQgdG8gbG9hZCBmcmFtZSAnaHR0cDovLzEyNy4wLjAuMTo4MDAwL3NlY3VyaXR5L2NvbnRl bnRTZWN1cml0eVBvbGljeS9yZXNvdXJjZXMvYWxlcnQtZmFpbC5odG1sJyBiZWNhdXNlIGl0IHZp b2xhdGVzIHRoZSBmb2xsb3dpbmcgQ29udGVudCBTZWN1cml0eSBQb2xpY3kgZGlyZWN0aXZlOiAi ZnJhbWUtc3JjICdub25lJyIuCiAKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9zZWN1cml0eS9jb250ZW50U2VjdXJpdHlQb2xpY3kvZnJhbWUtc3JjLXJlZGlyZWN0LWJsb2Nr ZWQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9jb250ZW50 U2VjdXJpdHlQb2xpY3kvZnJhbWUtc3JjLXJlZGlyZWN0LWJsb2NrZWQtZXhwZWN0ZWQudHh0Cmlu ZGV4IDNmYWU0YzU3MWNmZDRiNWQ5NzAxMjY0ZDc1NmRmMjdlMWY5YTIzYWIuLjllMjc3N2Y0YmI4 NzBiOGZmZTM5M2Q4YjhiNWM2YmYwNDg2NGQ2ZjcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0 dHAvdGVzdHMvc2VjdXJpdHkvY29udGVudFNlY3VyaXR5UG9saWN5L2ZyYW1lLXNyYy1yZWRpcmVj dC1ibG9ja2VkLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3Vy aXR5L2NvbnRlbnRTZWN1cml0eVBvbGljeS9mcmFtZS1zcmMtcmVkaXJlY3QtYmxvY2tlZC1leHBl Y3RlZC50eHQKQEAgLTEsMyArMSwzIEBACi1DT05TT0xFIE1FU1NBR0U6IFJlZnVzZWQgdG8gZnJh bWUgJ2h0dHA6Ly9sb2NhbGhvc3Q6ODAwMC9zZWN1cml0eS9jb250ZW50U2VjdXJpdHlQb2xpY3kv cmVzb3VyY2VzL2FsZXJ0LWZhaWwuaHRtbCcgYmVjYXVzZSBpdCB2aW9sYXRlcyB0aGUgZm9sbG93 aW5nIENvbnRlbnQgU2VjdXJpdHkgUG9saWN5IGRpcmVjdGl2ZTogImZyYW1lLXNyYyAxMjcuMC4w LjE6ODAwMCIuCitDT05TT0xFIE1FU1NBR0U6IFJlZnVzZWQgdG8gbG9hZCBmcmFtZSAnaHR0cDov L2xvY2FsaG9zdDo4MDAwL3NlY3VyaXR5L2NvbnRlbnRTZWN1cml0eVBvbGljeS9yZXNvdXJjZXMv YWxlcnQtZmFpbC5odG1sJyBiZWNhdXNlIGl0IHZpb2xhdGVzIHRoZSBmb2xsb3dpbmcgQ29udGVu dCBTZWN1cml0eSBQb2xpY3kgZGlyZWN0aXZlOiAiZnJhbWUtc3JjIDEyNy4wLjAuMTo4MDAwIi4K IAogCg==