146268 2015-06-23 17:54:23 -0700 Remove some dead code from Download 2015-06-24 02:26:02 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi andersca commit-queue darin ossy sam oldest_to_newest 1104274 0 ryuan.choi 2015-06-23 17:54:23 -0700 Since WebKit2 Windows is dropped, there are some dead code in Download. 1104287 1 255463 ryuan.choi 2015-06-23 18:21:56 -0700 Created attachment 255463 Patch 1104315 2 255463 ossy 2015-06-23 21:58:52 -0700 Comment on attachment 255463 Patch LGTM, but it should be reviewed by a wk2 owner. 1104332 3 255463 commit-queue 2015-06-24 02:25:56 -0700 Comment on attachment 255463 Patch Clearing flags on attachment: 255463 Committed r185905: <http://trac.webkit.org/changeset/185905> 1104333 4 commit-queue 2015-06-24 02:26:02 -0700 All reviewed patches have been landed. Closing bug. 255463 2015-06-23 18:21:56 -0700 2015-06-24 02:25:56 -0700 Patch bug-146268-20150624102110.patch text/plain 6106 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1ODY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDE2MDE0MzEwY2UwNGM3 ZmRhODExN2RjMjEyYTJlMmFhZjYyYzE2ZC4uOWMzNTNhNWNiYjU5MDA3ZmY2MTI2MmE5NDc2OWFl MzQxMzFhZGZlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE1LTA2LTIzICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFJlbW92ZSBzb21l IGRlYWQgY29kZSBmcm9tIERvd25sb2FkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDYyNjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICByZXRyaWV2ZURlc3RpbmF0aW9uV2l0aFN1Z2dlc3RlZEZpbGVuYW1l KCkgd2FzIGludHJvZHVjZWQgZm9yIERvd25sb2FkQ0ZOZXRXaW4uY3BwIHNpbmNlIHI3NzU4NS4K KyAgICAgICAgZGlkRGVjaWRlRGVzdGluYXRpb24gYW5kIG90aGVycyBhcmUgYWxzbyBpbnRyb2R1 Y2VkIGZvciBXZWJLaXQyIFdpbmRvd3MgcG9ydCBzaW5jZSByNzcwNTUuCisgICAgICAgIFNpbmNl IFdlYktpdDIgV2luZG93cyBwb3J0IGlzIGRyb3BwZWQsIG5vIG9uZSB1c2VzIHRoZW0gbm93Lgor CisgICAgICAgICogU2hhcmVkL0Rvd25sb2Fkcy9Eb3dubG9hZC5jcHA6CisgICAgICAgIChXZWJL aXQ6OkRvd25sb2FkOjpkZWNpZGVEZXN0aW5hdGlvbldpdGhTdWdnZXN0ZWRGaWxlbmFtZSk6Cisg ICAgICAgIChXZWJLaXQ6OkRvd25sb2FkOjpyZXRyaWV2ZURlc3RpbmF0aW9uV2l0aFN1Z2dlc3Rl ZEZpbGVuYW1lKTogRGVsZXRlZC4KKyAgICAgICAgKiBTaGFyZWQvRG93bmxvYWRzL0Rvd25sb2Fk Lmg6CisgICAgICAgIChXZWJLaXQ6OkRvd25sb2FkOjpkZXN0aW5hdGlvbik6IERlbGV0ZWQuCisg ICAgICAgICogU2hhcmVkL0Rvd25sb2Fkcy9pb3MvRG93bmxvYWRJT1MubW06CisgICAgICAgIChX ZWJLaXQ6OkRvd25sb2FkOjpkaWREZWNpZGVEZXN0aW5hdGlvbik6IERlbGV0ZWQuCisgICAgICAg ICogU2hhcmVkL0Rvd25sb2Fkcy9tYWMvRG93bmxvYWRNYWMubW06CisgICAgICAgIChXZWJLaXQ6 OkRvd25sb2FkOjpkaWREZWNpZGVEZXN0aW5hdGlvbik6IERlbGV0ZWQuCisgICAgICAgICogU2hh cmVkL0Rvd25sb2Fkcy9zb3VwL0Rvd25sb2FkU291cC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkRv d25sb2FkOjpkaWREZWNpZGVEZXN0aW5hdGlvbik6IERlbGV0ZWQuCisKIDIwMTUtMDYtMjIgIEd5 dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtFRkxdW0N1 c3RvbVByb3RvY29sXSBEbyBub3QgYWRkIGR1cGxpY2F0ZWQgY3VzdG9tIHNjaGVtZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0Rvd25sb2Fkcy9Eb3dubG9hZC5jcHAgYi9Tb3Vy Y2UvV2ViS2l0Mi9TaGFyZWQvRG93bmxvYWRzL0Rvd25sb2FkLmNwcAppbmRleCA3NzIyOWQ3M2Vm OTk0MTYxZGIzZWUzYjE3NTE2YmQ1ZjFlZDBiNTZmLi5kODcwZGZiNzEzMTQ4MGQzY2ZhNzgyNzRm M2E5MzdmZGE1ZDdlYjNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvRG93bmxv YWRzL0Rvd25sb2FkLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvRG93bmxvYWRzL0Rv d25sb2FkLmNwcApAQCAtNDMsOSArNDMsNiBAQCBEb3dubG9hZDo6RG93bmxvYWQoRG93bmxvYWRN YW5hZ2VyJiBkb3dubG9hZE1hbmFnZXIsIHVpbnQ2NF90IGRvd25sb2FkSUQsIGNvbnN0CiAgICAg OiBtX2Rvd25sb2FkTWFuYWdlcihkb3dubG9hZE1hbmFnZXIpCiAgICAgLCBtX2Rvd25sb2FkSUQo ZG93bmxvYWRJRCkKICAgICAsIG1fcmVxdWVzdChyZXF1ZXN0KQotI2lmIFVTRShDRk5FVFdPUksp Ci0gICAgLCBtX2FsbG93T3ZlcndyaXRlKGZhbHNlKQotI2VuZGlmCiB7CiAgICAgQVNTRVJUKG1f ZG93bmxvYWRJRCk7CiAKQEAgLTg4LDcgKzg1LDcgQEAgYm9vbCBEb3dubG9hZDo6c2hvdWxkRGVj b2RlU291cmNlRGF0YU9mTUlNRVR5cGUoY29uc3QgU3RyaW5nJiBtaW1lVHlwZSkKICAgICByZXR1 cm4gcmVzdWx0OwogfQogCi1TdHJpbmcgRG93bmxvYWQ6OnJldHJpZXZlRGVzdGluYXRpb25XaXRo U3VnZ2VzdGVkRmlsZW5hbWUoY29uc3QgU3RyaW5nJiBmaWxlbmFtZSwgYm9vbCYgYWxsb3dPdmVy d3JpdGUpCitTdHJpbmcgRG93bmxvYWQ6OmRlY2lkZURlc3RpbmF0aW9uV2l0aFN1Z2dlc3RlZEZp bGVuYW1lKGNvbnN0IFN0cmluZyYgZmlsZW5hbWUsIGJvb2wmIGFsbG93T3ZlcndyaXRlKQogewog ICAgIFN0cmluZyBkZXN0aW5hdGlvbjsKICAgICBTYW5kYm94RXh0ZW5zaW9uOjpIYW5kbGUgc2Fu ZGJveEV4dGVuc2lvbkhhbmRsZTsKQEAgLTEwMiwxNSArOTksNiBAQCBTdHJpbmcgRG93bmxvYWQ6 OnJldHJpZXZlRGVzdGluYXRpb25XaXRoU3VnZ2VzdGVkRmlsZW5hbWUoY29uc3QgU3RyaW5nJiBm aWxlbmFtZQogICAgIHJldHVybiBkZXN0aW5hdGlvbjsKIH0KIAotU3RyaW5nIERvd25sb2FkOjpk ZWNpZGVEZXN0aW5hdGlvbldpdGhTdWdnZXN0ZWRGaWxlbmFtZShjb25zdCBTdHJpbmcmIGZpbGVu YW1lLCBib29sJiBhbGxvd092ZXJ3cml0ZSkKLXsKLSAgICBTdHJpbmcgZGVzdGluYXRpb24gPSBy ZXRyaWV2ZURlc3RpbmF0aW9uV2l0aFN1Z2dlc3RlZEZpbGVuYW1lKGZpbGVuYW1lLCBhbGxvd092 ZXJ3cml0ZSk7Ci0KLSAgICBkaWREZWNpZGVEZXN0aW5hdGlvbihkZXN0aW5hdGlvbiwgYWxsb3dP dmVyd3JpdGUpOwotCi0gICAgcmV0dXJuIGRlc3RpbmF0aW9uOwotfQotCiB2b2lkIERvd25sb2Fk OjpkaWRDcmVhdGVEZXN0aW5hdGlvbihjb25zdCBTdHJpbmcmIHBhdGgpCiB7CiAgICAgc2VuZChN ZXNzYWdlczo6RG93bmxvYWRQcm94eTo6RGlkQ3JlYXRlRGVzdGluYXRpb24ocGF0aCkpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0Rvd25sb2Fkcy9Eb3dubG9hZC5oIGIvU291 cmNlL1dlYktpdDIvU2hhcmVkL0Rvd25sb2Fkcy9Eb3dubG9hZC5oCmluZGV4IDc1MDM3MmM5MGEw MWJlNjdmMTRjNjM2MzFiODIxODBkMzBlODYxNjEuLjJjNWQ0OWYwOTdkMDBlOWRiZmRmZTdkMjIx NTM0MmRiNDVmNGM2MTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9Eb3dubG9h ZHMvRG93bmxvYWQuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvRG93bmxvYWRzL0Rvd25s b2FkLmgKQEAgLTkwLDEwICs5MCw4IEBAIHB1YmxpYzoKICAgICB2b2lkIHBsYXRmb3JtRGlkRmlu aXNoKCk7CiAgICAgdm9pZCBkaWRGYWlsKGNvbnN0IFdlYkNvcmU6OlJlc291cmNlRXJyb3ImLCBj b25zdCBJUEM6OkRhdGFSZWZlcmVuY2UmIHJlc3VtZURhdGEpOwogICAgIHZvaWQgZGlkQ2FuY2Vs KGNvbnN0IElQQzo6RGF0YVJlZmVyZW5jZSYgcmVzdW1lRGF0YSk7Ci0gICAgdm9pZCBkaWREZWNp ZGVEZXN0aW5hdGlvbihjb25zdCBTdHJpbmcmLCBib29sIGFsbG93T3ZlcndyaXRlKTsKIAogI2lm IFVTRShDRk5FVFdPUkspCi0gICAgY29uc3QgU3RyaW5nJiBkZXN0aW5hdGlvbigpIGNvbnN0IHsg cmV0dXJuIG1fZGVzdGluYXRpb247IH0KICAgICBEb3dubG9hZEF1dGhlbnRpY2F0aW9uQ2xpZW50 KiBhdXRoZW50aWNhdGlvbkNsaWVudCgpOwogI2VuZGlmCiAKQEAgLTExNSw4ICsxMTMsNiBAQCBw cml2YXRlOgogCiAgICAgdm9pZCBwbGF0Zm9ybUludmFsaWRhdGUoKTsKIAotICAgIFN0cmluZyBy ZXRyaWV2ZURlc3RpbmF0aW9uV2l0aFN1Z2dlc3RlZEZpbGVuYW1lKGNvbnN0IFN0cmluZyYgZmls ZW5hbWUsIGJvb2wmIGFsbG93T3ZlcndyaXRlKTsKLQogICAgIERvd25sb2FkTWFuYWdlciYgbV9k b3dubG9hZE1hbmFnZXI7CiAgICAgdWludDY0X3QgbV9kb3dubG9hZElEOwogICAgIFdlYkNvcmU6 OlJlc291cmNlUmVxdWVzdCBtX3JlcXVlc3Q7CkBAIC0xMjcsOSArMTIzLDYgQEAgcHJpdmF0ZToK ICAgICBSZXRhaW5QdHI8TlNVUkxEb3dubG9hZD4gbV9uc1VSTERvd25sb2FkOwogICAgIFJldGFp blB0cjxXS0Rvd25sb2FkQXNEZWxlZ2F0ZT4gbV9kZWxlZ2F0ZTsKICNlbmRpZgotICAgIGJvb2wg bV9hbGxvd092ZXJ3cml0ZTsKLSAgICBTdHJpbmcgbV9kZXN0aW5hdGlvbjsKLSAgICBTdHJpbmcg bV9idW5kbGVQYXRoOwogI2lmIFVTRShDRk5FVFdPUkspCiAgICAgUmV0YWluUHRyPENGVVJMRG93 bmxvYWRSZWY+IG1fZG93bmxvYWQ7CiAgICAgUmVmUHRyPERvd25sb2FkQXV0aGVudGljYXRpb25D bGllbnQ+IG1fYXV0aGVudGljYXRpb25DbGllbnQ7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9TaGFyZWQvRG93bmxvYWRzL2lvcy9Eb3dubG9hZElPUy5tbSBiL1NvdXJjZS9XZWJLaXQyL1No YXJlZC9Eb3dubG9hZHMvaW9zL0Rvd25sb2FkSU9TLm1tCmluZGV4IDljNGYxOTI3MGFiN2JmMjdh Zjg2YTQ1NjJhOThhNmY5MWJlY2ViMWMuLmY4ZjQyMjA5ZDI3OWZmYTU0NmRhN2E5MWFhNTg5ZWQ0 MTQ1MDExZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9Eb3dubG9hZHMvaW9z L0Rvd25sb2FkSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9Eb3dubG9hZHMvaW9z L0Rvd25sb2FkSU9TLm1tCkBAIC0xNjEsMTEgKzE2MSw2IEBAIHZvaWQgRG93bmxvYWQ6OnBsYXRm b3JtSW52YWxpZGF0ZSgpCiAgICAgbm90SW1wbGVtZW50ZWQoKTsKIH0KIAotdm9pZCBEb3dubG9h ZDo6ZGlkRGVjaWRlRGVzdGluYXRpb24oY29uc3QgU3RyaW5nJiwgYm9vbCkKLXsKLSAgICBub3RJ bXBsZW1lbnRlZCgpOwotfQotCiB2b2lkIERvd25sb2FkOjpwbGF0Zm9ybURpZEZpbmlzaCgpCiB7 CiAgICAgbm90SW1wbGVtZW50ZWQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJl ZC9Eb3dubG9hZHMvbWFjL0Rvd25sb2FkTWFjLm1tIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0Rv d25sb2Fkcy9tYWMvRG93bmxvYWRNYWMubW0KaW5kZXggNTgzN2U3NDllNzc3OGI4ZjUwZDE4Yzdl N2NhZTBhZWQyMjBiMmM1MC4uZjg1MTM1NGYxZTBlM2E4ZDkyODk3MTkwODZkZmE4ZTUzZTJjMGM2 NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0Rvd25sb2Fkcy9tYWMvRG93bmxv YWRNYWMubW0KKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0Rvd25sb2Fkcy9tYWMvRG93bmxv YWRNYWMubW0KQEAgLTEzMSwxMCArMTMxLDYgQEAgdm9pZCBEb3dubG9hZDo6cGxhdGZvcm1JbnZh bGlkYXRlKCkKICAgICBtX25zVVJMRG93bmxvYWQgPSBudWxscHRyOwogfQogCi12b2lkIERvd25s b2FkOjpkaWREZWNpZGVEZXN0aW5hdGlvbihjb25zdCBTdHJpbmcmIGRlc3RpbmF0aW9uLCBib29s IGFsbG93T3ZlcndyaXRlKQotewotfQotCiB2b2lkIERvd25sb2FkOjpwbGF0Zm9ybURpZEZpbmlz aCgpCiB7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvRG93bmxvYWRzL3Nv dXAvRG93bmxvYWRTb3VwLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9Eb3dubG9hZHMvc291 cC9Eb3dubG9hZFNvdXAuY3BwCmluZGV4IDNjNTc5N2FjYzBlMDM2NDViOWUyNGRlYmIxNDExZWE2 ODMyMzg1ODYuLmMwOTlmODlhNDUzYjU5ZTdkNGMwN2JmYTRlMjA4Nzg3OGZjNmNlMDAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9Eb3dubG9hZHMvc291cC9Eb3dubG9hZFNvdXAu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9Eb3dubG9hZHMvc291cC9Eb3dubG9hZFNv dXAuY3BwCkBAIC0yNjMsMTEgKzI2Myw2IEBAIHZvaWQgRG93bmxvYWQ6OnBsYXRmb3JtSW52YWxp ZGF0ZSgpCiAgICAgbV9kb3dubG9hZENsaWVudCA9IG51bGxwdHI7CiB9CiAKLXZvaWQgRG93bmxv YWQ6OmRpZERlY2lkZURlc3RpbmF0aW9uKGNvbnN0IFN0cmluZyYgLypkZXN0aW5hdGlvbiovLCBi b29sIC8qYWxsb3dPdmVyd3JpdGUqLykKLXsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotfQotCiB2 b2lkIERvd25sb2FkOjpwbGF0Zm9ybURpZEZpbmlzaCgpCiB7CiAgICAgbV9yZXNvdXJjZUhhbmRs ZSA9IDA7Cg==