146255 2015-06-23 15:39:56 -0700 Add operator! and copy/move constructors to WeakObjCPtr 2015-06-23 15:47:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 1104211 0 andersca 2015-06-23 15:39:56 -0700 Add operator! and copy/move constructors to WeakObjCPtr 1104212 1 255442 andersca 2015-06-23 15:43:50 -0700 Created attachment 255442 Patch 1104214 2 255442 kling 2015-06-23 15:45:29 -0700 Comment on attachment 255442 Patch r=me Nice test. 1104216 3 commit-queue 2015-06-23 15:46:30 -0700 Attachment 255442 did not pass style-queue: ERROR: Source/WebKit2/Shared/mac/WeakObjCPtr.h:40: objc_copyWeak is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit2/Shared/mac/WeakObjCPtr.h:41: objc_moveWeak is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1104218 4 andersca 2015-06-23 15:47:41 -0700 Committed r185887: <http://trac.webkit.org/changeset/185887> 255442 2015-06-23 15:43:50 -0700 2015-06-23 15:45:29 -0700 Patch bug-146255-20150623154307.patch text/plain 3967 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1ODc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2U0NTRjYjg1MmY3NmM4 ODdkMzA4MWVjN2MxZTQ2NTI0N2U4NjY1Yy4uYzA3YTE1MmVlZTQ0NTY5MWEyNzFiOWVhNGQ3NmI3 ODI5MWNhOTg2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE1LTA2LTIzICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgQWRkIG9wZXJhdG9y ISBhbmQgY29weS9tb3ZlIGNvbnN0cnVjdG9ycyB0byBXZWFrT2JqQ1B0cgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2MjU1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQvbWFjL1dlYWtPYmpD UHRyLmg6CisgICAgICAgIChXZWJLaXQ6OldlYWtPYmpDUHRyOjpXZWFrT2JqQ1B0cik6CisgICAg ICAgIChXZWJLaXQ6OldlYWtPYmpDUHRyOjpvcGVyYXRvciEpOgorCisyMDE1LTA2LTIzICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgR2V0IHJpZCBvZiB0 aGUgd2luZG93IHJlc2l6ZXIgc2l6ZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQ2MjQwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJl ZC9tYWMvV2Vha09iakNQdHIuaCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvV2Vha09iakNQ dHIuaAppbmRleCBjYTBmMWIyYmY3OTc2ZjhhNTBmYWY2ODk1ODQzYTVkMDM1ZWZlNjg4Li4zMWZi YWIwOTAwNDMxMDc1NWJkNzg5MjQ2ZTU1NjQzNjE5NDg5YTc1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9TaGFyZWQvbWFjL1dlYWtPYmpDUHRyLmgKKysrIGIvU291cmNlL1dlYktpdDIvU2hh cmVkL21hYy9XZWFrT2JqQ1B0ci5oCkBAIC0zNyw2ICszNyw4IEBAIGV4dGVybiAiQyIgewogaWQg b2JqY19sb2FkV2Vha1JldGFpbmVkKGlkKik7CiBpZCBvYmpjX2luaXRXZWFrKGlkKiwgaWQpOwog dm9pZCBvYmpjX2Rlc3Ryb3lXZWFrKGlkKik7Cit2b2lkIG9iamNfY29weVdlYWsoaWQqLCBpZCop Owordm9pZCBvYmpjX21vdmVXZWFrKGlkKiwgaWQqKTsKIH0KICNlbmRpZgogCkBAIC01Niw2ICs1 OCwxNiBAQCBwdWJsaWM6CiAgICAgICAgIG9iamNfaW5pdFdlYWsoJm1fd2Vha1JlZmVyZW5jZSwg cHRyKTsKICAgICB9CiAKKyAgICBXZWFrT2JqQ1B0cihjb25zdCBXZWFrT2JqQ1B0ciYgb3RoZXIp CisgICAgeworICAgICAgICBvYmpjX2NvcHlXZWFrKCZtX3dlYWtSZWZlcmVuY2UsIGNvbnN0X2Nh c3Q8aWQqPigmb3RoZXIubV93ZWFrUmVmZXJlbmNlKSk7CisgICAgfQorCisgICAgV2Vha09iakNQ dHIoV2Vha09iakNQdHImJiBvdGhlcikKKyAgICB7CisgICAgICAgIG9iamNfbW92ZVdlYWsoJm1f d2Vha1JlZmVyZW5jZSwgJm90aGVyLm1fd2Vha1JlZmVyZW5jZSk7CisgICAgfQorCiAgICAgfldl YWtPYmpDUHRyKCkKICAgICB7CiAgICAgICAgIG9iamNfZGVzdHJveVdlYWsoJm1fd2Vha1JlZmVy ZW5jZSk7CkBAIC02OCw2ICs4MCwxMSBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiAqdGhpczsK ICAgICB9CiAKKyAgICBib29sIG9wZXJhdG9yISgpIGNvbnN0CisgICAgeworICAgICAgICByZXR1 cm4gIWdldCgpOworICAgIH0KKwogICAgIFJldGFpblB0cjxWYWx1ZVR5cGU+IGdldCgpIGNvbnN0 CiAgICAgewogICAgICAgICByZXR1cm4gYWRvcHROUyhvYmpjX2xvYWRXZWFrUmV0YWluZWQoY29u c3RfY2FzdDxpZCo+KCZtX3dlYWtSZWZlcmVuY2UpKSk7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFu Z2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTNiMTQzMTlhZWNlZmJiNTJkZWM5NWVhNDg3 ODhjNWU2MjcxY2IzZS4uYjMwNzNlYzg3YWZlMTdhNjRlYWUzMzRjM2NlNTlhNGZmNjdjZmZjNSAx MDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEzIEBACisyMDE1LTA2LTIzICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5j b20+CisKKyAgICAgICAgQWRkIG9wZXJhdG9yISBhbmQgY29weS9tb3ZlIGNvbnN0cnVjdG9ycyB0 byBXZWFrT2JqQ1B0cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQ2MjU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDIvY29jb2EvV2Vha09iakNQdHIubW06 CisgICAgICAgIChURVNUKToKKwogMjAxNS0wNi0yMyAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBh cHBsZS5jb20+CiAKICAgICAgICAgV0tGcmFtZUluZm8gc2hvdWxkIGhhdmUgYW4gYWNjZXNzb3Ig Zm9yIHRoZSBGcmFtZSdzIGN1cnJlbnQgc2VjdXJpdHkgb3JpZ2luLgpkaWZmIC0tZ2l0IGEvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyL2NvY29hL1dlYWtPYmpDUHRyLm1tIGIvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyL2NvY29hL1dlYWtPYmpDUHRyLm1tCmluZGV4 IDI5NThjMzk2ZTBhMWI4ZTJkNjgyMmQ3ZDJlMDdmOWEzMmIxODg5OTAuLmRhZmJiYjM5Njc0NmNh MjkyODE1OGM4OGZkNzBjZWQyZGZhOTBlOWEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0Mi9jb2NvYS9XZWFrT2JqQ1B0ci5tbQorKysgYi9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL1dlYktpdDIvY29jb2EvV2Vha09iakNQdHIubW0KQEAgLTEwNiwzICsxMDYs NDkgQEAgVEVTVChXZWJLaXQyX1dlYWtPYmpDUHRyLCBJZCkKIAogICAgIEVYUEVDVF9FUSh3ZWFr LmdldCgpLCAodm9pZCopbmlsKTsKIH0KKworVEVTVChXZWJLaXQyX1dlYWtPYmpDUHRyLCBMb2dp Y2FsTmVnYXRpb24pCit7CisgICAgaWQgb2JqZWN0ID0gW1tOU09iamVjdCBhbGxvY10gaW5pdF07 CisgICAgV2Vha09iakNQdHI8aWQ+IHdlYWsob2JqZWN0KTsKKworICAgIEVYUEVDVF9GQUxTRSgh d2Vhayk7CisKKyAgICBbb2JqZWN0IHJlbGVhc2VdOworCisgICAgRVhQRUNUX1RSVUUoIXdlYWsp OworfQorCitURVNUKFdlYktpdDJfV2Vha09iakNQdHIsIENvcHlDb25zdHJ1Y3RvcikKK3sKKyAg ICBpZCBvYmplY3QgPSBbW05TT2JqZWN0IGFsbG9jXSBpbml0XTsKKyAgICBXZWFrT2JqQ1B0cjxp ZD4gd2VhazEob2JqZWN0KTsKKyAgICBXZWFrT2JqQ1B0cjxpZD4gd2VhazIod2VhazEpOworCisg ICAgRVhQRUNUX0VRKHdlYWsxLmdldCgpLCBvYmplY3QpOworICAgIEVYUEVDVF9FUSh3ZWFrMi5n ZXQoKSwgb2JqZWN0KTsKKworICAgIHsKKyAgICAgICAgV2Vha09iakNQdHI8aWQ+IHdlYWszKHdl YWsyKTsKKyAgICB9CisKKyAgICBbb2JqZWN0IHJlbGVhc2VdOworCisgICAgRVhQRUNUX0VRKHdl YWsxLmdldCgpLCAodm9pZCopbmlsKTsKKyAgICBFWFBFQ1RfRVEod2VhazIuZ2V0KCksICh2b2lk KiluaWwpOworfQorCitURVNUKFdlYktpdDJfV2Vha09iakNQdHIsIE1vdmVDb25zdHJ1Y3RvcikK K3sKKyAgICBpZCBvYmplY3QgPSBbW05TT2JqZWN0IGFsbG9jXSBpbml0XTsKKyAgICBXZWFrT2Jq Q1B0cjxpZD4gd2VhazEob2JqZWN0KTsKKyAgICBXZWFrT2JqQ1B0cjxpZD4gd2VhazIoV1RGOjpt b3ZlKHdlYWsxKSk7CisKKyAgICBFWFBFQ1RfRVEod2VhazEuZ2V0KCksICh2b2lkKiluaWwpOwor ICAgIEVYUEVDVF9FUSh3ZWFrMi5nZXQoKSwgb2JqZWN0KTsKKworICAgIFtvYmplY3QgcmVsZWFz ZV07CisKKyAgICBFWFBFQ1RfRVEod2VhazEuZ2V0KCksICh2b2lkKiluaWwpOworICAgIEVYUEVD VF9FUSh3ZWFrMi5nZXQoKSwgKHZvaWQqKW5pbCk7Cit9Cg==