146252 2015-06-23 15:26:25 -0700 Should reduce tile coverage for the first paint after a tab switch 2015-06-23 19:10:23 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Performance P2 Normal --- 1 kling kling commit-queue kling koivisto oldest_to_newest 1104203 0 kling 2015-06-23 15:26:25 -0700 <rdar://problem/19821583> 1104210 1 255441 kling 2015-06-23 15:38:52 -0700 Created attachment 255441 Patch 1104220 2 255441 simon.fraser 2015-06-23 15:49:14 -0700 Comment on attachment 255441 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255441&action=review > Source/WebCore/page/FrameView.cpp:2496 > + // Turn off speculative tiling for a brief moment after a FrameView appears on screen. > + // Note that adjustTiledBackingCoverage() kicks the (500ms) timer to re-enable it. > + m_speculativeTilingEnabled = false; > + m_wasScrolledByUser = false; > + adjustTiledBackingCoverage(); Do you want to do this for non-main FrameViews? 1104227 3 kling 2015-06-23 16:01:09 -0700 (In reply to comment #2) > Comment on attachment 255441 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=255441&action=review > > > Source/WebCore/page/FrameView.cpp:2496 > > + // Turn off speculative tiling for a brief moment after a FrameView appears on screen. > > + // Note that adjustTiledBackingCoverage() kicks the (500ms) timer to re-enable it. > > + m_speculativeTilingEnabled = false; > > + m_wasScrolledByUser = false; > > + adjustTiledBackingCoverage(); > > Do you want to do this for non-main FrameViews? Ah, good point. We shouldn't do this for non-main FrameViews. 1104228 4 255445 kling 2015-06-23 16:02:04 -0700 Created attachment 255445 Patch Only do this for the main FrameView. 1104299 5 255445 commit-queue 2015-06-23 19:10:14 -0700 Comment on attachment 255445 Patch Clearing flags on attachment: 255445 Committed r185897: <http://trac.webkit.org/changeset/185897> 1104300 6 commit-queue 2015-06-23 19:10:23 -0700 All reviewed patches have been landed. Closing bug. 255441 2015-06-23 15:38:52 -0700 2015-06-23 16:02:04 -0700 Patch bug-146252.diff text/plain 2674 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlZDBhYmQ5Li5jOTA0YWE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAg QEAKKzIwMTUtMDYtMjMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFNob3VsZCByZWR1Y2UgdGlsZSBjb3ZlcmFnZSBmb3IgdGhlIGZpcnN0IHBhaW50IGFmdGVy IGEgdGFiIHN3aXRjaC4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE0NjI1Mj4KKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE5ODIxNTgzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlZHVjZSB0aGUgbnVtYmVyIG9mIHRpbGVzIHdlIG5l ZWQgdG8gcGFpbnQgYWZ0ZXIgc3dpdGNoaW5nIHRhYnMsCisgICAgICAgIHRvIHNob3J0ZW4gdGhl IHRpbWUgaXQgdGFrZXMgYmVmb3JlIHdlIGNhbiBmbHVzaCBwaXhlbHMgdG8gc2NyZWVuLgorCisg ICAgICAgIFdlIGFjY29tcGxpc2ggdGhpcyBieSBwaWdneWJhY2tpbmcgb24gdGhlICJzcGVjdWxh dGl2ZSB0aWxpbmcgZW5hYmxlZCIKKyAgICAgICAgbW9kZSBvZiBGcmFtZVZpZXcsIHdoaWNoIHdh cyBwcmV2aW91c2x5IG9ubHkgdXNlZCB0byB0aHJvdHRsZSBwYWludGluZworICAgICAgICBhbmQg bGF5ZXIgZmx1c2hlcyBkdXJpbmcgcGFnZSBsb2FkLgorCisgICAgICAgIFdoZW4gYSBGcmFtZVZp ZXcgYmVjb21lcyB2aXNpYmxlLCB3aGljaCBpcyB3aGF0IGhhcHBlbnMgd2hlbiB5b3UKKyAgICAg ICAgc3dpdGNoIHRvIGl0cyB0YWIsIHdlIHJldmVydCB0aGUgc3BlY3VsYXRpdmUgdGlsaW5nIG9w dGltaXphdGlvbiB0bworICAgICAgICBpdHMgaW5pdGlhbCBzdGF0ZSwgYW5kIHJlc2V0IHRoZSAi c2Nyb2xsZWQgYnkgdXNlciIgZmxhZy4KKworICAgICAgICBJbiBwcmFjdGljZSB0aGlzIG1lYW5z IHRoYXQgYWZ0ZXIgc3dpdGNoaW5nIHRhYnMsIHdlIG9ubHkgZ2VuZXJhdGUKKyAgICAgICAgZW5v dWdoIHRpbGVzIHRvIGZpbGwgdGhlIHZpZXdwb3J0LiBUaGVuLCBhZnRlciA1MDBtcyBoYXMgcGFz c2VkCisgICAgICAgIG9yIHRoZSB1c2VyIHNjcm9sbHMgdGhlIHBhZ2UsIHdlIGdvIGJhY2sgdG8g dGhlIHVzdWFsIHNwZWN1bGF0aXZlCisgICAgICAgIHRpbGluZyBtb2RlLgorCisgICAgICAgICog cGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpzaG93KToK KwogMjAxNS0wNi0yMiAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgog CiAgICAgICAgIFtpT1NdIEFyYWJpYyB0ZXh0IHN0eWxlZCB3aXRoIEdlb3JnaWEgaXMgcmVuZGVy ZWQgYXMgYm94ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAppbmRleCBhYmM2M2JmLi5mYzBh NmFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCkBAIC0yNDg1LDYgKzI0ODUsMTcgQEAg dm9pZCBGcmFtZVZpZXc6OnNwZWN1bGF0aXZlVGlsaW5nRW5hYmxlVGltZXJGaXJlZCgpCiAgICAg YWRqdXN0VGlsZWRCYWNraW5nQ292ZXJhZ2UoKTsKIH0KIAordm9pZCBGcmFtZVZpZXc6OnNob3co KQoreworICAgIFNjcm9sbFZpZXc6OnNob3coKTsKKworICAgIC8vIFR1cm4gb2ZmIHNwZWN1bGF0 aXZlIHRpbGluZyBmb3IgYSBicmllZiBtb21lbnQgYWZ0ZXIgYSBGcmFtZVZpZXcgYXBwZWFycyBv biBzY3JlZW4uCisgICAgLy8gTm90ZSB0aGF0IGFkanVzdFRpbGVkQmFja2luZ0NvdmVyYWdlKCkg a2lja3MgdGhlICg1MDBtcykgdGltZXIgdG8gcmUtZW5hYmxlIGl0LgorICAgIG1fc3BlY3VsYXRp dmVUaWxpbmdFbmFibGVkID0gZmFsc2U7CisgICAgbV93YXNTY3JvbGxlZEJ5VXNlciA9IGZhbHNl OworICAgIGFkanVzdFRpbGVkQmFja2luZ0NvdmVyYWdlKCk7Cit9CisKIHZvaWQgRnJhbWVWaWV3 OjpsYXlvdXRUaW1lckZpcmVkKCkKIHsKICNpZmRlZiBJTlNUUlVNRU5UX0xBWU9VVF9TQ0hFRFVM SU5HCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oIGIvU291cmNl L1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaAppbmRleCBiNmQwODdiLi40NjQzZjhlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRnJhbWVWaWV3LmgKQEAgLTU0Niw2ICs1NDYsOCBAQCBwdWJsaWM6CiAKICAgICB2b2lk IGRpZENoYW5nZVNjcm9sbE9mZnNldCgpOwogCisgICAgdm9pZCBzaG93KCkgb3ZlcnJpZGU7CisK IHByb3RlY3RlZDoKICAgICB2aXJ0dWFsIGJvb2wgc2Nyb2xsQ29udGVudHNGYXN0UGF0aChjb25z dCBJbnRTaXplJiBzY3JvbGxEZWx0YSwgY29uc3QgSW50UmVjdCYgcmVjdFRvU2Nyb2xsLCBjb25z dCBJbnRSZWN0JiBjbGlwUmVjdCkgb3ZlcnJpZGU7CiAgICAgdmlydHVhbCB2b2lkIHNjcm9sbENv bnRlbnRzU2xvd1BhdGgoY29uc3QgSW50UmVjdCYgdXBkYXRlUmVjdCkgb3ZlcnJpZGU7Cg== 255445 2015-06-23 16:02:04 -0700 2015-06-23 19:10:14 -0700 Patch bug-146252-2.diff text/plain 2735 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlZDBhYmQ5Li5jOTA0YWE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAg QEAKKzIwMTUtMDYtMjMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFNob3VsZCByZWR1Y2UgdGlsZSBjb3ZlcmFnZSBmb3IgdGhlIGZpcnN0IHBhaW50IGFmdGVy IGEgdGFiIHN3aXRjaC4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE0NjI1Mj4KKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE5ODIxNTgzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlZHVjZSB0aGUgbnVtYmVyIG9mIHRpbGVzIHdlIG5l ZWQgdG8gcGFpbnQgYWZ0ZXIgc3dpdGNoaW5nIHRhYnMsCisgICAgICAgIHRvIHNob3J0ZW4gdGhl IHRpbWUgaXQgdGFrZXMgYmVmb3JlIHdlIGNhbiBmbHVzaCBwaXhlbHMgdG8gc2NyZWVuLgorCisg ICAgICAgIFdlIGFjY29tcGxpc2ggdGhpcyBieSBwaWdneWJhY2tpbmcgb24gdGhlICJzcGVjdWxh dGl2ZSB0aWxpbmcgZW5hYmxlZCIKKyAgICAgICAgbW9kZSBvZiBGcmFtZVZpZXcsIHdoaWNoIHdh cyBwcmV2aW91c2x5IG9ubHkgdXNlZCB0byB0aHJvdHRsZSBwYWludGluZworICAgICAgICBhbmQg bGF5ZXIgZmx1c2hlcyBkdXJpbmcgcGFnZSBsb2FkLgorCisgICAgICAgIFdoZW4gYSBGcmFtZVZp ZXcgYmVjb21lcyB2aXNpYmxlLCB3aGljaCBpcyB3aGF0IGhhcHBlbnMgd2hlbiB5b3UKKyAgICAg ICAgc3dpdGNoIHRvIGl0cyB0YWIsIHdlIHJldmVydCB0aGUgc3BlY3VsYXRpdmUgdGlsaW5nIG9w dGltaXphdGlvbiB0bworICAgICAgICBpdHMgaW5pdGlhbCBzdGF0ZSwgYW5kIHJlc2V0IHRoZSAi c2Nyb2xsZWQgYnkgdXNlciIgZmxhZy4KKworICAgICAgICBJbiBwcmFjdGljZSB0aGlzIG1lYW5z IHRoYXQgYWZ0ZXIgc3dpdGNoaW5nIHRhYnMsIHdlIG9ubHkgZ2VuZXJhdGUKKyAgICAgICAgZW5v dWdoIHRpbGVzIHRvIGZpbGwgdGhlIHZpZXdwb3J0LiBUaGVuLCBhZnRlciA1MDBtcyBoYXMgcGFz c2VkCisgICAgICAgIG9yIHRoZSB1c2VyIHNjcm9sbHMgdGhlIHBhZ2UsIHdlIGdvIGJhY2sgdG8g dGhlIHVzdWFsIHNwZWN1bGF0aXZlCisgICAgICAgIHRpbGluZyBtb2RlLgorCisgICAgICAgICog cGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpzaG93KToK KwogMjAxNS0wNi0yMiAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgog CiAgICAgICAgIFtpT1NdIEFyYWJpYyB0ZXh0IHN0eWxlZCB3aXRoIEdlb3JnaWEgaXMgcmVuZGVy ZWQgYXMgYm94ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAppbmRleCBhYmM2M2JmLi4xZDY4 NzdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCkBAIC0yNDg1LDYgKzI0ODUsMTkgQEAg dm9pZCBGcmFtZVZpZXc6OnNwZWN1bGF0aXZlVGlsaW5nRW5hYmxlVGltZXJGaXJlZCgpCiAgICAg YWRqdXN0VGlsZWRCYWNraW5nQ292ZXJhZ2UoKTsKIH0KIAordm9pZCBGcmFtZVZpZXc6OnNob3co KQoreworICAgIFNjcm9sbFZpZXc6OnNob3coKTsKKworICAgIGlmIChmcmFtZSgpLmlzTWFpbkZy YW1lKCkpIHsKKyAgICAgICAgLy8gVHVybiBvZmYgc3BlY3VsYXRpdmUgdGlsaW5nIGZvciBhIGJy aWVmIG1vbWVudCBhZnRlciBhIEZyYW1lVmlldyBhcHBlYXJzIG9uIHNjcmVlbi4KKyAgICAgICAg Ly8gTm90ZSB0aGF0IGFkanVzdFRpbGVkQmFja2luZ0NvdmVyYWdlKCkga2lja3MgdGhlICg1MDBt cykgdGltZXIgdG8gcmUtZW5hYmxlIGl0LgorICAgICAgICBtX3NwZWN1bGF0aXZlVGlsaW5nRW5h YmxlZCA9IGZhbHNlOworICAgICAgICBtX3dhc1Njcm9sbGVkQnlVc2VyID0gZmFsc2U7CisgICAg ICAgIGFkanVzdFRpbGVkQmFja2luZ0NvdmVyYWdlKCk7CisgICAgfQorfQorCiB2b2lkIEZyYW1l Vmlldzo6bGF5b3V0VGltZXJGaXJlZCgpCiB7CiAjaWZkZWYgSU5TVFJVTUVOVF9MQVlPVVRfU0NI RURVTElORwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaCBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmgKaW5kZXggYjZkMDg3Yi4uNDY0M2Y4ZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0ZyYW1lVmlldy5oCkBAIC01NDYsNiArNTQ2LDggQEAgcHVibGljOgogCiAgICAg dm9pZCBkaWRDaGFuZ2VTY3JvbGxPZmZzZXQoKTsKIAorICAgIHZvaWQgc2hvdygpIG92ZXJyaWRl OworCiBwcm90ZWN0ZWQ6CiAgICAgdmlydHVhbCBib29sIHNjcm9sbENvbnRlbnRzRmFzdFBhdGgo Y29uc3QgSW50U2l6ZSYgc2Nyb2xsRGVsdGEsIGNvbnN0IEludFJlY3QmIHJlY3RUb1Njcm9sbCwg Y29uc3QgSW50UmVjdCYgY2xpcFJlY3QpIG92ZXJyaWRlOwogICAgIHZpcnR1YWwgdm9pZCBzY3Jv bGxDb250ZW50c1Nsb3dQYXRoKGNvbnN0IEludFJlY3QmIHVwZGF0ZVJlY3QpIG92ZXJyaWRlOwo=