146247 2015-06-23 14:10:40 -0700 Web Inspector: Some brief previews are incorrectly treated as lossless 2015-06-23 15:09:58 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1104173 0 joepeck 2015-06-23 14:10:40 -0700 * SUMMARY Some brief previews are incorrectly treated as lossless. * TEST <script> console.log("My Object", {a:1, b:2, c:3, d:4}); </script> * STEPS TO REPRODUCE 1. Inspect test page 2. Show console 3. Reload => Object displays as lossless, but we only see 3 of the 4 properties. Should be lossy so we can expand 1104174 1 255430 joepeck 2015-06-23 14:13:17 -0700 Created attachment 255430 [PATCH] Proposed Fix 1104175 2 255431 joepeck 2015-06-23 14:14:46 -0700 Created attachment 255431 [PATCH] Proposed Fix Improved ChangeLog. 1104197 3 255431 commit-queue 2015-06-23 15:09:54 -0700 Comment on attachment 255431 [PATCH] Proposed Fix Clearing flags on attachment: 255431 Committed r185886: <http://trac.webkit.org/changeset/185886> 1104199 4 commit-queue 2015-06-23 15:09:58 -0700 All reviewed patches have been landed. Closing bug. 255430 2015-06-23 14:13:17 -0700 2015-06-23 14:14:46 -0700 [PATCH] Proposed Fix lossless.patch text/plain 3267 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDczYTRjOGIuLjI2NWUxYmYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA2LTIzICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogU29tZSBi cmllZiBwcmV2aWV3cyBhcmUgaW5jb3JyZWN0bHkgdHJlYXRlZCBhcyBsb3NzbGVzcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2MjQ3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL09iamVjdFByZXZpZXdWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk9iamVj dFByZXZpZXdWaWV3LnByb3RvdHlwZS5fYXBwZW5kRW50cnlQcmV2aWV3cyk6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuT2JqZWN0UHJldmlld1ZpZXcucHJvdG90eXBlLl9hcHBlbmRQcm9wZXJ0eVBy ZXZpZXdzKToKKyAgICAgICAgV2hlbiB3ZSBoYXZlIGEgYnJpZWYgcHJldmlldyB3ZSBtYXkgbmVl ZCB0byBvdmVycmlkZSBsb3NzbGVzcyAvIG92ZXJmbG93CisgICAgICAgIGlmIHRoZSBwcmV2aWV3 IGl0c2VsZiBzaG93cyBsZXNzIHByb3BlcnRpZXMgdGhhbiB3ZXJlIGluIHRoZSBwcmV2aWV3Lgor CiAyMDE1LTA2LTE5ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAg ICAgICAgV2ViIEluc3BlY3RvcjogRHVwbGljYXRlIG9mIHN0eWxlIGF0dHJpYnV0ZSBpbiBydWxl cyBwYW5lbCBmb3Igc2hhZG93IGNvbnRlbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09iamVjdFByZXZpZXdWaWV3LmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0UHJldmlld1ZpZXcuanMKaW5k ZXggMjZjN2JkZS4uZjZhOTUwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0UHJldmlld1ZpZXcuanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0UHJldmlld1ZpZXcuanMKQEAgLTE0 OCw2ICsxNDgsNyBAQCBXZWJJbnNwZWN0b3IuT2JqZWN0UHJldmlld1ZpZXcgPSBjbGFzcyBPYmpl Y3RQcmV2aWV3VmlldyBleHRlbmRzIFdlYkluc3BlY3Rvci5PYgogICAgIF9hcHBlbmRFbnRyeVBy ZXZpZXdzKGVsZW1lbnQsIHByZXZpZXcpCiAgICAgewogICAgICAgICB2YXIgbG9zc2xlc3MgPSBw cmV2aWV3Lmxvc3NsZXNzICYmICFwcmV2aWV3LnByb3BlcnR5UHJldmlld3MubGVuZ3RoOworICAg ICAgICB2YXIgb3ZlcmZsb3cgPSBwcmV2aWV3Lm92ZXJmbG93OwogCiAgICAgICAgIHZhciBpc0l0 ZXJhdG9yID0gcHJldmlldy5zdWJ0eXBlID09PSAiaXRlcmF0b3IiOwogCkBAIC0xNzEsNyArMTcy LDEyIEBAIFdlYkluc3BlY3Rvci5PYmplY3RQcmV2aWV3VmlldyA9IGNsYXNzIE9iamVjdFByZXZp ZXdWaWV3IGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iCiAgICAgICAgICAgICAgICAgbG9zc2xlc3Mg PSBmYWxzZTsKICAgICAgICAgfQogCi0gICAgICAgIGlmIChwcmV2aWV3Lm92ZXJmbG93KQorICAg ICAgICBpZiAocHJldmlldy5jb2xsZWN0aW9uRW50cnlQcmV2aWV3cy5sZW5ndGggPiBsaW1pdCkg eworICAgICAgICAgICAgbG9zc2xlc3MgPSBmYWxzZTsKKyAgICAgICAgICAgIG92ZXJmbG93ID0g dHJ1ZTsKKyAgICAgICAgfQorCisgICAgICAgIGlmIChvdmVyZmxvdykKICAgICAgICAgICAgIGVs ZW1lbnQuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoIiwgXHUyMDI2IikpOwog ICAgICAgICBlbGVtZW50LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKGlzSXRl cmF0b3IgPyAiXSIgOiAifSIpKTsKIApAQCAtMTg4LDYgKzE5NCw5IEBAIFdlYkluc3BlY3Rvci5P YmplY3RQcmV2aWV3VmlldyA9IGNsYXNzIE9iamVjdFByZXZpZXdWaWV3IGV4dGVuZHMgV2ViSW5z cGVjdG9yLk9iCiAgICAgICAgIGlmIChwcmV2aWV3LnN1YnR5cGUgPT09ICJkYXRlIikKICAgICAg ICAgICAgIHJldHVybiAhcHJldmlldy5wcm9wZXJ0eVByZXZpZXdzLmxlbmd0aDsKIAorICAgICAg ICB2YXIgbG9zc2xlc3MgPSBwcmV2aWV3Lmxvc3NsZXNzOworICAgICAgICB2YXIgb3ZlcmZsb3cg PSBwcmV2aWV3Lm92ZXJmbG93OworCiAgICAgICAgIC8vIEZJWE1FOiBBcnJheSBwcmV2aWV3cyBz aG91bGQgaGF2ZSBiZXR0ZXIgc3BhcnNlIHN1cHBvcnQ6ICh1bmRlZmluZWQgw5cgMTApLgogICAg ICAgICB2YXIgaXNBcnJheSA9IHByZXZpZXcuc3VidHlwZSA9PT0gImFycmF5IjsKIApAQCAtMjI0 LDEyICsyMzMsMTYgQEAgV2ViSW5zcGVjdG9yLk9iamVjdFByZXZpZXdWaWV3ID0gY2xhc3MgT2Jq ZWN0UHJldmlld1ZpZXcgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2IKICAgICAgICAgICAgICAgICBl bGVtZW50LmFwcGVuZENoaWxkKFdlYkluc3BlY3Rvci5Gb3JtYXR0ZWRWYWx1ZS5jcmVhdGVFbGVt ZW50Rm9yUHJvcGVydHlQcmV2aWV3KHByb3BlcnR5KSk7CiAgICAgICAgIH0KIAotICAgICAgICBp ZiAocHJldmlldy5vdmVyZmxvdykKLSAgICAgICAgICAgIGVsZW1lbnQuYXBwZW5kQ2hpbGQoZG9j dW1lbnQuY3JlYXRlVGV4dE5vZGUoIiwgXHUyMDI2IikpOworICAgICAgICBpZiAobnVtYmVyQWRk ZWQgPT09IGxpbWl0ICYmIHByZXZpZXcucHJvcGVydHlQcmV2aWV3cy5sZW5ndGggPiBsaW1pdCkg eworICAgICAgICAgICAgbG9zc2xlc3MgPSBmYWxzZTsKKyAgICAgICAgICAgIG92ZXJmbG93ID0g dHJ1ZTsKKyAgICAgICAgfQogCisgICAgICAgIGlmIChvdmVyZmxvdykKKyAgICAgICAgICAgIGVs ZW1lbnQuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoIiwgXHUyMDI2IikpOwog ICAgICAgICBlbGVtZW50LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKGlzQXJy YXkgPyAiXSIgOiAifSIpKTsKIAotICAgICAgICByZXR1cm4gcHJldmlldy5sb3NzbGVzczsKKyAg ICAgICAgcmV0dXJuIGxvc3NsZXNzOwogICAgIH0KIAogICAgIF9hcHBlbmRWYWx1ZVByZXZpZXco ZWxlbWVudCwgcHJldmlldykK 255431 2015-06-23 14:14:46 -0700 2015-06-23 15:09:54 -0700 [PATCH] Proposed Fix better2.patch text/plain 3272 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDczYTRjOGIuLmZlNTQ4MGIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA2LTIzICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogU29tZSBi cmllZiBwcmV2aWV3cyBhcmUgaW5jb3JyZWN0bHkgdHJlYXRlZCBhcyBsb3NzbGVzcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2MjQ3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL09iamVjdFByZXZpZXdWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk9iamVj dFByZXZpZXdWaWV3LnByb3RvdHlwZS5fYXBwZW5kRW50cnlQcmV2aWV3cyk6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuT2JqZWN0UHJldmlld1ZpZXcucHJvdG90eXBlLl9hcHBlbmRQcm9wZXJ0eVBy ZXZpZXdzKToKKyAgICAgICAgV2hlbiB3ZSBoYXZlIGEgYnJpZWYgcHJldmlldyB3ZSBtYXkgbmVl ZCB0byBvdmVycmlkZSBsb3NzbGVzcyAvIG92ZXJmbG93CisgICAgICAgIGlmIHRoZSBwcmV2aWV3 IHZpZXcgaXRzZWxmIHNob3dzIGxlc3MgcHJvcGVydGllcyB0aGFuIHdlcmUgaW4gdGhlIHByZXZp ZXcuCisKIDIwMTUtMDYtMTkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4K IAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBEdXBsaWNhdGUgb2Ygc3R5bGUgYXR0cmlidXRlIGlu IHJ1bGVzIHBhbmVsIGZvciBzaGFkb3cgY29udGVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0UHJldmlld1ZpZXcuanMgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RQcmV2aWV3Vmlldy5q cwppbmRleCAyNmM3YmRlLi5mNmE5NTA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RQcmV2aWV3Vmlldy5qcworKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RQcmV2aWV3Vmlldy5qcwpA QCAtMTQ4LDYgKzE0OCw3IEBAIFdlYkluc3BlY3Rvci5PYmplY3RQcmV2aWV3VmlldyA9IGNsYXNz IE9iamVjdFByZXZpZXdWaWV3IGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iCiAgICAgX2FwcGVuZEVu dHJ5UHJldmlld3MoZWxlbWVudCwgcHJldmlldykKICAgICB7CiAgICAgICAgIHZhciBsb3NzbGVz cyA9IHByZXZpZXcubG9zc2xlc3MgJiYgIXByZXZpZXcucHJvcGVydHlQcmV2aWV3cy5sZW5ndGg7 CisgICAgICAgIHZhciBvdmVyZmxvdyA9IHByZXZpZXcub3ZlcmZsb3c7CiAKICAgICAgICAgdmFy IGlzSXRlcmF0b3IgPSBwcmV2aWV3LnN1YnR5cGUgPT09ICJpdGVyYXRvciI7CiAKQEAgLTE3MSw3 ICsxNzIsMTIgQEAgV2ViSW5zcGVjdG9yLk9iamVjdFByZXZpZXdWaWV3ID0gY2xhc3MgT2JqZWN0 UHJldmlld1ZpZXcgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2IKICAgICAgICAgICAgICAgICBsb3Nz bGVzcyA9IGZhbHNlOwogICAgICAgICB9CiAKLSAgICAgICAgaWYgKHByZXZpZXcub3ZlcmZsb3cp CisgICAgICAgIGlmIChwcmV2aWV3LmNvbGxlY3Rpb25FbnRyeVByZXZpZXdzLmxlbmd0aCA+IGxp bWl0KSB7CisgICAgICAgICAgICBsb3NzbGVzcyA9IGZhbHNlOworICAgICAgICAgICAgb3ZlcmZs b3cgPSB0cnVlOworICAgICAgICB9CisKKyAgICAgICAgaWYgKG92ZXJmbG93KQogICAgICAgICAg ICAgZWxlbWVudC5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgiLCBcdTIwMjYi KSk7CiAgICAgICAgIGVsZW1lbnQuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUo aXNJdGVyYXRvciA/ICJdIiA6ICJ9IikpOwogCkBAIC0xODgsNiArMTk0LDkgQEAgV2ViSW5zcGVj dG9yLk9iamVjdFByZXZpZXdWaWV3ID0gY2xhc3MgT2JqZWN0UHJldmlld1ZpZXcgZXh0ZW5kcyBX ZWJJbnNwZWN0b3IuT2IKICAgICAgICAgaWYgKHByZXZpZXcuc3VidHlwZSA9PT0gImRhdGUiKQog ICAgICAgICAgICAgcmV0dXJuICFwcmV2aWV3LnByb3BlcnR5UHJldmlld3MubGVuZ3RoOwogCisg ICAgICAgIHZhciBsb3NzbGVzcyA9IHByZXZpZXcubG9zc2xlc3M7CisgICAgICAgIHZhciBvdmVy ZmxvdyA9IHByZXZpZXcub3ZlcmZsb3c7CisKICAgICAgICAgLy8gRklYTUU6IEFycmF5IHByZXZp ZXdzIHNob3VsZCBoYXZlIGJldHRlciBzcGFyc2Ugc3VwcG9ydDogKHVuZGVmaW5lZCDDlyAxMCku CiAgICAgICAgIHZhciBpc0FycmF5ID0gcHJldmlldy5zdWJ0eXBlID09PSAiYXJyYXkiOwogCkBA IC0yMjQsMTIgKzIzMywxNiBAQCBXZWJJbnNwZWN0b3IuT2JqZWN0UHJldmlld1ZpZXcgPSBjbGFz cyBPYmplY3RQcmV2aWV3VmlldyBleHRlbmRzIFdlYkluc3BlY3Rvci5PYgogICAgICAgICAgICAg ICAgIGVsZW1lbnQuYXBwZW5kQ2hpbGQoV2ViSW5zcGVjdG9yLkZvcm1hdHRlZFZhbHVlLmNyZWF0 ZUVsZW1lbnRGb3JQcm9wZXJ0eVByZXZpZXcocHJvcGVydHkpKTsKICAgICAgICAgfQogCi0gICAg ICAgIGlmIChwcmV2aWV3Lm92ZXJmbG93KQotICAgICAgICAgICAgZWxlbWVudC5hcHBlbmRDaGls ZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgiLCBcdTIwMjYiKSk7CisgICAgICAgIGlmIChudW1i ZXJBZGRlZCA9PT0gbGltaXQgJiYgcHJldmlldy5wcm9wZXJ0eVByZXZpZXdzLmxlbmd0aCA+IGxp bWl0KSB7CisgICAgICAgICAgICBsb3NzbGVzcyA9IGZhbHNlOworICAgICAgICAgICAgb3ZlcmZs b3cgPSB0cnVlOworICAgICAgICB9CiAKKyAgICAgICAgaWYgKG92ZXJmbG93KQorICAgICAgICAg ICAgZWxlbWVudC5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgiLCBcdTIwMjYi KSk7CiAgICAgICAgIGVsZW1lbnQuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUo aXNBcnJheSA/ICJdIiA6ICJ9IikpOwogCi0gICAgICAgIHJldHVybiBwcmV2aWV3Lmxvc3NsZXNz OworICAgICAgICByZXR1cm4gbG9zc2xlc3M7CiAgICAgfQogCiAgICAgX2FwcGVuZFZhbHVlUHJl dmlldyhlbGVtZW50LCBwcmV2aWV3KQo=