146220 2015-06-22 18:01:17 -0700 [cssjit] Disable compiling scrollbar pseudoclass selectors 2015-06-22 18:31:19 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen simon.fraser oldest_to_newest 1103970 0 achristensen 2015-06-22 18:01:17 -0700 Selectors like this don't work correctly in the css jit body :not(.example_id):hover::-webkit-scrollbar-thumb:horizontal Let's just not compile them until this is fixed. 1103972 1 achristensen 2015-06-22 18:03:17 -0700 This will be fixed in https://bugs.webkit.org/show_bug.cgi?id=146221 1103974 2 255382 achristensen 2015-06-22 18:04:37 -0700 Created attachment 255382 Patch 1103976 3 255382 benjamin 2015-06-22 18:06:59 -0700 Comment on attachment 255382 Patch Ok 1103979 4 achristensen 2015-06-22 18:10:16 -0700 http://trac.webkit.org/changeset/185854 1103987 5 simon.fraser 2015-06-22 18:19:36 -0700 Why doesn't the changelog explain why you disabled them? 1103989 6 achristensen 2015-06-22 18:31:19 -0700 I figured that information would be in bugzilla. Maybe I should put more info in the ChangeLogs. This patch makes it use the correct non-compiled CSS selector interpreter with scrollbar pseudo classes instead of the css jit, which behaves incorrectly with :not and scrollbar pseudo classes. It is a slight performance hit when scrollbars are used, which is not very often. 255382 2015-06-22 18:04:37 -0700 2015-06-22 18:06:59 -0700 Patch bug-146220-20150622180355.patch text/plain 1605 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTg1MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA2LTIyICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW2Nzc2ppdF0g RGlzYWJsZSBjb21waWxpbmcgc2Nyb2xsYmFyIHBzZXVkb2NsYXNzIHNlbGVjdG9ycworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2MjIwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjc3NqaXQvU2VsZWN0 b3JDb21waWxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTZWxlY3RvckNvbXBpbGVyOjphZGRT Y3JvbGxiYXJQc2V1ZG9DbGFzc1R5cGUpOgorICAgICAgICBEb24ndCBjb21waWxlIHNlbGVjdG9y cyB3aXRoIHNjcm9sbGJhciBwc2V1ZG9jbGFzc2VzLgorCiAyMDE1LTA2LTIyICBTaW1vbiBGcmFz ZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIC13ZWJraXQtY2xpcC1wYXRo IGNsaXBzIGluY29ycmVjdGx5IGlmIHRoZSBlbGVtZW50IGJvdW5kcyBnbyBiZXlvbmQgdGhlIHRv cCBlZGdlIG9mIHRoZSBwYWdlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jc3NqaXQvU2VsZWN0b3JD b21waWxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3Nzaml0L1NlbGVjdG9y Q29tcGlsZXIuY3BwCShyZXZpc2lvbiAxODU4NDEpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3NqaXQv U2VsZWN0b3JDb21waWxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQzNSw2ICs0MzUsMTEgQEAg RnVuY3Rpb25UeXBlIFNlbGVjdG9yRnJhZ21lbnQ6OmFwcGVuZFVubwogCiBzdGF0aWMgaW5saW5l IEZ1bmN0aW9uVHlwZSBhZGRTY3JvbGxiYXJQc2V1ZG9DbGFzc1R5cGUoY29uc3QgQ1NTU2VsZWN0 b3ImIHNlbGVjdG9yLCBTZWxlY3RvckZyYWdtZW50JiBmcmFnbWVudCkKIHsKKyAgICAvLyBGSVhN RTogc2Nyb2xsYmFyIHBzZXVkb2NsYXNzIGludGVyYWN0aW9uIHdpdGggOm5vdCBkb2Vzbid0IGJl aGF2ZSBjb3JyZWN0bHkuCisgICAgLy8gQ29tcGlsZSB0aGVtIHdoZW4gdGhleSBhcmUgZml4ZWQg YW5kIHRlc3RlZC4KKyAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQ2MjIxCisgICAgcmV0dXJuIEZ1bmN0aW9uVHlwZTo6Q2Fubm90Q29tcGlsZTsKKyAgICAK ICAgICBzd2l0Y2ggKHNlbGVjdG9yLnBzZXVkb0NsYXNzVHlwZSgpKSB7CiAgICAgY2FzZSBDU1NT ZWxlY3Rvcjo6UHNldWRvQ2xhc3NXaW5kb3dJbmFjdGl2ZToKICAgICAgICAgZnJhZ21lbnQudW5v cHRpbWl6ZWRQc2V1ZG9DbGFzc2VzLmFwcGVuZChKU0M6OkZ1bmN0aW9uUHRyKGlzV2luZG93SW5h Y3RpdmUpKTsK