146216 2015-06-22 14:40:13 -0700 Get rid of the Windows specific BinarySemaphore implementation 2015-06-22 15:08:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin cmarcelo commit-queue oldest_to_newest 1103927 0 andersca 2015-06-22 14:40:13 -0700 Get rid of the Windows specific BinarySemaphore implementation 1103930 1 255372 andersca 2015-06-22 14:41:22 -0700 Created attachment 255372 Patch 1103934 2 255372 kling 2015-06-22 14:45:33 -0700 Comment on attachment 255372 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255372&action=review > Source/WTF/ChangeLog:9 > + The fact that the Windows implementation uses a HEVENT internally was only useful > + to the Windows port of WebKit2; we can get rid of it now. I'll take your word for it. 1103942 3 andersca 2015-06-22 15:08:16 -0700 Committed r185847: <http://trac.webkit.org/changeset/185847> 255372 2015-06-22 14:41:22 -0700 2015-06-22 14:45:33 -0700 Patch bug-146216-20150622144040.patch text/plain 6151 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1ODQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGExZTg1ZWI0YzM4NGY0NTFlMmU1Njhm YzExNTI3MGZhYmI3N2YxZjQuLmE5M2JlZjk2NWFmZjJiOGZiNDAyNGE3MzdhYjc3ODMwNjVlODcw NzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTUtMDYtMjIgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBHZXQgcmlkIG9mIHRoZSBXaW5kb3dzIHNwZWNp ZmljIEJpbmFyeVNlbWFwaG9yZSBpbXBsZW1lbnRhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2MjE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGZhY3QgdGhhdCB0aGUgV2luZG93cyBpbXBs ZW1lbnRhdGlvbiB1c2VzIGEgSEVWRU5UIGludGVybmFsbHkgd2FzIG9ubHkgdXNlZnVsCisgICAg ICAgIHRvIHRoZSBXaW5kb3dzIHBvcnQgb2YgV2ViS2l0Mjsgd2UgY2FuIGdldCByaWQgb2YgaXQg bm93LgorCisgICAgICAgICogV1RGLnZjeHByb2ovV1RGLnZjeHByb2o6CisgICAgICAgICogV1RG LnZjeHByb2ovV1RGLnZjeHByb2ouZmlsdGVyczoKKyAgICAgICAgKiB3dGYvdGhyZWFkcy9CaW5h cnlTZW1hcGhvcmUuaDoKKyAgICAgICAgKFdURjo6QmluYXJ5U2VtYXBob3JlOjpldmVudCk6IERl bGV0ZWQuCisgICAgICAgICogd3RmL3RocmVhZHMvd2luL0JpbmFyeVNlbWFwaG9yZVdpbi5jcHA6 IFJlbW92ZWQuCisgICAgICAgIChXVEY6OkJpbmFyeVNlbWFwaG9yZTo6QmluYXJ5U2VtYXBob3Jl KTogRGVsZXRlZC4KKyAgICAgICAgKFdURjo6QmluYXJ5U2VtYXBob3JlOjp+QmluYXJ5U2VtYXBo b3JlKTogRGVsZXRlZC4KKyAgICAgICAgKFdURjo6QmluYXJ5U2VtYXBob3JlOjpzaWduYWwpOiBE ZWxldGVkLgorICAgICAgICAoV1RGOjpCaW5hcnlTZW1hcGhvcmU6OndhaXQpOiBEZWxldGVkLgor CiAyMDE1LTA2LTIxICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4K IAogICAgICAgICBQYWdlIGxvYWQgcGVyZm9ybWFuY2UgcmVncmVzc2lvbiBkdWUgdG8gYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU1NDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYv V1RGLnZjeHByb2ovV1RGLnZjeHByb2ogYi9Tb3VyY2UvV1RGL1dURi52Y3hwcm9qL1dURi52Y3hw cm9qCmluZGV4IDFmNmY5MGUxOWExZTExYzE1MGY4YzA1NTc2ODNiNWJhNjFlOGRlZmUuLjVhMmQy NTMzMzM4NGY1NzgzYzNmZTgwZjJkZDg2MWVmNDczYzExZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X VEYvV1RGLnZjeHByb2ovV1RGLnZjeHByb2oKKysrIGIvU291cmNlL1dURi9XVEYudmN4cHJvai9X VEYudmN4cHJvagpAQCAtMTQ1LDcgKzE0NSw2IEBACiAgICAgPENsQ29tcGlsZSBJbmNsdWRlPSIu Llx3dGZcVGhyZWFkaW5nV2luLmNwcCIgLz4KICAgICA8Q2xDb21waWxlIEluY2x1ZGU9Ii4uXHd0 Zlx0aHJlYWRzcGVjaWZpY1dpbi5jcHAiIC8+CiAgICAgPENsQ29tcGlsZSBJbmNsdWRlPSIuLlx3 dGZcdGhyZWFkc1xCaW5hcnlTZW1hcGhvcmUuY3BwIiAvPgotICAgIDxDbENvbXBpbGUgSW5jbHVk ZT0iLi5cd3RmXHRocmVhZHNcd2luXEJpbmFyeVNlbWFwaG9yZVdpbi5jcHAiIC8+CiAgICAgPENs Q29tcGlsZSBJbmNsdWRlPSIuLlx3dGZcdW5pY29kZVxpY3VcQ29sbGF0b3JJQ1UuY3BwIiAvPgog ICAgIDxDbENvbXBpbGUgSW5jbHVkZT0iLi5cd3RmXHVuaWNvZGVcVVRGOC5jcHAiIC8+CiAgICAg PENsQ29tcGlsZSBJbmNsdWRlPSIuLlx3dGZcd2luXE1haW5UaHJlYWRXaW4uY3BwIiAvPgpkaWZm IC0tZ2l0IGEvU291cmNlL1dURi9XVEYudmN4cHJvai9XVEYudmN4cHJvai5maWx0ZXJzIGIvU291 cmNlL1dURi9XVEYudmN4cHJvai9XVEYudmN4cHJvai5maWx0ZXJzCmluZGV4IGMyMWIwY2NmYTE1 NTM3YWVhZDQ4NDNkYTljZmY2M2Y2NmEzNDA2YzYuLmZiN2U3YzQ5YTk5OTk2ZDUyMjg2NDU3YWIz MjliMTg4ZjdlMmM1ZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvV1RGLnZjeHByb2ovV1RGLnZj eHByb2ouZmlsdGVycworKysgYi9Tb3VyY2UvV1RGL1dURi52Y3hwcm9qL1dURi52Y3hwcm9qLmZp bHRlcnMKQEAgLTEwMiw5ICsxMDIsNiBAQAogICAgIDxDbENvbXBpbGUgSW5jbHVkZT0iLi5cd3Rm XHdpblxNYWluVGhyZWFkV2luLmNwcCI+CiAgICAgICA8RmlsdGVyPnd0Zlx3aW48L0ZpbHRlcj4K ICAgICA8L0NsQ29tcGlsZT4KLSAgICA8Q2xDb21waWxlIEluY2x1ZGU9Ii4uXHd0Zlx0aHJlYWRz XHdpblxCaW5hcnlTZW1hcGhvcmVXaW4uY3BwIj4KLSAgICAgIDxGaWx0ZXI+dGhyZWFkc1x3aW48 L0ZpbHRlcj4KLSAgICA8L0NsQ29tcGlsZT4KICAgICA8Q2xDb21waWxlIEluY2x1ZGU9Ii4uXHd0 Zlx0aHJlYWRzXEJpbmFyeVNlbWFwaG9yZS5jcHAiPgogICAgICAgPEZpbHRlcj50aHJlYWRzPC9G aWx0ZXI+CiAgICAgPC9DbENvbXBpbGU+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90aHJl YWRzL0JpbmFyeVNlbWFwaG9yZS5oIGIvU291cmNlL1dURi93dGYvdGhyZWFkcy9CaW5hcnlTZW1h cGhvcmUuaAppbmRleCBjYWUxMDIzMWI1YjVhZmViOWViNTVlYTc3YzZmYWE0MmNlNjEyNTJmLi5i NWRiNWQ3YWQzN2EzYjcxMTAwMzdmNzI5YWE5NzE5ZTZjZDJhMzEyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV1RGL3d0Zi90aHJlYWRzL0JpbmFyeVNlbWFwaG9yZS5oCisrKyBiL1NvdXJjZS9XVEYvd3Rm L3RocmVhZHMvQmluYXJ5U2VtYXBob3JlLmgKQEAgLTQxLDE5ICs0MSwxMSBAQCBwdWJsaWM6CiAg ICAgV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgc2lnbmFsKCk7CiAgICAgV1RGX0VYUE9SVF9QUklW QVRFIGJvb2wgd2FpdChkb3VibGUgYWJzb2x1dGVUaW1lKTsKIAotI2lmIFBMQVRGT1JNKFdJTikK LSAgICBIQU5ETEUgZXZlbnQoKSBjb25zdCB7IHJldHVybiBtX2V2ZW50OyB9Ci0jZW5kaWYKLQog cHJpdmF0ZToKLSNpZiBQTEFURk9STShXSU4pCi0gICAgSEFORExFIG1fZXZlbnQ7Ci0jZWxzZQog ICAgIGJvb2wgbV9pc1NldDsKIAogICAgIE11dGV4IG1fbXV0ZXg7CiAgICAgVGhyZWFkQ29uZGl0 aW9uIG1fY29uZGl0aW9uOwotI2VuZGlmCiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXVEYKZGlmZiAt LWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RocmVhZHMvd2luL0JpbmFyeVNlbWFwaG9yZVdpbi5jcHAg Yi9Tb3VyY2UvV1RGL3d0Zi90aHJlYWRzL3dpbi9CaW5hcnlTZW1hcGhvcmVXaW4uY3BwCmRlbGV0 ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwZGFkMWFjNWNmMTg3MGE5MzY0YTk1OTU2YmM2MTQy MTE1MzNjMDgxLi4wMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwCi0tLSBh L1NvdXJjZS9XVEYvd3RmL3RocmVhZHMvd2luL0JpbmFyeVNlbWFwaG9yZVdpbi5jcHAKKysrIC9k ZXYvbnVsbApAQCAtMSw3NSArMCwwIEBACi0vKgotICogQ29weXJpZ2h0IChDKSAyMDExIEFwcGxl IEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KLSAqCi0gKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNl IGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKLSAqIG1vZGlmaWNh dGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9u cwotICogYXJlIG1ldDoKLSAqIDEuIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0 IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0Ci0gKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBj b25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCi0gKiAyLiBSZWRpc3RyaWJ1 dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAot ICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBk aXNjbGFpbWVyIGluIHRoZQotICogICAgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJp YWxzIHByb3ZpZGVkIHdpdGggdGhlIGRpc3RyaWJ1dGlvbi4KLSAqCi0gKiBUSElTIFNPRlRXQVJF IElTIFBST1ZJREVEIEJZIEFQUExFIElOQy4gQU5EIElUUyBDT05UUklCVVRPUlMgYGBBUyBJUycn Ci0gKiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJV VCBOT1QgTElNSVRFRCBUTywKLSAqIFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRB QklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIKLSAqIFBVUlBPU0UgQVJFIERJU0NM QUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIEFQUExFIElOQy4gT1IgSVRTIENPTlRSSUJVVE9SUwot ICogQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lB TCwgRVhFTVBMQVJZLCBPUgotICogQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJV VCBOT1QgTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YKLSAqIFNVQlNUSVRVVEUgR09PRFMgT1Ig U0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUwotICog SU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZIFRIRU9SWSBPRiBMSUFCSUxJ VFksIFdIRVRIRVIgSU4KLSAqIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUIChJ TkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpCi0gKiBBUklTSU5HIElOIEFOWSBXQVkg T1VUIE9GIFRIRSBVU0UgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GCi0gKiBU SEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCi0gKi8KLQotI2luY2x1ZGUgImNvbmZpZy5o IgotI2luY2x1ZGUgIkJpbmFyeVNlbWFwaG9yZS5oIgotCi1uYW1lc3BhY2UgV1RGIHsKLQotQmlu YXJ5U2VtYXBob3JlOjpCaW5hcnlTZW1hcGhvcmUoKQotICAgIDogbV9ldmVudCg6OkNyZWF0ZUV2 ZW50VygwLCBGQUxTRSwgRkFMU0UsIDApKQotewotfQotCi1CaW5hcnlTZW1hcGhvcmU6On5CaW5h cnlTZW1hcGhvcmUoKQotewotICAgIDo6Q2xvc2VIYW5kbGUobV9ldmVudCk7Ci19Ci0KLXZvaWQg QmluYXJ5U2VtYXBob3JlOjpzaWduYWwoKQotewotICAgIDo6U2V0RXZlbnQobV9ldmVudCk7Ci19 Ci0KLWJvb2wgQmluYXJ5U2VtYXBob3JlOjp3YWl0KGRvdWJsZSBhYnNvbHV0ZVRpbWUpCi17Ci0g ICAgRFdPUkQgaW50ZXJ2YWwgPSBhYnNvbHV0ZVRpbWVUb1dhaXRUaW1lb3V0SW50ZXJ2YWwoYWJz b2x1dGVUaW1lKTsKLSAgICBpZiAoIWludGVydmFsKSB7Ci0gICAgICAgIC8vIENvbnNpZGVyIHRo ZSB3YWl0IHRvIGhhdmUgdGltZWQgb3V0LCBldmVuIGlmIHRoZSBldmVudCBoYXMgYWxyZWFkeSBi ZWVuIHNpZ25hbGVkLCB0bwotICAgICAgICAvLyBtYXRjaCB0aGUgV1RGOjpUaHJlYWRDb25kaXRp b24gaW1wbGVtZW50YXRpb24uCi0gICAgICAgIHJldHVybiBmYWxzZTsKLSAgICB9Ci0KLSAgICBE V09SRCByZXN1bHQgPSA6OldhaXRGb3JTaW5nbGVPYmplY3QobV9ldmVudCwgaW50ZXJ2YWwpOwot ICAgIHN3aXRjaCAocmVzdWx0KSB7Ci0gICAgY2FzZSBXQUlUX09CSkVDVF8wOgotICAgICAgICAv LyBUaGUgZXZlbnQgd2FzIHNpZ25hbGVkLgotICAgICAgICByZXR1cm4gdHJ1ZTsKLQotICAgIGNh c2UgV0FJVF9USU1FT1VUOgotICAgICAgICAvLyBUaGUgd2FpdCB0aW1lZCBvdXQuCi0gICAgICAg IHJldHVybiBmYWxzZTsKLQotICAgIGNhc2UgV0FJVF9GQUlMRUQ6Ci0gICAgICAgIEFTU0VSVF9X SVRIX01FU1NBR0UoZmFsc2UsICI6OldhaXRGb3JTaW5nbGVPYmplY3QgZmFpbGVkIHdpdGggZXJy b3IgJWx1IiwgOjpHZXRMYXN0RXJyb3IoKSk7Ci0gICAgICAgIHJldHVybiBmYWxzZTsKLQotICAg IGRlZmF1bHQ6Ci0gICAgICAgIEFTU0VSVF9XSVRIX01FU1NBR0UoZmFsc2UsICI6OldhaXRGb3JT aW5nbGVPYmplY3QgcmV0dXJuZWQgdW5leHBlY3RlZCByZXN1bHQgJWx1IiwgcmVzdWx0KTsKLSAg ICAgICAgcmV0dXJuIGZhbHNlOwotICAgIH0KLX0KLQotfSAvLyBuYW1lc3BhY2UgV1RGCg==