146203 2015-06-22 05:29:13 -0700 [WinCairo] WebDownload::initWithRequest is not implemented. 2015-06-23 01:58:59 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham oldest_to_newest 1103815 0 peavo 2015-06-22 05:29:13 -0700 The method WebDownload::initWithRequest is not implemented on WinCairo. 1103817 1 255344 peavo 2015-06-22 05:45:13 -0700 Created attachment 255344 Patch 1103894 2 255344 achristensen 2015-06-22 12:29:03 -0700 Comment on attachment 255344 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255344&action=review Does this make it so we can finally download things from within WinLauncher? > Source/WebKit/win/WebDownloadCurl.cpp:186 > + // If destination is already set, we don't need to ask delegate. > + if (!m_destination.isEmpty()) > + return; Is this correct? What if the destination is already set but we want to change it? 1103916 3 255367 peavo 2015-06-22 14:21:14 -0700 Created attachment 255367 Patch 1103917 4 peavo 2015-06-22 14:24:26 -0700 (In reply to comment #2) > Thanks for reviewing :) > > Does this make it so we can finally download things from within WinLauncher? > Unfortunately, no. WinLauncher crashes for me when I try to download a link, but I don't think it would take much work to fix this crash and get downloading from WinLauncher to work. > > Source/WebKit/win/WebDownloadCurl.cpp:186 > > + // If destination is already set, we don't need to ask delegate. > > + if (!m_destination.isEmpty()) > > + return; > > Is this correct? What if the destination is already set but we want to > change it? Good point, I removed this in the latest patch. 1103923 5 255367 achristensen 2015-06-22 14:34:52 -0700 Comment on attachment 255367 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255367&action=review Let's fix that crash and get downloading working, then! > Source/WebKit/win/ChangeLog:12 > + (WebDownload::didReceiveResponse): Do not ask delegate for destination if already set. Remove this line. 1103924 6 255369 peavo 2015-06-22 14:37:56 -0700 Created attachment 255369 Patch 1103932 7 peavo 2015-06-22 14:44:00 -0700 (In reply to comment #5) > Comment on attachment 255367 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=255367&action=review > > Let's fix that crash and get downloading working, then! > I will try to debug the crash soon :) 1103933 8 255369 achristensen 2015-06-22 14:45:17 -0700 Comment on attachment 255369 Patch This looks good, but I don't think it should go in until we fix the crash that this makes possible. 1103937 9 peavo 2015-06-22 14:51:51 -0700 (In reply to comment #8) > Comment on attachment 255369 [details] > Patch > > This looks good, but I don't think it should go in until we fix the crash > that this makes possible. Thanks :) I believe WinLauncher crashes when downloading without this patch aswell. Is it OK if I commit this patch, and make a separate patch for the crash? 1103938 10 255369 achristensen 2015-06-22 14:52:42 -0700 Comment on attachment 255369 Patch Sure. 1104062 11 peavo 2015-06-23 01:58:59 -0700 Committed r185868: <http://trac.webkit.org/changeset/185868> 255344 2015-06-22 05:45:13 -0700 2015-06-22 14:21:07 -0700 Patch bug-146203-20150622144420.patch text/plain 1998 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTgyNCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA2LTIy ICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fp cm9dIFdlYkRvd25sb2FkOjppbml0V2l0aFJlcXVlc3QgaXMgbm90IGltcGxlbWVudGVkLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2MjAzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wbGVtZW50IG1l dGhvZCB0byBzdGFydCBkb3dubG9hZCBmcm9tIGEgSVdlYlVSTFJlcXVlc3Qgb2JqZWN0LgorCisg ICAgICAgICogV2ViRG93bmxvYWRDdXJsLmNwcDoKKyAgICAgICAgKFdlYkRvd25sb2FkOjppbml0 V2l0aFJlcXVlc3QpOiBJbXBsZW1lbnRlZC4KKyAgICAgICAgKFdlYkRvd25sb2FkOjpkaWRSZWNl aXZlUmVzcG9uc2UpOiBEbyBub3QgYXNrIGRlbGVnYXRlIGZvciBkZXN0aW5hdGlvbiBpZiBhbHJl YWR5IHNldC4KKwogMjAxNS0wNi0xOCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUu Y29tPgogCiAgICAgICAgIFJlbW92ZSBzaG91bGRJbnRlcnJ1cHRKYXZhU2NyaXB0CkluZGV4OiBT b3VyY2UvV2ViS2l0L3dpbi9XZWJEb3dubG9hZEN1cmwuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQvd2luL1dlYkRvd25sb2FkQ3VybC5jcHAJKHJldmlzaW9uIDE4NTgyMikKKysrIFNv dXJjZS9XZWJLaXQvd2luL1dlYkRvd25sb2FkQ3VybC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgx LDggKzgxLDE0IEBAIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgV2ViRG93bmxvYWQ6OmkKICAg ICAgICAgLyogW2luXSAqLyBJV2ViVVJMUmVxdWVzdCogcmVxdWVzdCwgCiAgICAgICAgIC8qIFtp bl0gKi8gSVdlYkRvd25sb2FkRGVsZWdhdGUqIGRlbGVnYXRlKQogewotICAgbm90SW1wbGVtZW50 ZWQoKTsKLSAgIHJldHVybiBFX0ZBSUw7CisgICAgQlN0cmluZyB1cmw7CisKKyAgICBpZiAoIVNV Q0NFRURFRChyZXF1ZXN0LT5VUkwoJnVybCkpKQorICAgICAgICByZXR1cm4gRV9GQUlMOworCisg ICAgaW5pdChVUkwoUGFyc2VkVVJMU3RyaW5nLCBTdHJpbmcodXJsKSksIGRlbGVnYXRlKTsKKwor ICAgIHJldHVybiBTX09LOwogfQogCiBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIFdlYkRvd25s b2FkOjppbml0VG9SZXN1bWVXaXRoQnVuZGxlKApAQCAtMTc1LDYgKzE4MSwxMCBAQCB2b2lkIFdl YkRvd25sb2FkOjpkaWRSZWNlaXZlUmVzcG9uc2UoKQogICAgICAgICBDT01QdHI8V2ViVVJMUmVz cG9uc2U+IHdlYlJlc3BvbnNlKEFkb3B0Q09NLCBXZWJVUkxSZXNwb25zZTo6Y3JlYXRlSW5zdGFu Y2UocmVzcG9uc2UpKTsKICAgICAgICAgbV9kZWxlZ2F0ZS0+ZGlkUmVjZWl2ZVJlc3BvbnNlKHRo aXMsIHdlYlJlc3BvbnNlLmdldCgpKTsKIAorICAgICAgICAvLyBJZiBkZXN0aW5hdGlvbiBpcyBh bHJlYWR5IHNldCwgd2UgZG9uJ3QgbmVlZCB0byBhc2sgZGVsZWdhdGUuCisgICAgICAgIGlmICgh bV9kZXN0aW5hdGlvbi5pc0VtcHR5KCkpCisgICAgICAgICAgICByZXR1cm47CisKICAgICAgICAg U3RyaW5nIHN1Z2dlc3RlZEZpbGVuYW1lID0gcmVzcG9uc2Uuc3VnZ2VzdGVkRmlsZW5hbWUoKTsK ICAgICAgICAgaWYgKHN1Z2dlc3RlZEZpbGVuYW1lLmlzRW1wdHkoKSkKICAgICAgICAgICAgIHN1 Z2dlc3RlZEZpbGVuYW1lID0gcGF0aEdldEZpbGVOYW1lKHJlc3BvbnNlLnVybCgpLnN0cmluZygp KTsK 255367 2015-06-22 14:21:14 -0700 2015-06-22 14:37:49 -0700 Patch bug-146203-20150622232021.patch text/plain 1454 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTgyNCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA2LTIy ICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fp cm9dIFdlYkRvd25sb2FkOjppbml0V2l0aFJlcXVlc3QgaXMgbm90IGltcGxlbWVudGVkLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2MjAzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wbGVtZW50IG1l dGhvZCB0byBzdGFydCBkb3dubG9hZCBmcm9tIGEgSVdlYlVSTFJlcXVlc3Qgb2JqZWN0LgorCisg ICAgICAgICogV2ViRG93bmxvYWRDdXJsLmNwcDoKKyAgICAgICAgKFdlYkRvd25sb2FkOjppbml0 V2l0aFJlcXVlc3QpOiBJbXBsZW1lbnRlZC4KKyAgICAgICAgKFdlYkRvd25sb2FkOjpkaWRSZWNl aXZlUmVzcG9uc2UpOiBEbyBub3QgYXNrIGRlbGVnYXRlIGZvciBkZXN0aW5hdGlvbiBpZiBhbHJl YWR5IHNldC4KKwogMjAxNS0wNi0xOCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUu Y29tPgogCiAgICAgICAgIFJlbW92ZSBzaG91bGRJbnRlcnJ1cHRKYXZhU2NyaXB0CkluZGV4OiBT b3VyY2UvV2ViS2l0L3dpbi9XZWJEb3dubG9hZEN1cmwuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQvd2luL1dlYkRvd25sb2FkQ3VybC5jcHAJKHJldmlzaW9uIDE4NTgyMikKKysrIFNv dXJjZS9XZWJLaXQvd2luL1dlYkRvd25sb2FkQ3VybC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgx LDggKzgxLDE0IEBAIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgV2ViRG93bmxvYWQ6OmkKICAg ICAgICAgLyogW2luXSAqLyBJV2ViVVJMUmVxdWVzdCogcmVxdWVzdCwgCiAgICAgICAgIC8qIFtp bl0gKi8gSVdlYkRvd25sb2FkRGVsZWdhdGUqIGRlbGVnYXRlKQogewotICAgbm90SW1wbGVtZW50 ZWQoKTsKLSAgIHJldHVybiBFX0ZBSUw7CisgICAgQlN0cmluZyB1cmw7CisKKyAgICBpZiAoIVNV Q0NFRURFRChyZXF1ZXN0LT5VUkwoJnVybCkpKQorICAgICAgICByZXR1cm4gRV9GQUlMOworCisg ICAgaW5pdChVUkwoUGFyc2VkVVJMU3RyaW5nLCBTdHJpbmcodXJsKSksIGRlbGVnYXRlKTsKKwor ICAgIHJldHVybiBTX09LOwogfQogCiBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIFdlYkRvd25s b2FkOjppbml0VG9SZXN1bWVXaXRoQnVuZGxlKAo= 255369 2015-06-22 14:37:56 -0700 2015-06-22 14:52:42 -0700 Patch bug-146203-20150622233703.patch text/plain 1358 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTgyNCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA2LTIy ICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fp cm9dIFdlYkRvd25sb2FkOjppbml0V2l0aFJlcXVlc3QgaXMgbm90IGltcGxlbWVudGVkLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2MjAzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wbGVtZW50IG1l dGhvZCB0byBzdGFydCBkb3dubG9hZCBmcm9tIGEgSVdlYlVSTFJlcXVlc3Qgb2JqZWN0LgorCisg ICAgICAgICogV2ViRG93bmxvYWRDdXJsLmNwcDoKKyAgICAgICAgKFdlYkRvd25sb2FkOjppbml0 V2l0aFJlcXVlc3QpOiBJbXBsZW1lbnRlZC4KKwogMjAxNS0wNi0xOCAgQW5kZXJzIENhcmxzc29u ICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBzaG91bGRJbnRlcnJ1cHRK YXZhU2NyaXB0CkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9XZWJEb3dubG9hZEN1cmwuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvd2luL1dlYkRvd25sb2FkQ3VybC5jcHAJKHJldmlz aW9uIDE4NTgyMikKKysrIFNvdXJjZS9XZWJLaXQvd2luL1dlYkRvd25sb2FkQ3VybC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTgxLDggKzgxLDE0IEBAIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUg V2ViRG93bmxvYWQ6OmkKICAgICAgICAgLyogW2luXSAqLyBJV2ViVVJMUmVxdWVzdCogcmVxdWVz dCwgCiAgICAgICAgIC8qIFtpbl0gKi8gSVdlYkRvd25sb2FkRGVsZWdhdGUqIGRlbGVnYXRlKQog ewotICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgIHJldHVybiBFX0ZBSUw7CisgICAgQlN0cmluZyB1 cmw7CisKKyAgICBpZiAoIVNVQ0NFRURFRChyZXF1ZXN0LT5VUkwoJnVybCkpKQorICAgICAgICBy ZXR1cm4gRV9GQUlMOworCisgICAgaW5pdChVUkwoUGFyc2VkVVJMU3RyaW5nLCBTdHJpbmcodXJs KSksIGRlbGVnYXRlKTsKKworICAgIHJldHVybiBTX09LOwogfQogCiBIUkVTVUxUIFNURE1FVEhP RENBTExUWVBFIFdlYkRvd25sb2FkOjppbml0VG9SZXN1bWVXaXRoQnVuZGxlKAo=