146202 2015-06-22 05:06:27 -0700 REGRESSION(r182303): [GTK] Context menu API is broken since r182303 2015-06-22 05:43:26 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned berto commit-queue csaavedra gustavo mcatanzaro mrobinson pnormand svillar oldest_to_newest 1103807 0 cgarcia 2015-06-22 05:06:27 -0700 And we didn't notice it because context menu API tests are skipped (see https://bugs.webkit.org/show_bug.cgi?id=117689). The problem is that ContextMenuclient API changed in r182303, but we didn't notice it either, and the default handler for getContextMenuFromProposedMenu was executed. An override keyword would have caught this. 1103811 1 255343 cgarcia 2015-06-22 05:08:44 -0700 Created attachment 255343 Patch 1103814 2 commit-queue 2015-06-22 05:10:46 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1103816 3 cgarcia 2015-06-22 05:43:26 -0700 Committed r185825: <http://trac.webkit.org/changeset/185825> 255343 2015-06-22 05:08:44 -0700 2015-06-22 05:14:34 -0700 Patch wk2-context-menu-broken.diff text/plain 2795 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlZmYzODgwLi5jMjA2ZDM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTUtMDYtMjIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjE4MjMwMyk6IFtHVEtdIENvbnRleHQgbWVudSBBUEkg aXMgYnJva2VuIHNpbmNlIHIxODIzMDMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0NjIwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoZSBwcm9ibGVtIGlzIHRoYXQgQ29udGV4dE1lbnVjbGllbnQgQVBJ IGNoYW5nZWQgaW4gcjE4MjMwMywgYnV0CisgICAgICAgIHdlIGRpZG4ndCBub3RpY2UgaXQgZWl0 aGVyLCBhbmQgdGhlIGRlZmF1bHQgaGFuZGxlciBmb3IKKyAgICAgICAgZ2V0Q29udGV4dE1lbnVG cm9tUHJvcG9zZWRNZW51IHdhcyBleGVjdXRlZC4gQW4gb3ZlcnJpZGUga2V5d29yZAorICAgICAg ICB3b3VsZCBoYXZlIGNhdWdodCB0aGlzLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsv V2ViS2l0Q29udGV4dE1lbnVDbGllbnQuY3BwOiBCdWlsZCBhIFZlY3RvciBvZgorICAgICAgICBX ZWJDb250ZXh0TWVudUl0ZW1EYXRhIGFzIGV4cGVjdGVkIGJ5IG91ciBBUEksIGFuZCBhZGQgYWRk CisgICAgICAgIG92ZXJyaWRlIGtleXdvcmQgdG8gZW5zdXJlIHRoaXMgZG9lc24ndCBoYXBwZW4g YWdhaW4uCisKIDIwMTUtMDYtMTYgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBw bGUuY29tPgogCiAgICAgICAgIFBhZ2UgbG9hZCBwZXJmb3JtYW5jZSByZWdyZXNzaW9uIGR1ZSB0 byBidWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTU0MgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0Q29udGV4dE1lbnVDbGllbnQuY3Bw IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0Q29udGV4dE1lbnVDbGll bnQuY3BwCmluZGV4IGFiZmE0NjkuLjY5YzI2MjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdENvbnRleHRNZW51Q2xpZW50LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRDb250ZXh0TWVudUNsaWVudC5jcHAK QEAgLTIxLDYgKzIxLDcgQEAKICNpbmNsdWRlICJXZWJLaXRDb250ZXh0TWVudUNsaWVudC5oIgog CiAjaW5jbHVkZSAiQVBJQ29udGV4dE1lbnVDbGllbnQuaCIKKyNpbmNsdWRlICJXZWJDb250ZXh0 TWVudUl0ZW0uaCIKICNpbmNsdWRlICJXZWJLaXRXZWJWaWV3QmFzZVByaXZhdGUuaCIKICNpbmNs dWRlICJXZWJLaXRXZWJWaWV3UHJpdmF0ZS5oIgogCkBAIC0zNCw3ICszNSw3IEBAIHB1YmxpYzoK ICAgICB9CiAKIHByaXZhdGU6Ci0gICAgYm9vbCBnZXRDb250ZXh0TWVudUZyb21Qcm9wb3NlZE1l bnUoV2ViUGFnZVByb3h5JiwgY29uc3QgVmVjdG9yPFdlYkNvbnRleHRNZW51SXRlbURhdGE+JiBw cm9wb3NlZE1lbnUsIFZlY3RvcjxXZWJDb250ZXh0TWVudUl0ZW1EYXRhPiYsIGNvbnN0IFdlYkhp dFRlc3RSZXN1bHQ6OkRhdGEmIGhpdFRlc3RSZXN1bHREYXRhLCBBUEk6Ok9iamVjdCogdXNlckRh dGEpCisgICAgYm9vbCBnZXRDb250ZXh0TWVudUZyb21Qcm9wb3NlZE1lbnUoV2ViUGFnZVByb3h5 JiwgY29uc3QgVmVjdG9yPFJlZlB0cjxXZWJDb250ZXh0TWVudUl0ZW0+PiYgcHJvcG9zZWRNZW51 LCBWZWN0b3I8UmVmUHRyPFdlYkNvbnRleHRNZW51SXRlbT4+JiwgY29uc3QgV2ViSGl0VGVzdFJl c3VsdDo6RGF0YSYgaGl0VGVzdFJlc3VsdERhdGEsIEFQSTo6T2JqZWN0KiB1c2VyRGF0YSkgb3Zl cnJpZGUKICAgICB7CiAgICAgICAgIEdSZWZQdHI8R1ZhcmlhbnQ+IHZhcmlhbnQ7CiAgICAgICAg IGlmICh1c2VyRGF0YSkgewpAQCAtNDIsNyArNDMsMTIgQEAgcHJpdmF0ZToKICAgICAgICAgICAg IENTdHJpbmcgdXNlckRhdGFTdHJpbmcgPSBzdGF0aWNfY2FzdDxBUEk6OlN0cmluZyo+KHVzZXJE YXRhKS0+c3RyaW5nKCkudXRmOCgpOwogICAgICAgICAgICAgdmFyaWFudCA9IGFkb3B0R1JlZihn X3ZhcmlhbnRfcGFyc2UobnVsbHB0ciwgdXNlckRhdGFTdHJpbmcuZGF0YSgpLCB1c2VyRGF0YVN0 cmluZy5kYXRhKCkgKyB1c2VyRGF0YVN0cmluZy5sZW5ndGgoKSwgbnVsbHB0ciwgbnVsbHB0cikp OwogICAgICAgICB9Ci0gICAgICAgIHdlYmtpdFdlYlZpZXdQb3B1bGF0ZUNvbnRleHRNZW51KG1f d2ViVmlldywgcHJvcG9zZWRNZW51LCBoaXRUZXN0UmVzdWx0RGF0YSwgdmFyaWFudC5nZXQoKSk7 CisKKyAgICAgICAgVmVjdG9yPFdlYkNvbnRleHRNZW51SXRlbURhdGE+IG1lbnVJdGVtczsKKyAg ICAgICAgbWVudUl0ZW1zLnJlc2VydmVJbml0aWFsQ2FwYWNpdHkocHJvcG9zZWRNZW51LnNpemUo KSk7CisgICAgICAgIGZvciAoYXV0byYgaXRlbSA6IHByb3Bvc2VkTWVudSkKKyAgICAgICAgICAg IG1lbnVJdGVtcy51bmNoZWNrZWRBcHBlbmQoKml0ZW0tPmRhdGEoKSk7CisgICAgICAgIHdlYmtp dFdlYlZpZXdQb3B1bGF0ZUNvbnRleHRNZW51KG1fd2ViVmlldywgbWVudUl0ZW1zLCBoaXRUZXN0 UmVzdWx0RGF0YSwgdmFyaWFudC5nZXQoKSk7CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0K IAo=