146197 2015-06-21 22:40:50 -0700 [Xcode] Fold the WebKit2SandboxProfiles-IOSOverride target into the Sandbox Profiles target 2015-06-22 21:11:45 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz andersca dbates sam oldest_to_newest 1103767 0 mitz 2015-06-21 22:40:50 -0700 We don’t need to maintain a separate build target for installing the sandbox profiles into the override location. 1103769 1 255338 mitz 2015-06-21 22:45:28 -0700 Created attachment 255338 Part 1: prepare the Sandbox Profiles target 1103847 2 255338 dbates 2015-06-22 09:28:57 -0700 Comment on attachment 255338 Part 1: prepare the Sandbox Profiles target View in context: https://bugs.webkit.org/attachment.cgi?id=255338&action=review > Source/WebKit2/Configurations/SandboxProfiles.xcconfig:1 > +INSTALL_PATH = $(INSTALL_PATH_ENGINEERING_BUILD_$(WK_INSTALL_OVERRIDE_SANDBOX_PROFILES)); I take it you meant to write "INSTALL_PATH_WK_INSTALL_OVERRIDE_SANDBOX_PROFILES_" instead of "INSTALL_PATH_ENGINEERING_BUILD_". 1103848 3 mitz 2015-06-22 09:30:18 -0700 (In reply to comment #2) > Comment on attachment 255338 [details] > Part 1: prepare the Sandbox Profiles target > > View in context: > https://bugs.webkit.org/attachment.cgi?id=255338&action=review > > > Source/WebKit2/Configurations/SandboxProfiles.xcconfig:1 > > +INSTALL_PATH = $(INSTALL_PATH_ENGINEERING_BUILD_$(WK_INSTALL_OVERRIDE_SANDBOX_PROFILES)); > > I take it you meant to write > "INSTALL_PATH_WK_INSTALL_OVERRIDE_SANDBOX_PROFILES_" instead of > "INSTALL_PATH_ENGINEERING_BUILD_". Good catch! Thank you. 1103861 4 mitz 2015-06-22 10:05:31 -0700 Committed attachment 255338 in <http://trac.webkit.org/r185832>. 1104015 5 mitz 2015-06-22 21:11:45 -0700 Deleted the target in <http://trac.webkit.org/r185861>. 255338 2015-06-21 22:45:28 -0700 2015-06-22 09:25:43 -0700 Part 1: prepare the Sandbox Profiles target bug-146197-20150621224447.patch text/plain 4881 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTgxNykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA2LTIxICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgUGFydCAxIG9mIFtYY29kZV0gRm9s ZCB0aGUgV2ViS2l0MlNhbmRib3hQcm9maWxlcy1JT1NPdmVycmlkZSB0YXJnZXQgaW50byB0aGUg U2FuZGJveCBQcm9maWxlcyB0YXJnZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0NjE5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogQ29uZmlndXJhdGlvbnMvU2FuZGJveFByb2ZpbGVzLnhjY29uZmln OiBBZGRlZC4gRGVmaW5lcyBJTlNUQUxMX1BBVEggYmFzZWQgb24gdGhlIHZhbHVlCisgICAgICAg IG9mIFdLX0lOU1RBTExfT1ZFUlJJREVfU0FOREJPWF9QUk9GSUxFUy4KKyAgICAgICAgKiBXZWJL aXQyLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2o6IFVzZSBTYW5kYm94UHJvZmlsZXMueGNjb25m aWcgZm9yIHRoZSBTYW5kYm94IFByb2ZpbGVzCisgICAgICAgIHRhcmdldCwgYW5kIGNoYW5nZSB0 aGUgZGVzdGluYXRpb24gcGF0aCBpbiBpdHMgQ29weSBGaWxlcyBidWlsZCBwaGFzZSB0byBJTlNU QUxMX1BBVEguCisKIDIwMTUtMDYtMjEgIEh5dW5nd29vayBMZWUgIDxoeXVuZ3dvb2subGVlQG5h dmVyY29ycC5jb20+CiAKICAgICAgICAgV0tBcHBsaWNhdGlvbkNhY2hlTWFuYWdlckRlbGV0ZUVu dHJpZXNGb3JPcmlnaW4oKSBoYXMgd3JvbmcgV2Vic2l0ZURhdGFUeXBlcy4KSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL0NvbmZpZ3VyYXRpb25zL1NhbmRib3hQcm9maWxlcy54Y2NvbmZpZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9Db25maWd1cmF0aW9ucy9TYW5kYm94UHJvZmlsZXMueGNj b25maWcJKHJldmlzaW9uIDApCisrKyBTb3VyY2UvV2ViS2l0Mi9Db25maWd1cmF0aW9ucy9TYW5k Ym94UHJvZmlsZXMueGNjb25maWcJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw0IEBACitJTlNU QUxMX1BBVEggPSAkKElOU1RBTExfUEFUSF9FTkdJTkVFUklOR19CVUlMRF8kKFdLX0lOU1RBTExf T1ZFUlJJREVfU0FOREJPWF9QUk9GSUxFUykpOworSU5TVEFMTF9QQVRIX1dLX0lOU1RBTExfT1ZF UlJJREVfU0FOREJPWF9QUk9GSUxFU18gPSAkKElOU1RBTExfUEFUSF9XS19JTlNUQUxMX09WRVJS SURFX1NBTkRCT1hfUFJPRklMRVNfTk8pOworSU5TVEFMTF9QQVRIX1dLX0lOU1RBTExfT1ZFUlJJ REVfU0FOREJPWF9QUk9GSUxFU19OTyA9IC91c3IvbG9jYWwvc2hhcmUvc2FuZGJveC9wcm9maWxl cy9lbWJlZGRlZC9idWlsdGluOworSU5TVEFMTF9QQVRIX1dLX0lOU1RBTExfT1ZFUlJJREVfU0FO REJPWF9QUk9GSUxFU19ZRVMgPSAvdXNyL2xvY2FsL3NoYXJlL3NhbmRib3g7CkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9XZWJLaXQyLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvV2ViS2l0Mi54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCShyZXZp c2lvbiAxODU4MTUpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJLaXQyLnhjb2RlcHJvai9wcm9qZWN0 LnBieHByb2oJKHdvcmtpbmcgY29weSkKQEAgLTIxMDQsNyArMjEwNCw3IEBACiAJCUE3QUFEQTE1 MTkzOTVDQzMwMDNFQTFDNyAvKiBDb3B5RmlsZXMgKi8gPSB7CiAJCQlpc2EgPSBQQlhDb3B5Rmls ZXNCdWlsZFBoYXNlOwogCQkJYnVpbGRBY3Rpb25NYXNrID0gMjE0NzQ4MzY0NzsKLQkJCWRzdFBh dGggPSAvdXNyL2xvY2FsL3NoYXJlL3NhbmRib3gvcHJvZmlsZXMvZW1iZWRkZWQvYnVpbHRpbjsK KwkJCWRzdFBhdGggPSAiJChJTlNUQUxMX1BBVEgpIjsKIAkJCWRzdFN1YmZvbGRlclNwZWMgPSAw OwogCQkJZmlsZXMgPSAoCiAJCQkJQTc4Q0NEREExOTNBQzlGNDAwNUVDQzI1IC8qIGNvbS5hcHBs ZS5XZWJLaXQuRGF0YWJhc2VzLnNiIGluIENvcHlGaWxlcyAqLywKQEAgLTI5ODAsNiArMjk4MCw3 IEBACiAJCTM3QzRDMDkyMTgxNEIzQUYwMDM2ODhCOSAvKiBXS05TQXJyYXkuaCAqLyA9IHtpc2Eg PSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25vd25GaWxlVHlwZSA9 IHNvdXJjZWNvZGUuYy5oOyBwYXRoID0gV0tOU0FycmF5Lmg7IHNvdXJjZVRyZWUgPSAiPGdyb3Vw PiI7IH07CiAJCTM3REZBNkZGMTgxMEJCOTIwMDFGNEE5RiAvKiBXS0ZvdW5kYXRpb24uaCAqLyA9 IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25vd25GaWxl VHlwZSA9IHNvdXJjZWNvZGUuYy5oOyBwYXRoID0gV0tGb3VuZGF0aW9uLmg7IHNvdXJjZVRyZWUg PSAiPGdyb3VwPiI7IH07CiAJCTM3RTI1RDZEMThGREU1RDYwMDVEM0EwMCAvKiBBUElGb3JtQ2xp ZW50LmggKi8gPSB7aXNhID0gUEJYRmlsZVJlZmVyZW5jZTsgZmlsZUVuY29kaW5nID0gNDsgbGFz dEtub3duRmlsZVR5cGUgPSBzb3VyY2Vjb2RlLmMuaDsgcGF0aCA9IEFQSUZvcm1DbGllbnQuaDsg c291cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKKwkJMzdFODNENDAxQjM3RDI3QjAwMjA3OUVFIC8q IFNhbmRib3hQcm9maWxlcy54Y2NvbmZpZyAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBs YXN0S25vd25GaWxlVHlwZSA9IHRleHQueGNjb25maWc7IHBhdGggPSBTYW5kYm94UHJvZmlsZXMu eGNjb25maWc7IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07CiAJCTM3RjYyM0I3MTJBNTdCNjIw MEUzRkRGNiAvKiBXS0ZpbmRPcHRpb25zLmggKi8gPSB7aXNhID0gUEJYRmlsZVJlZmVyZW5jZTsg ZmlsZUVuY29kaW5nID0gNDsgbGFzdEtub3duRmlsZVR5cGUgPSBzb3VyY2Vjb2RlLmMuaDsgcGF0 aCA9IFdLRmluZE9wdGlvbnMuaDsgc291cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKIAkJMzdGQzE5 NDYxODUwRkJGMjAwOENGQTQ3IC8qIFdLQnJvd3NpbmdDb250ZXh0TG9hZERlbGVnYXRlUHJpdmF0 ZS5oICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9IDQ7IGxhc3RL bm93bkZpbGVUeXBlID0gc291cmNlY29kZS5jLmg7IHBhdGggPSBXS0Jyb3dzaW5nQ29udGV4dExv YWREZWxlZ2F0ZVByaXZhdGUuaDsgc291cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKIAkJMzdGQzE5 NDgxODUxMEQ2QTAwOENGQTQ3IC8qIFdLTlNVUkxBdXRoZW50aWNhdGlvbkNoYWxsZW5nZS5tbSAq LyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25vd25G aWxlVHlwZSA9IHNvdXJjZWNvZGUuY3BwLm9iamNwcDsgcGF0aCA9IFdLTlNVUkxBdXRoZW50aWNh dGlvbkNoYWxsZW5nZS5tbTsgc291cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKQEAgLTQ0OTUsNiAr NDQ5Niw3IEBACiAJCQkJQkNCRUNEQzIxNkI1Q0UyQTAwMDQ3QTFBIC8qIFBsdWdpblNlcnZpY2Uu NjQuRGV2ZWxvcG1lbnQueGNjb25maWcgKi8sCiAJCQkJQkM4MjgzRjQxNkI0RkM1MzAwQTI3OEZF IC8qIFBsdWdpblNlcnZpY2UuNjQueGNjb25maWcgKi8sCiAJCQkJNUQ0NDJBNTUxNkQ1ODU2NzAw QUMzMzMxIC8qIFBsdWdpblNlcnZpY2UuZW50aXRsZW1lbnRzICovLAorCQkJCTM3RTgzRDQwMUIz N0QyN0IwMDIwNzlFRSAvKiBTYW5kYm94UHJvZmlsZXMueGNjb25maWcgKi8sCiAJCQkJQTFFREQy REMxODg0QjlCNTAwQkJGRTk4IC8qIFNlY0l0ZW1TaGltLnhjY29uZmlnICovLAogCQkJCTUxODNC MzkzMTM3OUY4NUMwMEU4NzU0RSAvKiBTaGltLnhjY29uZmlnICovLAogCQkJCTFBNEY5NzZFMTAw RTdCNjYwMDYzN0ExOCAvKiBWZXJzaW9uLnhjY29uZmlnICovLApAQCAtMTA2MjUsNiArMTA2Mjcs NyBAQAogCQl9OwogCQlBN0FBREExMTE5Mzk1Q0E5MDAzRUExQzcgLyogRGVidWcgKi8gPSB7CiAJ CQlpc2EgPSBYQ0J1aWxkQ29uZmlndXJhdGlvbjsKKwkJCWJhc2VDb25maWd1cmF0aW9uUmVmZXJl bmNlID0gMzdFODNENDAxQjM3RDI3QjAwMjA3OUVFIC8qIFNhbmRib3hQcm9maWxlcy54Y2NvbmZp ZyAqLzsKIAkJCWJ1aWxkU2V0dGluZ3MgPSB7CiAJCQkJUFJPRFVDVF9OQU1FID0gIiQoVEFSR0VU X05BTUUpIjsKIAkJCX07CkBAIC0xMDYzMiw2ICsxMDYzNSw3IEBACiAJCX07CiAJCUE3QUFEQTEy MTkzOTVDQTkwMDNFQTFDNyAvKiBSZWxlYXNlICovID0gewogCQkJaXNhID0gWENCdWlsZENvbmZp Z3VyYXRpb247CisJCQliYXNlQ29uZmlndXJhdGlvblJlZmVyZW5jZSA9IDM3RTgzRDQwMUIzN0Qy N0IwMDIwNzlFRSAvKiBTYW5kYm94UHJvZmlsZXMueGNjb25maWcgKi87CiAJCQlidWlsZFNldHRp bmdzID0gewogCQkJCVBST0RVQ1RfTkFNRSA9ICIkKFRBUkdFVF9OQU1FKSI7CiAJCQl9OwpAQCAt MTA2MzksNiArMTA2NDMsNyBAQAogCQl9OwogCQlBN0FBREExMzE5Mzk1Q0E5MDAzRUExQzcgLyog UHJvZHVjdGlvbiAqLyA9IHsKIAkJCWlzYSA9IFhDQnVpbGRDb25maWd1cmF0aW9uOworCQkJYmFz ZUNvbmZpZ3VyYXRpb25SZWZlcmVuY2UgPSAzN0U4M0Q0MDFCMzdEMjdCMDAyMDc5RUUgLyogU2Fu ZGJveFByb2ZpbGVzLnhjY29uZmlnICovOwogCQkJYnVpbGRTZXR0aW5ncyA9IHsKIAkJCQlQUk9E VUNUX05BTUUgPSAiJChUQVJHRVRfTkFNRSkiOwogCQkJfTsK