146183 2015-06-20 13:46:09 -0700 [Cocoa] Actually use Objective-C lightweight generics when the compiler supports them 2015-06-20 20:28:10 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz andersca commit-queue sam oldest_to_newest 1103650 0 mitz 2015-06-20 13:46:09 -0700 We are currently using Objective-C lightweight generics in framework headers, but when building WebKit we ignore them. 1103652 1 255297 mitz 2015-06-20 13:50:24 -0700 Created attachment 255297 Define WK_ARRAY, WK_SET and WK_DICTIONARY to use generics where available 1103682 2 255297 commit-queue 2015-06-20 20:28:06 -0700 Comment on attachment 255297 Define WK_ARRAY, WK_SET and WK_DICTIONARY to use generics where available Clearing flags on attachment: 255297 Committed r185803: <http://trac.webkit.org/changeset/185803> 1103683 3 commit-queue 2015-06-20 20:28:10 -0700 All reviewed patches have been landed. Closing bug. 255297 2015-06-20 13:50:24 -0700 2015-06-20 20:28:06 -0700 Define WK_ARRAY, WK_SET and WK_DICTIONARY to use generics where available bug-146183-20150620134945.patch text/plain 4301 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTc5OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE1LTA2LTIwICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBBY3R1YWxseSB1c2Ug T2JqZWN0aXZlLUMgbGlnaHR3ZWlnaHQgZ2VuZXJpY3Mgd2hlbiB0aGUgY29tcGlsZXIgc3VwcG9y dHMgdGhlbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQ2MTgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTaGFyZWQvQVBJL0NvY29hL1dLRm91bmRhdGlvbi5oOiBXaGVuIHRoZSBjb21waWxlciBzdXBw b3J0cyBPYmplY3RpdmUtQyBnZW5lcmljcywgZGVmaW5lCisgICAgICAgIFdLX0FSUkFZIGFuZCBX S19TRVQgdG8gdXNlIHRoZW0uIEFsc28gYWRkZWQgYSBkZWZpbml0aW9uIG9mIFdLX0RJQ1RJT05B UlkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaDog VXNlIFdLX0RJQ1RJT05BUlkgZm9yIHRoZSBvcHRpb25zIGRpY3Rpb25hcnkgb2YKKyAgICAgICAg LV9sb2FkUmVxdWVzdDp3aXRoT3B0aW9uczouCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0Nv Y29hL1dLV2Vic2l0ZURhdGFTdG9yZS5tbToKKyAgICAgICAgKC1bV0tXZWJzaXRlRGF0YVN0b3Jl IGZldGNoRGF0YVJlY29yZHNPZlR5cGVzOmNvbXBsZXRpb25IYW5kbGVyOl0pOiBNYWRlIHRoZSBj b21wbGV0aW9uCisgICAgICAgIGhhbGRlciB0eXBlIG1hdGNoIHRoZSBkZWNsYXJhdGlvbiwgbm93 IHRoYXQgTlNBcnJheSBhbmQgV0tfQVJSQVkoV0tXZWJzaXRlRGF0YVJlY29yZCAqKSBhcmUKKyAg ICAgICAgbm90IHRoZSBzYW1lLgorCisgICAgICAgICogbWFjL3Bvc3Rwcm9jZXNzLWZyYW1ld29y ay1oZWFkZXJzLnNoOiBBbHNvIHJld3JpdGUgV0tfRElDVElPTkFSWS4KKwogMjAxNS0wNi0yMCAg TWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CiAKICAgICAgICAgQ2hl Y2sgZm9yIFNIQTEgY2VydGlmaWNhdGVzIGlnbm9yZXMgc3VicmVzb3VyY2VzCkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9TaGFyZWQvQVBJL0NvY29hL1dLRm91bmRhdGlvbi5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQ29jb2EvV0tGb3VuZGF0aW9uLmgJKHJldmlzaW9u IDE4NTc5OCkKKysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQ29jb2EvV0tGb3VuZGF0aW9u LmgJKHdvcmtpbmcgY29weSkKQEAgLTQ5LDkgKzQ5LDIwIEBACiAjZGVmaW5lIFdLX0VOVU1fQVZB SUxBQkxFKF9tYWMsIF9pb3MpCiAjZGVmaW5lIFdLX0VOVU1fQVZBSUxBQkxFX0lPUyhfaW9zKQog CisjaWYgX19oYXNfZmVhdHVyZShvYmpjX2dlbmVyaWNzKQorCisjZGVmaW5lIFdLX0FSUkFZKF9v YmplY3RUeXBlKSBOU0FycmF5PF9vYmplY3RUeXBlPgorI2RlZmluZSBXS19ESUNUSU9OQVJZKF9r ZXlUeXBlLCBfdmFsdWVUeXBlKSBOU0RpY3Rpb25hcnk8X2tleVR5cGUsIF92YWx1ZVR5cGU+Cisj ZGVmaW5lIFdLX1NFVChfb2JqZWN0VHlwZSkgTlNTZXQ8X29iamVjdFR5cGU+CisKKyNlbHNlCisK ICNkZWZpbmUgV0tfQVJSQVkoLi4uKSBOU0FycmF5CisjZGVmaW5lIFdLX0RJQ1RJT05BUlkoLi4u KSBOU0RpY3Rpb25hcnkKICNkZWZpbmUgV0tfU0VUKC4uLikgTlNTZXQKIAorI2VuZGlmCisKICNp Zm5kZWYgX19OU2lfOF8zCiAjZGVmaW5lIF9fTlNpXzhfMyBpbnRyb2R1Y2VkPTguMwogI2VuZGlm CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZh dGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dL V2ViVmlld1ByaXZhdGUuaAkocmV2aXNpb24gMTg1Nzk4KQorKysgU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmgJKHdvcmtpbmcgY29weSkKQEAgLTIw NCw3ICsyMDQsNyBAQCBXS19FWFRFUk4gTlNTdHJpbmcgKiBjb25zdCBfV0tTaG91bGRPcGVuCiBA cHJvcGVydHkgKG5vbmF0b21pYywgc2V0dGVyPV9zZXRTY3JvbGxQZXJmb3JtYW5jZURhdGFDb2xs ZWN0aW9uRW5hYmxlZDopIEJPT0wgX3Njcm9sbFBlcmZvcm1hbmNlRGF0YUNvbGxlY3Rpb25FbmFi bGVkIFdLX0FWQUlMQUJMRShXS19NQUNfVEJBLCBXS19JT1NfVEJBKTsKIEBwcm9wZXJ0eSAobm9u YXRvbWljLCByZWFkb25seSkgTlNBcnJheSAqX3Njcm9sbFBlcmZvcm1hbmNlRGF0YSBXS19BVkFJ TEFCTEUoV0tfTUFDX1RCQSwgV0tfSU9TX1RCQSk7CiAKLS0gKFdLTmF2aWdhdGlvbiAqKV9sb2Fk UmVxdWVzdDooTlNVUkxSZXF1ZXN0ICopcmVxdWVzdCB3aXRoT3B0aW9uczooTlNEaWN0aW9uYXJ5 ICopbG9hZE9wdGlvbnMgV0tfQVZBSUxBQkxFKFdLX01BQ19UQkEsIFdLX0lPU19UQkEpOworLSAo V0tOYXZpZ2F0aW9uICopX2xvYWRSZXF1ZXN0OihOU1VSTFJlcXVlc3QgKilyZXF1ZXN0IHdpdGhP cHRpb25zOihXS19ESUNUSU9OQVJZKE5TU3RyaW5nICosIGlkKSAqKWxvYWRPcHRpb25zIFdLX0FW QUlMQUJMRShXS19NQUNfVEJBLCBXS19JT1NfVEJBKTsKIAogQGVuZAogCkluZGV4OiBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vic2l0ZURhdGFTdG9yZS5tbQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vic2l0ZURhdGFT dG9yZS5tbQkocmV2aXNpb24gMTg1Nzk4KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9Db2NvYS9XS1dlYnNpdGVEYXRhU3RvcmUubW0JKHdvcmtpbmcgY29weSkKQEAgLTc0LDcgKzc0 LDcgQEAgc3RhdGljIHN0ZDo6Y2hyb25vOjpzeXN0ZW1fY2xvY2s6OnRpbWVfcAogICAgIHJldHVy biBzeXN0ZW1fY2xvY2s6OnRpbWVfcG9pbnQoZHVyYXRpb25fY2FzdDxzeXN0ZW1fY2xvY2s6OmR1 cmF0aW9uPihkdXJhdGlvbjxkb3VibGU+KGRhdGUudGltZUludGVydmFsU2luY2UxOTcwKSkpOwog fQogCi0tICh2b2lkKWZldGNoRGF0YVJlY29yZHNPZlR5cGVzOihOU1NldCAqKWRhdGFUeXBlcyBj b21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXikoTlNBcnJheSAqKSljb21wbGV0aW9uSGFuZGxlcgor LSAodm9pZClmZXRjaERhdGFSZWNvcmRzT2ZUeXBlczooTlNTZXQgKilkYXRhVHlwZXMgY29tcGxl dGlvbkhhbmRsZXI6KHZvaWQgKF4pKFdLX0FSUkFZKFdLV2Vic2l0ZURhdGFSZWNvcmQgKikgKikp Y29tcGxldGlvbkhhbmRsZXIKIHsKICAgICBhdXRvIGNvbXBsZXRpb25IYW5kbGVyQ29weSA9IEJs b2NrX2NvcHkoY29tcGxldGlvbkhhbmRsZXIpOwogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9tYWMv cG9zdHByb2Nlc3MtZnJhbWV3b3JrLWhlYWRlcnMuc2gKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvbWFjL3Bvc3Rwcm9jZXNzLWZyYW1ld29yay1oZWFkZXJzLnNoCShyZXZpc2lvbiAxODU3 OTgpCisrKyBTb3VyY2UvV2ViS2l0Mi9tYWMvcG9zdHByb2Nlc3MtZnJhbWV3b3JrLWhlYWRlcnMu c2gJKHdvcmtpbmcgY29weSkKQEAgLTU5LDYgKzU5LDcgQEAgZnVuY3Rpb24gcmV3cml0ZV9oZWFk ZXJzICgpIHsKIAogICAgIFNFRF9PUFRJT05TPSgKICAgICAgICAgLWUgJ3MvV0tfQVJSQVlcKChb XlwpXSspXCkvTlNBcnJheTxcMT4vZycKKyAgICAgICAgLWUgJ3MvV0tfRElDVElPTkFSWVwoKFte XCldKylcKS9OU0RpY3Rpb25hcnk8XDE+L2cnCiAgICAgICAgIC1lICdzL1dLX1NFVFwoKFteXCld KylcKS9OU1NldDxcMT4vZycKICAgICAgICAgLWUgcy9XS19BU1NVTUVfTk9OTlVMTF9CRUdJTi9O U19BU1NVTUVfTk9OTlVMTF9CRUdJTi8KICAgICAgICAgLWUgcy9XS19BU1NVTUVfTk9OTlVMTF9F TkQvTlNfQVNTVU1FX05PTk5VTExfRU5ELwo=