146181 2015-06-20 08:27:53 -0700 [EFL][GTK] Define GLIB_VERSION_MIN_REQUIRED and require glib 2.36 for GTK 2015-06-21 02:37:36 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=146184 P2 Trivial --- 1 mcatanzaro mcatanzaro benjamin cgarcia clopez cmarcelo commit-queue gyuyoung.kim mcatanzaro mrobinson oldest_to_newest 1103618 0 mcatanzaro 2015-06-20 08:27:53 -0700 Define GLIB_VERSION_MIN_REQUIRED to silence more deprecation warnings. 1103619 1 255291 mcatanzaro 2015-06-20 08:29:26 -0700 Created attachment 255291 Patch 1103620 2 mcatanzaro 2015-06-20 08:46:32 -0700 This fixes the following deprecation warnings that cannot otherwise be fixed without bumping the GTK port's GLib requirement from 2.34 to 2.36 (to gain access to GTask, the replacement for GSimpleAsyncResult): [4164/4532] Building CXX object Source...oup/WebKitSoupRequestInputStream.cpp.o ../../Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp:57:9: warning: 'g_simple_async_result_set_op_res_gssize' is deprecated [-Wdeprecated-declarations] g_simple_async_result_set_op_res_gssize(result, bytesRead); ^ /home/mcatanzaro/jhbuild/install/include/glib-2.0/gio/gsimpleasyncresult.h:82:21: note: 'g_simple_async_result_set_op_res_gssize' has been explicitly marked deprecated here void g_simple_async_result_set_op_res_gssize (GSimpleAsyncResult *simple, ^ ../../Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp:60:9: warning: 'g_simple_async_result_take_error' is deprecated [-Wdeprecated-declarations] g_simple_async_result_take_error(result, error); ^ /home/mcatanzaro/jhbuild/install/include/glib-2.0/gio/gsimpleasyncresult.h:116:21: note: 'g_simple_async_result_take_error' has been explicitly marked deprecated here void g_simple_async_result_take_error (GSimpleAsyncResult *simple, ^ ../../Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp:61:5: warning: 'g_simple_async_result_complete_in_idle' is deprecated [-Wdeprecated-declarations] g_simple_async_result_complete_in_idle(result); ^ /home/mcatanzaro/jhbuild/install/include/glib-2.0/gio/gsimpleasyncresult.h:106:21: note: 'g_simple_async_result_complete_in_idle' has been explicitly marked deprecated here void g_simple_async_result_complete_in_idle (GSimpleAsyncResult *simple); ^ ../../Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp:87:52: warning: 'g_simple_async_result_new' is deprecated [-Wdeprecated-declarations] GRefPtr<GSimpleAsyncResult> result = adoptGRef(g_simple_async_result_new(G_OBJECT(stream), callback, userData, reinterpret_cast<void*>(webkitSoupRequestInputStreamReadAsync))); ^ /home/mcatanzaro/jhbuild/install/include/glib-2.0/gio/gsimpleasyncresult.h:51:21: note: 'g_simple_async_result_new' has been explicitly marked deprecated here GSimpleAsyncResult *g_simple_async_result_new (GObject *source_object, ^ ../../Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp:92:9: warning: 'g_simple_async_result_set_op_res_gssize' is deprecated [-Wdeprecated-declarations] g_simple_async_result_set_op_res_gssize(result.get(), 0); ^ /home/mcatanzaro/jhbuild/install/include/glib-2.0/gio/gsimpleasyncresult.h:82:21: note: 'g_simple_async_result_set_op_res_gssize' has been explicitly marked deprecated here void g_simple_async_result_set_op_res_gssize (GSimpleAsyncResult *simple, ^ ../../Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp:93:9: warning: 'g_simple_async_result_complete_in_idle' is deprecated [-Wdeprecated-declarations] g_simple_async_result_complete_in_idle(result.get()); ^ /home/mcatanzaro/jhbuild/install/include/glib-2.0/gio/gsimpleasyncresult.h:106:21: note: 'g_simple_async_result_complete_in_idle' has been explicitly marked deprecated here void g_simple_async_result_complete_in_idle (GSimpleAsyncResult *simple); ^ ../../Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp:108:20: warning: 'g_simple_async_result_get_source_tag' is deprecated [-Wdeprecated-declarations] g_warn_if_fail(g_simple_async_result_get_source_tag(simpleResult) == webkitSoupRequestInputStreamReadAsync); ^ /home/mcatanzaro/jhbuild/install/include/glib-2.0/glib/gmessages.h:303:18: note: expanded from macro 'g_warn_if_fail' if G_LIKELY (expr) ; \ ^ /home/mcatanzaro/jhbuild/install/include/glib-2.0/glib/gmacros.h:329:25: note: expanded from macro 'G_LIKELY' #define G_LIKELY(expr) (expr) ^ /home/mcatanzaro/jhbuild/install/include/glib-2.0/gio/gsimpleasyncresult.h:99:21: note: 'g_simple_async_result_get_source_tag' has been explicitly marked deprecated here gpointer g_simple_async_result_get_source_tag (GSimpleAsyncResult *simple); ^ ../../Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp:110:12: warning: 'g_simple_async_result_get_op_res_gssize' is deprecated [-Wdeprecated-declarations] return g_simple_async_result_get_op_res_gssize(simpleResult); ^ /home/mcatanzaro/jhbuild/install/include/glib-2.0/gio/gsimpleasyncresult.h:85:21: note: 'g_simple_async_result_get_op_res_gssize' has been explicitly marked deprecated here gssize g_simple_async_result_get_op_res_gssize (GSimpleAsyncResult *simple); ^ 8 warnings generated. 1103622 3 mcatanzaro 2015-06-20 08:51:55 -0700 Um, actually, we use GTask all over the place. Let's bump our minimum to 2.36 to reflect reality. One point to Carloz Lopez! 1103623 4 255292 mcatanzaro 2015-06-20 08:57:49 -0700 Created attachment 255292 Patch 1103625 5 mcatanzaro 2015-06-20 09:00:16 -0700 (In reply to comment #3) > One point to Carloz Lopez! (This was just a typo.) 1103634 6 mrobinson 2015-06-20 09:48:31 -0700 How long have we depended on something beyond our minimum dependencies? 1103646 7 mcatanzaro 2015-06-20 12:34:08 -0700 We've used GTask for 24 months and one day (to be unnecessarily precise). See the bugs tracked by bug #117149, which notes that "now we depend on glib 2.36." I guess at some point (maybe during the build system switch) our version requirement went backwards by accident. 1103667 8 255292 commit-queue 2015-06-20 16:01:31 -0700 Comment on attachment 255292 Patch Clearing flags on attachment: 255292 Committed r185802: <http://trac.webkit.org/changeset/185802> 1103668 9 commit-queue 2015-06-20 16:01:44 -0700 All reviewed patches have been landed. Closing bug. 1103713 10 cgarcia 2015-06-21 02:37:36 -0700 (In reply to comment #6) > How long have we depended on something beyond our minimum dependencies? Never. We agreed on depending on 2.36.0 since WebKitGTK+ 2.0.0 https://lists.webkit.org/pipermail/webkit-gtk/2013-March/001387.html https://bugs.webkit.org/show_bug.cgi?id=113282 http://trac.webkit.org/changeset/147547 255291 2015-06-20 08:29:26 -0700 2015-06-20 08:57:43 -0700 Patch bug-146181-20150620102847.patch text/plain 1218 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NzkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGYwMjJkMDdlMmM2MGUwYWEzOTUxMmEz MjY2OWQwZmQ0ZDk3YmYxOTEuLmEzMjViNzdmODkxMTA2MTU2ZTIwOWI3MmUxYzg5NDZkYjljM2Ri MjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUtMDYtMjAgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtFRkxdW0dUS10gRGVmaW5lIEdMSUJf VkVSU0lPTl9NSU5fUkVRVUlSRUQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0NjE4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIERlZmluZSBhbHNvIEdMSUJfVkVSU0lPTl9NSU5fUkVRVUlSRUQgdG8gYXZv aWQgZGVwcmVjYXRpb24gd2FybmluZ3MuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKwog MjAxNS0wNi0xOSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CiAK ICAgICAgICAgW1NPVVBdIERlZmluZSBTT1VQX1ZFUlNJT05fTUlOX1JFUVVJUkVECmRpZmYgLS1n aXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0u aAppbmRleCBmMzkzNjNhOTgyOWRlZGJhODIwMzZhYTA0OWJiYWJjZWYyOTFmYjY0Li42OTNiMzcz MjdhMzlmNTFhZTQxY2I3NzQ5ZDgwMDY3MjM0YzM0NTFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RG L3d0Zi9QbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKQEAgLTQ4OCw2 ICs0ODgsMTIgQEAKICNkZWZpbmUgVVNFX1dFQlAgMQogI2VuZGlmCiAKKyNpZiBQTEFURk9STShF RkwpCisjZGVmaW5lIEdMSUJfVkVSU0lPTl9NSU5fUkVRVUlSRUQgR0xJQl9WRVJTSU9OXzJfMzgK KyNlbGlmIFBMQVRGT1JNKEdUSykKKyNkZWZpbmUgR0xJQl9WRVJTSU9OX01JTl9SRVFVSVJFRCBH TElCX1ZFUlNJT05fMl8zNAorI2VuZGlmCisKICNpZiBQTEFURk9STShHVEspICYmICFkZWZpbmVk KEdUS19BUElfVkVSU0lPTl8yKQogI2RlZmluZSBHREtfVkVSU0lPTl9NSU5fUkVRVUlSRUQgR0RL X1ZFUlNJT05fM182CiAjZW5kaWYK 255292 2015-06-20 08:57:49 -0700 2015-06-20 16:01:31 -0700 Patch bug-146181-20150620105709.patch text/plain 2537 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NzkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGYwMjJkMDdlMmM2MGUwYWEzOTUxMmEz MjY2OWQwZmQ0ZDk3YmYxOTEuLmNmODE4N2E5NWY2YjJkNzk2ZTYxMjIxMzgwNmU3ZTA3ZjAzZDAx MmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUtMDYtMjAgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtFRkxdW0dUS10gRGVmaW5lIEdMSUJf VkVSU0lPTl9NSU5fUkVRVUlSRUQgYW5kIHJlcXVpcmUgZ2xpYiAyLjM2IGZvciBHVEsKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjE4MQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERlZmluZSBHTElCX1ZF UlNJT05fTUlOX1JFUVVJUkVEIHRvIGF2b2lkIGRlcHJlY2F0aW9uIHdhcm5pbmdzLgorCisgICAg ICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMTUtMDYtMTkgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtTT1VQXSBEZWZpbmUgU09VUF9WRVJT SU9OX01JTl9SRVFVSVJFRApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaCBi L1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKaW5kZXggZjM5MzYzYTk4MjlkZWRiYTgyMDM2YWEw NDliYmFiY2VmMjkxZmI2NC4uYzIzNGY1MDE4Mjc5M2MxZjZkNWJiMzAzNTBmZTVlMzJjMDM2Y2Jm YyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAorKysgYi9Tb3VyY2UvV1RG L3d0Zi9QbGF0Zm9ybS5oCkBAIC00ODgsNiArNDg4LDEyIEBACiAjZGVmaW5lIFVTRV9XRUJQIDEK ICNlbmRpZgogCisjaWYgUExBVEZPUk0oRUZMKQorI2RlZmluZSBHTElCX1ZFUlNJT05fTUlOX1JF UVVJUkVEIEdMSUJfVkVSU0lPTl8yXzM4CisjZWxpZiBQTEFURk9STShHVEspCisjZGVmaW5lIEdM SUJfVkVSU0lPTl9NSU5fUkVRVUlSRUQgR0xJQl9WRVJTSU9OXzJfMzYKKyNlbmRpZgorCiAjaWYg UExBVEZPUk0oR1RLKSAmJiAhZGVmaW5lZChHVEtfQVBJX1ZFUlNJT05fMikKICNkZWZpbmUgR0RL X1ZFUlNJT05fTUlOX1JFUVVJUkVEIEdES19WRVJTSU9OXzNfNgogI2VuZGlmCmRpZmYgLS1naXQg YS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCmluZGV4IDU1YWUyNDM3ZWNjZDJhZWE3MTY5ZGNmZWY0OGRkZDBiYmViZDQ4NWIuLjA0 NGZhOTExYjMyYjk4MzM5YjU0ZjQ3MTBmOWY4OWY4MDJkZWMyYmYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNt YWtlCkBAIC0yNDQsNyArMjQ0LDcgQEAgc2V0KGdsaWJfY29tcG9uZW50cyBnaW8gZ29iamVjdCBn dGhyZWFkIGdtb2R1bGUpCiBpZiAoRU5BQkxFX0dBTUVQQURfREVQUkVDQVRFRCBPUiBFTkFCTEVf R0VPTE9DQVRJT04pCiAgICAgbGlzdChBUFBFTkQgZ2xpYl9jb21wb25lbnRzIGdpby11bml4KQog ZW5kaWYgKCkKLWZpbmRfcGFja2FnZShHTElCIDIuMzMuMiBSRVFVSVJFRCBDT01QT05FTlRTICR7 Z2xpYl9jb21wb25lbnRzfSkKK2ZpbmRfcGFja2FnZShHTElCIDIuMzYgUkVRVUlSRUQgQ09NUE9O RU5UUyAke2dsaWJfY29tcG9uZW50c30pCiAKIGlmIChFTkFCTEVfQ1JFREVOVElBTF9TVE9SQUdF KQogICAgIGZpbmRfcGFja2FnZShMaWJzZWNyZXQpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9D aGFuZ2VMb2cKaW5kZXggZmFjMGMyOTM3ZGI2ZjgzYjZjNzgyN2VhYWNhYjY3MDY0ZjM3MzU4OC4u MjNiZTM4NmYxYmVmOTg0ZGMwYzlkZmY3MTI3NGZlMzE3ZDNiZTczMCAxMDA2NDQKLS0tIGEvQ2hh bmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA2LTIwICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbRUZMXVtH VEtdIERlZmluZSBHTElCX1ZFUlNJT05fTUlOX1JFUVVJUkVEIGFuZCByZXF1aXJlIGdsaWIgMi4z NiBmb3IgR1RLCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDYxODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBCdW1wIG91ciBHTGliIHJlcXVpcmVtZW50IHRvIDIuMzYgdG8gcmVmbGVjdCByZWFsaXR5LCBz aW5jZSB3ZSBhcmUgdXNpbmcgR1Rhc2suCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9u c0dUSy5jbWFrZToKKwogMjAxNS0wNi0yMCAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAbmF2ZXJj b3JwLmNvbT4KIAogICAgICAgICBbRUZMXSBEbyBub3QgY29uc2lkZXIgdGVzdCBkaXJlY3Rvcmll cyB3aGVuIERFVkVMT1BFUl9NT0RFIGlzIE9GRgo=