146176 2015-06-19 17:58:54 -0700 Web Inspector: Duplication of style attribute in rules panel for shadow content 2015-06-19 23:21:11 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue dino graouts joepeck jonowells mattbaker nvasilyev timothy tobi+webkit webkit-bug-importer oldest_to_newest 1103527 0 joepeck 2015-06-19 17:58:54 -0700 * SUMMARY Duplicate of style attribute in rules panel for shadow content. Regressed with: <http://trac.webkit.org/changeset/184000> * TEST <audio controls></audio> * STEPS TO REPRODUCE 1. Inspect any page with <audio> 2. Enable Shadow DOM (Elements tab) 3. Expand the audio 4. Select the <input pseudo="-webkit-media-controls-timeline" style="background-image: -webkit-canvas(_webkit-media-controls-timeline-6bd0eaf2-ef13-461e-86f2-fc4d3c7794f2);" min="0" max="NaN" class="hidden"> 5. Show Style Rules sidebar => the CSS is duplicated in the Styles Attribute section * NOTES - CSSStyleDeclarationTextEditor.js's CSSStyleDeclarationTextEditor.prototype._resetContent makes an assumption that styleText will always be empty for a readOnly editor. It turns out that for a Style Attribute that is Read Only, that is not the case. I think the only way that can happen is a Shadow DOM node with a Style Attribute (as we are seeing it here). We should more gracefully handle this. 1103528 1 joepeck 2015-06-19 17:59:06 -0700 <rdar://problem/21467669> 1103529 2 255259 joepeck 2015-06-19 18:00:55 -0700 Created attachment 255259 [PATCH] Proposed Fix 1103530 3 255260 joepeck 2015-06-19 18:01:43 -0700 Created attachment 255260 [PATCH] Proposed Fix Fixed title. 1103534 4 tobi+webkit 2015-06-19 18:18:04 -0700 Good catch and good fix! I would add it to the commit-queue. 1103583 5 255260 commit-queue 2015-06-19 23:21:05 -0700 Comment on attachment 255260 [PATCH] Proposed Fix Clearing flags on attachment: 255260 Committed r185789: <http://trac.webkit.org/changeset/185789> 1103584 6 commit-queue 2015-06-19 23:21:11 -0700 All reviewed patches have been landed. Closing bug. 255259 2015-06-19 18:00:55 -0700 2015-06-19 18:01:43 -0700 [PATCH] Proposed Fix style-fix.patch text/plain 3171 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGFiZGRiZWIuLjczYTRjOGIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA2LTE5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRHVwbGlj YXRlIG9mIHN0eWxlIGF0dHJpYnV0ZSBpbiBydWxlcyBwYW5lbCBmb3Igc2hhZG93IGNvbnRlbnQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjE3Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9WaWV3cy9DU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvci5qczoKKyAgICAgICAg VGhlIHN0eWxlVGV4dCBjYW4gYmUgbm9uLWVtcHR5IGZvciBhIHJlYWRvbmx5IGVkaXRvciBpZiB0 aGUgZWRpdG9yIGlzIGZvcgorICAgICAgICB0aGUgc3R5bGUgYXR0cmlidXRlIG9mIGEgc2hhZG93 IGRvbSBub2RlLiBJbnN0ZWFkIG9mIGFzc3VtaW5nIGl0IGlzIGVtcHR5CisgICAgICAgIHdlIGNh biBqdXN0IGNsZWFyIHRoZSBlZGl0b3Igb3Vyc2VsdmVzIGFuZCByZWdlbmVyYXRlIGZyb20gcHJv cGVydGllcy4KKwogMjAxNS0wNi0xOSAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+ CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogTWFrZSBydWxlIGljb24gdG9nZ2xlIGFsbCBwcm9w ZXJ0aWVzIGZvciB0aGF0IHNlbGVjdG9yIG9uIGFuZCBvZmYKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGVjbGFyYXRpb25UZXh0 RWRpdG9yLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1NT U3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3IuanMKaW5kZXggZTMyMmI4MS4uYWU0YmU2NyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1NTU3R5 bGVEZWNsYXJhdGlvblRleHRFZGl0b3IuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3IuanMKQEAgLTEw NTIsMTkgKzEwNTIsMTYgQEAgV2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRp dG9yID0gY2xhc3MgQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3IKICAgICAgICAgICAgIHZh ciBzdHlsZVRleHQgPSB0aGlzLl9zdHlsZS50ZXh0LnRyaW0oKTsKICAgICAgICAgICAgIHZhciBm aW5kV2hpdGVzcGFjZSA9IC9ccysvZzsKIAotICAgICAgICAgICAgLy8gT25seSBmb3JtYXQgbm9u LWVtcHR5IHN0eWxlcy4gS2VlcCBpbiBtaW5kIHRoYXQgc3R5bGVUZXh0IGlzIGFsd2F5cyBlbXB0 eQotICAgICAgICAgICAgLy8gZm9yICJyZWFkT25seSIgRWRpdG9ycy4gQnV0IHByZXBhcmUgQ2hl Y2tib3ggcGxhY2Vob2xkZXJzIGluIGFueSBjYXNlLgotICAgICAgICAgICAgLy8gQmVjYXVzZSB0 aGF0IHdpbGwgaW5kZW50IHRoZSBjdXJzb3Igd2hlbiB0aGUgVXNlciBzdGFydHMgdHlwaW5nLgor ICAgICAgICAgICAgLy8gV2Ugb25seSBuZWVkIHRvIGZvcm1hdCBub24tZW1wdHkgc3R5bGVzLCBi dXQgcHJlcGFyZSBjaGVja2JveCBwbGFjZWhvbGRlcnMKKyAgICAgICAgICAgIC8vIGluIGFueSBj YXNlIGJlY2F1c2UgdGhhdCB3aWxsIGluZGVudCB0aGUgY3Vyc29yIHdoZW4gdGhlIFVzZXIgc3Rh cnRzIHR5cGluZy4KICAgICAgICAgICAgIGlmICghc3R5bGVUZXh0ICYmICFpc0VkaXRvclJlYWRP bmx5KSB7CiAgICAgICAgICAgICAgICAgdGhpcy5fbWFya0xpbmVzV2l0aENoZWNrYm94UGxhY2Vo b2xkZXIoKTsKICAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICB9CiAKLSAgICAg ICAgICAgIC8vIFNldCBub24tb3B0aW1pemVkLCB2YWxpZCBhbmQgaW52YWxpZCBzdHlsZXMgaW4g cHJlcGFyYXRpb24gZm9yIHRoZSBGb3JtYXR0ZXIuCi0gICAgICAgICAgICAvLyBTZXQgZW1wdHkg c3RyaW5nIGluIGNhc2Ugb2YgcmVhZG9ubHkgc3R5bGVzLgotICAgICAgICAgICAgdGhpcy5fY29k ZU1pcnJvci5zZXRWYWx1ZShzdHlsZVRleHQpOwotCisgICAgICAgICAgICAvLyBHZW5lcmF0ZSBm b3JtYXR0ZWQgY29udGVudCBmb3IgcmVhZG9ubHkgZWRpdG9ycyBieSBpdGVyYXRpbmcgcHJvcGVy dGllcy4KICAgICAgICAgICAgIGlmIChpc0VkaXRvclJlYWRPbmx5KSB7CisgICAgICAgICAgICAg ICAgdGhpcy5fY29kZU1pcnJvci5zZXRWYWx1ZSgiIik7CiAgICAgICAgICAgICAgICAgdmFyIGxp bmVOdW1iZXIgPSAwOwogICAgICAgICAgICAgICAgIHRoaXMuX2l0ZXJhdGVPdmVyUHJvcGVydGll cyhmYWxzZSwgZnVuY3Rpb24ocHJvcGVydHkpIHsKICAgICAgICAgICAgICAgICAgICAgdmFyIGZy b20gPSB7bGluZTogbGluZU51bWJlciwgY2g6IDB9OwpAQCAtMTA3NCwxMCArMTA3MSwxMiBAQCBX ZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3IgPSBjbGFzcyBDU1NTdHls ZURlY2xhcmF0aW9uVGV4dEVkaXRvcgogICAgICAgICAgICAgICAgICAgICB0aGlzLl9jcmVhdGVU ZXh0TWFya2VyRm9yUHJvcGVydHlJZk5lZWRlZChmcm9tLCB0bywgcHJvcGVydHkpOwogICAgICAg ICAgICAgICAgICAgICBsaW5lTnVtYmVyKys7CiAgICAgICAgICAgICAgICAgfSk7Ci0KICAgICAg ICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICB9CiAKKyAgICAgICAgICAgIC8vIFNldCBu b24tb3B0aW1pemVkLCB2YWxpZCBhbmQgaW52YWxpZCBzdHlsZXMgaW4gcHJlcGFyYXRpb24gZm9y IHRoZSBGb3JtYXR0ZXIuCisgICAgICAgICAgICB0aGlzLl9jb2RlTWlycm9yLnNldFZhbHVlKHN0 eWxlVGV4dCk7CisKICAgICAgICAgICAgIC8vIE5vdyB0aGUgRm9ybWF0dGVyIHByZXR0eSBwcmlu dHMgdGhlIHN0eWxlcy4KICAgICAgICAgICAgIHRoaXMuX2NvZGVNaXJyb3Iuc2V0VmFsdWUodGhp cy5fZm9ybWF0dGVkQ29udGVudEZyb21FZGl0b3IoKSk7CiAK 255260 2015-06-19 18:01:43 -0700 2015-06-19 23:21:05 -0700 [PATCH] Proposed Fix style-fix.patch text/plain 3173 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGFiZGRiZWIuLjczYTRjOGIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA2LTE5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRHVwbGlj YXRpb24gb2Ygc3R5bGUgYXR0cmlidXRlIGluIHJ1bGVzIHBhbmVsIGZvciBzaGFkb3cgY29udGVu dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2MTc2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2Vy SW50ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yLmpzOgorICAgICAg ICBUaGUgc3R5bGVUZXh0IGNhbiBiZSBub24tZW1wdHkgZm9yIGEgcmVhZG9ubHkgZWRpdG9yIGlm IHRoZSBlZGl0b3IgaXMgZm9yCisgICAgICAgIHRoZSBzdHlsZSBhdHRyaWJ1dGUgb2YgYSBzaGFk b3cgZG9tIG5vZGUuIEluc3RlYWQgb2YgYXNzdW1pbmcgaXQgaXMgZW1wdHkKKyAgICAgICAgd2Ug Y2FuIGp1c3QgY2xlYXIgdGhlIGVkaXRvciBvdXJzZWx2ZXMgYW5kIHJlZ2VuZXJhdGUgZnJvbSBw cm9wZXJ0aWVzLgorCiAyMDE1LTA2LTE5ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBNYWtlIHJ1bGUgaWNvbiB0b2dnbGUgYWxsIHBy b3BlcnRpZXMgZm9yIHRoYXQgc2VsZWN0b3Igb24gYW5kIG9mZgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVEZWNsYXJhdGlvblRl eHRFZGl0b3IuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9D U1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvci5qcwppbmRleCBlMzIyYjgxLi5hZTRiZTY3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DU1NT dHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9DU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvci5qcwpAQCAt MTA1MiwxOSArMTA1MiwxNiBAQCBXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRF ZGl0b3IgPSBjbGFzcyBDU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvcgogICAgICAgICAgICAg dmFyIHN0eWxlVGV4dCA9IHRoaXMuX3N0eWxlLnRleHQudHJpbSgpOwogICAgICAgICAgICAgdmFy IGZpbmRXaGl0ZXNwYWNlID0gL1xzKy9nOwogCi0gICAgICAgICAgICAvLyBPbmx5IGZvcm1hdCBu b24tZW1wdHkgc3R5bGVzLiBLZWVwIGluIG1pbmQgdGhhdCBzdHlsZVRleHQgaXMgYWx3YXlzIGVt cHR5Ci0gICAgICAgICAgICAvLyBmb3IgInJlYWRPbmx5IiBFZGl0b3JzLiBCdXQgcHJlcGFyZSBD aGVja2JveCBwbGFjZWhvbGRlcnMgaW4gYW55IGNhc2UuCi0gICAgICAgICAgICAvLyBCZWNhdXNl IHRoYXQgd2lsbCBpbmRlbnQgdGhlIGN1cnNvciB3aGVuIHRoZSBVc2VyIHN0YXJ0cyB0eXBpbmcu CisgICAgICAgICAgICAvLyBXZSBvbmx5IG5lZWQgdG8gZm9ybWF0IG5vbi1lbXB0eSBzdHlsZXMs IGJ1dCBwcmVwYXJlIGNoZWNrYm94IHBsYWNlaG9sZGVycworICAgICAgICAgICAgLy8gaW4gYW55 IGNhc2UgYmVjYXVzZSB0aGF0IHdpbGwgaW5kZW50IHRoZSBjdXJzb3Igd2hlbiB0aGUgVXNlciBz dGFydHMgdHlwaW5nLgogICAgICAgICAgICAgaWYgKCFzdHlsZVRleHQgJiYgIWlzRWRpdG9yUmVh ZE9ubHkpIHsKICAgICAgICAgICAgICAgICB0aGlzLl9tYXJrTGluZXNXaXRoQ2hlY2tib3hQbGFj ZWhvbGRlcigpOwogICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIH0KIAotICAg ICAgICAgICAgLy8gU2V0IG5vbi1vcHRpbWl6ZWQsIHZhbGlkIGFuZCBpbnZhbGlkIHN0eWxlcyBp biBwcmVwYXJhdGlvbiBmb3IgdGhlIEZvcm1hdHRlci4KLSAgICAgICAgICAgIC8vIFNldCBlbXB0 eSBzdHJpbmcgaW4gY2FzZSBvZiByZWFkb25seSBzdHlsZXMuCi0gICAgICAgICAgICB0aGlzLl9j b2RlTWlycm9yLnNldFZhbHVlKHN0eWxlVGV4dCk7Ci0KKyAgICAgICAgICAgIC8vIEdlbmVyYXRl IGZvcm1hdHRlZCBjb250ZW50IGZvciByZWFkb25seSBlZGl0b3JzIGJ5IGl0ZXJhdGluZyBwcm9w ZXJ0aWVzLgogICAgICAgICAgICAgaWYgKGlzRWRpdG9yUmVhZE9ubHkpIHsKKyAgICAgICAgICAg ICAgICB0aGlzLl9jb2RlTWlycm9yLnNldFZhbHVlKCIiKTsKICAgICAgICAgICAgICAgICB2YXIg bGluZU51bWJlciA9IDA7CiAgICAgICAgICAgICAgICAgdGhpcy5faXRlcmF0ZU92ZXJQcm9wZXJ0 aWVzKGZhbHNlLCBmdW5jdGlvbihwcm9wZXJ0eSkgewogICAgICAgICAgICAgICAgICAgICB2YXIg ZnJvbSA9IHtsaW5lOiBsaW5lTnVtYmVyLCBjaDogMH07CkBAIC0xMDc0LDEwICsxMDcxLDEyIEBA IFdlYkluc3BlY3Rvci5DU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvciA9IGNsYXNzIENTU1N0 eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yCiAgICAgICAgICAgICAgICAgICAgIHRoaXMuX2NyZWF0 ZVRleHRNYXJrZXJGb3JQcm9wZXJ0eUlmTmVlZGVkKGZyb20sIHRvLCBwcm9wZXJ0eSk7CiAgICAg ICAgICAgICAgICAgICAgIGxpbmVOdW1iZXIrKzsKICAgICAgICAgICAgICAgICB9KTsKLQogICAg ICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIH0KIAorICAgICAgICAgICAgLy8gU2V0 IG5vbi1vcHRpbWl6ZWQsIHZhbGlkIGFuZCBpbnZhbGlkIHN0eWxlcyBpbiBwcmVwYXJhdGlvbiBm b3IgdGhlIEZvcm1hdHRlci4KKyAgICAgICAgICAgIHRoaXMuX2NvZGVNaXJyb3Iuc2V0VmFsdWUo c3R5bGVUZXh0KTsKKwogICAgICAgICAgICAgLy8gTm93IHRoZSBGb3JtYXR0ZXIgcHJldHR5IHBy aW50cyB0aGUgc3R5bGVzLgogICAgICAgICAgICAgdGhpcy5fY29kZU1pcnJvci5zZXRWYWx1ZSh0 aGlzLl9mb3JtYXR0ZWRDb250ZW50RnJvbUVkaXRvcigpKTsKIAo=