146147 2015-06-19 07:19:29 -0700 [WinCairo] Null pointer crash in BitmapTexture::updateContents. 2022-06-21 20:12:21 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=22132 P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham cmarcelo commit-queue kondapallykalyan luiz noam ossy ys.suh oldest_to_newest 1103238 0 peavo 2015-06-19 07:19:29 -0700 When I have a lot of WebViews open, and memory usage is high (> 700MB), I often get a null pointer exception in BitmapTexture::updateContents. 1103239 1 255190 peavo 2015-06-19 07:22:56 -0700 Created attachment 255190 Patch 1103249 2 255190 bfulgham 2015-06-19 09:07:09 -0700 Comment on attachment 255190 Patch r=me. 1103250 3 bfulgham 2015-06-19 09:08:41 -0700 It looks like this null check is missing in a few places system-wide (not just WinCairo). 1103253 4 bfulgham 2015-06-19 09:43:04 -0700 This bug was originally reported back in 2008! See Bug 22132. :-) 1103266 5 255190 commit-queue 2015-06-19 10:14:11 -0700 Comment on attachment 255190 Patch Clearing flags on attachment: 255190 Committed r185752: <http://trac.webkit.org/changeset/185752> 1103267 6 commit-queue 2015-06-19 10:14:16 -0700 All reviewed patches have been landed. Closing bug. 1103582 7 peavo 2015-06-19 23:07:41 -0700 (In reply to comment #2) > Comment on attachment 255190 [details] > Patch > > r=me. Thanks! 1103591 8 peavo 2015-06-19 23:53:01 -0700 (In reply to comment #4) > This bug was originally reported back in 2008! See Bug 22132. :-) Thanks for fixing this, Brent :) 1877202 9 fujii 2022-06-21 20:12:21 -0700 *** Bug 102011 has been marked as a duplicate of this bug. *** 255190 2015-06-19 07:22:56 -0700 2015-06-19 10:14:11 -0700 Patch bug-146147-20150619162213.patch text/plain 1537 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTc0NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA2LTE5ICBQZXIgQXJu ZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dIE51bGwg cG9pbnRlciBjcmFzaCBpbiBCaXRtYXBUZXh0dXJlOjp1cGRhdGVDb250ZW50cy4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjE0NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIG51bGwgcG9pbnRl ciBjaGVjay4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9CaXRtYXBUZXh0 dXJlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkJpdG1hcFRleHR1cmU6OnVwZGF0ZUNvbnRlbnRz KToKKwogMjAxNS0wNi0xOSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgog CiAgICAgICAgIFJlbW92ZSB1bm5lY2Vzc2FyeSBzdm46ZXhlY3V0YWJsZSBmbGFncwpJbmRleDog U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0JpdG1hcFRleHR1cmUuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9C aXRtYXBUZXh0dXJlLmNwcAkocmV2aXNpb24gMTg1NzQ3KQorKysgU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0JpdG1hcFRleHR1cmUuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0zNiw2ICszNiwxMCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiB2b2lkIEJpdG1hcFRleHR1cmU6 OnVwZGF0ZUNvbnRlbnRzKFRleHR1cmVNYXBwZXIqIHRleHR1cmVNYXBwZXIsIEdyYXBoaWNzTGF5 ZXIqIHNvdXJjZUxheWVyLCBjb25zdCBJbnRSZWN0JiB0YXJnZXRSZWN0LCBjb25zdCBJbnRQb2lu dCYgb2Zmc2V0LCBVcGRhdGVDb250ZW50c0ZsYWcgdXBkYXRlQ29udGVudHNGbGFnKQogewogICAg IHN0ZDo6dW5pcXVlX3B0cjxJbWFnZUJ1ZmZlcj4gaW1hZ2VCdWZmZXIgPSBJbWFnZUJ1ZmZlcjo6 Y3JlYXRlKHRhcmdldFJlY3Quc2l6ZSgpKTsKKworICAgIGlmICghaW1hZ2VCdWZmZXIpCisgICAg ICAgIHJldHVybjsKKwogICAgIEdyYXBoaWNzQ29udGV4dCogY29udGV4dCA9IGltYWdlQnVmZmVy LT5jb250ZXh0KCk7CiAgICAgY29udGV4dC0+c2V0SW1hZ2VJbnRlcnBvbGF0aW9uUXVhbGl0eSh0 ZXh0dXJlTWFwcGVyLT5pbWFnZUludGVycG9sYXRpb25RdWFsaXR5KCkpOwogICAgIGNvbnRleHQt PnNldFRleHREcmF3aW5nTW9kZSh0ZXh0dXJlTWFwcGVyLT50ZXh0RHJhd2luZ01vZGUoKSk7Cg==