146146 2015-06-19 01:29:16 -0700 Fix the Windows build after r185721 2015-06-19 06:32:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 146118 1 ossy webkit-unassigned achristensen andersca bfulgham commit-queue koivisto ossy peavo oldest_to_newest 1103213 0 ossy 2015-06-19 01:29:16 -0700 https://trac.webkit.org/changeset/185721 broke the WinCairo build: https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/46563 ..\..\win\DumpRenderTree.cpp(1372): error C2259: 'UIDelegate' : cannot instantiate abstract class [C:\Users\Alex\Documents\WinCairoBot\win-cairo-release\build\Tools\DumpRenderTree\DumpRenderTree.vcxproj\DumpRenderTree\DumpRenderTree.vcxproj] due to following members: 'HRESULT IWebUIDelegatePrivate::unused4(void)' : is abstract C:\Users\Alex\Documents\WinCairoBot\win-cairo-release\build\WebKitBuild\Release_WinCairo\Include\WebKit/WebKit.h(33580) : see declaration of 'IWebUIDelegatePrivate::unused4' 1103217 1 ossy 2015-06-19 01:36:18 -0700 Not only the WinCairo build, but Apple Windows build is broken too: https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/70926 But unfortunately you weren't able to notice it before landing, because Windows EWS is broken a week ago. 1103228 2 peavo 2015-06-19 04:58:37 -0700 I had the same problem as the Windows EWS locally, I had to run the command cpan LWP::Protocol::https from the shell. 1103231 3 255188 peavo 2015-06-19 05:42:50 -0700 Created attachment 255188 Patch 1103232 4 255188 ossy 2015-06-19 05:45:37 -0700 Comment on attachment 255188 Patch rs=me 1103233 5 peavo 2015-06-19 05:46:14 -0700 (In reply to comment #4) > Comment on attachment 255188 [details] > Patch > > rs=me Thanks! 1103234 6 255188 commit-queue 2015-06-19 06:32:35 -0700 Comment on attachment 255188 Patch Clearing flags on attachment: 255188 Committed r185747: <http://trac.webkit.org/changeset/185747> 1103235 7 commit-queue 2015-06-19 06:32:41 -0700 All reviewed patches have been landed. Closing bug. 255188 2015-06-19 05:42:50 -0700 2015-06-19 06:32:35 -0700 Patch bug-146146-20150619144207.patch text/plain 1687 peavo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4NTc0NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE1LTA2LTE5ICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNv bT4KKworICAgICAgICBGaXggdGhlIFdpbmRvd3MgYnVpbGQgYWZ0ZXIgcjE4NTcyMQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2MTQ2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3BlY3VsYXRpdmUgYnVp bGRmaXguCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS93aW4vVUlEZWxlZ2F0ZS5oOgorICAg ICAgICAoVUlEZWxlZ2F0ZTo6dW51c2VkNCk6IEFkZGVkLgorICAgICAgICAoVUlEZWxlZ2F0ZTo6 d2ViVmlld1Nob3VsZEludGVycnVwdEphdmFTY3JpcHQpOiBEZWxldGVkLgorCiAyMDE1LTA2LTE5 ICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZC4gQWRkIG15c2VsZiBhcyBhIGNvbW1pdHRlci4KSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJU cmVlL3dpbi9VSURlbGVnYXRlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUv d2luL1VJRGVsZWdhdGUuaAkocmV2aXNpb24gMTg1NzQ2KQorKysgVG9vbHMvRHVtcFJlbmRlclRy ZWUvd2luL1VJRGVsZWdhdGUuaAkod29ya2luZyBjb3B5KQpAQCAtMzE3LDcgKzMxNyw5IEBAIHBy b3RlY3RlZDoKICAgICB2aXJ0dWFsIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgdW51c2VkMigp IHsgcmV0dXJuIEVfTk9USU1QTDsgfQogICAgIAogICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRI T0RDQUxMVFlQRSB1bnVzZWQzKCkgeyByZXR1cm4gRV9OT1RJTVBMOyB9Ci0gICAgCisKKyAgICB2 aXJ0dWFsIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgdW51c2VkNCgpIHsgcmV0dXJuIEVfTk9U SU1QTDsgfQorCiAgICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIHdlYlZpZXdT Y3JvbGxlZCggCiAgICAgICAgIC8qIFtpbl0gKi8gSVdlYlZpZXcgKnNlbmRlcikgeyByZXR1cm4g RV9OT1RJTVBMOyB9CiAgICAgCkBAIC0zMjgsMTAgKzMzMCw2IEBAIHByb3RlY3RlZDoKICAgICAg ICAgLyogW2luXSAqLyBCU1RSIHVybCwKICAgICAgICAgLyogW2luXSAqLyBCT09MIGlzRXJyb3Ip OwogICAgIAotICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSB3ZWJWaWV3U2hv dWxkSW50ZXJydXB0SmF2YVNjcmlwdCggCi0gICAgICAgIC8qIFtpbl0gKi8gSVdlYlZpZXcgKnNl bmRlciwKLSAgICAgICAgLyogW3JldHZhbF1bb3V0XSAqLyBCT09MICpyZXN1bHQpIHsgcmV0dXJu IEVfTk9USU1QTDsgfQotICAgIAogICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQ RSB3ZWJWaWV3UmVjZWl2ZWRGb2N1cyggCiAgICAgICAgIC8qIFtpbl0gKi8gSVdlYlZpZXcgKnNl bmRlcikgeyByZXR1cm4gRV9OT1RJTVBMOyB9CiAgICAgCg==