146143 2015-06-18 23:46:11 -0700 [WK2] ConnectionUnix should use FastMalloc to allocate on-heap resources 2015-06-22 05:07:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan cgarcia commit-queue mrobinson svillar oldest_to_newest 1103193 0 zan 2015-06-18 23:46:11 -0700 [WK2] ConnectionUnix should use FastMalloc to allocate on-heap resources 1103195 1 255180 zan 2015-06-19 00:00:31 -0700 Created attachment 255180 Patch 1103198 2 commit-queue 2015-06-19 00:03:43 -0700 Attachment 255180 did not pass style-queue: ERROR: Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:449: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1103204 3 255180 cgarcia 2015-06-19 00:37:55 -0700 Comment on attachment 255180 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255180&action=review > Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:451 > + size_t attachmentFDBufferLength = std::count_if(attachments.begin(), attachments.end(), > + [](const Attachment& attachment) { > + return attachment.fileDescriptor() != -1; > + }); Cool 1103808 4 255180 zan 2015-06-22 05:07:34 -0700 Comment on attachment 255180 Patch Clearing flags on attachment: 255180 Committed r185824: <http://trac.webkit.org/changeset/185824> 1103810 5 zan 2015-06-22 05:07:51 -0700 All reviewed patches have been landed. Closing bug. 255180 2015-06-19 00:00:31 -0700 2015-06-22 05:07:34 -0700 Patch bug-146143-20150618235952.patch text/plain 4561 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NzM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTRhZmJjZjUzY2U3OTgx ZGZjZDQ5ZWIzZDI0OGU5OGQ5MmRiMDI1YS4uY2VhMzhjMWQxNWZmNzczZWQzMGZjZDRmOTAwYmQz MTlkZDIxNWI0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDE1LTA2LTE4ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbV0syXSBDb25uZWN0 aW9uVW5peCBzaG91bGQgdXNlIEZhc3RNYWxsb2MgdG8gYWxsb2NhdGUgb24taGVhcCByZXNvdXJj ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjE0 MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElQQyBo YW5kbGluZyBpbiBVbml4LXNwZWNpZmljIElQQzo6Q29ubmVjdGlvbiBpbXBsZW1lbnRhdGlvbiBz aG91bGQgdXNlCisgICAgICAgIEZhc3RNYWxsb2MgdG8gYWxsb2NhdGUgb24taGVhcCByZXNvdXJj ZXMsIGluc3RlYWQgb2YgYWxsb2NhdGluZyB2aWEgdGhlCisgICAgICAgIHN5c3RlbSBhbGxvY2F0 b3IuCisKKyAgICAgICAgVGhlIEF0dGFjaG1lbnRJbmZvIGNsYXNzIGlzIG1hcmtlZCBhcyBhbGxv Y2F0YWJsZSB0aHJvdWdoIEZhc3RNYWxsb2MuCisgICAgICAgIFRoYXQgd2F5IGl0IGNhbiBiZSBh bGxvY2F0ZWQgdGhyb3VnaCBGYXN0TWFsbG9jIHdoaWxlIHN0aWxsIGhhbmRsZWQKKyAgICAgICAg dGhyb3VnaCBzdGQ6OnVuaXF1ZV9wdHI8Pi4KKworICAgICAgICBUaGUgY2hhcltdIGFycmF5cyBp biByZWFkQnl0ZXNGcm9tU29ja2V0KCkgYW5kIENvbm5lY3Rpb246OnNlbmRPdXRnb2luZ01lc3Nh Z2UoKQorICAgICAgICBhcmUgbm93IGhhbmRsZWQgdGhyb3VnaCBhIE1hbGxvY1B0cjw+IG9iamVj dC4KKworICAgICAgICBJbiBDb25uZWN0aW9uOjpzZW5kT3V0Z29pbmdNZXNzYWdlKCksIGJvdGgg dGhlIEF0dGFjaG1lbnRJbmZvW10gYW5kIGNoYXJbXQorICAgICAgICBhcnJheXMgYXJlIG5vdyBv bmx5IGFsbG9jYXRlZCBpZiB0aGVyZSBhcmUgYWN0dWFsIGF0dGFjaG1lbnRzIGNvbnRhaW5lZAor ICAgICAgICBpbiB0aGUgbWVzc2FnZS4gVGhlIGNvZGUgdGhhdCdzIGNvbmRpdGlvbmVkIHdpdGgg YSBub24tZW1wdHkgYXR0YWNobWVudHMKKyAgICAgICAgVmVjdG9yIGlzIG5vdyBhbHNvIGdyb3Vw ZWQgdG9nZXRoZXIsIGluIGEgc2luZ2xlIGJyYW5jaC4KKworICAgICAgICAqIFBsYXRmb3JtL0lQ Qy91bml4L0Nvbm5lY3Rpb25Vbml4LmNwcDoKKyAgICAgICAgKElQQzo6cmVhZEJ5dGVzRnJvbVNv Y2tldCk6CisgICAgICAgIChJUEM6OkNvbm5lY3Rpb246OnNlbmRPdXRnb2luZ01lc3NhZ2UpOgor CiAyMDE1LTA2LTE4ICBKb24gTGVlICA8am9ubGVlQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRh dGUgQVZLaXQgdXNhZ2Ugb2YgcGlwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9y bS9JUEMvdW5peC9Db25uZWN0aW9uVW5peC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9J UEMvdW5peC9Db25uZWN0aW9uVW5peC5jcHAKaW5kZXggYTUzYWZjNzIyYTY5NTc4ZjQ2Mzc2MWU1 ZDc1ZWQ4MWQxYTI2OGM5OS4uNTZhYjVhMzM5NDQ2YWRlYjI5ZjE4YmIyZWYwYmFkYzUyMDg4MDRk ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vSVBDL3VuaXgvQ29ubmVjdGlv blVuaXguY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy91bml4L0Nvbm5lY3Rp b25Vbml4LmNwcApAQCAtOTQsNiArOTQsNyBAQCBwcml2YXRlOgogfTsKIAogY2xhc3MgQXR0YWNo bWVudEluZm8geworICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgogICAgIEF0 dGFjaG1lbnRJbmZvKCkKICAgICAgICAgOiBtX3R5cGUoQXR0YWNobWVudDo6VW5pbml0aWFsaXpl ZCkKQEAgLTI3NCw4ICsyNzUsOCBAQCBzdGF0aWMgc3NpemVfdCByZWFkQnl0ZXNGcm9tU29ja2V0 KGludCBzb2NrZXREZXNjcmlwdG9yLCB1aW50OF90KiBidWZmZXIsIGludCBjbwogICAgIG1lbXNl dCgmaW92LCAwLCBzaXplb2YoaW92KSk7CiAKICAgICBtZXNzYWdlLm1zZ19jb250cm9sbGVuID0g Q01TR19TUEFDRShzaXplb2YoaW50KSAqIGF0dGFjaG1lbnRNYXhBbW91bnQpOwotICAgIGF1dG8g YXR0YWNobWVudERlc2NyaXB0b3JCdWZmZXIgPSBzdGQ6Om1ha2VfdW5pcXVlPGNoYXJbXT4obWVz c2FnZS5tc2dfY29udHJvbGxlbik7Ci0gICAgbWVtc2V0KGF0dGFjaG1lbnREZXNjcmlwdG9yQnVm ZmVyLmdldCgpLCAwLCBtZXNzYWdlLm1zZ19jb250cm9sbGVuKTsKKyAgICBNYWxsb2NQdHI8Y2hh cj4gYXR0YWNobWVudERlc2NyaXB0b3JCdWZmZXIgPSBNYWxsb2NQdHI8Y2hhcj46Om1hbGxvYyhz aXplb2YoY2hhcikgKiBtZXNzYWdlLm1zZ19jb250cm9sbGVuKTsKKyAgICBtZW1zZXQoYXR0YWNo bWVudERlc2NyaXB0b3JCdWZmZXIuZ2V0KCksIDAsIHNpemVvZihjaGFyKSAqIG1lc3NhZ2UubXNn X2NvbnRyb2xsZW4pOwogICAgIG1lc3NhZ2UubXNnX2NvbnRyb2wgPSBhdHRhY2htZW50RGVzY3Jp cHRvckJ1ZmZlci5nZXQoKTsKIAogICAgIGlvdlswXS5pb3ZfYmFzZSA9IGJ1ZmZlcjsKQEAgLTQz OCwyMSArNDM5LDIwIEBAIGJvb2wgQ29ubmVjdGlvbjo6c2VuZE91dGdvaW5nTWVzc2FnZShzdGQ6 OnVuaXF1ZV9wdHI8TWVzc2FnZUVuY29kZXI+IGVuY29kZXIpCiAgICAgaW92WzBdLmlvdl9iYXNl ID0gcmVpbnRlcnByZXRfY2FzdDx2b2lkKj4oJm1lc3NhZ2VJbmZvKTsKICAgICBpb3ZbMF0uaW92 X2xlbiA9IHNpemVvZihtZXNzYWdlSW5mbyk7CiAKLSAgICBhdXRvIGF0dGFjaG1lbnRJbmZvID0g c3RkOjptYWtlX3VuaXF1ZTxBdHRhY2htZW50SW5mb1tdPihhdHRhY2htZW50cy5zaXplKCkpOwot Ci0gICAgc2l6ZV90IGF0dGFjaG1lbnRGREJ1ZmZlckxlbmd0aCA9IDA7Ci0gICAgaWYgKCFhdHRh Y2htZW50cy5pc0VtcHR5KCkpIHsKLSAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBhdHRh Y2htZW50cy5zaXplKCk7ICsraSkgewotICAgICAgICAgICAgaWYgKGF0dGFjaG1lbnRzW2ldLmZp bGVEZXNjcmlwdG9yKCkgIT0gLTEpCi0gICAgICAgICAgICAgICAgYXR0YWNobWVudEZEQnVmZmVy TGVuZ3RoKys7Ci0gICAgICAgIH0KLSAgICB9Ci0gICAgYXV0byBhdHRhY2htZW50RkRCdWZmZXIg PSBzdGQ6Om1ha2VfdW5pcXVlPGNoYXJbXT4oQ01TR19TUEFDRShzaXplb2YoaW50KSAqIGF0dGFj aG1lbnRGREJ1ZmZlckxlbmd0aCkpOworICAgIHN0ZDo6dW5pcXVlX3B0cjxBdHRhY2htZW50SW5m b1tdPiBhdHRhY2htZW50SW5mbzsKKyAgICBNYWxsb2NQdHI8Y2hhcj4gYXR0YWNobWVudEZEQnVm ZmVyOwogCiAgICAgaWYgKCFhdHRhY2htZW50cy5pc0VtcHR5KCkpIHsKICAgICAgICAgaW50KiBm ZFB0ciA9IDA7CiAKKyAgICAgICAgc2l6ZV90IGF0dGFjaG1lbnRGREJ1ZmZlckxlbmd0aCA9IHN0 ZDo6Y291bnRfaWYoYXR0YWNobWVudHMuYmVnaW4oKSwgYXR0YWNobWVudHMuZW5kKCksCisgICAg ICAgICAgICBbXShjb25zdCBBdHRhY2htZW50JiBhdHRhY2htZW50KSB7CisgICAgICAgICAgICAg ICAgcmV0dXJuIGF0dGFjaG1lbnQuZmlsZURlc2NyaXB0b3IoKSAhPSAtMTsKKyAgICAgICAgICAg IH0pOworCiAgICAgICAgIGlmIChhdHRhY2htZW50RkRCdWZmZXJMZW5ndGgpIHsKKyAgICAgICAg ICAgIGF0dGFjaG1lbnRGREJ1ZmZlciA9IE1hbGxvY1B0cjxjaGFyPjo6bWFsbG9jKHNpemVvZihj aGFyKSAqIENNU0dfU1BBQ0Uoc2l6ZW9mKGludCkgKiBhdHRhY2htZW50RkRCdWZmZXJMZW5ndGgp KTsKKwogICAgICAgICAgICAgbWVzc2FnZS5tc2dfY29udHJvbCA9IGF0dGFjaG1lbnRGREJ1ZmZl ci5nZXQoKTsKICAgICAgICAgICAgIG1lc3NhZ2UubXNnX2NvbnRyb2xsZW4gPSBDTVNHX1NQQUNF KHNpemVvZihpbnQpICogYXR0YWNobWVudEZEQnVmZmVyTGVuZ3RoKTsKICAgICAgICAgICAgIG1l bXNldChtZXNzYWdlLm1zZ19jb250cm9sLCAwLCBtZXNzYWdlLm1zZ19jb250cm9sbGVuKTsKQEAg LTQ2NSw2ICs0NjUsNyBAQCBib29sIENvbm5lY3Rpb246OnNlbmRPdXRnb2luZ01lc3NhZ2Uoc3Rk Ojp1bmlxdWVfcHRyPE1lc3NhZ2VFbmNvZGVyPiBlbmNvZGVyKQogICAgICAgICAgICAgZmRQdHIg PSByZWludGVycHJldF9jYXN0PGludCo+KENNU0dfREFUQShjbXNnKSk7CiAgICAgICAgIH0KIAor ICAgICAgICBhdHRhY2htZW50SW5mbyA9IHN0ZDo6bWFrZV91bmlxdWU8QXR0YWNobWVudEluZm9b XT4oYXR0YWNobWVudHMuc2l6ZSgpKTsKICAgICAgICAgaW50IGZkSW5kZXggPSAwOwogICAgICAg ICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGF0dGFjaG1lbnRzLnNpemUoKTsgKytpKSB7CiAgICAg ICAgICAgICBhdHRhY2htZW50SW5mb1tpXS5zZXRUeXBlKGF0dGFjaG1lbnRzW2ldLnR5cGUoKSk7 Cg==