146141 2015-06-18 22:49:44 -0700 Web Inspector: Avoid getOwnPropertyNames/Symbols on very large lists 2015-06-19 01:06:42 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck burg commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1103176 0 joepeck 2015-06-18 22:49:44 -0700 * SUMMARY Avoid getOwnPropertyNames/Symbols on very large lists. Note that better handling of large lists in general should be handled by: <https://webkit.org/b/143589> Web Inspector: Better handling for large collections in Object Trees For now, lets not hang / out of memory trying to build a list of all the property names in a multi-million element list. * STEPS TO REPRODUCE 1. js> var buffer = new ArrayBuffer(10000000); var int8View = new Int8Array(buffer); int8View => hang (Web Content Process's memory grows, attempting to get property names for a preview) 2. js> var buffer = new ArrayBuffer(10000000); var int8View = new Int8Array(buffer); 3. Type: "int8View." => hang (Web Content Process's memory grows, attempting to get property names for autocompletion) 1103179 1 joepeck 2015-06-18 22:56:55 -0700 <rdar://problem/21233251> 1103181 2 255175 joepeck 2015-06-18 22:57:48 -0700 Created attachment 255175 [PATCH] Proposed Fix 1103207 3 255175 commit-queue 2015-06-19 01:06:37 -0700 Comment on attachment 255175 [PATCH] Proposed Fix Clearing flags on attachment: 255175 Committed r185741: <http://trac.webkit.org/changeset/185741> 1103208 4 commit-queue 2015-06-19 01:06:42 -0700 All reviewed patches have been landed. Closing bug. 255175 2015-06-18 22:57:48 -0700 2015-06-19 01:06:37 -0700 [PATCH] Proposed Fix large-lists.patch text/plain 15299 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0OTcyMzhhLi5mZDYzODIzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTUtMDYt MTggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIg SW5zcGVjdG9yOiBBdm9pZCBnZXRPd25Qcm9wZXJ0eU5hbWVzL1N5bWJvbHMgb24gdmVyeSBsYXJn ZSBsaXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQ2MTQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBpbnNwZWN0b3IvbW9kZWwvcmVtb3RlLW9iamVjdC1leHBlY3RlZC50eHQ6CisgICAgICAgICog aW5zcGVjdG9yL21vZGVsL3JlbW90ZS1vYmplY3QuaHRtbDoKKyAgICAgICAgVGhlcmUgd2VyZSBl eGlzdGluZyBwcm9ncmVzc2lvbnMgKDAgPT4gLTEpLgorICAgICAgICBUaGVyZSB3ZXJlIGV4aXN0 aW5nIHJlZ3Jlc3Npb25zIChSZWdFeHAgcHJvcGVydGllcyBtb3ZpbmcgdG8gcHJvdG90eXBlIHdp dGggZGVzY3JpcHRvcnMgb24gdGhlIHByb3RvdHlwZSkuCisgICAgICAgIEFkZCBhIHRlc3QgZm9y IGEgdmVyeSBsYXJnZSBsaXN0IHRoYXQgd291bGQgaGF2ZSBjYXVzZWQgb3V0IG9mIG1lbW9yeSAv IGhhbmcuCisKIDIwMTUtMDYtMTggIEt5dW5nVGFlIEtpbSAgPGt0Zi5raW1Ac2Ftc3VuZy5jb20+ IGFuZCBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAg W0NTUzNdIEFkZCBzdXBwb3J0IGZvciB0aGUgd29yZC1icmVhazprZWVwLWFsbCBDU1MgcHJvcGVy dHkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9tb2RlbC9yZW1vdGUtb2JqZWN0 LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9tb2RlbC9yZW1vdGUtb2JqZWN0 LWV4cGVjdGVkLnR4dAppbmRleCA3YTlhMGFkLi42Y2QzNDBiIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9pbnNwZWN0b3IvbW9kZWwvcmVtb3RlLW9iamVjdC1leHBlY3RlZC50eHQKKysrIGIvTGF5 b3V0VGVzdHMvaW5zcGVjdG9yL21vZGVsL3JlbW90ZS1vYmplY3QtZXhwZWN0ZWQudHh0CkBAIC0y NzMsMjYgKzI3Myw2IEBAIEVYUFJFU1NJT046IC8gLwogICAgICAgICAiX25hbWUiOiAibGFzdElu ZGV4IiwKICAgICAgICAgIl90eXBlIjogIm51bWJlciIsCiAgICAgICAgICJfdmFsdWUiOiAiMCIK LSAgICAgIH0sCi0gICAgICB7Ci0gICAgICAgICJfbmFtZSI6ICJnbG9iYWwiLAotICAgICAgICAi X3R5cGUiOiAiYm9vbGVhbiIsCi0gICAgICAgICJfdmFsdWUiOiAiZmFsc2UiCi0gICAgICB9LAot ICAgICAgewotICAgICAgICAiX25hbWUiOiAiaWdub3JlQ2FzZSIsCi0gICAgICAgICJfdHlwZSI6 ICJib29sZWFuIiwKLSAgICAgICAgIl92YWx1ZSI6ICJmYWxzZSIKLSAgICAgIH0sCi0gICAgICB7 Ci0gICAgICAgICJfbmFtZSI6ICJtdWx0aWxpbmUiLAotICAgICAgICAiX3R5cGUiOiAiYm9vbGVh biIsCi0gICAgICAgICJfdmFsdWUiOiAiZmFsc2UiCi0gICAgICB9LAotICAgICAgewotICAgICAg ICAiX25hbWUiOiAic291cmNlIiwKLSAgICAgICAgIl90eXBlIjogInN0cmluZyIsCi0gICAgICAg ICJfdmFsdWUiOiAiICIKICAgICAgIH0KICAgICBdLAogICAgICJfZW50cmllcyI6IG51bGwKQEAg LTMxNywyNiArMjk3LDYgQEAgRVhQUkVTU0lPTjogLyg/OikvCiAgICAgICAgICJfbmFtZSI6ICJs YXN0SW5kZXgiLAogICAgICAgICAiX3R5cGUiOiAibnVtYmVyIiwKICAgICAgICAgIl92YWx1ZSI6 ICIwIgotICAgICAgfSwKLSAgICAgIHsKLSAgICAgICAgIl9uYW1lIjogImdsb2JhbCIsCi0gICAg ICAgICJfdHlwZSI6ICJib29sZWFuIiwKLSAgICAgICAgIl92YWx1ZSI6ICJmYWxzZSIKLSAgICAg IH0sCi0gICAgICB7Ci0gICAgICAgICJfbmFtZSI6ICJpZ25vcmVDYXNlIiwKLSAgICAgICAgIl90 eXBlIjogImJvb2xlYW4iLAotICAgICAgICAiX3ZhbHVlIjogImZhbHNlIgotICAgICAgfSwKLSAg ICAgIHsKLSAgICAgICAgIl9uYW1lIjogIm11bHRpbGluZSIsCi0gICAgICAgICJfdHlwZSI6ICJi b29sZWFuIiwKLSAgICAgICAgIl92YWx1ZSI6ICJmYWxzZSIKLSAgICAgIH0sCi0gICAgICB7Ci0g ICAgICAgICJfbmFtZSI6ICJzb3VyY2UiLAotICAgICAgICAiX3R5cGUiOiAic3RyaW5nIiwKLSAg ICAgICAgIl92YWx1ZSI6ICIoPzopIgogICAgICAgfQogICAgIF0sCiAgICAgIl9lbnRyaWVzIjog bnVsbApAQCAtMzYxLDI2ICszMjEsNiBAQCBFWFBSRVNTSU9OOiAvXnIoZSlnW2VdezEsfXgrLwog ICAgICAgICAiX25hbWUiOiAibGFzdEluZGV4IiwKICAgICAgICAgIl90eXBlIjogIm51bWJlciIs CiAgICAgICAgICJfdmFsdWUiOiAiMCIKLSAgICAgIH0sCi0gICAgICB7Ci0gICAgICAgICJfbmFt ZSI6ICJnbG9iYWwiLAotICAgICAgICAiX3R5cGUiOiAiYm9vbGVhbiIsCi0gICAgICAgICJfdmFs dWUiOiAiZmFsc2UiCi0gICAgICB9LAotICAgICAgewotICAgICAgICAiX25hbWUiOiAiaWdub3Jl Q2FzZSIsCi0gICAgICAgICJfdHlwZSI6ICJib29sZWFuIiwKLSAgICAgICAgIl92YWx1ZSI6ICJm YWxzZSIKLSAgICAgIH0sCi0gICAgICB7Ci0gICAgICAgICJfbmFtZSI6ICJtdWx0aWxpbmUiLAot ICAgICAgICAiX3R5cGUiOiAiYm9vbGVhbiIsCi0gICAgICAgICJfdmFsdWUiOiAiZmFsc2UiCi0g ICAgICB9LAotICAgICAgewotICAgICAgICAiX25hbWUiOiAic291cmNlIiwKLSAgICAgICAgIl90 eXBlIjogInN0cmluZyIsCi0gICAgICAgICJfdmFsdWUiOiAiXnIoZSlnW2VdezEsfXgrIgogICAg ICAgfQogICAgIF0sCiAgICAgIl9lbnRyaWVzIjogbnVsbApAQCAtNDA1LDI2ICszNDUsNiBAQCBF WFBSRVNTSU9OOiAvXnIoZSlnW2VdezEsfXgrL2lnCiAgICAgICAgICJfbmFtZSI6ICJsYXN0SW5k ZXgiLAogICAgICAgICAiX3R5cGUiOiAibnVtYmVyIiwKICAgICAgICAgIl92YWx1ZSI6ICIwIgot ICAgICAgfSwKLSAgICAgIHsKLSAgICAgICAgIl9uYW1lIjogImdsb2JhbCIsCi0gICAgICAgICJf dHlwZSI6ICJib29sZWFuIiwKLSAgICAgICAgIl92YWx1ZSI6ICJ0cnVlIgotICAgICAgfSwKLSAg ICAgIHsKLSAgICAgICAgIl9uYW1lIjogImlnbm9yZUNhc2UiLAotICAgICAgICAiX3R5cGUiOiAi Ym9vbGVhbiIsCi0gICAgICAgICJfdmFsdWUiOiAidHJ1ZSIKLSAgICAgIH0sCi0gICAgICB7Ci0g ICAgICAgICJfbmFtZSI6ICJtdWx0aWxpbmUiLAotICAgICAgICAiX3R5cGUiOiAiYm9vbGVhbiIs Ci0gICAgICAgICJfdmFsdWUiOiAiZmFsc2UiCi0gICAgICB9LAotICAgICAgewotICAgICAgICAi X25hbWUiOiAic291cmNlIiwKLSAgICAgICAgIl90eXBlIjogInN0cmluZyIsCi0gICAgICAgICJf dmFsdWUiOiAiXnIoZSlnW2VdezEsfXgrIgogICAgICAgfQogICAgIF0sCiAgICAgIl9lbnRyaWVz IjogbnVsbApAQCAtNDQ5LDI2ICszNjksNiBAQCBFWFBSRVNTSU9OOiBuZXcgUmVnRXhwKCcnKQog ICAgICAgICAiX25hbWUiOiAibGFzdEluZGV4IiwKICAgICAgICAgIl90eXBlIjogIm51bWJlciIs CiAgICAgICAgICJfdmFsdWUiOiAiMCIKLSAgICAgIH0sCi0gICAgICB7Ci0gICAgICAgICJfbmFt ZSI6ICJnbG9iYWwiLAotICAgICAgICAiX3R5cGUiOiAiYm9vbGVhbiIsCi0gICAgICAgICJfdmFs dWUiOiAiZmFsc2UiCi0gICAgICB9LAotICAgICAgewotICAgICAgICAiX25hbWUiOiAiaWdub3Jl Q2FzZSIsCi0gICAgICAgICJfdHlwZSI6ICJib29sZWFuIiwKLSAgICAgICAgIl92YWx1ZSI6ICJm YWxzZSIKLSAgICAgIH0sCi0gICAgICB7Ci0gICAgICAgICJfbmFtZSI6ICJtdWx0aWxpbmUiLAot ICAgICAgICAiX3R5cGUiOiAiYm9vbGVhbiIsCi0gICAgICAgICJfdmFsdWUiOiAiZmFsc2UiCi0g ICAgICB9LAotICAgICAgewotICAgICAgICAiX25hbWUiOiAic291cmNlIiwKLSAgICAgICAgIl90 eXBlIjogInN0cmluZyIsCi0gICAgICAgICJfdmFsdWUiOiAiKD86KSIKICAgICAgIH0KICAgICBd LAogICAgICJfZW50cmllcyI6IG51bGwKQEAgLTQ5MywyNiArMzkzLDYgQEAgRVhQUkVTU0lPTjog bmV3IFJlZ0V4cCgndGVzdCcsICdpJykKICAgICAgICAgIl9uYW1lIjogImxhc3RJbmRleCIsCiAg ICAgICAgICJfdHlwZSI6ICJudW1iZXIiLAogICAgICAgICAiX3ZhbHVlIjogIjAiCi0gICAgICB9 LAotICAgICAgewotICAgICAgICAiX25hbWUiOiAiZ2xvYmFsIiwKLSAgICAgICAgIl90eXBlIjog ImJvb2xlYW4iLAotICAgICAgICAiX3ZhbHVlIjogImZhbHNlIgotICAgICAgfSwKLSAgICAgIHsK LSAgICAgICAgIl9uYW1lIjogImlnbm9yZUNhc2UiLAotICAgICAgICAiX3R5cGUiOiAiYm9vbGVh biIsCi0gICAgICAgICJfdmFsdWUiOiAidHJ1ZSIKLSAgICAgIH0sCi0gICAgICB7Ci0gICAgICAg ICJfbmFtZSI6ICJtdWx0aWxpbmUiLAotICAgICAgICAiX3R5cGUiOiAiYm9vbGVhbiIsCi0gICAg ICAgICJfdmFsdWUiOiAiZmFsc2UiCi0gICAgICB9LAotICAgICAgewotICAgICAgICAiX25hbWUi OiAic291cmNlIiwKLSAgICAgICAgIl90eXBlIjogInN0cmluZyIsCi0gICAgICAgICJfdmFsdWUi OiAidGVzdCIKICAgICAgIH0KICAgICBdLAogICAgICJfZW50cmllcyI6IG51bGwKQEAgLTU2Myw3 ICs0NDMsNyBAQCBFWFBSRVNTSU9OOiBbMCwgLTAsIDEsIDJdCiAgICAgICB7CiAgICAgICAgICJf bmFtZSI6ICIxIiwKICAgICAgICAgIl90eXBlIjogIm51bWJlciIsCi0gICAgICAgICJfdmFsdWUi OiAiMCIKKyAgICAgICAgIl92YWx1ZSI6ICItMCIKICAgICAgIH0sCiAgICAgICB7CiAgICAgICAg ICJfbmFtZSI6ICIyIiwKQEAgLTExOTksNiArMTA3OSw3NyBAQCBFWFBSRVNTSU9OOiB2YXIgaW50 QXJyYXkgPSBuZXcgSW50MzJBcnJheShuZXcgQXJyYXlCdWZmZXIoMTYpKTsgZm9yICh2YXIgaSA9 IDA7CiB9CiAKIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tCitFWFBSRVNTSU9OOiB2YXIgYnVmZmVyID0gbmV3IEFycmF5QnVmZmVyKDEwMDAwMDAw KTsgdmFyIGludDhWaWV3ID0gbmV3IEludDhBcnJheShidWZmZXIpOyBpbnQ4VmlldworeworICAi X3R5cGUiOiAib2JqZWN0IiwKKyAgIl9zdWJ0eXBlIjogImFycmF5IiwKKyAgIl9vYmplY3RJZCI6 ICI8ZmlsdGVyZWQ+IiwKKyAgIl9kZXNjcmlwdGlvbiI6ICJJbnQ4QXJyYXkiLAorICAiX3NpemUi OiAxMDAwMDAwMCwKKyAgIl9wcmV2aWV3IjogeworICAgICJfdHlwZSI6ICJvYmplY3QiLAorICAg ICJfc3VidHlwZSI6ICJhcnJheSIsCisgICAgIl9kZXNjcmlwdGlvbiI6ICJJbnQ4QXJyYXkiLAor ICAgICJfbG9zc2xlc3MiOiBmYWxzZSwKKyAgICAiX292ZXJmbG93IjogdHJ1ZSwKKyAgICAiX3Np emUiOiAxMDAwMDAwMCwKKyAgICAiX3Byb3BlcnRpZXMiOiBbCisgICAgICB7CisgICAgICAgICJf bmFtZSI6ICIwIiwKKyAgICAgICAgIl90eXBlIjogIm51bWJlciIsCisgICAgICAgICJfdmFsdWUi OiAiMCIKKyAgICAgIH0sCisgICAgICB7CisgICAgICAgICJfbmFtZSI6ICIxIiwKKyAgICAgICAg Il90eXBlIjogIm51bWJlciIsCisgICAgICAgICJfdmFsdWUiOiAiMCIKKyAgICAgIH0sCisgICAg ICB7CisgICAgICAgICJfbmFtZSI6ICIyIiwKKyAgICAgICAgIl90eXBlIjogIm51bWJlciIsCisg ICAgICAgICJfdmFsdWUiOiAiMCIKKyAgICAgIH0sCisgICAgICB7CisgICAgICAgICJfbmFtZSI6 ICIzIiwKKyAgICAgICAgIl90eXBlIjogIm51bWJlciIsCisgICAgICAgICJfdmFsdWUiOiAiMCIK KyAgICAgIH0sCisgICAgICB7CisgICAgICAgICJfbmFtZSI6ICI0IiwKKyAgICAgICAgIl90eXBl IjogIm51bWJlciIsCisgICAgICAgICJfdmFsdWUiOiAiMCIKKyAgICAgIH0sCisgICAgICB7Cisg ICAgICAgICJfbmFtZSI6ICI1IiwKKyAgICAgICAgIl90eXBlIjogIm51bWJlciIsCisgICAgICAg ICJfdmFsdWUiOiAiMCIKKyAgICAgIH0sCisgICAgICB7CisgICAgICAgICJfbmFtZSI6ICI2IiwK KyAgICAgICAgIl90eXBlIjogIm51bWJlciIsCisgICAgICAgICJfdmFsdWUiOiAiMCIKKyAgICAg IH0sCisgICAgICB7CisgICAgICAgICJfbmFtZSI6ICI3IiwKKyAgICAgICAgIl90eXBlIjogIm51 bWJlciIsCisgICAgICAgICJfdmFsdWUiOiAiMCIKKyAgICAgIH0sCisgICAgICB7CisgICAgICAg ICJfbmFtZSI6ICI4IiwKKyAgICAgICAgIl90eXBlIjogIm51bWJlciIsCisgICAgICAgICJfdmFs dWUiOiAiMCIKKyAgICAgIH0sCisgICAgICB7CisgICAgICAgICJfbmFtZSI6ICI5IiwKKyAgICAg ICAgIl90eXBlIjogIm51bWJlciIsCisgICAgICAgICJfdmFsdWUiOiAiMCIKKyAgICAgIH0KKyAg ICBdLAorICAgICJfZW50cmllcyI6IG51bGwKKyAgfQorfQorCistLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogRVhQUkVTU0lPTjogKHt9KQogewog ICAiX3R5cGUiOiAib2JqZWN0IiwKQEAgLTEyNjEsNyArMTIxMiw3IEBAIEVYUFJFU1NJT046ICh7 YTogMSwgYjogMCwgYzogLTB9KQogICAgICAgewogICAgICAgICAiX25hbWUiOiAiYyIsCiAgICAg ICAgICJfdHlwZSI6ICJudW1iZXIiLAotICAgICAgICAiX3ZhbHVlIjogIjAiCisgICAgICAgICJf dmFsdWUiOiAiLTAiCiAgICAgICB9CiAgICAgXSwKICAgICAiX2VudHJpZXMiOiBudWxsCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvbW9kZWwvcmVtb3RlLW9iamVjdC5odG1sIGIv TGF5b3V0VGVzdHMvaW5zcGVjdG9yL21vZGVsL3JlbW90ZS1vYmplY3QuaHRtbAppbmRleCBkMGY2 ZDZjLi45ZDMzODllIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvbW9kZWwvcmVt b3RlLW9iamVjdC5odG1sCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9tb2RlbC9yZW1vdGUt b2JqZWN0Lmh0bWwKQEAgLTg3LDYgKzg3LDcgQEAgZnVuY3Rpb24gdGVzdCgpCiAgICAgICAgIHtl eHByZXNzaW9uOiAiYSA9IG51bGw7IChmdW5jdGlvbigpIHsgYSA9IGFyZ3VtZW50czsgfSkoMSwg JzInLCAvMy8pOyBhIn0sCiAgICAgICAgIHtleHByZXNzaW9uOiAibmV3IEludDMyQXJyYXkobmV3 IEFycmF5QnVmZmVyKDE2KSkifSwKICAgICAgICAge2V4cHJlc3Npb246ICJ2YXIgaW50QXJyYXkg PSBuZXcgSW50MzJBcnJheShuZXcgQXJyYXlCdWZmZXIoMTYpKTsgZm9yICh2YXIgaSA9IDA7IGkg PCBpbnRBcnJheS5sZW5ndGg7ICsraSkgaW50QXJyYXlbaV0gPSBpOyBpbnRBcnJheSJ9LAorICAg ICAgICB7ZXhwcmVzc2lvbjogInZhciBidWZmZXIgPSBuZXcgQXJyYXlCdWZmZXIoMTAwMDAwMDAp OyB2YXIgaW50OFZpZXcgPSBuZXcgSW50OEFycmF5KGJ1ZmZlcik7IGludDhWaWV3In0sIC8vIDEw MDAwMDAwIGVsZW1lbnRzLgogCiAgICAgICAgIC8vIE9iamVjdAogICAgICAgICB7ZXhwcmVzc2lv bjogIih7fSkifSwKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGNhZDc3Y2QuLjFkOTU5MGIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA2LTE4ICBK b3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogQXZvaWQgZ2V0T3duUHJvcGVydHlOYW1lcy9TeW1ib2xzIG9uIHZlcnkgbGFyZ2UgbGlz dHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjE0 MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5z cGVjdG9yL0luamVjdGVkU2NyaXB0U291cmNlLmpzOgorICAgICAgICAoSW5qZWN0ZWRTY3JpcHQu cHJvdG90eXBlLl9wcm9wZXJ0eURlc2NyaXB0b3JzKToKKyAgICAgICAgQXZvaWQgY2FsbGluZyBn ZXRPd25Qcm9wZXJ0eU5hbWVzL1N5bWJvbHMgb24gdmVyeSBsYXJnZSBsaXN0cy4gSW5zdGVhZAor ICAgICAgICBqdXN0IGdlbmVyYXRlIHByb3BlcnR5IGRlc2NyaXB0b3JzIGZvciB0aGUgZmlyc3Qg MTAwIGluZGV4ZXMuIE5vdGUKKyAgICAgICAgdGhpcyB3b3VsZCBiZWhhdmUgcG9vcmx5IGZvciBz cGFyc2UgYXJyYXlzIHdpdGggYSBsZW5ndGggPiAxMDAsIGJ1dAorICAgICAgICBnZW5lcmFsIHN1 cHBvcnQgZm9yIGxpc3RzIHdpdGggbW9yZSB0aGFuIDEwMCBlbGVtZW50cyBpcyBwb29yLiBTZWU6 CisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xNDM1ODk+IFdlYiBJbnNwZWN0b3I6IEJl dHRlciBoYW5kbGluZyBmb3IgbGFyZ2UgY29sbGVjdGlvbnMgaW4gT2JqZWN0IFRyZWVzCisKIDIw MTUtMDYtMTggIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAg ICAgW0RGR10gQXZvaWQgT1NSIGV4aXQgaW4gdGhlIG1pZGRsZSBvZiBzdHJpbmcgY29uY2F0ZW5h dGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9JbmplY3Rl ZFNjcmlwdFNvdXJjZS5qcyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSW5qZWN0 ZWRTY3JpcHRTb3VyY2UuanMKaW5kZXggNjZiNmNjMC4uZTU3NjEzOSAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qcworKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0U291cmNlLmpz CkBAIC02OTgsMTIgKzY5OCwzNCBAQCBJbmplY3RlZFNjcmlwdC5wcm90b3R5cGUgPSB7CiAgICAg ICAgICAgICB9CiAgICAgICAgIH0KIAotICAgICAgICAvLyBJdGVyYXRlIHByb3RvdHlwZSBjaGFp bi4KKyAgICAgICAgZnVuY3Rpb24gYXJyYXlJbmRleFByb3BlcnR5TmFtZXMobywgbGVuZ3RoKQor ICAgICAgICB7CisgICAgICAgICAgICB2YXIgYXJyYXkgPSBuZXcgQXJyYXkobGVuZ3RoKTsKKyAg ICAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgbGVuZ3RoOyArK2kpIHsKKyAgICAgICAgICAg ICAgICBpZiAoaSBpbiBvKQorICAgICAgICAgICAgICAgICAgICBhcnJheS5wdXNoKCIiICsgaSk7 CisgICAgICAgICAgICB9CisgICAgICAgICAgICByZXR1cm4gYXJyYXk7CisgICAgICAgIH0KKwor ICAgICAgICAvLyBGSVhNRTogPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE0MzU4OT4gV2ViIEluc3Bl Y3RvcjogQmV0dGVyIGhhbmRsaW5nIGZvciBsYXJnZSBjb2xsZWN0aW9ucyBpbiBPYmplY3QgVHJl ZXMKKyAgICAgICAgLy8gRm9yIGFycmF5IHR5cGVzIHdpdGggYSBsYXJnZSBsZW5ndGggd2UgYXR0 ZW1wdCB0byBza2lwIGdldE93blByb3BlcnR5TmFtZXMgYW5kIGluc3RlYWQganVzdCBzdWJsaXN0 IG9mIGluZGV4ZXMuCisgICAgICAgIHZhciBpc0FycmF5VHlwZVdpdGhMYXJnZUxlbmd0aCA9IGZh bHNlOworICAgICAgICB0cnkgeworICAgICAgICAgICAgaXNBcnJheVR5cGVXaXRoTGFyZ2VMZW5n dGggPSBpbmplY3RlZFNjcmlwdC5fc3VidHlwZShvYmplY3QpID09PSAiYXJyYXkiICYmIGlzRmlu aXRlKG9iamVjdC5sZW5ndGgpICYmIG9iamVjdC5sZW5ndGggPiAxMDA7CisgICAgICAgIH0gY2F0 Y2goZSkge30KKwogICAgICAgICBmb3IgKHZhciBvID0gb2JqZWN0OyB0aGlzLl9pc0RlZmluZWQo byk7IG8gPSBvLl9fcHJvdG9fXykgewogICAgICAgICAgICAgdmFyIGlzT3duUHJvcGVydHkgPSBv ID09PSBvYmplY3Q7Ci0gICAgICAgICAgICBwcm9jZXNzUHJvcGVydGllcyhvLCBPYmplY3QuZ2V0 T3duUHJvcGVydHlOYW1lcyhvKSwgaXNPd25Qcm9wZXJ0eSk7Ci0gICAgICAgICAgICBpZiAoT2Jq ZWN0LmdldE93blByb3BlcnR5U3ltYm9scykKLSAgICAgICAgICAgICAgICBwcm9jZXNzUHJvcGVy dGllcyhvLCBPYmplY3QuZ2V0T3duUHJvcGVydHlTeW1ib2xzKG8pLCBpc093blByb3BlcnR5KTsK KworICAgICAgICAgICAgaWYgKGlzQXJyYXlUeXBlV2l0aExhcmdlTGVuZ3RoICYmIGlzT3duUHJv cGVydHkpCisgICAgICAgICAgICAgICAgcHJvY2Vzc1Byb3BlcnRpZXMobywgYXJyYXlJbmRleFBy b3BlcnR5TmFtZXMobywgMTAwKSwgaXNPd25Qcm9wZXJ0eSk7CisgICAgICAgICAgICBlbHNlIHsK KyAgICAgICAgICAgICAgICBwcm9jZXNzUHJvcGVydGllcyhvLCBPYmplY3QuZ2V0T3duUHJvcGVy dHlOYW1lcyhvKSwgaXNPd25Qcm9wZXJ0eSk7CisgICAgICAgICAgICAgICAgaWYgKE9iamVjdC5n ZXRPd25Qcm9wZXJ0eVN5bWJvbHMpCisgICAgICAgICAgICAgICAgICAgIHByb2Nlc3NQcm9wZXJ0 aWVzKG8sIE9iamVjdC5nZXRPd25Qcm9wZXJ0eVN5bWJvbHMobyksIGlzT3duUHJvcGVydHkpOwor ICAgICAgICAgICAgfQorCiAgICAgICAgICAgICBpZiAoY29sbGVjdGlvbk1vZGUgPT09IEluamVj dGVkU2NyaXB0LkNvbGxlY3Rpb25Nb2RlLk93blByb3BlcnRpZXMpCiAgICAgICAgICAgICAgICAg YnJlYWs7CiAgICAgICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM3MTMyNzIuLmQ2 MWYzNmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA2 LTE4ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2Vi IEluc3BlY3RvcjogQXZvaWQgZ2V0T3duUHJvcGVydHlOYW1lcy9TeW1ib2xzIG9uIHZlcnkgbGFy Z2UgbGlzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0NjE0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVXNlckludGVyZmFjZS9Db250cm9sbGVycy9KYXZhU2NyaXB0UnVudGltZUNvbXBsZXRpb25Q cm92aWRlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5KYXZhU2NyaXB0UnVudGltZUNvbXBs ZXRpb25Qcm92aWRlci5wcm90b3R5cGUuY29tcGxldGlvbkNvbnRyb2xsZXJDb21wbGV0aW9uc05l ZWRlZCk6CisgICAgICAgIFdoZW4gYnVpbGRpbmcgY29tcGxldGlvbnMgZm9yIGEgbGFyZ2UgYXJy YXksIGluc3RlYWQgb2YgYnVpbGRpbmcgYSBsaXN0IG9mIGFsbCB0aGUgaW5kaWNlcworICAgICAg ICBqdXN0IHNlbmQgYSBzaW5nbGUgbnVtYmVyIGJhY2sgdG8gdGhlIGZyb250ZW5kIGFuZCBsZXQg aXQgZ2VuZXJhdGUgYSBsaXN0IGZvciBjb21wbGV0aW9uLgorICAgICAgICBXZSBzaG91bGQgZG8g ZXZlbiBiZXR0ZXIgYW5kIGF2b2lkIGJ1aWxkaW5nIGEgbG9va3VwIHRhYmxlIGhlcmUgZm9yIGNv bXBsZXRpb24gb2YgYW4gaW5kZXguCisKIDIwMTUtMDYtMTggIERldmluIFJvdXNzbyAgPGRyb3Vz c29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFkZCBhIGZpbHRlciBmb3Ig Q1NTIHByb3BlcnRpZXMgaW4gdGhlIFN0eWxlcyBzaWRlYmFyCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9KYXZhU2NyaXB0UnVudGlt ZUNvbXBsZXRpb25Qcm92aWRlci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0NvbnRyb2xsZXJzL0phdmFTY3JpcHRSdW50aW1lQ29tcGxldGlvblByb3ZpZGVyLmpzCmlu ZGV4IDRjNzgyNjkuLjZkZjVlMmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0phdmFTY3JpcHRSdW50aW1lQ29tcGxldGlvblByb3Zp ZGVyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xs ZXJzL0phdmFTY3JpcHRSdW50aW1lQ29tcGxldGlvblByb3ZpZGVyLmpzCkBAIC0xMjUsNiArMTI1 LDM0IEBAIFdlYkluc3BlY3Rvci5KYXZhU2NyaXB0UnVudGltZUNvbXBsZXRpb25Qcm92aWRlciA9 IGNsYXNzIEphdmFTY3JpcHRSdW50aW1lQ29tcGxlCiAgICAgICAgICAgICAgICAgcmV0dXJuOwog ICAgICAgICAgICAgfQogCisgICAgICAgICAgICBmdW5jdGlvbiBnZXRBcnJheUNvbXBsZXRpb25z KHByaW1pdGl2ZVR5cGUpCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgdmFyIGFycmF5 ID0gdGhpczsKKyAgICAgICAgICAgICAgICB2YXIgYXJyYXlMZW5ndGg7CisKKyAgICAgICAgICAg ICAgICB2YXIgcmVzdWx0U2V0ID0ge307CisgICAgICAgICAgICAgICAgZm9yICh2YXIgbyA9IGFy cmF5OyBvOyBvID0gby5fX3Byb3RvX18pIHsKKyAgICAgICAgICAgICAgICAgICAgdHJ5IHsKKyAg ICAgICAgICAgICAgICAgICAgICAgIGlmIChvID09PSBhcnJheSAmJiBvLmxlbmd0aCkgeworICAg ICAgICAgICAgICAgICAgICAgICAgICAgIC8vIElmIHRoZSBhcnJheSB0eXBlIGhhcyBhIGxlbmd0 aCwgZG9uJ3QgaW5jbHVkZSBhIGxpc3Qgb2YgYWxsIHRoZSBpbmRleGVzLgorICAgICAgICAgICAg ICAgICAgICAgICAgICAgIC8vIEluY2x1ZGUgaXQgYXQgdGhlIGVuZCBhbmQgdGhlIGZyb250ZW5k IGNhbiBidWlsZCB0aGUgbGlzdC4KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBhcnJheUxl bmd0aCA9IG8ubGVuZ3RoOworICAgICAgICAgICAgICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICB2YXIgbmFtZXMgPSBPYmplY3QuZ2V0T3duUHJvcGVydHlO YW1lcyhvKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8 IG5hbWVzLmxlbmd0aDsgKytpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZXN1 bHRTZXRbbmFtZXNbaV1dID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICAgICAgICAgIH0KKyAgICAg ICAgICAgICAgICAgICAgfSBjYXRjaCAoZSkgeworICAgICAgICAgICAgICAgICAgICAgICAgLy8g SWdub3JlCisgICAgICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICB9CisKKyAgICAg ICAgICAgICAgICBpZiAoYXJyYXlMZW5ndGgpCisgICAgICAgICAgICAgICAgICAgIHJlc3VsdFNl dFsibGVuZ3RoIl0gPSBhcnJheUxlbmd0aDsKKworICAgICAgICAgICAgICAgIHJldHVybiByZXN1 bHRTZXQ7CisgICAgICAgICAgICB9CisKICAgICAgICAgICAgIGZ1bmN0aW9uIGdldENvbXBsZXRp b25zKHByaW1pdGl2ZVR5cGUpCiAgICAgICAgICAgICB7CiAgICAgICAgICAgICAgICAgdmFyIG9i amVjdDsKQEAgLTE1MSw3ICsxNzksOSBAQCBXZWJJbnNwZWN0b3IuSmF2YVNjcmlwdFJ1bnRpbWVD b21wbGV0aW9uUHJvdmlkZXIgPSBjbGFzcyBKYXZhU2NyaXB0UnVudGltZUNvbXBsZQogICAgICAg ICAgICAgICAgIHJldHVybiByZXN1bHRTZXQ7CiAgICAgICAgICAgICB9CiAKLSAgICAgICAgICAg IGlmIChyZXN1bHQudHlwZSA9PT0gIm9iamVjdCIgfHwgcmVzdWx0LnR5cGUgPT09ICJmdW5jdGlv biIpCisgICAgICAgICAgICBpZiAocmVzdWx0LnN1YnR5cGUgPT09ICJhcnJheSIpCisgICAgICAg ICAgICAgICAgcmVzdWx0LmNhbGxGdW5jdGlvbkpTT04oZ2V0QXJyYXlDb21wbGV0aW9ucywgdW5k ZWZpbmVkLCByZWNlaXZlZEFycmF5UHJvcGVydHlOYW1lcy5iaW5kKHRoaXMpKTsKKyAgICAgICAg ICAgIGVsc2UgaWYgKHJlc3VsdC50eXBlID09PSAib2JqZWN0IiB8fCByZXN1bHQudHlwZSA9PT0g ImZ1bmN0aW9uIikKICAgICAgICAgICAgICAgICByZXN1bHQuY2FsbEZ1bmN0aW9uSlNPTihnZXRD b21wbGV0aW9ucywgdW5kZWZpbmVkLCByZWNlaXZlZFByb3BlcnR5TmFtZXMuYmluZCh0aGlzKSk7 CiAgICAgICAgICAgICBlbHNlIGlmIChyZXN1bHQudHlwZSA9PT0gInN0cmluZyIgfHwgcmVzdWx0 LnR5cGUgPT09ICJudW1iZXIiIHx8IHJlc3VsdC50eXBlID09PSAiYm9vbGVhbiIpCiAgICAgICAg ICAgICAgICAgV2ViSW5zcGVjdG9yLnJ1bnRpbWVNYW5hZ2VyLmV2YWx1YXRlSW5JbnNwZWN0ZWRX aW5kb3coIigiICsgZ2V0Q29tcGxldGlvbnMgKyAiKShcIiIgKyByZXN1bHQudHlwZSArICJcIiki LCAiY29tcGxldGlvbiIsIGZhbHNlLCB0cnVlLCB0cnVlLCBmYWxzZSwgZmFsc2UsIHJlY2VpdmVk UHJvcGVydHlOYW1lc0Zyb21FdmFsdWF0ZS5iaW5kKHRoaXMpKTsKQEAgLTE2NCw2ICsxOTQsMjAg QEAgV2ViSW5zcGVjdG9yLkphdmFTY3JpcHRSdW50aW1lQ29tcGxldGlvblByb3ZpZGVyID0gY2xh c3MgSmF2YVNjcmlwdFJ1bnRpbWVDb21wbGUKICAgICAgICAgICAgIHJlY2VpdmVkUHJvcGVydHlO YW1lcy5jYWxsKHRoaXMsIHJlc3VsdCAmJiAhd2FzVGhyb3duID8gcmVzdWx0LnZhbHVlIDogbnVs bCk7CiAgICAgICAgIH0KIAorICAgICAgICBmdW5jdGlvbiByZWNlaXZlZEFycmF5UHJvcGVydHlO YW1lcyhwcm9wZXJ0eU5hbWVzKQorICAgICAgICB7CisgICAgICAgICAgICAvLyBGSVhNRTogPGh0 dHBzOi8vd2Via2l0Lm9yZy9iLzE0MzU4OT4gV2ViIEluc3BlY3RvcjogQmV0dGVyIGhhbmRsaW5n IGZvciBsYXJnZSBjb2xsZWN0aW9ucyBpbiBPYmplY3QgVHJlZXMKKyAgICAgICAgICAgIC8vIElm IHRoZXJlIHdhcyBhbiBhcnJheSBsaWtlIG9iamVjdCwgd2UgZ2VuZXJhdGUgYXV0b2NvbXBsZXRp b24gdXAgdG8gMTAwMCBpbmRleGVzLCBidXQgdGhpcyBzaG91bGQKKyAgICAgICAgICAgIC8vIGhh bmRsZSBhIGxpc3Qgd2l0aCBhcmJpdHJhcnkgbGVuZ3RoLgorICAgICAgICAgICAgaWYgKHByb3Bl cnR5TmFtZXMgJiYgdHlwZW9mIHByb3BlcnR5TmFtZXMubGVuZ3RoID09PSAibnVtYmVyIikgewor ICAgICAgICAgICAgICAgIHZhciBtYXggPSBNYXRoLm1pbihwcm9wZXJ0eU5hbWVzLmxlbmd0aCwg MTAwMCk7CisgICAgICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBtYXg7ICsraSkKKyAg ICAgICAgICAgICAgICAgICAgcHJvcGVydHlOYW1lc1tpXSA9IHRydWU7CisgICAgICAgICAgICB9 CisKKyAgICAgICAgICAgIHJlY2VpdmVkUHJvcGVydHlOYW1lcy5jYWxsKHRoaXMsIHByb3BlcnR5 TmFtZXMpOworICAgICAgICB9CisKICAgICAgICAgZnVuY3Rpb24gcmVjZWl2ZWRQcm9wZXJ0eU5h bWVzKHByb3BlcnR5TmFtZXMpCiAgICAgICAgIHsKICAgICAgICAgICAgIHByb3BlcnR5TmFtZXMg PSBwcm9wZXJ0eU5hbWVzIHx8IHt9Owo=