146138 2015-06-18 21:18:44 -0700 Get CAContext directly for CALayer instead of walking the layer tree. 2015-06-19 12:38:28 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jeremyj-wk jeremyj-wk commit-queue eric.carlson simon.fraser thorton oldest_to_newest 1103157 0 jeremyj-wk 2015-06-18 21:18:44 -0700 Get CAContext directly for CALayer instead of walking the layer tree. 1103158 1 jeremyj-wk 2015-06-18 21:19:16 -0700 rdar://problem/21455378 1103159 2 255169 jeremyj-wk 2015-06-18 21:21:37 -0700 Created attachment 255169 Patch 1103244 3 255169 simon.fraser 2015-06-19 08:19:30 -0700 Comment on attachment 255169 Patch I can't review this without some more explanation in the changelog. 1103319 4 255169 darin 2015-06-19 11:25:04 -0700 Comment on attachment 255169 Patch Seems clearly more efficient and straightforward. Does it also fix any bugs? Can we make a regression test for the bugs it fixes? 1103326 5 jeremyj-wk 2015-06-19 11:32:44 -0700 (In reply to comment #4) > Comment on attachment 255169 [details] > Patch > > Seems clearly more efficient and straightforward. Does it also fix any bugs? > Can we make a regression test for the bugs it fixes? I don't know of any concrete failures that this fixes, only the hunch that the convoluted approach might fail where the direct approach would succeed. 1103327 6 255203 jeremyj-wk 2015-06-19 11:33:43 -0700 Created attachment 255203 Patch for landing. 1103330 7 jeremyj-wk 2015-06-19 11:34:06 -0700 (In reply to comment #3) > Comment on attachment 255169 [details] > Patch > > I can't review this without some more explanation in the changelog. Added more explanation. 1103366 8 255203 commit-queue 2015-06-19 12:29:36 -0700 Comment on attachment 255203 Patch for landing. Clearing flags on attachment: 255203 Committed r185763: <http://trac.webkit.org/changeset/185763> 255169 2015-06-18 21:21:37 -0700 2015-06-19 11:25:04 -0700 Patch bug-146138-20150618212100.patch text/plain 3393 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NzMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmFlMTc4NGMwZWM2YzY0 YmYyZjc3YWM3NjhmZDBlNDkzYzFkYjJmYi4uNzE1NzBlNWQ2NzM0YTI2ZGJmMzQ4MWIyOTYxNjA5 ZjE2NzhlYTdhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE1LTA2LTE4ICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KIAorICAgICAgICBHZXQgQ0FDb250ZXh0IGRp cmVjdGx5IGZvciBDQUxheWVyIGluc3RlYWQgb2Ygd2Fsa2luZyB0aGUgbGF5ZXIgdHJlZS4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjEzOAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9u T2JqQy5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlv bk9iakM6OnNldFZpZGVvRnVsbHNjcmVlbkxheWVyKToKKworMjAxNS0wNi0xOCAgSmVyZW15IEpv bmVzICA8amVyZW15akBhcHBsZS5jb20+CisKICAgICAgICAgRGlzYWJsZSBVSVdpbmRvdyBmb3Ig ZnVsbHNjcmVlbiB2aWRlbyBmb3Igc2VsZWN0ZWQgY2xpZW50cy4KICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTg1MgogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXll clByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2Jq Qy5tbQppbmRleCA3MGVmM2RlMmZlMTJiMjRiM2NjZDEyZmFiODVjZTQwZTc1ZGNkODFhLi5jOTgy NGJkZDUyZjBlNDM2NjE0MTYyNDI5ZWNjOWQyNzIzMTA3YTFmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclBy aXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9i akMubW0KQEAgLTExMDUsMzggKzExMDUsMjUgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVBVkZv dW5kYXRpb25PYmpDOjpzZXRWaWRlb0Z1bGxzY3JlZW5MYXllcihQbGF0Zm9ybUxheWVyKgogICAg IFtDQVRyYW5zYWN0aW9uIGJlZ2luXTsKICAgICBbQ0FUcmFuc2FjdGlvbiBzZXREaXNhYmxlQWN0 aW9uczpZRVNdOwogICAgIAotICAgIENBTGF5ZXIgKm9sZFJvb3RMYXllciA9IHZpZGVvRnVsbHNj cmVlbkxheWVyOwotICAgIHdoaWxlIChvbGRSb290TGF5ZXIuc3VwZXJsYXllcikKLSAgICAgICAg b2xkUm9vdExheWVyID0gb2xkUm9vdExheWVyLnN1cGVybGF5ZXI7Ci0KLSAgICBDQUxheWVyICpu ZXdSb290TGF5ZXIgPSBuaWw7CisgICAgQ0FDb250ZXh0ICpvbGRDb250ZXh0ID0gW21fdmlkZW9M YXllciBjb250ZXh0XTsKKyAgICBDQUNvbnRleHQgKm5ld0NvbnRleHQgPSBuaWw7CiAgICAgCiAg ICAgaWYgKG1fdmlkZW9GdWxsc2NyZWVuTGF5ZXIgJiYgbV92aWRlb0xheWVyKSB7CiAgICAgICAg IFttX3ZpZGVvTGF5ZXIgc2V0RnJhbWU6Q0dSZWN0TWFrZSgwLCAwLCBtX3ZpZGVvRnVsbHNjcmVl bkZyYW1lLndpZHRoKCksIG1fdmlkZW9GdWxsc2NyZWVuRnJhbWUuaGVpZ2h0KCkpXTsKICAgICAg ICAgW21fdmlkZW9MYXllciByZW1vdmVGcm9tU3VwZXJsYXllcl07CiAgICAgICAgIFttX3ZpZGVv RnVsbHNjcmVlbkxheWVyIGluc2VydFN1YmxheWVyOm1fdmlkZW9MYXllci5nZXQoKSBhdEluZGV4 OjBdOwotICAgICAgICBuZXdSb290TGF5ZXIgPSBtX3ZpZGVvRnVsbHNjcmVlbkxheWVyLmdldCgp OworICAgICAgICBuZXdDb250ZXh0ID0gW21fdmlkZW9GdWxsc2NyZWVuTGF5ZXIgY29udGV4dF07 CiAgICAgfSBlbHNlIGlmIChtX3ZpZGVvSW5saW5lTGF5ZXIgJiYgbV92aWRlb0xheWVyKSB7CiAg ICAgICAgIFttX3ZpZGVvTGF5ZXIgc2V0RnJhbWU6W21fdmlkZW9JbmxpbmVMYXllciBib3VuZHNd XTsKICAgICAgICAgW21fdmlkZW9MYXllciByZW1vdmVGcm9tU3VwZXJsYXllcl07CiAgICAgICAg IFttX3ZpZGVvSW5saW5lTGF5ZXIgaW5zZXJ0U3VibGF5ZXI6bV92aWRlb0xheWVyLmdldCgpIGF0 SW5kZXg6MF07Ci0gICAgICAgIG5ld1Jvb3RMYXllciA9IG1fdmlkZW9JbmxpbmVMYXllci5nZXQo KTsKKyAgICAgICAgbmV3Q29udGV4dCA9IFttX3ZpZGVvSW5saW5lTGF5ZXIgY29udGV4dF07CiAg ICAgfSBlbHNlIGlmIChtX3ZpZGVvTGF5ZXIpCiAgICAgICAgIFttX3ZpZGVvTGF5ZXIgcmVtb3Zl RnJvbVN1cGVybGF5ZXJdOwogCi0gICAgd2hpbGUgKG5ld1Jvb3RMYXllci5zdXBlcmxheWVyKQot ICAgICAgICBuZXdSb290TGF5ZXIgPSBuZXdSb290TGF5ZXIuc3VwZXJsYXllcjsKLQotICAgIGlm IChvbGRSb290TGF5ZXIgJiYgbmV3Um9vdExheWVyICYmIG9sZFJvb3RMYXllciAhPSBuZXdSb290 TGF5ZXIpIHsKLSAgICAgICAgbWFjaF9wb3J0X3QgZmVuY2VQb3J0ID0gMDsKLSAgICAgICAgZm9y IChDQUNvbnRleHQgKmNvbnRleHQgaW4gW0NBQ29udGV4dCBhbGxDb250ZXh0c10pIHsKLSAgICAg ICAgICAgIGlmIChjb250ZXh0LmxheWVyID09IG9sZFJvb3RMYXllciB8fCBjb250ZXh0LmxheWVy ID09IG5ld1Jvb3RMYXllcikgewotICAgICAgICAgICAgICAgIGlmICghZmVuY2VQb3J0KQotICAg ICAgICAgICAgICAgICAgICBmZW5jZVBvcnQgPSBbY29udGV4dCBjcmVhdGVGZW5jZVBvcnRdOwot ICAgICAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICAgICAgW2NvbnRleHQgc2V0RmVu Y2VQb3J0OmZlbmNlUG9ydF07Ci0gICAgICAgICAgICB9Ci0gICAgICAgIH0KKyAgICBpZiAob2xk Q29udGV4dCAmJiBuZXdDb250ZXh0ICYmIG9sZENvbnRleHQgIT0gbmV3Q29udGV4dCkgeworICAg ICAgICBtYWNoX3BvcnRfdCBmZW5jZVBvcnQgPSBbb2xkQ29udGV4dCBjcmVhdGVGZW5jZVBvcnRd OworICAgICAgICBbbmV3Q29udGV4dCBzZXRGZW5jZVBvcnQ6ZmVuY2VQb3J0XTsKICAgICAgICAg bWFjaF9wb3J0X2RlYWxsb2NhdGUobWFjaF90YXNrX3NlbGYoKSwgZmVuY2VQb3J0KTsKICAgICB9 CiAgICAgW0NBVHJhbnNhY3Rpb24gY29tbWl0XTsK 255203 2015-06-19 11:33:43 -0700 2015-06-19 12:29:36 -0700 Patch for landing. bug-146138-20150619113304.patch text/plain 3624 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NzMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmFlMTc4NGMwZWM2YzY0 YmYyZjc3YWM3NjhmZDBlNDkzYzFkYjJmYi4uNmMxNzNlY2QyYWYyN2UwZmQ3ZTc1NTliMWFiYjc2 ODliNWFiN2Y3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE1LTA2LTE4ICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KIAorICAgICAgICBHZXQgQ0FDb250ZXh0IGRp cmVjdGx5IGZvciBDQUxheWVyIGluc3RlYWQgb2Ygd2Fsa2luZyB0aGUgbGF5ZXIgdHJlZS4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjEzOAorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMjE0NTU5NzQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFy aW4gQWRsZXIuCisKKyAgICAgICAgVGhpcyB3aWxsIGdldCB0aGUgY29udGV4dCBkaXJlY3RseSBm cm9tIHRoZSBDQUxheWVyIGluc3RlYWQgb2YgZ2V0dGluZyBhbGwgQ0FDb250ZXh0cywgd2Fsa2lu ZyB0aGUgbGF5ZXIgdHJlZSAKKyAgICAgICAgdG8gdGhlIHJvb3QgYW5kIGNvbXBhcmluZyB0aGF0 IGFnYWluc3QgZWFjaCBDQUNvbnRleHQncyByb290IGxheWVyLgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0 aW9uT2JqQy5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRh dGlvbk9iakM6OnNldFZpZGVvRnVsbHNjcmVlbkxheWVyKToKKworMjAxNS0wNi0xOCAgSmVyZW15 IEpvbmVzICA8amVyZW15akBhcHBsZS5jb20+CisKICAgICAgICAgRGlzYWJsZSBVSVdpbmRvdyBm b3IgZnVsbHNjcmVlbiB2aWRlbyBmb3Igc2VsZWN0ZWQgY2xpZW50cy4KICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTg1MgogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBs YXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9u T2JqQy5tbQppbmRleCA3MGVmM2RlMmZlMTJiMjRiM2NjZDEyZmFiODVjZTQwZTc1ZGNkODFhLi5j OTgyNGJkZDUyZjBlNDM2NjE0MTYyNDI5ZWNjOWQyNzIzMTA3YTFmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXll clByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlv bk9iakMubW0KQEAgLTExMDUsMzggKzExMDUsMjUgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVB VkZvdW5kYXRpb25PYmpDOjpzZXRWaWRlb0Z1bGxzY3JlZW5MYXllcihQbGF0Zm9ybUxheWVyKgog ICAgIFtDQVRyYW5zYWN0aW9uIGJlZ2luXTsKICAgICBbQ0FUcmFuc2FjdGlvbiBzZXREaXNhYmxl QWN0aW9uczpZRVNdOwogICAgIAotICAgIENBTGF5ZXIgKm9sZFJvb3RMYXllciA9IHZpZGVvRnVs bHNjcmVlbkxheWVyOwotICAgIHdoaWxlIChvbGRSb290TGF5ZXIuc3VwZXJsYXllcikKLSAgICAg ICAgb2xkUm9vdExheWVyID0gb2xkUm9vdExheWVyLnN1cGVybGF5ZXI7Ci0KLSAgICBDQUxheWVy ICpuZXdSb290TGF5ZXIgPSBuaWw7CisgICAgQ0FDb250ZXh0ICpvbGRDb250ZXh0ID0gW21fdmlk ZW9MYXllciBjb250ZXh0XTsKKyAgICBDQUNvbnRleHQgKm5ld0NvbnRleHQgPSBuaWw7CiAgICAg CiAgICAgaWYgKG1fdmlkZW9GdWxsc2NyZWVuTGF5ZXIgJiYgbV92aWRlb0xheWVyKSB7CiAgICAg ICAgIFttX3ZpZGVvTGF5ZXIgc2V0RnJhbWU6Q0dSZWN0TWFrZSgwLCAwLCBtX3ZpZGVvRnVsbHNj cmVlbkZyYW1lLndpZHRoKCksIG1fdmlkZW9GdWxsc2NyZWVuRnJhbWUuaGVpZ2h0KCkpXTsKICAg ICAgICAgW21fdmlkZW9MYXllciByZW1vdmVGcm9tU3VwZXJsYXllcl07CiAgICAgICAgIFttX3Zp ZGVvRnVsbHNjcmVlbkxheWVyIGluc2VydFN1YmxheWVyOm1fdmlkZW9MYXllci5nZXQoKSBhdElu ZGV4OjBdOwotICAgICAgICBuZXdSb290TGF5ZXIgPSBtX3ZpZGVvRnVsbHNjcmVlbkxheWVyLmdl dCgpOworICAgICAgICBuZXdDb250ZXh0ID0gW21fdmlkZW9GdWxsc2NyZWVuTGF5ZXIgY29udGV4 dF07CiAgICAgfSBlbHNlIGlmIChtX3ZpZGVvSW5saW5lTGF5ZXIgJiYgbV92aWRlb0xheWVyKSB7 CiAgICAgICAgIFttX3ZpZGVvTGF5ZXIgc2V0RnJhbWU6W21fdmlkZW9JbmxpbmVMYXllciBib3Vu ZHNdXTsKICAgICAgICAgW21fdmlkZW9MYXllciByZW1vdmVGcm9tU3VwZXJsYXllcl07CiAgICAg ICAgIFttX3ZpZGVvSW5saW5lTGF5ZXIgaW5zZXJ0U3VibGF5ZXI6bV92aWRlb0xheWVyLmdldCgp IGF0SW5kZXg6MF07Ci0gICAgICAgIG5ld1Jvb3RMYXllciA9IG1fdmlkZW9JbmxpbmVMYXllci5n ZXQoKTsKKyAgICAgICAgbmV3Q29udGV4dCA9IFttX3ZpZGVvSW5saW5lTGF5ZXIgY29udGV4dF07 CiAgICAgfSBlbHNlIGlmIChtX3ZpZGVvTGF5ZXIpCiAgICAgICAgIFttX3ZpZGVvTGF5ZXIgcmVt b3ZlRnJvbVN1cGVybGF5ZXJdOwogCi0gICAgd2hpbGUgKG5ld1Jvb3RMYXllci5zdXBlcmxheWVy KQotICAgICAgICBuZXdSb290TGF5ZXIgPSBuZXdSb290TGF5ZXIuc3VwZXJsYXllcjsKLQotICAg IGlmIChvbGRSb290TGF5ZXIgJiYgbmV3Um9vdExheWVyICYmIG9sZFJvb3RMYXllciAhPSBuZXdS b290TGF5ZXIpIHsKLSAgICAgICAgbWFjaF9wb3J0X3QgZmVuY2VQb3J0ID0gMDsKLSAgICAgICAg Zm9yIChDQUNvbnRleHQgKmNvbnRleHQgaW4gW0NBQ29udGV4dCBhbGxDb250ZXh0c10pIHsKLSAg ICAgICAgICAgIGlmIChjb250ZXh0LmxheWVyID09IG9sZFJvb3RMYXllciB8fCBjb250ZXh0Lmxh eWVyID09IG5ld1Jvb3RMYXllcikgewotICAgICAgICAgICAgICAgIGlmICghZmVuY2VQb3J0KQot ICAgICAgICAgICAgICAgICAgICBmZW5jZVBvcnQgPSBbY29udGV4dCBjcmVhdGVGZW5jZVBvcnRd OwotICAgICAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICAgICAgW2NvbnRleHQgc2V0 RmVuY2VQb3J0OmZlbmNlUG9ydF07Ci0gICAgICAgICAgICB9Ci0gICAgICAgIH0KKyAgICBpZiAo b2xkQ29udGV4dCAmJiBuZXdDb250ZXh0ICYmIG9sZENvbnRleHQgIT0gbmV3Q29udGV4dCkgewor ICAgICAgICBtYWNoX3BvcnRfdCBmZW5jZVBvcnQgPSBbb2xkQ29udGV4dCBjcmVhdGVGZW5jZVBv cnRdOworICAgICAgICBbbmV3Q29udGV4dCBzZXRGZW5jZVBvcnQ6ZmVuY2VQb3J0XTsKICAgICAg ICAgbWFjaF9wb3J0X2RlYWxsb2NhdGUobWFjaF90YXNrX3NlbGYoKSwgZmVuY2VQb3J0KTsKICAg ICB9CiAgICAgW0NBVHJhbnNhY3Rpb24gY29tbWl0XTsK