146132 2015-06-18 17:09:16 -0700 Support releasing media sessions 2015-06-23 15:05:04 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 145411 1 mrajca webkit-unassigned conrad_shultz eric.carlson jer.noble mrajca webkit-bug-importer oldest_to_newest 1103097 0 mrajca 2015-06-18 17:09:16 -0700 Implement the release method described in section 5.1.3 of the Media Session spec, as well as its helper algorithm from section 4.6 "Releasing a media session". 1103101 1 255155 mrajca 2015-06-18 17:16:16 -0700 Created attachment 255155 Patch 1103316 2 255155 darin 2015-06-19 11:23:43 -0700 Comment on attachment 255155 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255155&action=review > Source/WebCore/Modules/mediasession/MediaSession.cpp:84 > + while (!m_activeParticipatingElements.isEmpty()) { > + HTMLMediaElement* element = m_activeParticipatingElements.takeAny(); > + element->pause(); > + } Could write this without the local variable: while (!m_activeParticipatingElements.isEmpty()) m_activeParticipatingElements.takeAny()->pause(); > Source/WebCore/Modules/mediasession/MediaSession.cpp:98 > + if (m_activeParticipatingElements.size() >= 1) I think !isEmpty() would be better. Sometimes it’s better not to take specification language too literally! One or more doesn’t have to turn into >= 1. 1103317 3 webkit-bug-importer 2015-06-19 11:24:07 -0700 <rdar://problem/21464030> 1104194 4 mrajca 2015-06-23 15:04:38 -0700 Committed r185885: <http://trac.webkit.org/changeset/185885> 1104195 5 mrajca 2015-06-23 15:05:04 -0700 (In reply to comment #2) > Comment on attachment 255155 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=255155&action=review > > > Source/WebCore/Modules/mediasession/MediaSession.cpp:84 > > + while (!m_activeParticipatingElements.isEmpty()) { > > + HTMLMediaElement* element = m_activeParticipatingElements.takeAny(); > > + element->pause(); > > + } > > Could write this without the local variable: > > while (!m_activeParticipatingElements.isEmpty()) > m_activeParticipatingElements.takeAny()->pause(); > > > Source/WebCore/Modules/mediasession/MediaSession.cpp:98 > > + if (m_activeParticipatingElements.size() >= 1) > > I think !isEmpty() would be better. Sometimes it’s better not to take > specification language too literally! One or more doesn’t have to turn into > >= 1. Thanks for the feedback. Fixed. 255155 2015-06-18 17:16:16 -0700 2015-06-19 11:23:43 -0700 Patch bug-146132-20150618171539.patch text/plain 3676 mrajca U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1Njc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDM5MGQ5NjA4NDlkOGUy MGVmMDJkYzQ2N2Q4Y2EyN2VhM2Q5ZjU5MC4uMTBmZTk0ZjE3YmMxNTQ0ZjE4NGVhZTE0ZjhjOWRk NjdlYmU3YzUzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA2LTE4ICBNYXR0 IFJhamNhICA8bXJhamNhQGFwcGxlLmNvbT4KKworICAgICAgICBTdXBwb3J0IHJlbGVhc2luZyBt ZWRpYSBzZXNzaW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQ2MTMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBNb2R1bGVzL21lZGlhc2Vzc2lvbi9NZWRpYVNlc3Npb24uY3BwOiBJbXBsZW1lbnRl ZCBhcyBkZXNjcmliZWQgaW4gdGhlIE1lZGlhIFNlc3Npb24gc3BlYy4KKyAgICAgICAgKFdlYkNv cmU6Ok1lZGlhU2Vzc2lvbjo6cmVsZWFzZVNlc3Npb24pOgorICAgICAgICAoV2ViQ29yZTo6TWVk aWFTZXNzaW9uOjpyZWxlYXNlSW50ZXJuYWwpOgorICAgICAgICAqIE1vZHVsZXMvbWVkaWFzZXNz aW9uL01lZGlhU2Vzc2lvbi5oOgorCiAyMDE1LTA2LTE2ICBNYXR0IFJhamNhICA8bXJhamNhQGFw cGxlLmNvbT4KIAogICAgICAgICBNZWRpYVNlc3Npb246IGhhbmRsZSBNZWRpYUV2ZW50VHJhY2tO ZXh0IGFuZCBNZWRpYUV2ZW50VHJhY2tQcmV2aW91cyBldmVudHMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzZXNzaW9uL01lZGlhU2Vzc2lvbi5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL21lZGlhc2Vzc2lvbi9NZWRpYVNlc3Npb24uY3BwCmluZGV4IGEyYTdl MzliZDA4ZDY0ZTYwOWFmNjdjOTNmOGY5NmE5NmIyZTE4NGQuLjk5YTJjNDc4NDU4YjcwYzc4Mzcz NDQ3YTM3OTYzMWFkNjg1MmM3NDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv bWVkaWFzZXNzaW9uL01lZGlhU2Vzc2lvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9tZWRpYXNlc3Npb24vTWVkaWFTZXNzaW9uLmNwcApAQCAtNzQsNiArNzQsMzkgQEAgdm9pZCBN ZWRpYVNlc3Npb246OmFkZEFjdGl2ZU1lZGlhRWxlbWVudChIVE1MTWVkaWFFbGVtZW50JiBlbGVt ZW50KQogCiB2b2lkIE1lZGlhU2Vzc2lvbjo6cmVsZWFzZVNlc3Npb24oKQogeworICAgIC8vIDUu MS4zCisgICAgLy8gMS4gTGV0IG1lZGlhIHNlc3Npb24gYmUgdGhlIGN1cnJlbnQgbWVkaWEgc2Vz c2lvbi4KKyAgICAvLyAyLiBJbmRlZmluaXRlbHkgcGF1c2UgYWxsIG9mIG1lZGlhIHNlc3Npb24n cyBhY3RpdmUgcGFydGljaXBhdGluZyBtZWRpYSBlbGVtZW50cy4KKyAgICAvLyAzLiBSZXNldCBt ZWRpYSBzZXNzaW9uJ3MgYWN0aXZlIHBhcnRpY2lwYXRpbmcgbWVkaWEgZWxlbWVudHMgdG8gYW4g ZW1wdHkgbGlzdC4KKyAgICB3aGlsZSAoIW1fYWN0aXZlUGFydGljaXBhdGluZ0VsZW1lbnRzLmlz RW1wdHkoKSkgeworICAgICAgICBIVE1MTWVkaWFFbGVtZW50KiBlbGVtZW50ID0gbV9hY3RpdmVQ YXJ0aWNpcGF0aW5nRWxlbWVudHMudGFrZUFueSgpOworICAgICAgICBlbGVtZW50LT5wYXVzZSgp OworICAgIH0KKworICAgIC8vIDQuIFJ1biB0aGUgbWVkaWEgc2Vzc2lvbiByZWxlYXNlIGFsZ29y aXRobSBmb3IgbWVkaWEgc2Vzc2lvbi4KKyAgICByZWxlYXNlSW50ZXJuYWwoKTsKK30KKwordm9p ZCBNZWRpYVNlc3Npb246OnJlbGVhc2VJbnRlcm5hbCgpCit7CisgICAgLy8gNi41LiBSZWxlYXNp bmcgYSBtZWRpYSBzZXNzaW9uCisgICAgLy8gMS4gSWYgY3VycmVudCBtZWRpYSBzZXNzaW9uJ3Mg Y3VycmVudCBzdGF0ZSBpcyBpZGxlLCB0aGVuIHRlcm1pbmF0ZSB0aGVzZSBzdGVwcy4KKyAgICBp ZiAobV9jdXJyZW50U3RhdGUgPT0gU3RhdGU6OklkbGUpCisgICAgICAgIHJldHVybjsKKworICAg IC8vIDIuIElmIGN1cnJlbnQgbWVkaWEgc2Vzc2lvbiBzdGlsbCBoYXMgb25lIG9yIG1vcmUgYWN0 aXZlIHBhcnRpY2lwYXRpbmcgbWVkaWEgZWxlbWVudHMsIHRoZW4gdGVybWluYXRlIHRoZXNlIHN0 ZXBzLgorICAgIGlmIChtX2FjdGl2ZVBhcnRpY2lwYXRpbmdFbGVtZW50cy5zaXplKCkgPj0gMSkK KyAgICAgICAgcmV0dXJuOworCisgICAgLy8gMy4gT3B0aW9uYWxseSwgYmFzZWQgb24gcGxhdGZv cm0gY29udmVudGlvbnMsIHRoZSB1c2VyIGFnZW50IG11c3QgcmVsZWFzZSBhbnkgY3VycmVudGx5 IGhlbGQgcGxhdGZvcm0gbWVkaWEgZm9jdXMKKyAgICAvLyAgICBmb3IgY3VycmVudCBtZWRpYSBz ZXNzaW9uLgorICAgIC8vIDQuIE9wdGlvbmFsbHksIGJhc2VkIG9uIHBsYXRmb3JtIGNvbnZlbnRp b25zLCB0aGUgdXNlciBhZ2VudCBtdXN0IHJlbW92ZSBhbnkgcHJldmlvdXNseSBlc3RhYmxpc2hl ZCBvbmdvaW5nIG1lZGlhCisgICAgLy8gICAgaW50ZXJmYWNlIGluIHRoZSB1bmRlcmx5aW5nIHBs YXRmb3Jt4oCZcyBub3RpZmljYXRpb25zIGFyZWEgYW5kIGFueSBvbmdvaW5nIG1lZGlhIGludGVy ZmFjZSBpbiB0aGUgdW5kZXJseWluZworICAgIC8vICAgIHBsYXRmb3JtJ3MgbG9jayBzY3JlZW4g YXJlYSBmb3IgY3VycmVudCBtZWRpYSBzZXNzaW9uLCBpZiBhbnkuCisgICAgLy8gNS4gT3B0aW9u YWxseSwgYmFzZWQgb24gcGxhdGZvcm0gY29udmVudGlvbnMsIHRoZSB1c2VyIGFnZW50IG11c3Qg cHJldmVudCBhbnkgaGFyZHdhcmUgYW5kL29yIHNvZnR3YXJlIG1lZGlhIGtleXMKKyAgICAvLyAg ICBmcm9tIGNvbnRyb2xsaW5nIHBsYXliYWNrIG9mIGN1cnJlbnQgbWVkaWEgc2Vzc2lvbidzIGFj dGl2ZSBwYXJ0aWNpcGF0aW5nIG1lZGlhIGVsZW1lbnRzLgorICAgIC8vIDYuIFNldCBjdXJyZW50 IG1lZGlhIHNlc3Npb24ncyBjdXJyZW50IHN0YXRlIHRvIGlkbGUuCisgICAgbV9jdXJyZW50U3Rh dGUgPSBTdGF0ZTo6SWRsZTsKIH0KIAogYm9vbCBNZWRpYVNlc3Npb246Omludm9rZSgpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc2Vzc2lvbi9NZWRpYVNlc3Npb24u aCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzZXNzaW9uL01lZGlhU2Vzc2lvbi5oCmlu ZGV4IGU4ZjY0ZWRhNTdmZDk2MjBiNmUyOGVjYjc1NmFmYzNhOGNkZGU2M2UuLjJkNmMyMmZkZDU3 ODIzMWJlMzJmZTJmZTc5N2E3NGJhZGZjZmI5ZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvbWVkaWFzZXNzaW9uL01lZGlhU2Vzc2lvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvbWVkaWFzZXNzaW9uL01lZGlhU2Vzc2lvbi5oCkBAIC03Miw2ICs3Miw4IEBAIHBy aXZhdGU6CiAKICAgICB2b2lkIGFkZEFjdGl2ZU1lZGlhRWxlbWVudChIVE1MTWVkaWFFbGVtZW50 Jik7CiAKKyAgICB2b2lkIHJlbGVhc2VJbnRlcm5hbCgpOworCiAgICAgU3RhdGUgbV9jdXJyZW50 U3RhdGUgeyBTdGF0ZTo6SWRsZSB9OwogICAgIFZlY3RvcjxIVE1MTWVkaWFFbGVtZW50Kj4gbV9w YXJ0aWNpcGF0aW5nRWxlbWVudHM7CiAgICAgSGFzaFNldDxIVE1MTWVkaWFFbGVtZW50Kj4gbV9h Y3RpdmVQYXJ0aWNpcGF0aW5nRWxlbWVudHM7Cg==