146112 2015-06-18 08:34:20 -0700 ~4% Membuster regression after WebKit r185452 2015-07-02 05:11:01 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified REOPENED InRadar P2 Normal --- 146544 1 koivisto webkit-unassigned cdumez cgarcia commit-queue kling oldest_to_newest 1102921 0 koivisto 2015-06-18 08:34:20 -0700 Looks like delaying writes in disk cache increased memory consumption in Membuster, probably due to keeping write buffers around longer. 1102930 1 255118 koivisto 2015-06-18 09:24:45 -0700 Created attachment 255118 patch 1102931 2 koivisto 2015-06-18 09:25:13 -0700 rdar://problem/21406677 1102932 3 255118 cdumez 2015-06-18 09:34:54 -0700 Comment on attachment 255118 patch View in context: https://bugs.webkit.org/attachment.cgi?id=255118&action=review r=me > Source/WebKit2/ChangeLog:8 > + Clear the cache write queue on critical memory pressure. There can be substantial amount of memory there and we I thought you were going to hurry the writes instead but why not. This is much simpler :) > Source/WebKit2/NetworkProcess/NetworkProcess.cpp:184 > + nit: Seems unnecessary to add a line here. 1102949 4 koivisto 2015-06-18 10:17:47 -0700 https://trac.webkit.org/r185704 1106366 5 commit-queue 2015-07-02 05:11:01 -0700 Re-opened since this is blocked by bug 146544 255118 2015-06-18 09:24:45 -0700 2015-06-18 09:34:54 -0700 patch disk-cache-low-memory.patch text/plain 4899 koivisto SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTcwMSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE1LTA2LTE4ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICB+NCUgTWVtYnVzdGVyIHJlZ3Jl c3Npb24gYWZ0ZXIgV2ViS2l0IHIxODU0NTIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0NjExMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIENsZWFyIHRoZSBjYWNoZSB3cml0ZSBxdWV1ZSBvbiBjcml0aWNh bCBtZW1vcnkgcHJlc3N1cmUuIFRoZXJlIGNhbiBiZSBzdWJzdGFudGlhbCBhbW91bnQgb2YgbWVt b3J5IHRoZXJlIGFuZCB3ZQorICAgICAgICBkb24ndCBrbm93IGhvdyBsb25nIHdyaXRpbmcgaXQg b3V0IHdpbGwgdGFrZS4gU3lzdGVtIGlzIG9mdGVuIHVuZGVyIEkvTyBwcmVzc3VyZSB0b28gaW4g bG93IG1lbW9yeSBzaXR1YXRpb25zLgorCisgICAgICAgIFRoaXMgYWxzbyBtYWtlcyBzZW5zZSBm b3IgcHJvY2VzcyBzdXNwZW5zaW9uIHdoZXJlIHdlIHNlbmQgc2ltdWxhdGVkIGNyaXRpY2FsIG1l bW9yeSBldmVudC4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNw cDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya1Byb2Nlc3M6Omxvd01lbW9yeUhhbmRsZXIpOgor ICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZS5jcHA6CisgICAgICAg IChXZWJLaXQ6Ok5ldHdvcmtDYWNoZTo6Q2FjaGU6OmhhbmRsZU1lbW9yeVByZXNzdXJlTm90aWZp Y2F0aW9uKToKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuaDoK KyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTdG9yYWdlLmNwcDoK KyAgICAgICAgKFdlYktpdDo6TmV0d29ya0NhY2hlOjpTdG9yYWdlOjpjbGVhcldyaXRlUXVldWUp OgorICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVN0b3JhZ2UuaDoK KwogMjAxNS0wNi0xOCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAg ICAgICAgIEZpeCBtaXNzaW5nIGJyYWNlcyBhbmQgZGVwcmVjYXRlZCBkZWNsYXJhdGlvbnMgd2Fy bmluZ3MgaW4gV2ViS2l0Tm90aWZpY2F0aW9uUHJvdmlkZXIuY3BwCkluZGV4OiBTb3VyY2UvV2Vi S2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuY3BwCShyZXZpc2lvbiAx ODU2OTgpCisrKyBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTE3Niw3ICsxNzYsMTIgQEAgQXV0aGVudGljYXRpb25NYW5h Z2VyJiBOZXR3b3JrUHJvY2Vzczo6ZAogdm9pZCBOZXR3b3JrUHJvY2Vzczo6bG93TWVtb3J5SGFu ZGxlcihDcml0aWNhbCBjcml0aWNhbCkKIHsKICAgICBwbGF0Zm9ybUxvd01lbW9yeUhhbmRsZXIo Y3JpdGljYWwpOworI2lmIEVOQUJMRShORVRXT1JLX0NBQ0hFKQorICAgIGlmIChOZXR3b3JrQ2Fj aGU6OnNpbmdsZXRvbigpLmlzRW5hYmxlZCgpKQorICAgICAgICBOZXR3b3JrQ2FjaGU6OnNpbmds ZXRvbigpLmhhbmRsZU1lbW9yeVByZXNzdXJlTm90aWZpY2F0aW9uKGNyaXRpY2FsKTsKKyNlbmRp ZgogICAgIFdURjo6cmVsZWFzZUZhc3RNYWxsb2NGcmVlTWVtb3J5KCk7CisKIH0KIAogdm9pZCBO ZXR3b3JrUHJvY2Vzczo6aW5pdGlhbGl6ZU5ldHdvcmtQcm9jZXNzKGNvbnN0IE5ldHdvcmtQcm9j ZXNzQ3JlYXRpb25QYXJhbWV0ZXJzJiBwYXJhbWV0ZXJzKQpJbmRleDogU291cmNlL1dlYktpdDIv TmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwCShyZXZpc2lv biAxODU2OTgpCisrKyBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3Jr Q2FjaGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NjIsNiArNTYyLDE2IEBAIHZvaWQgQ2FjaGU6 OmNsZWFyKCkKICAgICBjbGVhcihzdGQ6OmNocm9ubzo6c3lzdGVtX2Nsb2NrOjp0aW1lX3BvaW50 OjptaW4oKSwgbnVsbHB0cik7CiB9CiAKK3ZvaWQgQ2FjaGU6OmhhbmRsZU1lbW9yeVByZXNzdXJl Tm90aWZpY2F0aW9uKFdlYkNvcmU6OkNyaXRpY2FsIGNyaXRpY2FsKQoreworICAgIGlmIChjcml0 aWNhbCAhPSBXZWJDb3JlOjpDcml0aWNhbDo6WWVzKQorICAgICAgICByZXR1cm47CisgICAgLy8g VGhlcmUgY2FuIGJlIHN1YnN0YW50aWFsIGFtb3VudCBvZiBtZW1vcnkgaW4gdGhlIHdyaXRlIHF1 ZXVlIGFuZCB3ZSBkb24ndCBrbm93IGhvdyBsb25nIGl0IHdpbGwgdGFrZSB0byB3cml0ZSBpdCBv dXQuCisgICAgLy8gV2UgbWF5IGFsc28gYmUgYWJvdXQgdG8gc3VzcGVuZCB0aGUgcHJvY2Vzcy4K KyAgICBpZiAobV9zdG9yYWdlKQorICAgICAgICBtX3N0b3JhZ2UtPmNsZWFyV3JpdGVRdWV1ZSgp OworfQorCiBTdHJpbmcgQ2FjaGU6OnJlY29yZHNQYXRoKCkgY29uc3QKIHsKICAgICByZXR1cm4g bV9zdG9yYWdlID8gbV9zdG9yYWdlLT5yZWNvcmRzUGF0aCgpIDogU3RyaW5nKCk7CkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUu aAkocmV2aXNpb24gMTg1Njk4KQorKysgU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2Fj aGUvTmV0d29ya0NhY2hlLmgJKHdvcmtpbmcgY29weSkKQEAgLTMxLDYgKzMxLDcgQEAKICNpbmNs dWRlICJOZXR3b3JrQ2FjaGVFbnRyeS5oIgogI2luY2x1ZGUgIk5ldHdvcmtDYWNoZVN0b3JhZ2Uu aCIKICNpbmNsdWRlICJTaGFyZWFibGVSZXNvdXJjZS5oIgorI2luY2x1ZGUgPFdlYkNvcmUvTWVt b3J5UHJlc3N1cmVIYW5kbGVyLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9SZXNvdXJjZVJlc3BvbnNl Lmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CiAKQEAgLTEwMyw2ICsxMDQsOCBA QCBwdWJsaWM6CiAgICAgdm9pZCBjbGVhcigpOwogICAgIHZvaWQgY2xlYXIoc3RkOjpjaHJvbm86 OnN5c3RlbV9jbG9jazo6dGltZV9wb2ludCBtb2RpZmllZFNpbmNlLCBzdGQ6OmZ1bmN0aW9uPHZv aWQgKCk+JiYgY29tcGxldGlvbkhhbmRsZXIpOwogCisgICAgdm9pZCBoYW5kbGVNZW1vcnlQcmVz c3VyZU5vdGlmaWNhdGlvbihXZWJDb3JlOjpDcml0aWNhbCk7CisKICAgICB2b2lkIGR1bXBDb250 ZW50c1RvRmlsZSgpOwogCiAgICAgU3RyaW5nIHJlY29yZHNQYXRoKCkgY29uc3Q7CkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTdG9yYWdlLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3 b3JrQ2FjaGVTdG9yYWdlLmNwcAkocmV2aXNpb24gMTg1Njk4KQorKysgU291cmNlL1dlYktpdDIv TmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3RvcmFnZS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTg2Miw2ICs4NjIsMTMgQEAgdm9pZCBTdG9yYWdlOjpzaHJpbmsoKQogICAgIH0pOwog fQogCit2b2lkIFN0b3JhZ2U6OmNsZWFyV3JpdGVRdWV1ZSgpCit7CisgICAgTE9HKE5ldHdvcmtD YWNoZVN0b3JhZ2UsICIoTmV0d29ya1Byb2Nlc3MpIGNsZWFyaW5nIHdyaXRlIHF1ZXVlIik7CisK KyAgICBtX3BlbmRpbmdXcml0ZU9wZXJhdGlvbnMuY2xlYXIoKTsKK30KKwogdm9pZCBTdG9yYWdl OjpkZWxldGVPbGRWZXJzaW9ucygpCiB7CiAgICAgYmFja2dyb3VuZElPUXVldWUoKS5kaXNwYXRj aChbdGhpc10gewpJbmRleDogU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0 d29ya0NhY2hlU3RvcmFnZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQ cm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVN0b3JhZ2UuaAkocmV2aXNpb24gMTg1Njk4KQorKysg U291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3RvcmFnZS5o CSh3b3JraW5nIGNvcHkpCkBAIC04MCw2ICs4MCw4IEBAIHB1YmxpYzoKICAgICAvLyBOdWxsIHJl Y29yZCBzaWduYWxzIGVuZC4KICAgICB2b2lkIHRyYXZlcnNlKFRyYXZlcnNlRmxhZ3MsIFRyYXZl cnNlSGFuZGxlciYmKTsKIAorICAgIHZvaWQgY2xlYXJXcml0ZVF1ZXVlKCk7CisKICAgICB2b2lk IHNldENhcGFjaXR5KHNpemVfdCk7CiAgICAgc2l6ZV90IGNhcGFjaXR5KCkgY29uc3QgeyByZXR1 cm4gbV9jYXBhY2l0eTsgfQogICAgIHNpemVfdCBhcHByb3hpbWF0ZVNpemUoKSBjb25zdDsK