146108 2015-06-18 04:37:50 -0700 [EFL] Use SET_AND_EXPOSE_TO_BUILD instead of definitions 2015-06-18 16:36:12 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi commit-queue lucas.de.marchi oldest_to_newest 1102876 0 ryuan.choi 2015-06-18 04:37:50 -0700 Since r183416, OptionsGTK uses SET_AND_EXPOSE_TO_BUILD to add definitions to both CMake and compiler. EFL port also can use it to simplify definitions. 1102878 1 255107 ryuan.choi 2015-06-18 04:41:23 -0700 Created attachment 255107 Patch 1102909 2 255107 gyuyoung.kim 2015-06-18 07:26:06 -0700 Comment on attachment 255107 Patch LGTM 1103081 3 255107 commit-queue 2015-06-18 16:36:07 -0700 Comment on attachment 255107 Patch Clearing flags on attachment: 255107 Committed r185725: <http://trac.webkit.org/changeset/185725> 1103082 4 commit-queue 2015-06-18 16:36:12 -0700 All reviewed patches have been landed. Closing bug. 255107 2015-06-18 04:41:23 -0700 2015-06-18 16:36:07 -0700 Patch bug-146108-20150618204045.patch text/plain 3517 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IGFkYTQ5 ODhhNzQwNjhlNTFiZDE1NjgzMjE1ZGVhOGNlMGVkNmZhMmQuLjFhMTg5NmE5YzE2NmIyYTAyNjhk Mjk3MzAwOGU1ZTAwY2MzM2ZhNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC0xNDIsOSArMTQy LDkgQEAgaWYgKEVOQUJMRV9FQ09SRV9YKQogICAgIGZpbmRfcGFja2FnZShYMTEgUkVRVUlSRUQp CiAKICAgICBsaXN0KEFQUEVORCBFQ09SRV9BRERJVElPTkFMX0NPTVBPTkVOVFMgWCkKLSAgICBh ZGRfZGVmaW5pdGlvbnMoLURIQVZFX0VDT1JFX1gpCi0gICAgYWRkX2RlZmluaXRpb25zKC1EV1RG X1BMQVRGT1JNX1gxMT0xKQotICAgIGFkZF9kZWZpbml0aW9ucygtRE1PWl9YMTEpCisgICAgU0VU X0FORF9FWFBPU0VfVE9fQlVJTEQoSEFWRV9FQ09SRV9YIDEpCisgICAgU0VUX0FORF9FWFBPU0Vf VE9fQlVJTEQoV1RGX1BMQVRGT1JNX1gxMSAxKQorICAgIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxE KE1PWl9YMTEgMSkKIGVuZGlmICgpCiAKIGlmIChFTkFCTEVfQUNDRVNTSUJJTElUWSkKQEAgLTE4 Niw3ICsxODYsNyBAQCBlbmRpZiAoKQogCiBpZiAoRU5BQkxFX01FRElBX1NUUkVBTSkKICAgICBm aW5kX3BhY2thZ2UoT3BlbldlYlJUQyBSRVFVSVJFRCkKLSAgICBhZGRfZGVmaW5pdGlvbnMoLURV U0VfT1BFTldFQlJUQykKKyAgICBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChVU0VfT1BFTldFQlJU QyBUUlVFKQogZW5kaWYgKCkKIAogaWYgKEVOQUJMRV9ORVRTQ0FQRV9QTFVHSU5fQVBJKQpAQCAt MTk1LDEzICsxOTUsMTIgQEAgZW5kaWYgKCkKIAogaWYgKFdURl9PU19VTklYKQogICAgIHNldChF TkFCTEVfWDExX1RBUkdFVCBPTikKLSAgICBhZGRfZGVmaW5pdGlvbnMoLURYUF9VTklYKQorICAg IFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKFhQX1VOSVggMSkKIGVuZGlmIChXVEZfT1NfVU5JWCkK IAogaWYgKEVOQUJMRV9WSURFTyBPUiBFTkFCTEVfV0VCX0FVRElPKQogICAgIHNldChHU1RSRUFN RVJfQ09NUE9ORU5UUyBhcHAgbXBlZ3RzIHBidXRpbHMpCi0gICAgc2V0KFVTRV9HU1RSRUFNRVIg MSkKLSAgICBhZGRfZGVmaW5pdGlvbnMoLURVU0VfR1NUUkVBTUVSPTEpCisgICAgU0VUX0FORF9F WFBPU0VfVE9fQlVJTEQoVVNFX0dTVFJFQU1FUiBUUlVFKQogCiAgICAgaWYgKEVOQUJMRV9WSURF TykKICAgICAgICAgbGlzdChBUFBFTkQgR1NUUkVBTUVSX0NPTVBPTkVOVFMgdmlkZW8gdGFnKQpA QCAtMjIwLDMzICsyMTksMjggQEAgaWYgKEVOQUJMRV9WSURFTyBPUiBFTkFCTEVfV0VCX0FVRElP KQogICAgIGVuZGlmICgpCiBlbmRpZiAoKQogCi1hZGRfZGVmaW5pdGlvbnMoLURVU0VfQ09PUkRJ TkFURURfR1JBUEhJQ1M9MSkKLWFkZF9kZWZpbml0aW9ucygtRFVTRV9DT09SRElOQVRFRF9HUkFQ SElDU19NVUxUSVBST0NFU1M9MSkKLWFkZF9kZWZpbml0aW9ucygtRFVTRV9URVhUVVJFX01BUFBF Uj0xKQotCi1zZXQoRU5BQkxFX0dSQVBISUNTX0NPTlRFWFRfM0QgMSkKLWFkZF9kZWZpbml0aW9u cygtREVOQUJMRV9HUkFQSElDU19DT05URVhUXzNEPTEpCi1hZGRfZGVmaW5pdGlvbnMoLURVU0Vf R1JBUEhJQ1NfU1VSRkFDRT0xKQorU0VUX0FORF9FWFBPU0VfVE9fQlVJTEQoRU5BQkxFX0dSQVBI SUNTX0NPTlRFWFRfM0QgVFJVRSkKK1NFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKFVTRV9DT09SRElO QVRFRF9HUkFQSElDUyBUUlVFKQorU0VUX0FORF9FWFBPU0VfVE9fQlVJTEQoVVNFX0NPT1JESU5B VEVEX0dSQVBISUNTX01VTFRJUFJPQ0VTUyBUUlVFKQorU0VUX0FORF9FWFBPU0VfVE9fQlVJTEQo VVNFX0dSQVBISUNTX1NVUkZBQ0UgVFJVRSkKK1NFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKFVTRV9U RVhUVVJFX01BUFBFUiBUUlVFKQogCiBvcHRpb24oRU5BQkxFX0dMRVMyICJFbmFibGUgR0xFUyBT dXBwb3J0IikKIGlmIChFTkFCTEVfR0xFUzIpCiAgICAgZmluZF9wYWNrYWdlKE9wZW5HTEVTMiBS RVFVSVJFRCkKLSAgICBzZXQoVVNFX09QRU5HTF9FU18yIDEpCi0gICAgYWRkX2RlZmluaXRpb25z KC1EVVNFX09QRU5HTF9FU18yPTEpCisgICAgU0VUX0FORF9FWFBPU0VfVE9fQlVJTEQoVVNFX09Q RU5HTF9FU18yIFRSVUUpCiBlbHNlICgpCiAgICAgZmluZF9wYWNrYWdlKE9wZW5HTCBSRVFVSVJF RCkKLSAgICBzZXQoVVNFX09QRU5HTCAxKQotICAgIGFkZF9kZWZpbml0aW9ucygtRFVTRV9PUEVO R0w9MSkKKyAgICBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChVU0VfT1BFTkdMIFRSVUUpCiBlbmRp ZiAoKQogCiBvcHRpb24oRU5BQkxFX0VHTCAiRW5hYmxlIEVHTCBTdXBwb3J0IikKIGlmIChFTkFC TEVfRUdMKQogICAgIGZpbmRfcGFja2FnZShFR0wgUkVRVUlSRUQpCi0gICAgc2V0KFVTRV9FR0wg MSkKLSAgICBhZGRfZGVmaW5pdGlvbnMoLURVU0VfRUdMPTEpCisgICAgU0VUX0FORF9FWFBPU0Vf VE9fQlVJTEQoVVNFX0VHTCBUUlVFKQogZWxzZSAoKQogICAgIENIRUNLX0lOQ0xVREVfRklMRVMo IkdML2dseC5oIiBPUEVOR0xYX0ZPVU5EKQotICAgIGFkZF9kZWZpbml0aW9ucygtRFVTRV9HTFg9 MSkKKyAgICBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChVU0VfR0xYIFRSVUUpCiBlbmRpZiAoKQog CiBpZiAoRU5BQkxFX1dFQkdMIEFORCBPUEVOR0xYX0ZPVU5EKQpAQCAtMjY2LDcgKzI2MCw2IEBA IGVuZGlmICgpCiAKIGlmIChFTkFCTEVfU1BFRUNIX1NZTlRIRVNJUykKICAgICBmaW5kX3BhY2th Z2UoRXNwZWFrIFJFUVVJUkVEKQotICAgIGFkZF9kZWZpbml0aW9ucygtREVOQUJMRV9TUEVFQ0hf U1lOVEhFU0lTPTEpCiBlbmRpZiAoKQogCiBpZiAoRU5BQkxFX0ZUTF9KSVQpCmRpZmYgLS1naXQg YS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNWRlMjJmNjE3MjgyZWU2YjI0ODRkMzRiM2Ni Mjg3YWNkOWZlYzFhZi4uOWFhNWY5NjQ0YTU1N2QxZWE3Yjc0YmM4NDdhNGI0ODMwNDFlNjUwNSAx MDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisy MDE1LTA2LTE4ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgorCisgICAg ICAgIFtFRkxdIFVzZSBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRCBpbnN0ZWFkIG9mIGRlZmluaXRp b25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDYx MDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNv dXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlOgorCiAyMDE1LTA2LTE2ICBSeXVhbiBDaG9pICA8 cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgogCiAgICAgICAgIFtFRkxdIFJlbW92ZSBkdXBsaWNh dGVkIFBVQkxJQyBhcmd1bWVudCBpbiBPcHRpb25zRWZsLmNtYWtlCg==