146097 2015-06-17 20:27:11 -0700 Remove redundant chromium bug macro 2015-06-18 02:23:55 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim commit-queue glenn ossy oldest_to_newest 1102789 0 gyuyoung.kim 2015-06-17 20:27:11 -0700 We don't need to keep BUGCR keyword for TestExpectations anymore. 1102790 1 255081 gyuyoung.kim 2015-06-17 20:28:04 -0700 Created attachment 255081 Patch 1102864 2 255081 ossy 2015-06-18 02:20:24 -0700 Comment on attachment 255081 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255081&action=review LGTM > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:151 > - expectation_line.warnings.append('BUG\d+ is not allowed, must be one of BUGCR\d+, BUGWK\d+, BUGV8_\d+, or a non-numeric bug identifier.') > + expectation_line.warnings.append('BUG\d+ is not allowed, must be one of BUGWK\d+, BUGV8_\d+, or a non-numeric bug identifier.') Please remove BUGV8 too before landing. 1102865 3 gyuyoung.kim 2015-06-18 02:23:32 -0700 Committed r185698: <http://trac.webkit.org/changeset/185698> 1102866 4 gyuyoung.kim 2015-06-18 02:23:55 -0700 (In reply to comment #2) > Comment on attachment 255081 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=255081&action=review > > LGTM > > > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:151 > > - expectation_line.warnings.append('BUG\d+ is not allowed, must be one of BUGCR\d+, BUGWK\d+, BUGV8_\d+, or a non-numeric bug identifier.') > > + expectation_line.warnings.append('BUG\d+ is not allowed, must be one of BUGWK\d+, BUGV8_\d+, or a non-numeric bug identifier.') > > Please remove BUGV8 too before landing. Done ! 255081 2015-06-17 20:28:04 -0700 2015-06-18 02:20:24 -0700 Patch bug-146097-20150618122731.patch text/plain 2325 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1Njg0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTEwNTYwNTk3MjVmMzZjYzcwNjAzODhlYWVhZmNkZjI5 NDE2MDU3NC4uNDRhYjliMjQzNzg3NmE4MzMyODQ3ZjhhOTM0MGQwMDI1MjdmYmFjNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE1LTA2LTE3ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBSZW1vdmUgcmVkdW5kYW50IENocm9taXVtIGJ1ZyBrZXl3b3JkCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDYwOTcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weToKKyAgICAgICAgKFRl c3RFeHBlY3RhdGlvblBhcnNlci5fcGFyc2VfbW9kaWZpZXJzKTogUmVtb3ZlIEJVR0NSIGZvciBU ZXN0RXhwZWN0YXRpb25zLgorICAgICAgICAoVGVzdEV4cGVjdGF0aW9uTGluZS5fZm9ybWF0X2xp bmUpOiBEZWxldGVkLgorCiAyMDE1LTA2LTE3ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVu c2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0NvbnRlbnQgRXh0ZW5zaW9uc10gRmFpbCB0byBw YXJzZSBpbnZhbGlkIGFycmF5cwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zLnB5IGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zLnB5CmluZGV4IDM3 MjYxMTk5MDZlNWNkYWUzNjVmOTBiODkyYTA1ZmI1ZmEwYzJmZTMuLmI2NGI0ZjdkNWQ3MDcxMDBi Y2IyODgwOWE1MTkzZDI3OTI2OTAzNTEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnMucHkK QEAgLTE0OCw3ICsxNDgsNyBAQCBjbGFzcyBUZXN0RXhwZWN0YXRpb25QYXJzZXIob2JqZWN0KToK ICAgICAgICAgICAgIGVsaWYgbW9kaWZpZXIuc3RhcnRzd2l0aChzZWxmLkJVR19NT0RJRklFUl9Q UkVGSVgpOgogICAgICAgICAgICAgICAgIGhhc19idWdpZCA9IFRydWUKICAgICAgICAgICAgICAg ICBpZiByZS5tYXRjaChzZWxmLkJVR19NT0RJRklFUl9SRUdFWCwgbW9kaWZpZXIpOgotICAgICAg ICAgICAgICAgICAgICBleHBlY3RhdGlvbl9saW5lLndhcm5pbmdzLmFwcGVuZCgnQlVHXGQrIGlz IG5vdCBhbGxvd2VkLCBtdXN0IGJlIG9uZSBvZiBCVUdDUlxkKywgQlVHV0tcZCssIEJVR1Y4X1xk Kywgb3IgYSBub24tbnVtZXJpYyBidWcgaWRlbnRpZmllci4nKQorICAgICAgICAgICAgICAgICAg ICBleHBlY3RhdGlvbl9saW5lLndhcm5pbmdzLmFwcGVuZCgnQlVHXGQrIGlzIG5vdCBhbGxvd2Vk LCBtdXN0IGJlIG9uZSBvZiBCVUdXS1xkKywgQlVHVjhfXGQrLCBvciBhIG5vbi1udW1lcmljIGJ1 ZyBpZGVudGlmaWVyLicpCiAgICAgICAgICAgICAgICAgZWxzZToKICAgICAgICAgICAgICAgICAg ICAgZXhwZWN0YXRpb25fbGluZS5wYXJzZWRfYnVnX21vZGlmaWVycy5hcHBlbmQobW9kaWZpZXIp CiAgICAgICAgICAgICBlbHNlOgpAQCAtNDQ3LDggKzQ0Nyw2IEBAIGNsYXNzIFRlc3RFeHBlY3Rh dGlvbkxpbmUob2JqZWN0KToKICAgICAgICAgICAgIG1vZGlmaWVyID0gbW9kaWZpZXIudXBwZXIo KQogICAgICAgICAgICAgaWYgbW9kaWZpZXIuc3RhcnRzd2l0aCgnQlVHV0snKToKICAgICAgICAg ICAgICAgICBidWdzLmFwcGVuZCgnd2Via2l0Lm9yZy9iLycgKyBtb2RpZmllci5yZXBsYWNlKCdC VUdXSycsICcnKSkKLSAgICAgICAgICAgIGVsaWYgbW9kaWZpZXIuc3RhcnRzd2l0aCgnQlVHQ1In KToKLSAgICAgICAgICAgICAgICBidWdzLmFwcGVuZCgnY3JidWcuY29tLycgKyBtb2RpZmllci5y ZXBsYWNlKCdCVUdDUicsICcnKSkKICAgICAgICAgICAgIGVsaWYgbW9kaWZpZXIuc3RhcnRzd2l0 aCgnQlVHJyk6CiAgICAgICAgICAgICAgICAgIyBGSVhNRTogd2Ugc2hvdWxkIHByZXNlcnZlIGNh c2Ugb25jZSB3ZSBjYW4gZHJvcCB0aGUgb2xkIHN5bnRheC4KICAgICAgICAgICAgICAgICBidWdz LmFwcGVuZCgnQnVnKCcgKyBtb2RpZmllclszOl0ubG93ZXIoKSArICcpJykK