146084 2015-06-17 16:09:30 -0700 Also turn off long press on link preview. 2015-06-17 18:06:00 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yongjun_zhang webkit-unassigned andersca bdakin commit-queue mitz sam thorton oldest_to_newest 1102690 0 yongjun_zhang 2015-06-17 16:09:30 -0700 We also need to turn off long press on link preview. 1102691 1 yongjun_zhang 2015-06-17 16:10:27 -0700 <rdar://problem/21388784> 1102703 2 255050 yongjun_zhang 2015-06-17 16:49:57 -0700 Created attachment 255050 Patch. 1102706 3 255050 thorton 2015-06-17 16:55:47 -0700 Comment on attachment 255050 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=255050&action=review > Source/WebKit2/ChangeLog:3 > + Also turn off long press on link preview. "also" is kind of weird since there's no reference to what you had previously turned off. 1102732 4 255050 commit-queue 2015-06-17 18:05:55 -0700 Comment on attachment 255050 Patch. Clearing flags on attachment: 255050 Committed r185684: <http://trac.webkit.org/changeset/185684> 1102733 5 commit-queue 2015-06-17 18:06:00 -0700 All reviewed patches have been landed. Closing bug. 255050 2015-06-17 16:49:57 -0700 2015-06-17 18:05:55 -0700 Patch. disable_long_press.patch text/plain 2383 yongjun_zhang Y29tbWl0IDRmYmNiMThhZDI1N2FmMWExMzJmZjM4ZDRhMzRlYWVhOGJlMDRhOTEKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBXZWQgSnVuIDE3 IDE2OjA0OjA0IDIwMTUgLTA3MDAKCiAgICBBbHNvIHR1cm4gb2ZmIGxvbmcgcHJlc3Mgb24gbGlu ayBwcmV2aWV3LgogICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvYXR0YWNobWVudC5jZ2k/YnVn aWQ9MTQ2MDg0CgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNl L1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDJhZmY3YzAuLjFiYWNkNjkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxNS0wNi0xNyAgWW9uZ2p1biBaaGFuZyAgPHlvbmdqdW5femhhbmdA YXBwbGUuY29tPgorCisgICAgICAgIEFsc28gdHVybiBvZmYgbG9uZyBwcmVzcyBvbiBsaW5rIHBy ZXZpZXcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDYwODQKKworICAgICAgICBBbHNvIHR1cm4gb2ZmIGxvbmcgcHJlc3NzIGdlc3R1cmUgd2hlbiBw cmV2aWV3aW5nLiBUdXJuIHRoYXQgYmFjayBvbiB3aGVuIHByZXZpZXcgaXMgY29tcGxldGVkLgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9j ZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVu dFZpZXcgd2lsbFByZXNlbnRQcmV2aWV3Vmlld0NvbnRyb2xsZXI6Zm9yUG9zaXRpb246aW5Tb3Vy Y2VWaWV3Ol0pOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGRpZERpc21pc3NQcmV2aWV3Vmll d0NvbnRyb2xsZXI6Y29tbWl0dGluZzpdKToKKwogMjAxNS0wNi0xNyAgVGltIEhvcnRvbiAgPHRp bW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXBybyBjcmFzaCB3aGVuIHN3aXBp bmcgYmFjayBmcm9tIGEgTlkgVGltZXMgYXJ0aWNsZSBAIFdlYlBhZ2VQcm94eTo6bmF2aWdhdGlv bkdlc3R1cmVEaWRFbmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3Mv V0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lv cy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXggNGNkNDg1Ny4uMjMwNmNhOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJh Y3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3 SW50ZXJhY3Rpb24ubW0KQEAgLTMxNTMsNiArMzE1Myw3IEBAIHN0YXRpYyBib29sIGlzQXNzaXN0 YWJsZUlucHV0VHlwZShJbnB1dFR5cGUgdHlwZSkKIC0gKHZvaWQpd2lsbFByZXNlbnRQcmV2aWV3 Vmlld0NvbnRyb2xsZXI6KFVJVmlld0NvbnRyb2xsZXIgKil2aWV3Q29udHJvbGxlciBmb3JQb3Np dGlvbjooQ0dQb2ludClwb3NpdGlvbiBpblNvdXJjZVZpZXc6KFVJVmlldyAqKXNvdXJjZVZpZXcK IHsKICAgICBbc2VsZiByZW1vdmVHZXN0dXJlUmVjb2duaXplcjpfdG91Y2hFdmVudEdlc3R1cmVS ZWNvZ25pemVyLmdldCgpXTsKKyAgICBbc2VsZiByZW1vdmVHZXN0dXJlUmVjb2duaXplcjpfbG9u Z1ByZXNzR2VzdHVyZVJlY29nbml6ZXIuZ2V0KCldOwogCiAgICAgW3NlbGYgX2NhbmNlbEludGVy YWN0aW9uXTsKICAgICBbW3ZpZXdDb250cm9sbGVyIHByZXNlbnRhdGlvbkNvbnRyb2xsZXJdIHNl dFNvdXJjZVJlY3Q6X3Bvc2l0aW9uSW5mb3JtYXRpb24uYm91bmRzXTsKQEAgLTMxNjEsNiArMzE2 Miw3IEBAIHN0YXRpYyBib29sIGlzQXNzaXN0YWJsZUlucHV0VHlwZShJbnB1dFR5cGUgdHlwZSkK IC0gKHZvaWQpZGlkRGlzbWlzc1ByZXZpZXdWaWV3Q29udHJvbGxlcjooVUlWaWV3Q29udHJvbGxl ciAqKXZpZXdDb250cm9sbGVyIGNvbW1pdHRpbmc6KEJPT0wpY29tbWl0dGluZwogewogICAgIFtz ZWxmIGFkZEdlc3R1cmVSZWNvZ25pemVyOl90b3VjaEV2ZW50R2VzdHVyZVJlY29nbml6ZXIuZ2V0 KCldOworICAgIFtzZWxmIGFkZEdlc3R1cmVSZWNvZ25pemVyOl9sb25nUHJlc3NHZXN0dXJlUmVj b2duaXplci5nZXQoKV07CiAKICAgICBpZDxXS1VJRGVsZWdhdGVQcml2YXRlPiB1aURlbGVnYXRl ID0gc3RhdGljX2Nhc3Q8aWQgPFdLVUlEZWxlZ2F0ZVByaXZhdGU+PihbX3dlYlZpZXcgVUlEZWxl Z2F0ZV0pOwogICAgIGlmIChbdWlEZWxlZ2F0ZSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9y KF93ZWJWaWV3OmRpZERpc21pc3NQcmV2aWV3Vmlld0NvbnRyb2xsZXI6KV0pCg==