146080 2015-06-17 15:04:18 -0700 Web Inspector: Fix shape-highlight layout tests 2015-07-09 15:09:02 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 hi webkit-unassigned burg commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1102662 0 hi 2015-06-17 15:04:18 -0700 Currently, the tests in LayoutTests/inspector/dom/ are failing with unknown errors. These fixes are expecting the changes in https://bugs.webkit.org/show_bug.cgi?id=145658 to be made. 1102663 1 255040 hi 2015-06-17 15:08:40 -0700 Created attachment 255040 Patch 1102664 2 255040 joepeck 2015-06-17 15:09:44 -0700 Comment on attachment 255040 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255040&action=review > Source/WebCore/inspector/InspectorOverlay.cpp:668 > - shapeObject->setMarginShape(shapePath.copyRef()); > + shapeObject->setMarginShape(marginShapePath.copyRef()); Yay! > LayoutTests/http/tests/inspector/dom/shapes-test.js:35 > + InspectorTest.assert(!error, "When evaluating code, received unexpected error:" + error); > + InspectorTest.assert(!error, "When evaluating code, an exception was thrown:" + wasThrown); Missing LayoutTests/ChangeLog entry for the updates to this file. r- so you can add a changelog. Otherwise the patch looks great! 1102666 3 255041 hi 2015-06-17 15:19:43 -0700 Created attachment 255041 Patch 1102673 4 255041 joepeck 2015-06-17 15:23:54 -0700 Comment on attachment 255041 Patch r=me 1108322 5 webkit-bug-importer 2015-07-09 13:35:46 -0700 <rdar://problem/21752788> 1108323 6 255041 commit-queue 2015-07-09 13:36:01 -0700 Comment on attachment 255041 Patch Rejecting attachment 255041 from commit-queue. drousso@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 1108408 7 255041 commit-queue 2015-07-09 15:08:58 -0700 Comment on attachment 255041 Patch Clearing flags on attachment: 255041 Committed r186639: <http://trac.webkit.org/changeset/186639> 1108409 8 commit-queue 2015-07-09 15:09:02 -0700 All reviewed patches have been landed. Closing bug. 255040 2015-06-17 15:08:40 -0700 2015-06-17 15:19:39 -0700 Patch bug-146080-20150617150803.patch text/plain 2409 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkNWFkMGMxMjBiYmQ5YjI5ZGEwOTZmYTcxMjVkZWQyNjFkZTIyNjhjLi42 NzcxMWIwMTg4ZDU1MTVhNjc0ZWU5MDZjZmIwZTNjM2Q1M2U1MDA0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTUtMDYtMTcgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29t PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEZpeCBzaGFwZS1oaWdobGlnaHQgbGF5b3V0IHRl c3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDYw ODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGlu c3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmJ1aWxkT2Jq ZWN0Rm9yU2hhcGVPdXRzaWRlKTogTm93IHByb3Blcmx5IHJldHVybnMgdGhlIHNoYXBlIG1hcmdp bi4KKwogMjAxNS0wNi0xNyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4K IAogICAgICAgICBSRUdSRVNTSU9OIChyMTczMjgzLXIxNzMyOTYpOiBBbWF6b24uY29tIGZyb250 IHBhZ2UgaGFzIG5vIGNhcmV0IGluIHRoZSBzZWFyY2ggZmllbGQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5LmNwcAppbmRleCAyNWVkMTZiY2Q4NmUyMzg0ZWQy NjVkMDlmYmNiM2FkNjI4ZWVjN2JjLi5lMzU1ZTQ3ZDU3NTQ1NDBjZDg5ZmI1MzQ4MDQwZTA1MjQw NGFiYjBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yT3Zl cmxheS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvck92ZXJsYXku Y3BwCkBAIC02NjUsNyArNjY1LDcgQEAgc3RhdGljIFJlZlB0cjxJbnNwZWN0b3I6OlByb3RvY29s OjpPdmVybGF5VHlwZXM6OlNoYXBlT3V0c2lkZURhdGE+IGJ1aWxkT2JqZWN0Rm8KIAogICAgICAg ICAgICAgcGF0aHMubWFyZ2luU2hhcGUuYXBwbHkoJmluZm8sICZhcHBlbmRQYXRoU2VnbWVudCk7 CiAKLSAgICAgICAgICAgIHNoYXBlT2JqZWN0LT5zZXRNYXJnaW5TaGFwZShzaGFwZVBhdGguY29w eVJlZigpKTsKKyAgICAgICAgICAgIHNoYXBlT2JqZWN0LT5zZXRNYXJnaW5TaGFwZShtYXJnaW5T aGFwZVBhdGguY29weVJlZigpKTsKICAgICAgICAgfQogICAgIH0KIApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3IvZG9tL3NoYXBlcy10ZXN0LmpzIGIvTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3IvZG9tL3NoYXBlcy10ZXN0LmpzCmluZGV4IDIzYzU2 OTU2NDBiMGZiZmY2ZGJkY2VhMDY2NzFmNTNiZmY3Y2E1OTYuLmJjY2U5ZjE5YTM4Y2ZmY2I2OGZj ZTNjZDJiZDkyNWMwNWY1M2YwMzAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMv aW5zcGVjdG9yL2RvbS9zaGFwZXMtdGVzdC5qcworKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3Rz L2luc3BlY3Rvci9kb20vc2hhcGVzLXRlc3QuanMKQEAgLTMxLDExICszMSwxMSBAQCBJbnNwZWN0 b3JUZXN0LlNoYXBlcyA9IHsKICAgICAgICAgfQogCiAgICAgICAgIGZ1bmN0aW9uIHJlY2VpdmVk SGlnaGxpZ2h0T2JqZWN0KGVycm9yLCBwYXlsb2FkLCB3YXNUaHJvd24pIHsKLSAgICAgICAgICAg IGNvbnNvbGUuYXNzZXJ0KCFlcnJvciwgIldoZW4gZXZhbHVhdGluZyBjb2RlLCByZWNlaXZlZCB1 bmV4cGVjdGVkIGVycm9yOiIgKyBlcnJvcik7Ci0gICAgICAgICAgICBjb25zb2xlLmFzc2VydCgh ZXJyb3IsICJXaGVuIGV2YWx1YXRpbmcgY29kZSwgYW4gZXhjZXB0aW9uIHdhcyB0aHJvd246IiAr IHdhc1Rocm93bik7CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmFzc2VydCghZXJyb3IsICJX aGVuIGV2YWx1YXRpbmcgY29kZSwgcmVjZWl2ZWQgdW5leHBlY3RlZCBlcnJvcjoiICsgZXJyb3Ip OworICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5hc3NlcnQoIWVycm9yLCAiV2hlbiBldmFsdWF0 aW5nIGNvZGUsIGFuIGV4Y2VwdGlvbiB3YXMgdGhyb3duOiIgKyB3YXNUaHJvd24pOwogCiAgICAg ICAgICAgICB2YXIgZGF0YSA9IEpTT04ucGFyc2UocGF5bG9hZC52YWx1ZSk7Ci0gICAgICAgICAg ICBjYWxsYmFjayhkYXRhLmVsZW1lbnRJbmZvLnNoYXBlT3V0c2lkZUluZm8pOworICAgICAgICAg ICAgY2FsbGJhY2soZGF0YVswXS5lbGVtZW50RGF0YS5zaGFwZU91dHNpZGVEYXRhKTsKICAgICAg ICAgfQogICAgIH0sCiAK 255041 2015-06-17 15:19:43 -0700 2015-07-09 15:08:58 -0700 Patch bug-146080-20150617151907.patch text/plain 3051 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkNWFkMGMxMjBiYmQ5YjI5ZGEwOTZmYTcxMjVkZWQyNjFkZTIyNjhjLi42 NzcxMWIwMTg4ZDU1MTVhNjc0ZWU5MDZjZmIwZTNjM2Q1M2U1MDA0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTUtMDYtMTcgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29t PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEZpeCBzaGFwZS1oaWdobGlnaHQgbGF5b3V0IHRl c3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDYw ODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGlu c3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmJ1aWxkT2Jq ZWN0Rm9yU2hhcGVPdXRzaWRlKTogTm93IHByb3Blcmx5IHJldHVybnMgdGhlIHNoYXBlIG1hcmdp bi4KKwogMjAxNS0wNi0xNyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4K IAogICAgICAgICBSRUdSRVNTSU9OIChyMTczMjgzLXIxNzMyOTYpOiBBbWF6b24uY29tIGZyb250 IHBhZ2UgaGFzIG5vIGNhcmV0IGluIHRoZSBzZWFyY2ggZmllbGQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5LmNwcAppbmRleCAyNWVkMTZiY2Q4NmUyMzg0ZWQy NjVkMDlmYmNiM2FkNjI4ZWVjN2JjLi5lMzU1ZTQ3ZDU3NTQ1NDBjZDg5ZmI1MzQ4MDQwZTA1MjQw NGFiYjBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yT3Zl cmxheS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvck92ZXJsYXku Y3BwCkBAIC02NjUsNyArNjY1LDcgQEAgc3RhdGljIFJlZlB0cjxJbnNwZWN0b3I6OlByb3RvY29s OjpPdmVybGF5VHlwZXM6OlNoYXBlT3V0c2lkZURhdGE+IGJ1aWxkT2JqZWN0Rm8KIAogICAgICAg ICAgICAgcGF0aHMubWFyZ2luU2hhcGUuYXBwbHkoJmluZm8sICZhcHBlbmRQYXRoU2VnbWVudCk7 CiAKLSAgICAgICAgICAgIHNoYXBlT2JqZWN0LT5zZXRNYXJnaW5TaGFwZShzaGFwZVBhdGguY29w eVJlZigpKTsKKyAgICAgICAgICAgIHNoYXBlT2JqZWN0LT5zZXRNYXJnaW5TaGFwZShtYXJnaW5T aGFwZVBhdGguY29weVJlZigpKTsKICAgICAgICAgfQogICAgIH0KIApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGI0ZTgyNmIw N2E0ODFkMTJlMTEyNzYzMGIzZGYwY2QzNTEwYjgxZmEuLjFmMzZlMGM1YmY1OWJmYzViZWNkYjFk MDExZjBkMmE1ZTA1OGZkMWEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNS0wNi0xNyAgRGV2 aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog Rml4IHNoYXBlLWhpZ2hsaWdodCBsYXlvdXQgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjA4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHR0cC90ZXN0cy9pbnNwZWN0b3IvZG9tL3NoYXBl cy10ZXN0LmpzOiBVcGRhdGVkLgorCiAyMDE1LTA2LTE3ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5m cmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxNzMyODMtcjE3MzI5Nik6 IEFtYXpvbi5jb20gZnJvbnQgcGFnZSBoYXMgbm8gY2FyZXQgaW4gdGhlIHNlYXJjaCBmaWVsZApk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3IvZG9tL3NoYXBlcy10 ZXN0LmpzIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3IvZG9tL3NoYXBlcy10ZXN0 LmpzCmluZGV4IDIzYzU2OTU2NDBiMGZiZmY2ZGJkY2VhMDY2NzFmNTNiZmY3Y2E1OTYuLmJjY2U5 ZjE5YTM4Y2ZmY2I2OGZjZTNjZDJiZDkyNWMwNWY1M2YwMzAgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2RvbS9zaGFwZXMtdGVzdC5qcworKysgYi9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9kb20vc2hhcGVzLXRlc3QuanMKQEAgLTMxLDExICsz MSwxMSBAQCBJbnNwZWN0b3JUZXN0LlNoYXBlcyA9IHsKICAgICAgICAgfQogCiAgICAgICAgIGZ1 bmN0aW9uIHJlY2VpdmVkSGlnaGxpZ2h0T2JqZWN0KGVycm9yLCBwYXlsb2FkLCB3YXNUaHJvd24p IHsKLSAgICAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KCFlcnJvciwgIldoZW4gZXZhbHVhdGluZyBj b2RlLCByZWNlaXZlZCB1bmV4cGVjdGVkIGVycm9yOiIgKyBlcnJvcik7Ci0gICAgICAgICAgICBj b25zb2xlLmFzc2VydCghZXJyb3IsICJXaGVuIGV2YWx1YXRpbmcgY29kZSwgYW4gZXhjZXB0aW9u IHdhcyB0aHJvd246IiArIHdhc1Rocm93bik7CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmFz c2VydCghZXJyb3IsICJXaGVuIGV2YWx1YXRpbmcgY29kZSwgcmVjZWl2ZWQgdW5leHBlY3RlZCBl cnJvcjoiICsgZXJyb3IpOworICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5hc3NlcnQoIWVycm9y LCAiV2hlbiBldmFsdWF0aW5nIGNvZGUsIGFuIGV4Y2VwdGlvbiB3YXMgdGhyb3duOiIgKyB3YXNU aHJvd24pOwogCiAgICAgICAgICAgICB2YXIgZGF0YSA9IEpTT04ucGFyc2UocGF5bG9hZC52YWx1 ZSk7Ci0gICAgICAgICAgICBjYWxsYmFjayhkYXRhLmVsZW1lbnRJbmZvLnNoYXBlT3V0c2lkZUlu Zm8pOworICAgICAgICAgICAgY2FsbGJhY2soZGF0YVswXS5lbGVtZW50RGF0YS5zaGFwZU91dHNp ZGVEYXRhKTsKICAgICAgICAgfQogICAgIH0sCiAK