146075 2015-06-17 13:19:38 -0700 [EFL] test_ewk2_context_url_scheme_register has been crashed since r185553 2015-06-18 00:15:11 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 132813 145969 146046 1 ryuan.choi ryuan.choi cgarcia gyuyoung.kim lucas.de.marchi oldest_to_newest 1102629 0 ryuan.choi 2015-06-17 13:19:38 -0700 Since r185553, CustomProtocolManager sends StartLoading with request of SoupGenericRequest instead of request itself. But, EFL port does not set m_initiatingPageID via InjectedBundle, so updateSoupRequest did not update request of SoupGenericRequest via webkitSoupRequestGenericSetRequest. 1102642 1 255036 ryuan.choi 2015-06-17 14:16:50 -0700 Created attachment 255036 one suggestion 1102814 2 255036 cgarcia 2015-06-17 22:51:59 -0700 Comment on attachment 255036 one suggestion View in context: https://bugs.webkit.org/attachment.cgi?id=255036&action=review > Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:-127 > - if (!m_initiatingPageID) > - return; Ah, sorry, I didn't notice this early return. > Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:130 > + if (m_initiatingPageID) { > + uint64_t* initiatingPageIDPtr = static_cast<uint64_t*>(fastMalloc(sizeof(uint64_t))); > + *initiatingPageIDPtr = m_initiatingPageID; > + g_object_set_data_full(G_OBJECT(soupRequest), g_intern_static_string(gSoupRequestInitiatingPageIDKey), initiatingPageIDPtr, fastFree); > + } This correct. 1102826 3 255036 ryuan.choi 2015-06-17 23:30:49 -0700 Comment on attachment 255036 one suggestion Clearing flags on attachment: 255036 Committed r185693: <http://trac.webkit.org/changeset/185693> 1102827 4 ryuan.choi 2015-06-17 23:31:01 -0700 All reviewed patches have been landed. Closing bug. 255036 2015-06-17 14:16:50 -0700 2015-06-17 23:30:49 -0700 one suggestion bug-146075-20150618061613.patch text/plain 2492 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWM1ZDljMTU2MWIwMGEz ZGRkZWFjNTdiMDFiYmM0OTFlODZhYjc1NS4uNTgyODA1OGM4M2M2ZTE0NTY2NWY1YWUyM2U1ZDYz MTg5ZmE1MTRlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA2LTE3ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtFRkxdIHRlc3Rf ZXdrMl9jb250ZXh0X3VybF9zY2hlbWVfcmVnaXN0ZXIgaGFzIGJlZW4gY3Jhc2hlZCBzaW5jZSBy MTg1NTUzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDYwNzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBT aW5jZSByMTg1NTUzLCBDdXN0b21Qcm90b2NvbE1hbmFnZXIgc2VuZHMgU3RhcnRMb2FkaW5nIG1l c3NhZ2UgdG8gVUlQcm9jZXNzCisgICAgICAgIHdpdGggcmVxdWVzdCBvZiBTb3VwR2VuZXJpY1Jl cXVlc3QgaW5zdGVhZCBvZiByZXF1ZXN0IGl0c2VsZi4KKyAgICAgICAgQnV0LCByZXF1ZXN0IG9m IFNvdXBHZW5lcmljUmVxdWVzdCBpcyBudWxscHRyIGluIEVGTCBwb3J0IGJlY2F1c2UgRUZMIHBv cnQKKyAgICAgICAgZG9lcyBub3QgdXNlIG1faW5pdGlhdGluZ1BhZ2VJRC4KKworICAgICAgICBU aGlzIHBhdGNoIHVwZGF0ZXMgcmVxdWVzdCBvZiBTb3VwR2VuZXJpY1JlcXVlc3QgYWx0aG91Z2gg bV9pbml0aWF0aW5nUGFnZUlEIGlzIG51bGwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3Jr L3NvdXAvUmVzb3VyY2VSZXF1ZXN0U291cC5jcHA6IAorICAgICAgICAoV2ViQ29yZTo6UmVzb3Vy Y2VSZXF1ZXN0Ojp1cGRhdGVTb3VwUmVxdWVzdCk6CisKIDIwMTUtMDYtMTYgIEFsZXggQ2hyaXN0 ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbQ29udGVudCBFeHRl bnNpb25zXSBJbXBsZW1lbnQgYnJhbmNoIGNvbXBhY3Rpb24gZm9yIERGQSBieXRlY29kZS4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJl cXVlc3RTb3VwLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNv dXJjZVJlcXVlc3RTb3VwLmNwcAppbmRleCA0YzY2YWU1ZWVmM2Q5Y2U4MDE1OTAzNjdkNDExNmUx MzQ0OWQ0OTUyLi4wMjdmZGE5NWJkZDRlMzg2YmFhNmQ2YmY3YWFmYTg2NmU1MzNjNjAzIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VSZXF1 ZXN0U291cC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jl c291cmNlUmVxdWVzdFNvdXAuY3BwCkBAIC0xMjMsMTIgKzEyMywxMSBAQCBzdGF0aWMgY29uc3Qg Y2hhciogZ1NvdXBSZXF1ZXN0SW5pdGlhdGluZ1BhZ2VJREtleSA9ICJ3ay1zb3VwLXJlcXVlc3Qt aW5pdGlhdGluZwogCiB2b2lkIFJlc291cmNlUmVxdWVzdDo6dXBkYXRlU291cFJlcXVlc3QoU291 cFJlcXVlc3QqIHNvdXBSZXF1ZXN0KSBjb25zdAogewotICAgIGlmICghbV9pbml0aWF0aW5nUGFn ZUlEKQotICAgICAgICByZXR1cm47Ci0KLSAgICB1aW50NjRfdCogaW5pdGlhdGluZ1BhZ2VJRFB0 ciA9IHN0YXRpY19jYXN0PHVpbnQ2NF90Kj4oZmFzdE1hbGxvYyhzaXplb2YodWludDY0X3QpKSk7 Ci0gICAgKmluaXRpYXRpbmdQYWdlSURQdHIgPSBtX2luaXRpYXRpbmdQYWdlSUQ7Ci0gICAgZ19v YmplY3Rfc2V0X2RhdGFfZnVsbChHX09CSkVDVChzb3VwUmVxdWVzdCksIGdfaW50ZXJuX3N0YXRp Y19zdHJpbmcoZ1NvdXBSZXF1ZXN0SW5pdGlhdGluZ1BhZ2VJREtleSksIGluaXRpYXRpbmdQYWdl SURQdHIsIGZhc3RGcmVlKTsKKyAgICBpZiAobV9pbml0aWF0aW5nUGFnZUlEKSB7CisgICAgICAg IHVpbnQ2NF90KiBpbml0aWF0aW5nUGFnZUlEUHRyID0gc3RhdGljX2Nhc3Q8dWludDY0X3QqPihm YXN0TWFsbG9jKHNpemVvZih1aW50NjRfdCkpKTsKKyAgICAgICAgKmluaXRpYXRpbmdQYWdlSURQ dHIgPSBtX2luaXRpYXRpbmdQYWdlSUQ7CisgICAgICAgIGdfb2JqZWN0X3NldF9kYXRhX2Z1bGwo R19PQkpFQ1Qoc291cFJlcXVlc3QpLCBnX2ludGVybl9zdGF0aWNfc3RyaW5nKGdTb3VwUmVxdWVz dEluaXRpYXRpbmdQYWdlSURLZXkpLCBpbml0aWF0aW5nUGFnZUlEUHRyLCBmYXN0RnJlZSk7Cisg ICAgfQogCiAgICAgaWYgKFdFQktJVF9JU19TT1VQX1JFUVVFU1RfR0VORVJJQyhzb3VwUmVxdWVz dCkpCiAgICAgICAgIHdlYmtpdFNvdXBSZXF1ZXN0R2VuZXJpY1NldFJlcXVlc3QoV0VCS0lUX1NP VVBfUkVRVUVTVF9HRU5FUklDKHNvdXBSZXF1ZXN0KSwgKnRoaXMpOwo=