146074 2015-06-17 13:11:35 -0700 Client may receive began editing callback for already focused text field 2015-06-17 21:39:42 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates andersca jberlin sam oldest_to_newest 1102625 0 dbates 2015-06-17 13:11:35 -0700 An embedding client should only receive a began editing callback when a text field is newly focused. That is, subsequently focusing the text field by dispatching a programmatic DOM focus event at it should not dispatch a began editing callback. 1102626 1 dbates 2015-06-17 13:12:43 -0700 <rdar://problem/21293562> 1102633 2 255032 dbates 2015-06-17 13:30:33 -0700 Created attachment 255032 Patch and unit test We should look to further clean up TextFieldInputType::forwardEvent(), including moving the logic to update the caps lock indicator state from TextFieldInputType::forwardEvent() to TextFieldInputType::handle{Blur, Focus}Event(). I suggest we do such clean up in another bug. 1102799 3 255032 dbates 2015-06-17 21:39:39 -0700 Comment on attachment 255032 Patch and unit test Clearing flags on attachment: 255032 Committed r185692: <http://trac.webkit.org/changeset/185692> 1102800 4 dbates 2015-06-17 21:39:42 -0700 All reviewed patches have been landed. Closing bug. 255032 2015-06-17 13:30:33 -0700 2015-06-17 21:39:39 -0700 Patch and unit test bug-146074-20150617132957.patch text/plain 5367 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NjU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDRhYTBmYzFiYzA3ZGNi YTIyOTNlMmI4NTI1Y2VkMzk3ZjgyYjM2Mi4uNGU4MDk0MTAzZWY3NWJjYmI2OGUyMTQ0ZGM3Yjlj ZGMxNjE1YzcwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE1LTA2LTE3ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBDbGllbnQgbWF5IHJlY2Vp dmUgYmVnYW4gZWRpdGluZyBjYWxsYmFjayBmb3IgYWxyZWFkeSBmb2N1c2VkIHRleHQgZmllbGQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjA3NAor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjEyOTM1NjI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXMgYW4gaXNzdWUgd2hlcmUgdGhlIGNsaWVu dCB3b3VsZCBiZSBub3RpZmllZCB0aGF0IGJlZ2FuIGVkaXRpbmcgaW4gYSB0ZXh0IGZpZWxkCisg ICAgICAgIGZvciBlYWNoIHByb2dyYW1tYXRpYyBET00gZm9jdXMgZXZlbnQgZGlzcGF0Y2hlZCBh dCB0aGUgdGV4dCBmaWVsZCByZWdhcmRsZXNzIG9mCisgICAgICAgIHdoZXRoZXIgdGhlIGZpZWxk IHdhcyBmb2N1c2VkLiBUaGUgY2xpZW50IHNob3VsZCBvbmx5IGJlIG5vdGlmaWVkIHRoYXQgYmVn YW4gZWRpdGluZworICAgICAgICBleGFjdGx5IG9uY2Ugd2hlbiBhIHRleHQgZmllbGQgYmVjb21l cyBmb2N1c2VkIChlaXRoZXIgcHJvZ3JhbW1hdGljYWxseSBvciBieSB1c2VyIGludGVyYWN0aW9u KS4KKworICAgICAgICAqIGh0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlRleHRGaWVsZElucHV0VHlwZTo6Zm9yd2FyZEV2ZW50KTogTW92ZSBsb2dpYyB0byBk aXNwYXRjaCBlZGl0aW5nIGJlZ2FuIGNhbGxiYWNrIGZyb20gaGVyZS4uLgorICAgICAgICAoV2Vi Q29yZTo6VGV4dEZpZWxkSW5wdXRUeXBlOjpoYW5kbGVGb2N1c0V2ZW50KTogdG8gaGVyZS4gVGhp cyBmdW5jdGlvbiBpcyBjYWxsZWQgd2hlbiB0aGUKKyAgICAgICAgdGV4dCBmaWVsZCBiZWNvbWVz IG5ld2x5IGZvY3VzZWQuCisgICAgICAgICogaHRtbC9UZXh0RmllbGRJbnB1dFR5cGUuaDoKKwog MjAxNS0wNi0xNyAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAg ICAgIEFYOiBpbnB1dCByb2xlPSJzcGluYnV0dG9uIiBnZXRzIHNraXBwZWQgaW4gdm9pY2VvdmVy CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL1RleHRGaWVsZElucHV0VHlwZS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL1RleHRGaWVsZElucHV0VHlwZS5jcHAKaW5kZXggZDM2OWRh YTE2NDFmZDY5MDk4NTVlYmIwYmJkYWEwZTIxYjNkOTg2Ny4uN2Q1YjE0NmJhM2MxZDgzZGViZTE2 ZWNjMmViYTBiNzhhOTYyNTdlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0 RmllbGRJbnB1dFR5cGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvVGV4dEZpZWxkSW5w dXRUeXBlLmNwcApAQCAtMjA2LDE3ICsyMDYsMjEgQEAgdm9pZCBUZXh0RmllbGRJbnB1dFR5cGU6 OmZvcndhcmRFdmVudChFdmVudCogZXZlbnQpCiAgICAgICAgICAgICAgICAgfQogCiAgICAgICAg ICAgICAgICAgY2Fwc0xvY2tTdGF0ZU1heUhhdmVDaGFuZ2VkKCk7Ci0gICAgICAgICAgICB9IGVs c2UgaWYgKGV2ZW50LT50eXBlKCkgPT0gZXZlbnROYW1lcygpLmZvY3VzRXZlbnQpIHsKLSAgICAg ICAgICAgICAgICBpZiAoRnJhbWUqIGZyYW1lID0gZWxlbWVudCgpLmRvY3VtZW50KCkuZnJhbWUo KSkKLSAgICAgICAgICAgICAgICAgICAgZnJhbWUtPmVkaXRvcigpLnRleHRGaWVsZERpZEJlZ2lu RWRpdGluZygmZWxlbWVudCgpKTsKKyAgICAgICAgICAgIH0gZWxzZSBpZiAoZXZlbnQtPnR5cGUo KSA9PSBldmVudE5hbWVzKCkuZm9jdXNFdmVudCkKICAgICAgICAgICAgICAgICBjYXBzTG9ja1N0 YXRlTWF5SGF2ZUNoYW5nZWQoKTsKLSAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgZWxlbWVu dCgpLmZvcndhcmRFdmVudChldmVudCk7CiAgICAgICAgIH0KICAgICB9CiB9CiAKK3ZvaWQgVGV4 dEZpZWxkSW5wdXRUeXBlOjpoYW5kbGVGb2N1c0V2ZW50KE5vZGUqIG9sZEZvY3VzZWROb2RlLCBG b2N1c0RpcmVjdGlvbikKK3sKKyAgICBBU1NFUlRfVU5VU0VEKG9sZEZvY3VzZWROb2RlLCBvbGRG b2N1c2VkTm9kZSAhPSAmZWxlbWVudCgpKTsKKyAgICBpZiAoRnJhbWUqIGZyYW1lID0gZWxlbWVu dCgpLmRvY3VtZW50KCkuZnJhbWUoKSkKKyAgICAgICAgZnJhbWUtPmVkaXRvcigpLnRleHRGaWVs ZERpZEJlZ2luRWRpdGluZygmZWxlbWVudCgpKTsKK30KKwogdm9pZCBUZXh0RmllbGRJbnB1dFR5 cGU6OmhhbmRsZUJsdXJFdmVudCgpCiB7CiAgICAgSW5wdXRUeXBlOjpoYW5kbGVCbHVyRXZlbnQo KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmgg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL1RleHRGaWVsZElucHV0VHlwZS5oCmluZGV4IGNiNTg1ZWE3 Mjk2OGVmZGM4MTQ3ZDkzMjkyMzY1Yjg5OWVhNTIyOTYuLjk4NWMzZWE5YjRmMTMyNGYyOTNkZmRj YWQzMzA0NDYwYWE3YzFkODcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvVGV4dEZp ZWxkSW5wdXRUeXBlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1dFR5 cGUuaApAQCAtNjQsNiArNjQsNyBAQCBwcm90ZWN0ZWQ6CiAgICAgdmlydHVhbCB2b2lkIGRpc2Fi bGVkQXR0cmlidXRlQ2hhbmdlZCgpIG92ZXJyaWRlIGZpbmFsOwogICAgIHZpcnR1YWwgdm9pZCBy ZWFkb25seUF0dHJpYnV0ZUNoYW5nZWQoKSBvdmVycmlkZSBmaW5hbDsKICAgICB2aXJ0dWFsIGJv b2wgc3VwcG9ydHNSZWFkT25seSgpIGNvbnN0IG92ZXJyaWRlIGZpbmFsOworICAgIHZvaWQgaGFu ZGxlRm9jdXNFdmVudChOb2RlKiBvbGRGb2N1c2VkTm9kZSwgRm9jdXNEaXJlY3Rpb24pIG92ZXJy aWRlIGZpbmFsOwogICAgIHZpcnR1YWwgdm9pZCBoYW5kbGVCbHVyRXZlbnQoKSBvdmVycmlkZSBm aW5hbDsKICAgICB2aXJ0dWFsIHZvaWQgc2V0VmFsdWUoY29uc3QgU3RyaW5nJiwgYm9vbCB2YWx1 ZUNoYW5nZWQsIFRleHRGaWVsZEV2ZW50QmVoYXZpb3IpIG92ZXJyaWRlOwogICAgIHZpcnR1YWwg dm9pZCB1cGRhdGVJbm5lclRleHRWYWx1ZSgpIG92ZXJyaWRlIGZpbmFsOwpkaWZmIC0tZ2l0IGEv VG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGY0Mzc4YTZkNDJiZDhiMWVi OTVlNmU4YTc3MWMxNDQxZGYxZTBlYTQuLmUxM2NlYTMyYjA5YzU4ZTk1OWZiNzRiYWRjZDAwYmRl M2Q5MjIzZWMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxOSBAQAorMjAxNS0wNi0xNyAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0Bh cHBsZS5jb20+CisKKyAgICAgICAgQ2xpZW50IG1heSByZWNlaXZlIGJlZ2FuIGVkaXRpbmcgY2Fs bGJhY2sgZm9yIGFscmVhZHkgZm9jdXNlZCB0ZXh0IGZpZWxkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDYwNzQKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzIxMjkzNTYyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZCBhIHVuaXQgdGVzdCB0byBlbnN1cmUgdGhhdCBhIGNsaWVudCByZWNlaXZlcyBl eGFjdGx5IG9uZSBiZWdhbiBlZGl0aW5nCisgICAgICAgIGNhbGxiYWNrIHdoZW4gYSB0ZXh0IGZp ZWxkIGlzIG5ld2x5IGZvY3VzZWQuIEluIHBhcnRpY3VsYXIsIGRpc3BhdGNoaW5nCisgICAgICAg IGEgRE9NIGZvY3VzIGV2ZW50IGF0IGFuIGFscmVhZHkgZm9jdXNlZCB0ZXh0IGZpZWxkIGRvZXMg bm90IGRpc3BhdGNoIGEKKyAgICAgICAgYmVnYW4gZWRpdGluZyBjYWxsYmFjayB0byB0aGUgY2xp ZW50LgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyL1RleHRGaWVsZERp ZEJlZ2luQW5kRW5kRWRpdGluZy5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUX0Yp OgorCiAyMDE1LTA2LTE3ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAg ICAgW0NvY29hXSBFeHBvc2UgVUlEZWxlZ2F0ZTo6VUlDbGllbnQ6OmNsb3NlIHZpYSBXS1VJRGVs ZWdhdGUKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mi9UZXh0 RmllbGREaWRCZWdpbkFuZEVuZEVkaXRpbmcuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXQyL1RleHRGaWVsZERpZEJlZ2luQW5kRW5kRWRpdGluZy5jcHAKaW5kZXggNzFjODg3 YmQxZDQyZjU4NWExODM2Yzg0NzNjNWI3MjY0YWFkZWMwZS4uY2ZlMGJlMjU0Yzc4NGZkODQ2MzE0 NTY1NDBkZDM4M2YwMDFmNDEzOCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXQyL1RleHRGaWVsZERpZEJlZ2luQW5kRW5kRWRpdGluZy5jcHAKKysrIGIvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyL1RleHRGaWVsZERpZEJlZ2luQW5kRW5kRWRpdGlu Zy5jcHAKQEAgLTEyMCw2ICsxMjAsMTIgQEAgVEVTVF9GKFdlYktpdDJUZXh0RmllbGRCZWdpbkFu ZEVkaXRFZGl0aW5nVGVzdCwgVGV4dEZpZWxkRGlkQmVnaW5BbmRFbmRFZGl0aW5nRXYKICAgICBl eGVjdXRlSmF2YVNjcmlwdEFuZENoZWNrRGlkUmVjZWl2ZU1lc3NhZ2UoImJsdXJUZXh0RmllbGQo J3JlYWRvbmx5JykiLCAiRGlkUmVjZWl2ZVRleHRGaWVsZERpZEVuZEVkaXRpbmciKTsKIH0KIAor VEVTVF9GKFdlYktpdDJUZXh0RmllbGRCZWdpbkFuZEVkaXRFZGl0aW5nVGVzdCwgVGV4dEZpZWxk RGlkQmVnaW5TaG91bGROb3RCZURpc3BhdGNoZWRGb3JBbHJlYWR5Rm9jdXNlZEZpZWxkKQorewor ICAgIGV4ZWN1dGVKYXZhU2NyaXB0QW5kQ2hlY2tEaWRSZWNlaXZlTWVzc2FnZSgiZm9jdXNUZXh0 RmllbGQoJ2lucHV0Jyk7IGZvY3VzVGV4dEZpZWxkKCdpbnB1dCcpIiwgIkRpZFJlY2VpdmVUZXh0 RmllbGREaWRCZWdpbkVkaXRpbmciKTsKKyAgICBleGVjdXRlSmF2YVNjcmlwdEFuZENoZWNrRGlk UmVjZWl2ZU1lc3NhZ2UoImJsdXJUZXh0RmllbGQoJ2lucHV0JykiLCAiRGlkUmVjZWl2ZVRleHRG aWVsZERpZEVuZEVkaXRpbmciKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgVGVzdFdlYktpdEFQSQog CiAjZW5kaWYK