146072 2015-06-17 12:02:08 -0700 iOS WebKit1: [LegacyTileLayer drawInContext:] should ensure it has web lock 2015-06-17 12:52:53 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned oldest_to_newest 1102610 0 koivisto 2015-06-17 12:02:08 -0700 There are some scenarios where we end up drawing without web lock due to client or system issues. Protect against crashes by taking the lock. 1102611 1 koivisto 2015-06-17 12:02:44 -0700 rdar://problem/21149759 1102612 2 255028 koivisto 2015-06-17 12:09:26 -0700 Created attachment 255028 patch 1102621 3 koivisto 2015-06-17 12:52:53 -0700 https://trac.webkit.org/r185660 255028 2015-06-17 12:09:26 -0700 2015-06-17 12:11:59 -0700 patch drawincontext-lock.patch text/plain 2415 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTY1OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA2LTE3ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBpT1MgV2ViS2l0MTogW0xlZ2Fj eVRpbGVMYXllciBkcmF3SW5Db250ZXh0Ol0gc2hvdWxkIGVuc3VyZSBpdCBoYXMgd2ViIGxvY2sK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjA3Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGFy ZSBzb21lIHNjZW5hcmlvcyB3aGVyZSB3ZSBlbmQgdXAgZHJhd2luZyB3aXRob3V0IHdlYiBsb2Nr IGR1ZSB0byBjbGllbnQgb3Igc3lzdGVtIGlzc3Vlcy4KKyAgICAgICAgVGhpcyBjYW4gY2F1c2Ug Y3Jhc2hlcy4KKworICAgICAgICAqIHBsYXRmb3JtL2lvcy9MZWdhY3lUaWxlTGF5ZXIubW06Cisg ICAgICAgICgtW0xlZ2FjeVRpbGVMYXllciBzZXROZWVkc0Rpc3BsYXlJblJlY3Q6XSk6CisgICAg ICAgICgtW0xlZ2FjeVRpbGVMYXllciBkcmF3SW5Db250ZXh0Ol0pOgorCisgICAgICAgICAgICBF bnN1cmUgd2UgaGF2ZSB0aGUgd2ViIGxvY2sgd2hlbiBjYWxsZWQgaW4gbWFpbiB0aHJlYWQgKGV2 ZW4gdGhvdWdoIHdlIHNob3VsZCBoYXZlIGl0IGFscmVhZHkpLgorCiAyMDE1LTA2LTE3ICBCcmVu dCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIENTUyBzY3JvbGwgc25h cDogZGVmaW5pbmcgc25hcCBwb2ludHMgb24gYXhpcyB0aGF0IGRvZXMgbm90IHNjcm9sbCBkb2Vz IG5vdCB3b3JrIHByb3Blcmx5CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvTGVn YWN5VGlsZUxheWVyLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lv cy9MZWdhY3lUaWxlTGF5ZXIubW0JKHJldmlzaW9uIDE4NTUwMCkKKysrIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2lvcy9MZWdhY3lUaWxlTGF5ZXIubW0JKHdvcmtpbmcgY29weSkKQEAgLTc2LDYg Kzc2LDEwIEBAIHN0YXRpYyBMZWdhY3lUaWxlTGF5ZXIgKmxheWVyQmVpbmdQYWludGUKIAogLSAo dm9pZClzZXROZWVkc0Rpc3BsYXlJblJlY3Q6KENHUmVjdClyZWN0CiB7CisgICAgLy8gV2UgbmVl ZCB0byBkbyBXZWJLaXQgbGF5b3V0IGJlZm9yZSBwYWludGluZy4gTGF5b3V0IG1heSBnZW5lcmF0 ZSBuZXcgcmVwYWludCByZWN0cyBhbmQKKyAgICAvLyBpbnZhbGlkYXRlIG1vcmUgdGlsZXMsIHNv bWV0aGluZyB0aGF0IGlzIG5vdCBhbGxvd2VkIGluIGRyYXdJbkNvbnRleHQuCisgICAgLy8gQ2Fs bGluZyBzZXROZWVkc0xheW91dCBlbnN1cmVzIHRoYXQgbGF5b3V0U3VibGF5ZXJzIHdpbGwgZ2V0 IGNhbGxlZCBiZWZvcmUgZHJhd0luQ29udGV4dCBhbmQKKyAgICAvLyB3ZSBkbyBXZWJLaXQgbGF5 b3V0IHRoZXJlLgogICAgIFtzZWxmIHNldE5lZWRzTGF5b3V0XTsKICAgICBbc3VwZXIgc2V0TmVl ZHNEaXNwbGF5SW5SZWN0OnJlY3RdOwogfQpAQCAtOTEsNiArOTUsMTUgQEAgLSAodm9pZClsYXlv dXRTdWJsYXllcnMKIAogLSAodm9pZClkcmF3SW5Db250ZXh0OihDR0NvbnRleHRSZWYpY29udGV4 dAogeworICAgIC8vIEJ1Z3MgaW4gY2xpZW50cyBvciBvdGhlciBmcmFtZXdvcmtzIG1heSBjYXVz ZSB0aWxlIGludmFsaWRhdGlvbiBmcm9tIHdpdGhpbiBhIENBIGNvbW1pdC4KKyAgICAvLyBJbiB0 aGF0IGNhc2Ugd2UgbWF5YmUgbGVmdCB3aXRoIGRpcnR5IHRpbGVzIHRoYXQgaGF2ZSBkaXNwbGF5 IHN0aWxsIHBlbmRpbmcuIFNvbWUgZnV0dXJlCisgICAgLy8gY29tbWl0IHdpbGwgZmx1c2ggc3Vj aCB0aWxlcyBhbmQgdGhleSB3aWxsIGdldCBwYWludGVkIHdpdGhvdXQgaG9sZGluZyB0aGUgd2Vi IGxvY2suCisgICAgLy8gcmRhcjovL3Byb2JsZW0vMjExNDk3NTkKKyAgICAvLyBTdGlsbCBhc3Nl cnQgYXMgdGhlIGNvbmRpdGlvbiBpcyBub3Qgbm9ybWFsIGFuZCBtYXkgY2F1c2UgZ3JhcGhpY2Fs IGdsaXRjaGVzLgorICAgIEFTU0VSVChXZWJUaHJlYWRJc0xvY2tlZE9yRGlzYWJsZWQoKSk7Cisg ICAgaWYgKHB0aHJlYWRfbWFpbl9ucCgpKQorICAgICAgICBXZWJUaHJlYWRMb2NrKCk7CisKICAg ICBpZiAoX3RpbGVHcmlkKQogICAgICAgICBfdGlsZUdyaWQtPnRpbGVDYWNoZSgpLmRyYXdMYXll cihzZWxmLCBjb250ZXh0KTsKIH0K