146059 2015-06-17 06:18:30 -0700 GObject and ObjC bindings generator should not generate code for promise-based APIs 2015-06-18 00:03:44 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf commit-queue darin oldest_to_newest 1102532 0 youennf 2015-06-17 06:18:30 -0700 In case of a function returning a promise, GObject and ObjC may generate bindings for that function. The issue is that the returned type Promise may not be supported yet. It may be safer to disable binding generation for these functions, at least until Promise returned values are support by GObject and ObjC 1102533 1 255014 youennf 2015-06-17 06:24:17 -0700 Created attachment 255014 Patch 1102672 2 255014 darin 2015-06-17 15:23:35 -0700 Comment on attachment 255014 Patch Seems OK for now since we don’t have a strategy for binding these yet. 1102832 3 255014 commit-queue 2015-06-18 00:03:40 -0700 Comment on attachment 255014 Patch Clearing flags on attachment: 255014 Committed r185694: <http://trac.webkit.org/changeset/185694> 1102833 4 commit-queue 2015-06-18 00:03:44 -0700 All reviewed patches have been landed. Closing bug. 255014 2015-06-17 06:24:17 -0700 2015-06-18 00:03:40 -0700 Patch bug-146059-20150617152339.patch text/plain 6132 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NjQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWQ5ZjkxMjkzYzkwZWM5 ZDdiMDg2M2JmODk2ZDk5NzBiYWQ3MTJjNS4uMmFhODZjZGJhNjg1ZmVlMDVkZjI2YjllYmY4MWUw Y2UxMDQ2NTk3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE1LTA2LTE3ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CisKKyAgICAgICAgR09iamVj dCBhbmQgT2JqQyBiaW5kaW5ncyBnZW5lcmF0b3Igc2hvdWxkIG5vdCBnZW5lcmF0ZSBjb2RlIGZv ciBwcm9taXNlLWJhc2VkIEFQSXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0NjA1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIENvdmVyZWQgYnkgcmViYXNlZCBleHBlY3RhdGlvbnMuCisKKyAgICAgICAg KiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtOgorICAgICAgICAoU2tp cEZ1bmN0aW9uKTogRGlzYWJsaW5nIEdPYmplY3QgRE9NIGJpbmRpbmcgZm9yIGZ1bmN0aW9ucyBy ZXR1cm5pbmcgcHJvbWlzZXMuCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJh dG9yT2JqQy5wbToKKyAgICAgICAgKFNraXBGdW5jdGlvbik6IERpc2FibGluZyBPYmpDIERPTSBi aW5kaW5nIGZvciBmdW5jdGlvbnMgcmV0dXJuaW5nIHByb21pc2VzLgorICAgICAgICAqIGJpbmRp bmdzL3NjcmlwdHMvdGVzdC9HT2JqZWN0L1dlYktpdERPTVRlc3RPYmouY3BwOiBSZWJhc2luZyBl eHBlY3RhdGlvbi4KKyAgICAgICAgKHdlYmtpdF9kb21fdGVzdF9vYmpfZ2V0X3JlYWRfb25seV9s b25nX2F0dHIpOiBEZWxldGVkLgorICAgICAgICAod2Via2l0X2RvbV90ZXN0X29ial9nZXRfcmVh ZF9vbmx5X3N0cmluZ19hdHRyKTogRGVsZXRlZC4KKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRz L3Rlc3QvR09iamVjdC9XZWJLaXRET01UZXN0T2JqLmg6IFJlYmFzaW5nIGV4cGVjdGF0aW9uLgor ICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9PYmpDL0RPTVRlc3RPYmouaDogRGl0dG8u CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L09iakMvRE9NVGVzdE9iai5tbTogRGl0 dG8uCisgICAgICAgIChjb3JlKTogRGVsZXRlZC4KKwogMjAxNS0wNi0xNyAgWGFiaWVyIFJvZHJp Z3VleiBDYWx2YXIgIDxjYWx2YXJpc0BpZ2FsaWEuY29tPiBhbmQgWW91ZW5uIEZhYmxldCA8eW91 ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CiAKICAgICAgICAgW1N0cmVhbXMgQVBJXSBSZWFkYWJs ZUpTU3RyZWFtIHNob3VsZCBoYW5kbGUgcHJvbWlzZXMgcmV0dXJuZWQgYnkgSlMgc291cmNlIHB1 bGwgY2FsbGJhY2sKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv Q29kZUdlbmVyYXRvckdPYmplY3QucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtCmluZGV4IDJlOTQxMGY3MmEzOTQxZDNkMWEzOTI4NTg0 ZTIzMmRjNzlhNjAyYzguLjZjZmE1MTYyZjI0MDIxMzg3NzllMDA2ZTU0MDYxNmZlYmQ2NTE4YmUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRv ckdPYmplY3QucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9yR09iamVjdC5wbQpAQCAtMzYyLDYgKzM2MiwxMCBAQCBzdWIgU2tpcEZ1bmN0aW9uIHsK ICAgICAgICAgcmV0dXJuIDE7CiAgICAgfQogCisgICAgaWYgKCRmdW5jdGlvbi0+c2lnbmF0dXJl LT50eXBlIGVxICJQcm9taXNlIikgeworICAgICAgICByZXR1cm4gMTsKKyAgICB9CisKICAgICBy ZXR1cm4gMDsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9yT2JqQy5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv Q29kZUdlbmVyYXRvck9iakMucG0KaW5kZXggNWMwMTcxMmMxM2JhZDJjYTA0N2IyMTBmNmIzMDEw MTBhMTIxNmFiZC4uMTg1ZmY5YWU2MzNmOTVmNzc4MTAxMDE1NzUwZDMyZjVlZTlmMDBjMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yT2Jq Qy5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JP YmpDLnBtCkBAIC01MzcsNiArNTM3LDggQEAgc3ViIFNraXBGdW5jdGlvbgogICAgIHJldHVybiAx IGlmICRjb2RlR2VuZXJhdG9yLT5HZXRTZXF1ZW5jZVR5cGUoJGZ1bmN0aW9uLT5zaWduYXR1cmUt PnR5cGUpOwogICAgIHJldHVybiAxIGlmICRjb2RlR2VuZXJhdG9yLT5HZXRBcnJheVR5cGUoJGZ1 bmN0aW9uLT5zaWduYXR1cmUtPnR5cGUpOwogCisgICAgcmV0dXJuIDEgaWYgJGZ1bmN0aW9uLT5z aWduYXR1cmUtPnR5cGUgZXEgIlByb21pc2UiOworCiAgICAgZm9yZWFjaCBteSAkcGFyYW0gKEB7 JGZ1bmN0aW9uLT5wYXJhbWV0ZXJzfSkgewogICAgICAgICByZXR1cm4gMSBpZiAkY29kZUdlbmVy YXRvci0+R2V0U2VxdWVuY2VUeXBlKCRwYXJhbS0+dHlwZSk7CiAgICAgICAgIHJldHVybiAxIGlm ICRjb2RlR2VuZXJhdG9yLT5HZXRBcnJheVR5cGUoJHBhcmFtLT50eXBlKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9HT2JqZWN0L1dlYktpdERPTVRl c3RPYmouY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3Qv V2ViS2l0RE9NVGVzdE9iai5jcHAKaW5kZXggYmJjZTQ2ZGQ3MzViMWIzMWYwYzU4MDM2YjI3ODg2 NTQ5NjI3MGJhZS4uNmQ1ZTgwYmJlOWIwZDZiNTk1NjJmNzYxYTI4NmM5NjhmMDU1NGUxOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2Vi S2l0RE9NVGVzdE9iai5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90 ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdE9iai5jcHAKQEAgLTMzLDcgKzMzLDYgQEAKICNpbmNs dWRlICJXZWJLaXRET01Eb2N1bWVudFByaXZhdGUuaCIKICNpbmNsdWRlICJXZWJLaXRET01Ob2Rl UHJpdmF0ZS5oIgogI2luY2x1ZGUgIldlYktpdERPTVByaXZhdGUuaCIKLSNpbmNsdWRlICJXZWJL aXRET01Qcm9taXNlUHJpdmF0ZS5oIgogI2luY2x1ZGUgIldlYktpdERPTVNWR1BvaW50UHJpdmF0 ZS5oIgogI2luY2x1ZGUgIldlYktpdERPTVRlc3RFbnVtVHlwZVByaXZhdGUuaCIKICNpbmNsdWRl ICJXZWJLaXRET01UZXN0Tm9kZVByaXZhdGUuaCIKQEAgLTE1NTIsMTUgKzE1NTEsNiBAQCB2b2lk IHdlYmtpdF9kb21fdGVzdF9vYmpfYW55KFdlYktpdERPTVRlc3RPYmoqIHNlbGYsIGdmbG9hdCBh LCBnbG9uZyBiKQogICAgIGl0ZW0tPmFueShhLCBiKTsKIH0KIAotV2ViS2l0RE9NUHJvbWlzZSog d2Via2l0X2RvbV90ZXN0X29ial90ZXN0X3Byb21pc2VfZnVuY3Rpb24oV2ViS2l0RE9NVGVzdE9i aiogc2VsZikKLXsKLSAgICBXZWJDb3JlOjpKU01haW5UaHJlYWROdWxsU3RhdGUgc3RhdGU7Ci0g ICAgZ19yZXR1cm5fdmFsX2lmX2ZhaWwoV0VCS0lUX0RPTV9JU19URVNUX09CSihzZWxmKSwgMCk7 Ci0gICAgV2ViQ29yZTo6VGVzdE9iaiogaXRlbSA9IFdlYktpdDo6Y29yZShzZWxmKTsKLSAgICBS ZWZQdHI8V2ViQ29yZTo6UHJvbWlzZT4gZ29iamVjdFJlc3VsdCA9IFdURjo6Z2V0UHRyKGl0ZW0t PnRlc3RQcm9taXNlRnVuY3Rpb24oKSk7Ci0gICAgcmV0dXJuIFdlYktpdDo6a2l0KGdvYmplY3RS ZXN1bHQuZ2V0KCkpOwotfQotCiBnbG9uZyB3ZWJraXRfZG9tX3Rlc3Rfb2JqX2dldF9yZWFkX29u bHlfbG9uZ19hdHRyKFdlYktpdERPTVRlc3RPYmoqIHNlbGYpCiB7CiAgICAgV2ViQ29yZTo6SlNN YWluVGhyZWFkTnVsbFN0YXRlIHN0YXRlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdE9iai5oIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdE9iai5oCmlu ZGV4IDViZGRjMTYyYjMwZTMzM2I3ZjJhNDdlZjhlNjI0MGQyZGIzNTdlZWIuLjJkYmI2ZGM0MWIz NTA3ZTZhODcxZDE5NDgzNTZjN2JjNmE0NGEwMDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9HT2JqZWN0L1dlYktpdERPTVRlc3RPYmouaAorKysgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvR09iamVjdC9XZWJLaXRET01UZXN0 T2JqLmgKQEAgLTY1MSwxNyArNjUxLDYgQEAgV0VCS0lUX0FQSSB2b2lkCiB3ZWJraXRfZG9tX3Rl c3Rfb2JqX2FueShXZWJLaXRET01UZXN0T2JqKiBzZWxmLCBnZmxvYXQgYSwgZ2xvbmcgYik7CiAK IC8qKgotICogd2Via2l0X2RvbV90ZXN0X29ial90ZXN0X3Byb21pc2VfZnVuY3Rpb246Ci0gKiBA c2VsZjogQSAjV2ViS2l0RE9NVGVzdE9iagotICoKLSAqIFJldHVybnM6ICh0cmFuc2ZlciBub25l KTogQSAjV2ViS2l0RE9NUHJvbWlzZQotICoKLSAqIFN0YWJpbGl0eTogVW5zdGFibGUKLSoqLwot V0VCS0lUX0FQSSBXZWJLaXRET01Qcm9taXNlKgotd2Via2l0X2RvbV90ZXN0X29ial90ZXN0X3By b21pc2VfZnVuY3Rpb24oV2ViS2l0RE9NVGVzdE9iaiogc2VsZik7Ci0KLS8qKgogICogd2Via2l0 X2RvbV90ZXN0X29ial9nZXRfcmVhZF9vbmx5X2xvbmdfYXR0cjoKICAqIEBzZWxmOiBBICNXZWJL aXRET01UZXN0T2JqCiAgKgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy90ZXN0L09iakMvRE9NVGVzdE9iai5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy90ZXN0L09iakMvRE9NVGVzdE9iai5oCmluZGV4IGI1NTkxYTk4OTIxN2NiYWRmZDYzZGVh ZmNlZjQzMWZkYWNhZWM3ZjQuLjNiNzMxMDE4YTI5Y2I1OWVjYTkxYzNlODI2M2EwNzRiM2I3ZDQw MjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9PYmpD L0RPTVRlc3RPYmouaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3Qv T2JqQy9ET01UZXN0T2JqLmgKQEAgLTE3Myw1ICsxNzMsNCBAQCBXRUJDT1JFX0VYUE9SVCBAaW50 ZXJmYWNlIERPTVRlc3RPYmogOiBET01PYmplY3QKIC0gKHZvaWQpdmFyaWFkaWNEb3VibGVNZXRo b2Q6KGRvdWJsZSloZWFkIHRhaWw6KGRvdWJsZSl0YWlsOwogLSAodm9pZCl2YXJpYWRpY05vZGVN ZXRob2Q6KERPTU5vZGUgKiloZWFkIHRhaWw6KERPTU5vZGUgKil0YWlsOwogLSAodm9pZClhbnk6 KGZsb2F0KWEgYjooaW50KWI7Ci0tIChET01Qcm9taXNlICopdGVzdFByb21pc2VGdW5jdGlvbjsK IEBlbmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9P YmpDL0RPTVRlc3RPYmoubW0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3Qv T2JqQy9ET01UZXN0T2JqLm1tCmluZGV4IDA5MGExZDQ0YjM0MGZhMTU3MjM3MTRmZTZjZDc2ZTA3 ZTVhYmY5ZGYuLmFkYjI3MzBkMzE4MTNhZDcyODBlNDVkMDY5ODVkOTAzZTUwYTBmN2QgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9PYmpDL0RPTVRlc3RP YmoubW0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L09iakMvRE9N VGVzdE9iai5tbQpAQCAtMTE4MywxMiArMTE4Myw2IEBACiAgICAgSU1QTC0+YW55KGEsIGIpOwog fQogCi0tIChET01Qcm9taXNlICopdGVzdFByb21pc2VGdW5jdGlvbgotewotICAgIFdlYkNvcmU6 OkpTTWFpblRocmVhZE51bGxTdGF0ZSBzdGF0ZTsKLSAgICByZXR1cm4ga2l0KFdURjo6Z2V0UHRy KElNUEwtPnRlc3RQcm9taXNlRnVuY3Rpb24oKSkpOwotfQotCiBAZW5kCiAKIFdlYkNvcmU6OlRl c3RPYmoqIGNvcmUoRE9NVGVzdE9iaiAqd3JhcHBlcikK