146055 2015-06-17 05:03:00 -0700 URL: trim before scheme checks 2023-04-05 09:58:02 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED CONFIGURATION CHANGED P2 Normal --- 1 annevk webkit-unassigned ap beidson cdumez darin eoconnor kling oldest_to_newest 1102524 0 annevk 2015-06-17 05:03:00 -0700 The backslash replacement in https://github.com/WebKit/webkit/blob/master/Source/WebCore/platform/URL.cpp#L470 should happen after the C0 controls and space removal at https://github.com/WebKit/webkit/blob/master/Source/WebCore/platform/URL.cpp#L492 because otherwise e.g. " data:\" turns into "data:/" which does not seem desired. (I was also wondering if we could limit the backslash replacement to only the special schemes: http/https/ftp/gopher/file/ws/wss?) 1102927 1 ap 2015-06-18 09:14:13 -0700 Thank you, good catch! > (I was also wondering if we could limit the backslash replacement to only the special schemes: http/https/ftp/gopher/file/ws/wss?) Wait, so we perform backslash replacement for custom protocols? That seems crazy, hopefully no clients rely on that. 1103274 2 darin 2015-06-19 10:25:43 -0700 Yes, both these changes seem worthwhile. 1946754 3 annevk 2023-04-05 09:58:02 -0700 All this code changed due to the URL rewrite. And we match the standard except for a couple known cases.