146053 2015-06-17 02:30:03 -0700 [GTK] WEBKIT_CACHE_MODEL_DOCUMENT_VIEWER doesn't disable memory cache when set before the web process is launched 2015-06-17 08:33:26 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo svillar oldest_to_newest 1102515 0 cgarcia 2015-06-17 02:30:03 -0700 The cache is disabled in WebProcess::platformSetCacheModel() when the cache model is CacheModelDocumentViewer, but it's enabled again by WebProcess::setMemoryCacheDisabled() when memoryCacheDisabled creation parameter is processed. We need to make sure the cache model and memoryCacheDisabled parameters are consistent. 1102516 1 255008 cgarcia 2015-06-17 02:34:34 -0700 Created attachment 255008 Patch Unfortunately we don't have a way to check that memory cache is actually disabled in a unit test. Maybe if we eventually implement the WebsiteDataStore, we can get the origins, but for now, it doesn't seem to be possible. 1102552 2 cgarcia 2015-06-17 08:33:26 -0700 Committed r185651: <http://trac.webkit.org/changeset/185651> 255008 2015-06-17 02:34:34 -0700 2015-06-17 07:34:02 -0700 Patch wk2-memory-cache.diff text/plain 1941 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5ZWZjZWM5Li44NGM1MzdjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjMg QEAKIDIwMTUtMDYtMTcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIFdFQktJVF9DQUNIRV9NT0RFTF9ET0NVTUVOVF9WSUVXRVIgZG9l c24ndCBkaXNhYmxlIG1lbW9yeSBjYWNoZSB3aGVuIHNldCBiZWZvcmUgdGhlIHdlYiBwcm9jZXNz IGlzIGxhdW5jaGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDYwNTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGUgY2FjaGUgaXMgZGlzYWJsZWQgaW4gV2ViUHJvY2Vzczo6cGxhdGZvcm1TZXRDYWNo ZU1vZGVsKCkgd2hlbgorICAgICAgICB0aGUgY2FjaGUgbW9kZWwgaXMgQ2FjaGVNb2RlbERvY3Vt ZW50Vmlld2VyLCBidXQgaXQncyBlbmFibGVkCisgICAgICAgIGFnYWluIGJ5IFdlYlByb2Nlc3M6 OnNldE1lbW9yeUNhY2hlRGlzYWJsZWQoKSB3aGVuCisgICAgICAgIG1lbW9yeUNhY2hlRGlzYWJs ZWQgY3JlYXRpb24gcGFyYW1ldGVyIGlzIHByb2Nlc3NlZC4gV2UgbmVlZCB0bworICAgICAgICBt YWtlIHN1cmUgdGhlIGNhY2hlIG1vZGVsIGFuZCBtZW1vcnlDYWNoZURpc2FibGVkIHBhcmFtZXRl cnMgYXJlIGNvbnNpc3RlbnQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvZ3RrL1dlYlByb2Nlc3NQ b29sR3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2w6OnBsYXRmb3JtSW5p dGlhbGl6ZVdlYlByb2Nlc3MpOiBJbml0aWFsaXplCisgICAgICAgIG1lbW9yeUNhY2hlRGlzYWJs ZWQgcGFyYW1ldGVyIHRvIHRydWUgaWYgbWVtb3J5IGNhY2hlIHdhcworICAgICAgICBleHBsaWNp dGx5IGRpc2FibGVkIG9yIGNhY2hlIG1vZGVsIGlzIENhY2hlTW9kZWxEb2N1bWVudFZpZXdlci4K KworMjAxNS0wNi0xNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+ CisKICAgICAgICAgW0dUS10gUmVpbXBsZW1lbnQgd2Via2l0X3dlYl9jb250ZXh0X2NsZWFyX2Nh Y2hlIGZ1bmN0aW9uYWxpdHkuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDYwNDEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L2d0ay9XZWJQcm9jZXNzUG9vbEd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3Rr L1dlYlByb2Nlc3NQb29sR3RrLmNwcAppbmRleCA2MjMwNDNkLi5jY2RiNGFjIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYlByb2Nlc3NQb29sR3RrLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYlByb2Nlc3NQb29sR3RrLmNwcApAQCAt MTA4LDYgKzEwOCw4IEBAIHZvaWQgV2ViUHJvY2Vzc1Bvb2w6OnBsYXRmb3JtSW5pdGlhbGl6ZVdl YlByb2Nlc3MoV2ViUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycyYKICAgICAgICAgcGFyYW1ldGVy cy5pZ25vcmVUTFNFcnJvcnMgPSBtX2lnbm9yZVRMU0Vycm9yczsKICAgICAgICAgcGFyYW1ldGVy cy5kaXNrQ2FjaGVEaXJlY3RvcnkgPSBtX2NvbmZpZ3VyYXRpb24tPmRpc2tDYWNoZURpcmVjdG9y eSgpOwogICAgIH0KKworICAgIHBhcmFtZXRlcnMubWVtb3J5Q2FjaGVEaXNhYmxlZCA9IG1fbWVt b3J5Q2FjaGVEaXNhYmxlZCB8fCBtX2NhY2hlTW9kZWwgPT0gQ2FjaGVNb2RlbERvY3VtZW50Vmll d2VyOwogfQogCiB2b2lkIFdlYlByb2Nlc3NQb29sOjpwbGF0Zm9ybUludmFsaWRhdGVDb250ZXh0 KCkK