146049 2015-06-16 23:05:32 -0700 Web Inspector: Do not show JavaScriptCore builtins in inspector 2015-10-29 23:01:11 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck benjamin commit-queue ggaren graouts joepeck jonowells mark.lam mattbaker nvasilyev ossy timothy webkit-bug-importer oldest_to_newest 1102491 0 joepeck 2015-06-16 23:05:32 -0700 * SUMMARY Do not show JavaScriptCore builtins in inspector. * STEPS TO REPRODUCE 1. Inspect about:blank 2. Do a global search for "@call" => get to see the source for things like Function.prototype.call and Array.prototype.map * NOTES - The format is a pseudo JavaScript that doesn't parse as proper JavaScript so syntax-highlighting is off - Breakpoints don't really work in built-ins, though we somehow can pause in the scripts, so the experience is poor if we did allow it for now 1102492 1 255002 joepeck 2015-06-16 23:06:20 -0700 Created attachment 255002 [PATCH] Proposed Fix 1102494 2 joepeck 2015-06-16 23:07:50 -0700 *** Bug 145654 has been marked as a duplicate of this bug. *** 1102495 3 joepeck 2015-06-16 23:08:30 -0700 <rdar://problem/21247912> 1102649 4 255002 commit-queue 2015-06-17 14:35:03 -0700 Comment on attachment 255002 [PATCH] Proposed Fix Clearing flags on attachment: 255002 Committed r185670: <http://trac.webkit.org/changeset/185670> 1102650 5 commit-queue 2015-06-17 14:35:06 -0700 All reviewed patches have been landed. Closing bug. 1102908 6 ossy 2015-06-18 07:24:45 -0700 (In reply to comment #4) > Comment on attachment 255002 [details] > [PATCH] Proposed Fix > > Clearing flags on attachment: 255002 > > Committed r185670: <http://trac.webkit.org/changeset/185670> It made 2 tests fail everywhere. Could you check it? Maybe updating the expected file is the proper fix. 1102979 7 joepeck 2015-06-18 11:31:37 -0700 (In reply to comment #6) > (In reply to comment #4) > > Comment on attachment 255002 [details] > > [PATCH] Proposed Fix > > > > Clearing flags on attachment: 255002 > > > > Committed r185670: <http://trac.webkit.org/changeset/185670> > > It made 2 tests fail everywhere. Could you check it? > Maybe updating the expected file is the proper fix. Interesting. I have yet to reproduce this myself running the fast/profiler directory to these tests individually. I'm updating to see if I can reproduce. I agree, updating the expected results would be good, but it also seems as if the bots get different results from time to time. 1102991 8 joepeck 2015-06-18 12:18:36 -0700 I am still unable to reproduce locally, but the bots can reproduce a lot. Rather than keep them red, I rolled this out while I investigate. https://trac.webkit.org/changeset/185715 1137802 9 joepeck 2015-10-29 22:09:02 -0700 *** Bug 150710 has been marked as a duplicate of this bug. *** 1137803 10 joepeck 2015-10-29 22:12:51 -0700 Last time we tried this it broke profiler tests, and I think that was because we were doing this in the Recompiler visiting. This time I'm doing the same thing but gathering the list of sources to inform the inspector about is separate from recompiling. Take 2! 1137804 11 264381 joepeck 2015-10-29 22:13:08 -0700 Created attachment 264381 [PATCH] Proposed Fix 1137806 12 264381 ggaren 2015-10-29 22:14:34 -0700 Comment on attachment 264381 [PATCH] Proposed Fix r=me Can we test this? 1137807 13 joepeck 2015-10-29 22:19:10 -0700 (In reply to comment #12) > Comment on attachment 264381 [details] > [PATCH] Proposed Fix > > r=me > > Can we test this? We can write some form of test. I'll look into that tomorrow. In this case we could do a search for "@call" and ensure that we don't see such results, but that test is weak in the sense that if built-ins ever change syntax and that "@call" or some equivalent goes away and we end up testing nothing. Still worth looking into though! 1137812 14 264381 commit-queue 2015-10-29 23:01:07 -0700 Comment on attachment 264381 [PATCH] Proposed Fix Clearing flags on attachment: 264381 Committed r191779: <http://trac.webkit.org/changeset/191779> 1137813 15 commit-queue 2015-10-29 23:01:11 -0700 All reviewed patches have been landed. Closing bug. 255002 2015-06-16 23:06:20 -0700 2015-10-29 22:13:08 -0700 [PATCH] Proposed Fix builtins.patch text/plain 1160 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDQ0NTdmYjIuLmUxMDU0OWIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA2LTE2ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRG8gbm90 IHNob3cgSmF2YVNjcmlwdENvcmUgYnVpbHRpbnMgaW4gaW5zcGVjdG9yCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDYwNDkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRlYnVnZ2VyL0RlYnVnZ2VyLmNw cDoKKwogMjAxNS0wNi0xNiAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAog ICAgICAgICBJbmxpbmluZyBpbiB0aGUgREZHIHRyYXNoZXMgQnl0ZUNvZGVQYXJzZXI6Om1fY3Vy cmVudEluc3RydWN0aW9uIGZvciB0aGUgY2FsbGluZyBmdW5jdGlvbgpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyLmNwcCBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZWJ1Z2dlci9EZWJ1Z2dlci5jcHAKaW5kZXggNTc0MTA2OS4uMWYzMTA5MiAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyLmNwcAorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdnZXIvRGVidWdnZXIuY3BwCkBAIC03Niw3ICs3 Niw3IEBAIGlubGluZSB2b2lkIFJlY29tcGlsZXI6OnZpc2l0KEpTQ2VsbCogY2VsbCkKICAgICAg ICAgcmV0dXJuOwogCiAgICAgSlNGdW5jdGlvbiogZnVuY3Rpb24gPSBqc0Nhc3Q8SlNGdW5jdGlv bio+KGNlbGwpOwotICAgIGlmIChmdW5jdGlvbi0+ZXhlY3V0YWJsZSgpLT5pc0hvc3RGdW5jdGlv bigpKQorICAgIGlmIChmdW5jdGlvbi0+aXNIb3N0T3JCdWlsdGluRnVuY3Rpb24oKSkKICAgICAg ICAgcmV0dXJuOwogCiAgICAgRnVuY3Rpb25FeGVjdXRhYmxlKiBleGVjdXRhYmxlID0gZnVuY3Rp b24tPmpzRXhlY3V0YWJsZSgpOwo= 264381 2015-10-29 22:13:08 -0700 2015-10-29 23:01:07 -0700 [PATCH] Proposed Fix take-2.patch text/plain 1534 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDVkMmNkNzEuLjU5ZGZlOTMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE1LTEwLTI5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRG8gbm90 IHNob3cgSmF2YVNjcmlwdENvcmUgYnVpbHRpbnMgaW4gaW5zcGVjdG9yCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDYwNDkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRlYnVnZ2VyL0RlYnVnZ2VyLmNw cDoKKyAgICAgICAgV2hlbiBnYXRoZXJpbmcgc2NyaXB0cyB0byBub3RpZnkgdGhlIGluc3BlY3Rv ciAvIGRlYnVnZ2VycyBhYm91dAorICAgICAgICBza2lwIG92ZXIgc291cmNlcyBjb250YWluaW5n IGhvc3QgLyBidWlsdC1pbiBmdW5jdGlvbnMgYXMgdGhvc2UKKyAgICAgICAgZm9yIHRob3NlIHdv bid0IGNvbnRhaW4gc291cmNlIGNvZGUgZGV2ZWxvcGVycyBleHBlY3QgdG8gc2VlLgorCisyMDE1 LTEwLTI5ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAg Rml4IHR5cG8gaW4gInVzZSBzdHJpY3QiIGluIFR5cGVkQXJyYXkgYnVpbHRpbnMKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDcwOQogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdnZXIvRGVidWdnZXIuY3BwIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyLmNwcAppbmRleCAwN2RjYzgyLi43MDg4 MzE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdnZXIvRGVidWdnZXIu Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dlci9EZWJ1Z2dlci5jcHAKQEAg LTU4LDYgKzU4LDkgQEAgc3RydWN0IEdhdGhlclNvdXJjZVByb3ZpZGVycyA6IHB1YmxpYyBNYXJr ZWRCbG9jazo6Vm9pZEZ1bmN0b3IgewogICAgICAgICBpZiAoIWZ1bmN0aW9uLT5leGVjdXRhYmxl KCktPmlzRnVuY3Rpb25FeGVjdXRhYmxlKCkpCiAgICAgICAgICAgICByZXR1cm4gSXRlcmF0aW9u U3RhdHVzOjpDb250aW51ZTsKIAorICAgICAgICBpZiAoZnVuY3Rpb24tPmlzSG9zdE9yQnVpbHRp bkZ1bmN0aW9uKCkpCisgICAgICAgICAgICByZXR1cm4gSXRlcmF0aW9uU3RhdHVzOjpDb250aW51 ZTsKKwogICAgICAgICBzb3VyY2VQcm92aWRlcnMuYWRkKAogICAgICAgICAgICAganNDYXN0PEZ1 bmN0aW9uRXhlY3V0YWJsZSo+KGZ1bmN0aW9uLT5leGVjdXRhYmxlKCkpLT5zb3VyY2UoKS5wcm92 aWRlcigpKTsKICAgICAgICAgcmV0dXJuIEl0ZXJhdGlvblN0YXR1czo6Q29udGludWU7Cg==