146048 2015-06-16 22:50:09 -0700 Web Inspector: Improve a few more node preview types 2015-06-18 12:22:33 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 146114 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1102485 0 joepeck 2015-06-16 22:50:09 -0700 * SUMMARY Improve a few more node preview types (comment, and doctype). * TEST js> [document.createElement("div"), document.createComment("test"), document.doctype, document, document.createTextNode("text"), document.createDocumentFragment(), document.createAttribute("attr")] We should make the comment and doctype nodes appear nicer than we currently do. 1102486 1 255001 joepeck 2015-06-16 22:51:22 -0700 Created attachment 255001 [PATCH] Proposed Fix I considered improving #text "foo" To also have a red string for "foo", but decided against it, we didn't previously in any case. 1102651 2 255001 commit-queue 2015-06-17 14:35:16 -0700 Comment on attachment 255001 [PATCH] Proposed Fix Clearing flags on attachment: 255001 Committed r185671: <http://trac.webkit.org/changeset/185671> 1102652 3 commit-queue 2015-06-17 14:35:20 -0700 All reviewed patches have been landed. Closing bug. 1102937 4 ap 2015-06-18 09:48:20 -0700 Looks like this caused flaky failures on all bots (closer to always failing, in fact): https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fprofiler%2Fbuilt-in-function-calls-user-defined-function.html https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fprofiler%2Fbuilt-in-function-calls-anonymous.html I think that this needs to be rolled out. 1102943 5 commit-queue 2015-06-18 10:09:11 -0700 Re-opened since this is blocked by bug 146114 1102992 6 joepeck 2015-06-18 12:22:33 -0700 Re-landed in: http://trac.webkit.org/changeset/185716 255001 2015-06-16 22:51:22 -0700 2015-06-17 14:35:16 -0700 [PATCH] Proposed Fix even-better.patch text/plain 2654 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQ5MGVmNWQuLmRiNDM5MWMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE1LTA2LTE2ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSW1wcm92 ZSBhIGZldyBtb3JlIG5vZGUgcHJldmlldyB0eXBlcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2MDQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0Zvcm1hdHRlZFZh bHVlLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkZvcm1hdHRlZFZhbHVlLmNyZWF0ZUVsZW1l bnRGb3JOb2RlUHJldmlldyk6CisKKzIwMTUtMDYtMTYgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29y YXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbnNwZWN0b3IgU2NyaXB0 cyBldmFsdWF0ZWQgaW4gdGhlIHBhZ2Ugc2hvdWxkIG5vdCBiZSBzZWFyY2hhYmxlCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDYwNDAKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRm9ybWF0dGVk VmFsdWUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Gb3Jt YXR0ZWRWYWx1ZS5qcwppbmRleCA5N2ZiZDFmLi4yY2YzNjc3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Gb3JtYXR0ZWRWYWx1ZS5qcworKysg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Gb3JtYXR0ZWRWYWx1 ZS5qcwpAQCAtNjksMTUgKzY5LDM0IEBAIFdlYkluc3BlY3Rvci5Gb3JtYXR0ZWRWYWx1ZS5jcmVh dGVFbGVtZW50Rm9yTm9kZSA9IGZ1bmN0aW9uKG9iamVjdCkKIAogV2ViSW5zcGVjdG9yLkZvcm1h dHRlZFZhbHVlLmNyZWF0ZUVsZW1lbnRGb3JOb2RlUHJldmlldyA9IGZ1bmN0aW9uKHByZXZpZXcp CiB7CisgICAgdmFyIHZhbHVlID0gcHJldmlldy52YWx1ZTsKICAgICB2YXIgc3BhbiA9IGRvY3Vt ZW50LmNyZWF0ZUVsZW1lbnQoInNwYW4iKTsKICAgICBzcGFuLmNsYXNzTmFtZSA9ICJmb3JtYXR0 ZWQtbm9kZS1wcmV2aWV3IHN5bnRheC1oaWdobGlnaHRlZCI7CiAKLSAgICAvLyBBIG5vZGUgcHJl dmlldyBoYXMgYSB2ZXJ5IHN0cmljdCBmb3JtYXQsIHdpdGggYXQgbW9zdCBhIHNpbmdsZSBhdHRy aWJ1dGUuCisgICAgLy8gQ29tbWVudCBub2RlIHByZXZpZXcuCisgICAgaWYgKHZhbHVlLnN0YXJ0 c1dpdGgoIjwhLS0iKSkgeworICAgICAgICB2YXIgY29tbWVudCA9IHNwYW4uYXBwZW5kQ2hpbGQo ZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgic3BhbiIpKTsKKyAgICAgICAgY29tbWVudC5jbGFzc05h bWUgPSAiaHRtbC1jb21tZW50IjsKKyAgICAgICAgY29tbWVudC50ZXh0Q29udGVudCA9IHZhbHVl OworICAgICAgICByZXR1cm4gc3BhbjsKKyAgICB9CisKKyAgICAvLyBEb2N0eXBlIG5vZGUgcHJl dmlldy4KKyAgICBpZiAodmFsdWUuc3RhcnRzV2l0aCgiPCFET0NUWVBFIikpIHsKKyAgICAgICAg dmFyIGRvY3R5cGUgPSBzcGFuLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInNw YW4iKSk7CisgICAgICAgIGRvY3R5cGUuY2xhc3NOYW1lID0gImh0bWwtZG9jdHlwZSI7CisgICAg ICAgIGRvY3R5cGUudGV4dENvbnRlbnQgPSB2YWx1ZTsKKyAgICAgICAgcmV0dXJuIHNwYW47Cisg ICAgfQorCisgICAgLy8gRWxlbWVudCBub2RlIHByZXZpZXdzIGhhdmUgYSB2ZXJ5IHN0cmljdCBm b3JtYXQsIHdpdGggYXQgbW9zdCBhIHNpbmdsZSBhdHRyaWJ1dGUuCiAgICAgLy8gV2UgY2FuIHN0 eWxlIGl0IHVwIGxpa2UgYSBET01Ob2RlIHdpdGhvdXQgaW50ZXJhY3Rpdml0eS4KLSAgICB2YXIg bWF0Y2hlcyA9IHByZXZpZXcudmFsdWUubWF0Y2goL148KFxTKz8pKD86IChcUys/KT0iKC4qPyki KT8+JC8pOworICAgIHZhciBtYXRjaGVzID0gdmFsdWUubWF0Y2goL148KFxTKz8pKD86IChcUys/ KT0iKC4qPykiKT8+JC8pOworCisgICAgLy8gUmVtYWluaW5nIG5vZGUgdHlwZXMgYXJlIG9mdGVu ICN0ZXh0LCAjZG9jdW1lbnQsIGV0Yywgd2l0aCBhdHRyaWJ1dGUgbm9kZXMgcG90ZW50aWFsbHkg YmVpbmcgYW55IHN0cmluZy4KICAgICBpZiAoIW1hdGNoZXMpIHsKLSAgICAgICAgY29uc29sZS5l cnJvcigiTm9kZSBwcmV2aWV3IGRpZCBub3QgbWF0Y2ggZm9ybWF0LiIsIHByZXZpZXcudmFsdWUp Ci0gICAgICAgIHNwYW4udGV4dENvbnRlbnQgPSBwcmV2aWV3LnZhbHVlOworICAgICAgICBjb25z b2xlLmFzc2VydCghdmFsdWUuc3RhcnRzV2l0aCgiPCIpLCAiVW5leHBlY3RlZCBub2RlIHByZXZp ZXcgZm9ybWF0OiAiICsgdmFsdWUpOworICAgICAgICBzcGFuLnRleHRDb250ZW50ID0gdmFsdWU7 CiAgICAgICAgIHJldHVybiBzcGFuOwogICAgIH0KIAo=