146036 2015-06-16 16:52:19 -0700 Web Inspector: Improve Full Screen support for Web Inspector windows 2015-06-17 14:39:09 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1102390 0 joepeck 2015-06-16 16:52:19 -0700 * SUMMARY Improve Full Screen support for Web Inspector windows. * NOTES - Web Inspector window should support multi-tasking - When full screen, we should disable dock buttons - When entering fullscreen we should reduce the minimum width requirement 1102391 1 joepeck 2015-06-16 16:52:36 -0700 <rdar://problem/21048802> 1102395 2 254978 joepeck 2015-06-16 16:56:51 -0700 Created attachment 254978 [PATCH] Proposed Fix 1102653 3 254978 commit-queue 2015-06-17 14:39:06 -0700 Comment on attachment 254978 [PATCH] Proposed Fix Clearing flags on attachment: 254978 Committed r185672: <http://trac.webkit.org/changeset/185672> 1102654 4 commit-queue 2015-06-17 14:39:09 -0700 All reviewed patches have been landed. Closing bug. 254978 2015-06-16 16:56:51 -0700 2015-06-17 14:39:06 -0700 [PATCH] Proposed Fix fullscreen.patch text/plain 5040 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1NDZkM2RiLi5hYTdhMjBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTUtMDYtMTYgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbXByb3ZlIEZ1bGwgU2NyZWVuIHN1cHBvcnQgZm9yIFdl YiBJbnNwZWN0b3Igd2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQ2MDM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuaDoKKyAgICAgICAgKiBV SVByb2Nlc3MvbWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1tOgorICAgICAgICAoLVtXS1dlYklu c3BlY3RvclByb3h5T2JqQ0FkYXB0ZXIgd2luZG93RGlkRW50ZXJGdWxsU2NyZWVuOl0pOgorICAg ICAgICAoLVtXS1dlYkluc3BlY3RvclByb3h5T2JqQ0FkYXB0ZXIgd2luZG93RGlkRXhpdEZ1bGxT Y3JlZW46XSk6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybUNh bkF0dGFjaCk6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclByb3h5Ojp3aW5kb3dGdWxs U2NyZWVuRGlkQ2hhbmdlKToKKyAgICAgICAgV2hlbiBlbnRlcmluZyAvIGxlYXZpbmcgZnVsbCBz Y3JlZW4gdXBkYXRlIGF0dGFjaCBhdmFpbGFiaWxpdHkgdG8KKyAgICAgICAgcG90ZW50aWFsbHkg c2hvdyAvIGhpZGUgdGhlIGZyb250ZW5kJ3MgZG9ja2luZyBidXR0b25zLgorCisgICAgICAgIChX ZWJLaXQ6OldlYkluc3BlY3RvclByb3h5OjpjcmVhdGVJbnNwZWN0b3JXaW5kb3cpOgorICAgICAg ICBBbGxvdyBhIFdlYiBJbnNwZWN0b3Igd2luZG93IHRvIGJlIGEgZnVsbCBzY3JlZW4gYXV4aWxs YXJ5IHdpbmRvdywKKyAgICAgICAgc28gdGhhdCBpZiB0aGUgYXBwbGljYXRpb24gd2l0aCBhIFdl YlZpZXcgb3BlbnMgYSBkZXRhY2hlZCBpbnNwZWN0b3IKKyAgICAgICAgd2luZG93IGl0IGNhbiBi ZSBzaG93biBvbiB0aGUgc2FtZSBkZXNrdG9wIGFzIHRoZSBmdWxsIHNjcmVlbiBhcHAuCisgICAg ICAgIEFsc28sIHJlZHVjZSB0aGUgbWluaW11bSB3aW5kb3cgc2l6ZSByZXF1aXJlbWVudHMgZm9y IGZ1bGwgc2NyZWVuIHRpbGluZy4KKwogMjAxNS0wNi0xNSAgRGFuIEJlcm5zdGVpbiAgPG1pdHpA YXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxODUyOTgpOiBEYXRhYmFzZXMgc2Vy dmljZSBoYXMgV2ViIENvbnRlbnQgc2VydmljZeKAmXMgZW50aXRsZW1lbnRzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuaCBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5oCmluZGV4IDYzYjIxMDIuLjY0MGZl YjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94 eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5oCkBA IC0xMDEsNiArMTAxLDcgQEAgcHVibGljOgogICAgIHZvaWQgdXBkYXRlSW5zcGVjdG9yV2luZG93 VGl0bGUoKSBjb25zdDsKICAgICB2b2lkIGluc3BlY3RlZFZpZXdGcmFtZURpZENoYW5nZShDR0Zs b2F0ID0gMCk7CiAgICAgdm9pZCB3aW5kb3dGcmFtZURpZENoYW5nZSgpOworICAgIHZvaWQgd2lu ZG93RnVsbFNjcmVlbkRpZENoYW5nZSgpOwogICAgIE5TV2luZG93KiBpbnNwZWN0b3JXaW5kb3co KSBjb25zdCB7IHJldHVybiBtX2luc3BlY3RvcldpbmRvdy5nZXQoKTsgfQogCiAgICAgdm9pZCBz ZXRJbnNwZWN0b3JXaW5kb3dGcmFtZShXS1JlY3QmKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0gYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvbWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1tCmluZGV4IDE0ZWFhZDYuLmUx ZDk5ZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViSW5zcGVj dG9yUHJveHlNYWMubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJJbnNw ZWN0b3JQcm94eU1hYy5tbQpAQCAtMTQxLDYgKzE0MSwxNiBAQCAtICh2b2lkKXdpbmRvd1dpbGxD bG9zZTooTlNOb3RpZmljYXRpb24gKilub3RpZmljYXRpb24KICAgICBzdGF0aWNfY2FzdDxXZWJJ bnNwZWN0b3JQcm94eSo+KF9pbnNwZWN0b3JQcm94eSktPmNsb3NlKCk7CiB9CiAKKy0gKHZvaWQp d2luZG93RGlkRW50ZXJGdWxsU2NyZWVuOihOU05vdGlmaWNhdGlvbiAqKW5vdGlmaWNhdGlvbgor eworICAgIHN0YXRpY19jYXN0PFdlYkluc3BlY3RvclByb3h5Kj4oX2luc3BlY3RvclByb3h5KS0+ d2luZG93RnVsbFNjcmVlbkRpZENoYW5nZSgpOworfQorCistICh2b2lkKXdpbmRvd0RpZEV4aXRG dWxsU2NyZWVuOihOU05vdGlmaWNhdGlvbiAqKW5vdGlmaWNhdGlvbgoreworICAgIHN0YXRpY19j YXN0PFdlYkluc3BlY3RvclByb3h5Kj4oX2luc3BlY3RvclByb3h5KS0+d2luZG93RnVsbFNjcmVl bkRpZENoYW5nZSgpOworfQorCiAtICh2b2lkKWlnbm9yZU5leHRJbnNwZWN0ZWRWaWV3RnJhbWVE aWRDaGFuZ2UKIHsKICAgICBfaWdub3JlTmV4dEluc3BlY3RlZFZpZXdGcmFtZURpZENoYW5nZSA9 IFlFUzsKQEAgLTMwNCw2ICszMTQsMTQgQEAgdm9pZCBXZWJJbnNwZWN0b3JQcm94eTo6Y3JlYXRl SW5zcGVjdG9yV2luZG93KCkKICAgICBbd2luZG93IHNldERlbGVnYXRlOm1faW5zcGVjdG9yUHJv eHlPYmpDQWRhcHRlci5nZXQoKV07CiAgICAgW3dpbmRvdyBzZXRNaW5TaXplOk5TTWFrZVNpemUo bWluaW11bVdpbmRvd1dpZHRoLCBtaW5pbXVtV2luZG93SGVpZ2h0KV07CiAgICAgW3dpbmRvdyBz ZXRSZWxlYXNlZFdoZW5DbG9zZWQ6Tk9dOworICAgIFt3aW5kb3cgc2V0Q29sbGVjdGlvbkJlaGF2 aW9yOihbd2luZG93IGNvbGxlY3Rpb25CZWhhdmlvcl0gfCBOU1dpbmRvd0NvbGxlY3Rpb25CZWhh dmlvckZ1bGxTY3JlZW5BdXhpbGlhcnkpXTsKKworI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5f UkVRVUlSRUQgPj0gMTAxMTAwCisgICAgQ0dGbG9hdCBhcHByb3hpbWF0ZWx5SGFsZlNjcmVlblNp emUgPSAod2luZG93LnNjcmVlbi5mcmFtZS5zaXplLndpZHRoIC8gMikgLSA0OworICAgIENHRmxv YXQgbWluaW11bUZ1bGxTY3JlZW5XaWR0aCA9IHN0ZDo6bWF4PENHRmxvYXQ+KDYzNiwgYXBwcm94 aW1hdGVseUhhbGZTY3JlZW5TaXplKTsKKyAgICBbd2luZG93IHNldE1pbkZ1bGxTY3JlZW5Db250 ZW50U2l6ZTpOU01ha2VTaXplKG1pbmltdW1GdWxsU2NyZWVuV2lkdGgsIG1pbmltdW1XaW5kb3dI ZWlnaHQpXTsKKyAgICBbd2luZG93IHNldENvbGxlY3Rpb25CZWhhdmlvcjooW3dpbmRvdyBjb2xs ZWN0aW9uQmVoYXZpb3JdIHwgTlNXaW5kb3dDb2xsZWN0aW9uQmVoYXZpb3JGdWxsU2NyZWVuQWxs b3dzVGlsaW5nKV07CisjZW5kaWYKIAogI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlS RUQgPj0gMTAxMDAwCiAgICAgd2luZG93LnRpdGxlYmFyQXBwZWFyc1RyYW5zcGFyZW50ID0gWUVT OwpAQCAtNDYzLDYgKzQ4MSw5IEBAIFdlYlBhZ2VQcm94eSogV2ViSW5zcGVjdG9yUHJveHk6OnBs YXRmb3JtQ3JlYXRlSW5zcGVjdG9yUGFnZSgpCiAKIGJvb2wgV2ViSW5zcGVjdG9yUHJveHk6OnBs YXRmb3JtQ2FuQXR0YWNoKGJvb2wgd2ViUHJvY2Vzc0NhbkF0dGFjaCkKIHsKKyAgICBpZiAoW21f aW5zcGVjdG9yV2luZG93IHN0eWxlTWFza10gJiBOU0Z1bGxTY3JlZW5XaW5kb3dNYXNrKQorICAg ICAgICByZXR1cm4gZmFsc2U7CisKICAgICBOU1ZpZXcgKmluc3BlY3RlZFZpZXcgPSBpbnNwZWN0 ZWRQYWdlKCktPndrVmlldygpLl9pbnNwZWN0b3JBdHRhY2htZW50VmlldzsKICAgICBpZiAoW2lu c3BlY3RlZFZpZXcgaXNLaW5kT2ZDbGFzczpbV0tWaWV3IGNsYXNzXV0pCiAgICAgICAgIHJldHVy biB3ZWJQcm9jZXNzQ2FuQXR0YWNoOwpAQCAtNjM1LDEzICs2NTYsMjUgQEAgdm9pZCBXZWJJbnNw ZWN0b3JQcm94eTo6d2luZG93RnJhbWVEaWRDaGFuZ2UoKQogICAgIGluc3BlY3RlZFBhZ2UoKS0+ cGFnZUdyb3VwKCkucHJlZmVyZW5jZXMoKS5zZXRJbnNwZWN0b3JXaW5kb3dGcmFtZShmcmFtZVN0 cmluZyk7CiB9CiAKK3ZvaWQgV2ViSW5zcGVjdG9yUHJveHk6OndpbmRvd0Z1bGxTY3JlZW5EaWRD aGFuZ2UoKQoreworICAgIEFTU0VSVCghbV9pc0F0dGFjaGVkKTsKKyAgICBBU1NFUlQobV9pc1Zp c2libGUpOworICAgIEFTU0VSVChtX2luc3BlY3RvcldpbmRvdyk7CisKKyAgICBpZiAobV9pc0F0 dGFjaGVkIHx8ICFtX2lzVmlzaWJsZSB8fCAhbV9pbnNwZWN0b3JXaW5kb3cpCisgICAgICAgIHJl dHVybjsKKworICAgIGF0dGFjaEF2YWlsYWJpbGl0eUNoYW5nZWQocGxhdGZvcm1DYW5BdHRhY2go Y2FuQXR0YWNoKCkpKTsgICAgCit9CisKIHZvaWQgV2ViSW5zcGVjdG9yUHJveHk6Omluc3BlY3Rl ZFZpZXdGcmFtZURpZENoYW5nZShDR0Zsb2F0IGN1cnJlbnREaW1lbnNpb24pCiB7CiAgICAgaWYg KCFtX2lzVmlzaWJsZSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgaWYgKCFtX2lzQXR0YWNoZWQp IHsKLSAgICAgICAgLy8gQ2hlY2sgaWYgdGhlIGF0dGFjaCBhdmFpYmlsaXR5IGNoYW5nZWQuIFdl IG5lZWQgdG8gZG8gdGhpcyBoZXJlIGluIGNhc2UKKyAgICAgICAgLy8gQ2hlY2sgaWYgdGhlIGF0 dGFjaCBhdmFpbGFiaWxpdHkgY2hhbmdlZC4gV2UgbmVlZCB0byBkbyB0aGlzIGhlcmUgaW4gY2Fz ZQogICAgICAgICAvLyB0aGUgYXR0YWNobWVudCB2aWV3IGlzIG5vdCB0aGUgV0tWaWV3LgogICAg ICAgICBhdHRhY2hBdmFpbGFiaWxpdHlDaGFuZ2VkKHBsYXRmb3JtQ2FuQXR0YWNoKGNhbkF0dGFj aCgpKSk7CiAgICAgICAgIHJldHVybjsK