146025 2015-06-16 11:34:17 -0700 REGRESSION(r185012): chat frame in Gmail now says "Something's not right" 2015-06-16 12:48:35 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P1 Normal --- 145465 1 cdumez cdumez barraclough commit-queue darin esprehn+autocc kangil.han kling mark.lam simon.fraser webkit-bug-importer oldest_to_newest 1102292 0 cdumez 2015-06-16 11:34:17 -0700 chat frame in GMail now says "Something's not right" after r185012. Radar: <rdar://problem/21391412> 1102299 1 254961 cdumez 2015-06-16 11:55:37 -0700 Created attachment 254961 Patch 1102304 2 254961 darin 2015-06-16 12:08:55 -0700 Comment on attachment 254961 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254961&action=review > Source/WebCore/dom/Document.cpp:2764 > - double previousInterval = timerAlignmentInterval(); > - > m_isTimerThrottlingEnabled = shouldThrottle; > - > - if (previousInterval != timerAlignmentInterval()) > - didChangeTimerAlignmentInterval(); > + didChangeTimerAlignmentInterval(); Why this change? 1102308 3 254961 cdumez 2015-06-16 12:27:25 -0700 Comment on attachment 254961 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254961&action=review >> Source/WebCore/dom/Document.cpp:2764 >> + didChangeTimerAlignmentInterval(); > > Why this change? Now timerAlignmentInterval() takes an argument that is timer-specific so we can no longer call it here to determine if we should call didChangeTimerAlignmentInterval(). We need to call didChangeTimerAlignmentInterval() to notify all timers that their alignment may have changed. It is better to call this one too often rather than not enough as otherwise we may fail to update the interval of some timers. If the document-level throttling state has changed, some timers in the Document (the ones that have reached the max nesting level) need to be updated so we need to call this function. 1102311 4 254961 cdumez 2015-06-16 12:48:26 -0700 Comment on attachment 254961 Patch Clearing flags on attachment: 254961 Committed r185602: <http://trac.webkit.org/changeset/185602> 1102312 5 cdumez 2015-06-16 12:48:35 -0700 All reviewed patches have been landed. Closing bug. 254961 2015-06-16 11:55:37 -0700 2015-06-16 12:48:26 -0700 Patch bug-146025-20150616115502.patch text/plain 5481 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTFkMzNlMWE1MmMzNDVi ZWRlMDhiMzYwYjdlODBiZDdlYzk5NzY2MS4uYjYzZDc5MjYzYjgzOWQwYjEyNTY4ZDI2YmFiMTA0 YzY2YTEyYTRmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMxIEBACiAyMDE1LTA2LTE2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgUkVHUkVTU0lPTihyMTg1MDEy KTogY2hhdCBmcmFtZSBpbiBHbWFpbCBub3cgc2F5cyAiU29tZXRoaW5nJ3Mgbm90IHJpZ2h0Igor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2MDI1Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMTM5MTQxMj4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPbmx5IHRocm90dGxlIHRpbWVycyBpbiBub24tdmlz aWJsZSBpZnJhbWVzIG9uY2UgdGhleSd2ZSByZWFjaGVkIHRoZQorICAgICAgICBtYXggbmVzdGlu ZyBsZXZlbCB0byBhdm9pZCB0aHJvdHRsaW5nIGNyaXRpY2FsIG9uZS1zaG90IHRpbWVycy4gVGhp cyBpcworICAgICAgICBjb25zaXN0ZW50IHdpdGggdGhlIGRlZmF1bHQgRE9NVGltZXIgdGhyb3R0 bGluZyBiZWhhdmlvciB0aGF0IGlzCisgICAgICAgIGRlZmluZWQgaW4gdGhlIHNwZWNpZmljYXRp b24uCisKKyAgICAgICAgUG93ZXItd2lzZSwgd2UgYXJlIG1vc3RseSBpbnRlcmVzdGVkIGluIERP TVRpbWVycyB0aGF0IGZpcmUgZnJlcXVlbnRseQorICAgICAgICBhbmQgY2F1c2UgaGlnaCBDUFUg dXNhZ2Ugb3ZlciBhbiBleHRlbmRlZCBwZXJpb2Qgb2YgdGltZSBhbnl3YXkuCisKKyAgICAgICAg KiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnNldFRpbWVy VGhyb3R0bGluZ0VuYWJsZWQpOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnRpbWVyQWxp Z25tZW50SW50ZXJ2YWwpOgorICAgICAgICAqIGRvbS9Eb2N1bWVudC5oOgorICAgICAgICAqIGRv bS9TY3JpcHRFeGVjdXRpb25Db250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQ6OnRpbWVyQWxpZ25tZW50SW50ZXJ2YWwpOgorICAgICAgICAqIGRvbS9T Y3JpcHRFeGVjdXRpb25Db250ZXh0Lmg6CisgICAgICAgICogcGFnZS9ET01UaW1lci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpET01UaW1lcjo6YWxpZ25lZEZpcmVUaW1lKToKKworMjAxNS0wNi0x NiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCiAgICAgICAgIFB1cmdlIFN0eWxl ZEVsZW1lbnQncyBwcmVzZW50YXRpb24gYXR0cmlidXRlIGNhY2hlIG9uIG1lbW9yeSBwcmVzc3Vy ZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1OTk5 CiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMTM1OTI1Mj4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3Bw CmluZGV4IGNhNjQ4ZjI2MmVmYjA1OGNmOTQ5NDE3ZmI2YTQ1MjY4MGZkMTYzNzUuLmY1NWY5YjFm NGUwMzEwMGU4Mjg0ZTgwYzc4NmQ0ZjlmOGRkNzU0YjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNw cApAQCAtMjc2MCwyMiArMjc2MCwxOSBAQCB2b2lkIERvY3VtZW50OjpzZXRUaW1lclRocm90dGxp bmdFbmFibGVkKGJvb2wgc2hvdWxkVGhyb3R0bGUpCiAgICAgaWYgKG1faXNUaW1lclRocm90dGxp bmdFbmFibGVkID09IHNob3VsZFRocm90dGxlKQogICAgICAgICByZXR1cm47CiAKLSAgICBkb3Vi bGUgcHJldmlvdXNJbnRlcnZhbCA9IHRpbWVyQWxpZ25tZW50SW50ZXJ2YWwoKTsKLQogICAgIG1f aXNUaW1lclRocm90dGxpbmdFbmFibGVkID0gc2hvdWxkVGhyb3R0bGU7Ci0KLSAgICBpZiAocHJl dmlvdXNJbnRlcnZhbCAhPSB0aW1lckFsaWdubWVudEludGVydmFsKCkpCi0gICAgICAgIGRpZENo YW5nZVRpbWVyQWxpZ25tZW50SW50ZXJ2YWwoKTsKKyAgICBkaWRDaGFuZ2VUaW1lckFsaWdubWVu dEludGVydmFsKCk7CiB9CiAKLWRvdWJsZSBEb2N1bWVudDo6dGltZXJBbGlnbm1lbnRJbnRlcnZh bCgpIGNvbnN0Citkb3VibGUgRG9jdW1lbnQ6OnRpbWVyQWxpZ25tZW50SW50ZXJ2YWwoYm9vbCBo YXNSZWFjaGVkTWF4TmVzdGluZ0xldmVsKSBjb25zdAogewotICAgIGlmIChtX2lzVGltZXJUaHJv dHRsaW5nRW5hYmxlZCkKKyAgICAvLyBBcHBseSBEb2N1bWVudC1sZXZlbCBET01UaW1lciB0aHJv dHRsaW5nIG9ubHkgaWYgdGltZXJzIGhhdmUgcmVhY2hlZCB0aGVpciBtYXhpbXVtIG5lc3Rpbmcg bGV2ZWwgYXMgdGhlIFBhZ2UgbWF5IHN0aWxsIGJlIHZpc2libGUuCisgICAgaWYgKG1faXNUaW1l clRocm90dGxpbmdFbmFibGVkICYmIGhhc1JlYWNoZWRNYXhOZXN0aW5nTGV2ZWwpCiAgICAgICAg IHJldHVybiBET01UaW1lcjo6aGlkZGVuUGFnZUFsaWdubWVudEludGVydmFsKCk7CiAKICAgICBQ YWdlKiBwYWdlID0gdGhpcy0+cGFnZSgpOwogICAgIGlmICghcGFnZSkKLSAgICAgICAgcmV0dXJu IFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OnRpbWVyQWxpZ25tZW50SW50ZXJ2YWwoKTsKKyAgICAg ICAgcmV0dXJuIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OnRpbWVyQWxpZ25tZW50SW50ZXJ2YWwo aGFzUmVhY2hlZE1heE5lc3RpbmdMZXZlbCk7CiAgICAgcmV0dXJuIHBhZ2UtPnNldHRpbmdzKCku ZG9tVGltZXJBbGlnbm1lbnRJbnRlcnZhbCgpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9kb20vRG9jdW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCmluZGV4 IGJhYTJjNGZhMDYzODAzZjliNGZhZDg1M2E5OTQ0YjdiZGQwMDhiZGMuLjBkYjYxNDMzNzI0ZDI1 YjFiNWU3NmZkMDcyMzhkNGIwNTEyZWE1ZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCkBAIC0xMzAx LDcgKzEzMDEsNyBAQCBwcml2YXRlOgogCiAgICAgdmlydHVhbCBkb3VibGUgbWluaW11bVRpbWVy SW50ZXJ2YWwoKSBjb25zdCBvdmVycmlkZSBmaW5hbDsKIAotICAgIHZpcnR1YWwgZG91YmxlIHRp bWVyQWxpZ25tZW50SW50ZXJ2YWwoKSBjb25zdCBvdmVycmlkZSBmaW5hbDsKKyAgICB2aXJ0dWFs IGRvdWJsZSB0aW1lckFsaWdubWVudEludGVydmFsKGJvb2wgaGFzUmVhY2hlZE1heE5lc3RpbmdM ZXZlbCkgY29uc3Qgb3ZlcnJpZGUgZmluYWw7CiAKICAgICB2b2lkIHVwZGF0ZVRpdGxlKGNvbnN0 IFN0cmluZ1dpdGhEaXJlY3Rpb24mKTsKICAgICB2b2lkIHVwZGF0ZUZvY3VzQXBwZWFyYW5jZVRp bWVyRmlyZWQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFeGVjdXRp b25Db250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFeGVjdXRpb25Db250ZXh0 LmNwcAppbmRleCBlZDExOGI4ZTU0YjliZGM0YmRhNjQ1YzlhODQ3NGUzYTIwYTFkMTMxLi40MmY1 ZTc5OTM5MmY1MWZjNzlkZGQxMTM1MzM5MmFlNDc2YmMyZWZiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9kb20vU2NyaXB0RXhlY3V0aW9uQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvZG9tL1NjcmlwdEV4ZWN1dGlvbkNvbnRleHQuY3BwCkBAIC00NDksNyArNDQ5LDcgQEAgdm9p ZCBTY3JpcHRFeGVjdXRpb25Db250ZXh0OjpkaWRDaGFuZ2VUaW1lckFsaWdubWVudEludGVydmFs KCkKICAgICAgICAgdGltZXItPmRpZENoYW5nZUFsaWdubWVudEludGVydmFsKCk7CiB9CiAKLWRv dWJsZSBTY3JpcHRFeGVjdXRpb25Db250ZXh0Ojp0aW1lckFsaWdubWVudEludGVydmFsKCkgY29u c3QKK2RvdWJsZSBTY3JpcHRFeGVjdXRpb25Db250ZXh0Ojp0aW1lckFsaWdubWVudEludGVydmFs KGJvb2wpIGNvbnN0CiB7CiAgICAgcmV0dXJuIERPTVRpbWVyOjpkZWZhdWx0QWxpZ25tZW50SW50 ZXJ2YWwoKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFeGVjdXRp b25Db250ZXh0LmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0RXhlY3V0aW9uQ29udGV4dC5o CmluZGV4IDFkMWUxOGI2ZGM5NzY5NjFlMjA5ZjU0MzkwZTNiNzYxMGRkYjhjZWIuLjBmYWEwNjlm ODc0Y2VmOWViZGViYTNmYmMwM2VhMjM0ZGQyNDAzNDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2RvbS9TY3JpcHRFeGVjdXRpb25Db250ZXh0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9t L1NjcmlwdEV4ZWN1dGlvbkNvbnRleHQuaApAQCAtMTczLDcgKzE3Myw3IEBAIHB1YmxpYzoKICAg ICB2aXJ0dWFsIGRvdWJsZSBtaW5pbXVtVGltZXJJbnRlcnZhbCgpIGNvbnN0OwogCiAgICAgdm9p ZCBkaWRDaGFuZ2VUaW1lckFsaWdubWVudEludGVydmFsKCk7Ci0gICAgdmlydHVhbCBkb3VibGUg dGltZXJBbGlnbm1lbnRJbnRlcnZhbCgpIGNvbnN0OworICAgIHZpcnR1YWwgZG91YmxlIHRpbWVy QWxpZ25tZW50SW50ZXJ2YWwoYm9vbCBoYXNSZWFjaGVkTWF4TmVzdGluZ0xldmVsKSBjb25zdDsK IAogICAgIHZpcnR1YWwgRXZlbnRRdWV1ZSYgZXZlbnRRdWV1ZSgpIGNvbnN0ID0gMDsKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01UaW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0RPTVRpbWVyLmNwcAppbmRleCAyOTgwZWEyMTQ5YTcwNTAwYTA5Y2M3NWQ5Y2U0NTky ZWQzZmMxMGY2Li41ODVhYTcyNjhhOWMzMWQ1YmJmM2M2ZTNhNGY0YjFjMDBhNjIzOWQ0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVRpbWVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0RPTVRpbWVyLmNwcApAQCAtNDI4LDcgKzQyOCw3IEBAIGRvdWJsZSBET01UaW1l cjo6aW50ZXJ2YWxDbGFtcGVkVG9NaW5pbXVtKCkgY29uc3QKIAogZG91YmxlIERPTVRpbWVyOjph bGlnbmVkRmlyZVRpbWUoZG91YmxlIGZpcmVUaW1lKSBjb25zdAogewotICAgIGlmIChkb3VibGUg YWxpZ25tZW50SW50ZXJ2YWwgPSBzY3JpcHRFeGVjdXRpb25Db250ZXh0KCktPnRpbWVyQWxpZ25t ZW50SW50ZXJ2YWwoKSkKKyAgICBpZiAoZG91YmxlIGFsaWdubWVudEludGVydmFsID0gc2NyaXB0 RXhlY3V0aW9uQ29udGV4dCgpLT50aW1lckFsaWdubWVudEludGVydmFsKG1fbmVzdGluZ0xldmVs ID49IG1heFRpbWVyTmVzdGluZ0xldmVsKSkKICAgICAgICAgcmV0dXJuIGNlaWwoZmlyZVRpbWUg LyBhbGlnbm1lbnRJbnRlcnZhbCkgKiBhbGlnbm1lbnRJbnRlcnZhbDsKIAogICAgIHJldHVybiBm aXJlVGltZTsK