146014 2015-06-16 04:11:43 -0700 [SOUP] Fix return-type-c-linkage warning after r185553 2015-06-19 16:26:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 145121 145969 1 ossy mcatanzaro cgarcia commit-queue mcatanzaro svillar oldest_to_newest 1102217 0 ossy 2015-06-16 04:11:43 -0700 After http://trac.webkit.org/changeset/185553 we get the following warning if we build WebKit with clang: ../../Source/WebCore/platform/network/soup/WebKitSoupRequestGeneric.h:61:33: warning: 'webkitSoupRequestGenericGetRequest' has C-linkage specified, but returns user-defined type 'const WebCore::ResourceRequest &' which is incompatible with C [-Wreturn-type-c-linkage] const WebCore::ResourceRequest& webkitSoupRequestGenericGetRequest(WebKitSoupRequestGeneric*); ^ 1 warning generated. 1103418 1 mcatanzaro 2015-06-19 14:47:04 -0700 As much as I hate to convert a nice reference into a pointer, the alternative is to move the G_END_DECLS up above those function declarations, and that would be weird. 1103420 2 255229 mcatanzaro 2015-06-19 14:49:23 -0700 Created attachment 255229 Patch 1103476 3 255229 commit-queue 2015-06-19 16:26:35 -0700 Comment on attachment 255229 Patch Clearing flags on attachment: 255229 Committed r185774: <http://trac.webkit.org/changeset/185774> 1103477 4 commit-queue 2015-06-19 16:26:40 -0700 All reviewed patches have been landed. Closing bug. 255229 2015-06-19 14:49:23 -0700 2015-06-19 16:26:35 -0700 Patch bug-146014-20150619164844.patch text/plain 4612 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NzYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTI5OTg1ZmVkYWM5ZDE3 NGIyZTk3YmY0YWFhOTc5Y2Y4MTVmNjE3ZC4uZmIwN2Q2MDM0ZjExNjEyMTA2OTFiMmFjYzkyODg2 NmE3ODk4ZTM0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA2LTE5ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbU09VUF0g Rml4IHJldHVybi10eXBlLWMtbGlua2FnZSB3YXJuaW5nIGFmdGVyIHIxODU1NTMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjAxNAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29y ay9zb3VwL1dlYktpdFNvdXBSZXF1ZXN0R2VuZXJpYy5jcHA6CisgICAgICAgICh3ZWJraXRTb3Vw UmVxdWVzdEdlbmVyaWNHZXRSZXF1ZXN0KTogUmV0dXJuIGEgcG9pbnRlciByYXRoZXIgdGhhbiBh IHJlZmVyZW5jZS4KKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvV2ViS2l0U291cFJl cXVlc3RHZW5lcmljLmg6IHdlYmtpdFNvdXBSZXF1ZXN0R2VuZXJpY0dldFJlcXVlc3Qgbm93Cisg ICAgICAgIHJldHVybnMgYSBwb2ludGVyIHJhdGhlciB0aGFuIGEgcmVmZXJlbmNlLgorCiAyMDE1 LTA2LTE5ICBKZXJlbXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KIAogICAgICAgICBHZXQg Q0FDb250ZXh0IGRpcmVjdGx5IGZvciBDQUxheWVyIGluc3RlYWQgb2Ygd2Fsa2luZyB0aGUgbGF5 ZXIgdHJlZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZwppbmRleCBhZTU2ZjlmMGQxOGIyYzA4YTkzZDYyMDliYzI0ZDBhNWQ0 NzBmZGU5Li4wYzQ4YzJiMTNhOWU4M2ZkODkwYjNmOTYyYTk0ZDFlOWEyZGI3Y2YwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUtMDYtMTkgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNh dGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtTT1VQXSBGaXggcmV0dXJuLXR5cGUtYy1s aW5rYWdlIHdhcm5pbmcgYWZ0ZXIgcjE4NTU1MworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2MDE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQvTmV0d29yay9DdXN0b21Qcm90b2NvbHMvc291 cC9DdXN0b21Qcm90b2NvbE1hbmFnZXJJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q3VzdG9t UHJvdG9jb2xNYW5hZ2VySW1wbDo6c3RhcnQpOiB3ZWJraXRTb3VwUmVxdWVzdEdlbmVyaWNHZXRS ZXF1ZXN0IG5vdyByZXR1cm5zCisgICAgICAgIGEgcG9pbnRlciByYXRoZXIgdGhhbiBhIHJlZmVy ZW5jZS4KKwogMjAxNS0wNi0xOCAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4K IAogICAgICAgICBbaU9TXSBzY3JvbGxJbnRvVmlld0lmTmVlZGVkIGlzIG5vdCB3b3JraW5nIHdp dGggc2Nyb2xsLXNuYXAgcG9pbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL3NvdXAvV2ViS2l0U291cFJlcXVlc3RHZW5lcmljLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9XZWJLaXRTb3VwUmVxdWVzdEdlbmVyaWMuY3BwCmlu ZGV4IGNkMmE5MDc4OWJjZjJiNGQ3M2Y0ZTU1NTFhNzYxMGMyNzBiNmEwMjYuLmE3NDk0OTVkZDQ1 YzQyY2Y3Y2Y5MTNjOGVkOGI3MWY1ODEwZWMzYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvc291cC9XZWJLaXRTb3VwUmVxdWVzdEdlbmVyaWMuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9XZWJLaXRTb3VwUmVxdWVzdEdl bmVyaWMuY3BwCkBAIC0xMDAsNyArMTAwLDcgQEAgdm9pZCB3ZWJraXRTb3VwUmVxdWVzdEdlbmVy aWNTZXRSZXF1ZXN0KFdlYktpdFNvdXBSZXF1ZXN0R2VuZXJpYyogcmVxdWVzdCwgY29uc3QKICAg ICByZXF1ZXN0LT5wcml2LT5yZXNvdXJjZVJlcXVlc3QgPSByZXNvdXJjZVJlcXVlc3Q7CiB9CiAK LWNvbnN0IFJlc291cmNlUmVxdWVzdCYgd2Via2l0U291cFJlcXVlc3RHZW5lcmljR2V0UmVxdWVz dChXZWJLaXRTb3VwUmVxdWVzdEdlbmVyaWMqIHJlcXVlc3QpCitjb25zdCBSZXNvdXJjZVJlcXVl c3QqIHdlYmtpdFNvdXBSZXF1ZXN0R2VuZXJpY0dldFJlcXVlc3QoV2ViS2l0U291cFJlcXVlc3RH ZW5lcmljKiByZXF1ZXN0KQogewotICAgIHJldHVybiByZXF1ZXN0LT5wcml2LT5yZXNvdXJjZVJl cXVlc3Q7CisgICAgcmV0dXJuICZyZXF1ZXN0LT5wcml2LT5yZXNvdXJjZVJlcXVlc3Q7CiB9CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvV2ViS2l0U291 cFJlcXVlc3RHZW5lcmljLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAv V2ViS2l0U291cFJlcXVlc3RHZW5lcmljLmgKaW5kZXggMDljYmQyNzI1M2Q0M2RiOTg1MDY1ZDQ0 MzRkZGM2ZjFhYjgzNDBhYi4uMGU1MTM5YTA4ZTNiZTVlMzQ2YjEyODZmOTk4MzI2MmZhMGFmNTdj NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1dlYktp dFNvdXBSZXF1ZXN0R2VuZXJpYy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvc291cC9XZWJLaXRTb3VwUmVxdWVzdEdlbmVyaWMuaApAQCAtNTgsNyArNTgsNyBAQCBHVHlw ZSB3ZWJraXRfc291cF9yZXF1ZXN0X2dlbmVyaWNfZ2V0X3R5cGUoKTsKIHZvaWQgd2Via2l0U291 cFJlcXVlc3RHZW5lcmljU2V0Q29udGVudExlbmd0aChXZWJLaXRTb3VwUmVxdWVzdEdlbmVyaWMq LCBnb2Zmc2V0IGNvbnRlbnRMZW5ndGgpOwogdm9pZCB3ZWJraXRTb3VwUmVxdWVzdEdlbmVyaWNT ZXRDb250ZW50VHlwZShXZWJLaXRTb3VwUmVxdWVzdEdlbmVyaWMqLCBjb25zdCBjaGFyKiBtaW1l VHlwZSk7CiB2b2lkIHdlYmtpdFNvdXBSZXF1ZXN0R2VuZXJpY1NldFJlcXVlc3QoV2ViS2l0U291 cFJlcXVlc3RHZW5lcmljKiwgY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0Jik7Ci1jb25z dCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmIHdlYmtpdFNvdXBSZXF1ZXN0R2VuZXJpY0dldFJl cXVlc3QoV2ViS2l0U291cFJlcXVlc3RHZW5lcmljKik7Citjb25zdCBXZWJDb3JlOjpSZXNvdXJj ZVJlcXVlc3QqIHdlYmtpdFNvdXBSZXF1ZXN0R2VuZXJpY0dldFJlcXVlc3QoV2ViS2l0U291cFJl cXVlc3RHZW5lcmljKik7CiAKIEdfRU5EX0RFQ0xTCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1NoYXJlZC9OZXR3b3JrL0N1c3RvbVByb3RvY29scy9zb3VwL0N1c3RvbVByb3RvY29sTWFu YWdlckltcGwuY3BwIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL05ldHdvcmsvQ3VzdG9tUHJvdG9j b2xzL3NvdXAvQ3VzdG9tUHJvdG9jb2xNYW5hZ2VySW1wbC5jcHAKaW5kZXggMmRkMjQ2MDVkMGUz NmUwY2FkZjk3NDZkM2E3ZTk3Mzk4YmY4NjJjYi4uOWFjMWJhNTA2OGFjOWM0N2ZiM2FhYjVjMzVh MzY5NGRjNDE0MTZlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL05ldHdvcmsv Q3VzdG9tUHJvdG9jb2xzL3NvdXAvQ3VzdG9tUHJvdG9jb2xNYW5hZ2VySW1wbC5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvU2hhcmVkL05ldHdvcmsvQ3VzdG9tUHJvdG9jb2xzL3NvdXAvQ3VzdG9t UHJvdG9jb2xNYW5hZ2VySW1wbC5jcHAKQEAgLTE5MCw3ICsxOTAsNyBAQCB2b2lkIEN1c3RvbVBy b3RvY29sTWFuYWdlckltcGw6OnN0YXJ0KEdUYXNrKiB0YXNrKQogICAgIFdlYktpdFNvdXBSZXF1 ZXN0R2VuZXJpYyogcmVxdWVzdCA9IFdFQktJVF9TT1VQX1JFUVVFU1RfR0VORVJJQyhnX3Rhc2tf Z2V0X3NvdXJjZV9vYmplY3QodGFzaykpOwogICAgIG1fY3VzdG9tUHJvdG9jb2xNYXAuc2V0KGN1 c3RvbVByb3RvY29sSUQsIHN0ZDo6bWFrZV91bmlxdWU8V2ViU291cFJlcXVlc3RBc3luY0RhdGE+ KHRhc2ssIHJlcXVlc3QpKTsKIAotICAgIG1fY2hpbGRQcm9jZXNzLT5zZW5kKE1lc3NhZ2VzOjpD dXN0b21Qcm90b2NvbE1hbmFnZXJQcm94eTo6U3RhcnRMb2FkaW5nKGN1c3RvbVByb3RvY29sSUQs IHdlYmtpdFNvdXBSZXF1ZXN0R2VuZXJpY0dldFJlcXVlc3QocmVxdWVzdCkpLCAwKTsKKyAgICBt X2NoaWxkUHJvY2Vzcy0+c2VuZChNZXNzYWdlczo6Q3VzdG9tUHJvdG9jb2xNYW5hZ2VyUHJveHk6 OlN0YXJ0TG9hZGluZyhjdXN0b21Qcm90b2NvbElELCAqd2Via2l0U291cFJlcXVlc3RHZW5lcmlj R2V0UmVxdWVzdChyZXF1ZXN0KSksIDApOwogfQogCiBHSW5wdXRTdHJlYW0qIEN1c3RvbVByb3Rv Y29sTWFuYWdlckltcGw6OmZpbmlzaChHVGFzayogdGFzaywgR0Vycm9yKiogZXJyb3IpCg==